[INFO] crate rust_release_artefact 0.1.3 is already in cache [INFO] extracting crate rust_release_artefact 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rust_release_artefact/0.1.3 [INFO] extracting crate rust_release_artefact 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_release_artefact/0.1.3 [INFO] validating manifest of rust_release_artefact-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust_release_artefact-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust_release_artefact-0.1.3 [INFO] finished frobbing rust_release_artefact-0.1.3 [INFO] frobbed toml for rust_release_artefact-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rust_release_artefact/0.1.3/Cargo.toml [INFO] started frobbing rust_release_artefact-0.1.3 [INFO] finished frobbing rust_release_artefact-0.1.3 [INFO] frobbed toml for rust_release_artefact-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_release_artefact/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust_release_artefact-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust_release_artefact/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 817875b6e934c7b23ee0eaff94521b59695a84ded9635d38947a5294c0903ed4 [INFO] running `"docker" "start" "-a" "817875b6e934c7b23ee0eaff94521b59695a84ded9635d38947a5294c0903ed4"` [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking rust_release_artefact v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:251:56 [INFO] [stderr] | [INFO] [stderr] 251 | return Err(Error::UnrecognisedManifestRule(line.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:448:16 [INFO] [stderr] | [INFO] [stderr] 448 | if files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:455:12 [INFO] [stderr] | [INFO] [stderr] 455 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:774:36 [INFO] [stderr] | [INFO] [stderr] 774 | dest_path.parent().unwrap_or(dest_root.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| dest_root.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:920:9 [INFO] [stderr] | [INFO] [stderr] 920 | / match self { [INFO] [stderr] 921 | | &Error::IoError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 922 | | &Error::WalkDirError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 923 | | &Error::NoArtefacts(ref path) => { [INFO] [stderr] ... | [INFO] [stderr] 943 | | ), [INFO] [stderr] 944 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 920 | match *self { [INFO] [stderr] 921 | Error::IoError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 922 | Error::WalkDirError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 923 | Error::NoArtefacts(ref path) => { [INFO] [stderr] 924 | write!(f, "Staging area {:?} contains no artefacts", path) [INFO] [stderr] 925 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | / match self { [INFO] [stderr] 951 | | &Error::IoError(ref inner) => { [INFO] [stderr] 952 | | <_ as error::Error>::description(inner) [INFO] [stderr] 953 | | } [INFO] [stderr] ... | [INFO] [stderr] 969 | | } [INFO] [stderr] 970 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 950 | match *self { [INFO] [stderr] 951 | Error::IoError(ref inner) => { [INFO] [stderr] 952 | <_ as error::Error>::description(inner) [INFO] [stderr] 953 | } [INFO] [stderr] 954 | Error::WalkDirError(ref inner) => { [INFO] [stderr] 955 | <_ as error::Error>::description(inner) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:251:56 [INFO] [stderr] | [INFO] [stderr] 251 | return Err(Error::UnrecognisedManifestRule(line.into())); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:448:16 [INFO] [stderr] | [INFO] [stderr] 448 | if files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:455:12 [INFO] [stderr] | [INFO] [stderr] 455 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:774:36 [INFO] [stderr] | [INFO] [stderr] 774 | dest_path.parent().unwrap_or(dest_root.as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| dest_root.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:920:9 [INFO] [stderr] | [INFO] [stderr] 920 | / match self { [INFO] [stderr] 921 | | &Error::IoError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 922 | | &Error::WalkDirError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 923 | | &Error::NoArtefacts(ref path) => { [INFO] [stderr] ... | [INFO] [stderr] 943 | | ), [INFO] [stderr] 944 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 920 | match *self { [INFO] [stderr] 921 | Error::IoError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 922 | Error::WalkDirError(ref inner) => write!(f, "{}", inner), [INFO] [stderr] 923 | Error::NoArtefacts(ref path) => { [INFO] [stderr] 924 | write!(f, "Staging area {:?} contains no artefacts", path) [INFO] [stderr] 925 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | / match self { [INFO] [stderr] 951 | | &Error::IoError(ref inner) => { [INFO] [stderr] 952 | | <_ as error::Error>::description(inner) [INFO] [stderr] 953 | | } [INFO] [stderr] ... | [INFO] [stderr] 969 | | } [INFO] [stderr] 970 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 950 | match *self { [INFO] [stderr] 951 | Error::IoError(ref inner) => { [INFO] [stderr] 952 | <_ as error::Error>::description(inner) [INFO] [stderr] 953 | } [INFO] [stderr] 954 | Error::WalkDirError(ref inner) => { [INFO] [stderr] 955 | <_ as error::Error>::description(inner) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:993:9 [INFO] [stderr] | [INFO] [stderr] 993 | / fs::File::create(artefact_path.join("rust-installer-version"))? [INFO] [stderr] 994 | | .write(b"3\n")?; [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:996:9 [INFO] [stderr] | [INFO] [stderr] 996 | / fs::File::create(artefact_path.join("version"))? [INFO] [stderr] 997 | | .write(b"1.2.3 (4d90ac38c 2018-04-03)")?; [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:999:9 [INFO] [stderr] | [INFO] [stderr] 999 | / fs::File::create(artefact_path.join("git-commit-hash"))? [INFO] [stderr] 1000 | | .write(b"4d90ac38c0b61bb69470b61ea2cccea0df48d9e5")?; [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1002:9 [INFO] [stderr] | [INFO] [stderr] 1002 | / fs::File::create(artefact_path.join("components"))? [INFO] [stderr] 1003 | | .write(b"component-a\ncomponent-b\n")?; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1008:9 [INFO] [stderr] | [INFO] [stderr] 1008 | / fs::File::create(component_a_path.join("a-file-1"))? [INFO] [stderr] 1009 | | .write(b"a-data-1")?; [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1010:9 [INFO] [stderr] | [INFO] [stderr] 1010 | / fs::File::create(component_a_path.join("a-file-2"))? [INFO] [stderr] 1011 | | .write(b"a-data-2")?; [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1012:9 [INFO] [stderr] | [INFO] [stderr] 1012 | / fs::File::create(component_a_path.join("manifest.in"))? [INFO] [stderr] 1013 | | .write(b"file:a-file-1\nfile:a-file-2\n")?; [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1018:9 [INFO] [stderr] | [INFO] [stderr] 1018 | / fs::File::create(component_b_path.join("b-file-1"))? [INFO] [stderr] 1019 | | .write(b"b-data-1")?; [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1024:9 [INFO] [stderr] | [INFO] [stderr] 1024 | / fs::File::create(component_b_subdir_path.join("sub-file-1"))? [INFO] [stderr] 1025 | | .write(b"sub-data-1")?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1026:9 [INFO] [stderr] | [INFO] [stderr] 1026 | / fs::File::create(component_b_subdir_path.join("sub-file-2"))? [INFO] [stderr] 1027 | | .write(b"sub-data-2")?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1028:9 [INFO] [stderr] | [INFO] [stderr] 1028 | / fs::File::create(component_b_subdir_path.join("sub-file-3"))? [INFO] [stderr] 1029 | | .write(b"sub-data-3")?; [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1031:9 [INFO] [stderr] | [INFO] [stderr] 1031 | / fs::File::create(component_b_path.join("manifest.in"))? [INFO] [stderr] 1032 | | .write(b"file:b-file-1\ndir:subdir\n")?; [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1057:13 [INFO] [stderr] | [INFO] [stderr] 1057 | artefact.components.get("component-a").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&artefact.components["component-a"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1071:13 [INFO] [stderr] | [INFO] [stderr] 1071 | artefact.components.get("component-b").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&artefact.components["component-b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1119:9 [INFO] [stderr] | [INFO] [stderr] 1119 | / fs::File::create(other_artefact_path.join("rust-installer-version")) [INFO] [stderr] 1120 | | .unwrap() [INFO] [stderr] 1121 | | .write(b"3\n") [INFO] [stderr] 1122 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1144:9 [INFO] [stderr] | [INFO] [stderr] 1144 | / fs::OpenOptions::new() [INFO] [stderr] 1145 | | .write(true) [INFO] [stderr] 1146 | | .truncate(true) [INFO] [stderr] 1147 | | .open(stage.path().join("some-artefact/rust-installer-version")) [INFO] [stderr] 1148 | | .unwrap() [INFO] [stderr] 1149 | | .write(b"37") [INFO] [stderr] 1150 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1234:9 [INFO] [stderr] | [INFO] [stderr] 1234 | / fs::OpenOptions::new() [INFO] [stderr] 1235 | | .write(true) [INFO] [stderr] 1236 | | .append(true) [INFO] [stderr] 1237 | | .open(stage.path().join("some-artefact/components")) [INFO] [stderr] 1238 | | .unwrap() [INFO] [stderr] 1239 | | .write(b"\x88\x88\n") [INFO] [stderr] 1240 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1254:9 [INFO] [stderr] | [INFO] [stderr] 1254 | / fs::OpenOptions::new() [INFO] [stderr] 1255 | | .write(true) [INFO] [stderr] 1256 | | .append(true) [INFO] [stderr] 1257 | | .open(stage.path().join("some-artefact/components")) [INFO] [stderr] 1258 | | .unwrap() [INFO] [stderr] 1259 | | .write(b"invalid\0component\n") [INFO] [stderr] 1260 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1274:9 [INFO] [stderr] | [INFO] [stderr] 1274 | / fs::OpenOptions::new() [INFO] [stderr] 1275 | | .write(true) [INFO] [stderr] 1276 | | .append(true) [INFO] [stderr] 1277 | | .open(stage.path().join("some-artefact/components")) [INFO] [stderr] 1278 | | .unwrap() [INFO] [stderr] 1279 | | .write(b"missing-component\n") [INFO] [stderr] 1280 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:1297:9 [INFO] [stderr] | [INFO] [stderr] 1297 | / fs::OpenOptions::new() [INFO] [stderr] 1298 | | .write(true) [INFO] [stderr] 1299 | | .append(true) [INFO] [stderr] 1300 | | .open(stage.path().join("some-artefact/component-a/manifest.in")) [INFO] [stderr] 1301 | | .unwrap() [INFO] [stderr] 1302 | | .write(b"bogus\n") [INFO] [stderr] 1303 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1335:9 [INFO] [stderr] | [INFO] [stderr] 1335 | / artefact [INFO] [stderr] 1336 | | .components [INFO] [stderr] 1337 | | .get("component-a") [INFO] [stderr] 1338 | | .unwrap() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1335 | &artefact [INFO] [stderr] 1336 | .components["component-a"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1353:9 [INFO] [stderr] | [INFO] [stderr] 1353 | / artefact [INFO] [stderr] 1354 | | .components [INFO] [stderr] 1355 | | .get("component-b") [INFO] [stderr] 1356 | | .unwrap() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1353 | &artefact [INFO] [stderr] 1354 | .components["component-b"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1378:27 [INFO] [stderr] | [INFO] [stderr] 1378 | let component_b = artefact.components.get("component-b").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&artefact.components["component-b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 18 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_release_artefact`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "817875b6e934c7b23ee0eaff94521b59695a84ded9635d38947a5294c0903ed4"` [INFO] running `"docker" "rm" "-f" "817875b6e934c7b23ee0eaff94521b59695a84ded9635d38947a5294c0903ed4"` [INFO] [stdout] 817875b6e934c7b23ee0eaff94521b59695a84ded9635d38947a5294c0903ed4