[INFO] crate rust_md5 0.2.0 is already in cache [INFO] extracting crate rust_md5 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rust_md5/0.2.0 [INFO] extracting crate rust_md5 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_md5/0.2.0 [INFO] validating manifest of rust_md5-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust_md5-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust_md5-0.2.0 [INFO] finished frobbing rust_md5-0.2.0 [INFO] frobbed toml for rust_md5-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rust_md5/0.2.0/Cargo.toml [INFO] started frobbing rust_md5-0.2.0 [INFO] finished frobbing rust_md5-0.2.0 [INFO] frobbed toml for rust_md5-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_md5/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust_md5-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust_md5/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 089e012d8f2618a0cc16b5f63caf0856357d88f39a0cb77f1e224ec2433795e9 [INFO] running `"docker" "start" "-a" "089e012d8f2618a0cc16b5f63caf0856357d88f39a0cb77f1e224ec2433795e9"` [INFO] [stderr] Checking rust_md5 v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / return bytes.iter() [INFO] [stderr] 3 | | .map(|b| format!("{:02x}", b)) [INFO] [stderr] 4 | | .collect::>() [INFO] [stderr] 5 | | .join(""); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 2 | bytes.iter() [INFO] [stderr] 3 | .map(|b| format!("{:02x}", b)) [INFO] [stderr] 4 | .collect::>() [INFO] [stderr] 5 | .join("") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | a: WrappingRotating(0x67452301), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6745_2301` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | b: WrappingRotating(0xefcdab89), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xefcd_ab89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | c: WrappingRotating(0x98badcfe), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x98ba_dcfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | d: WrappingRotating(0x10325476), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1032_5476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/md5/mod.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | return buf.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / return bytes.iter() [INFO] [stderr] 3 | | .map(|b| format!("{:02x}", b)) [INFO] [stderr] 4 | | .collect::>() [INFO] [stderr] 5 | | .join(""); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 2 | bytes.iter() [INFO] [stderr] 3 | .map(|b| format!("{:02x}", b)) [INFO] [stderr] 4 | .collect::>() [INFO] [stderr] 5 | .join("") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | a: WrappingRotating(0x67452301), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6745_2301` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | b: WrappingRotating(0xefcdab89), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xefcd_ab89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | c: WrappingRotating(0x98badcfe), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x98ba_dcfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/md5/mod.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | d: WrappingRotating(0x10325476), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1032_5476` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/md5/mod.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | return buf.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn to_hex_string(bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `list`. [INFO] [stderr] --> src/md5/reader.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for index in 0..=15 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &mut list { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md5/reader.rs:39:48 [INFO] [stderr] | [INFO] [stderr] 39 | list[index] |= (item as u32) << (8 * shift); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(item)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/md5/reader.rs:48:79 [INFO] [stderr] | [INFO] [stderr] 48 | self.state = if size > 1 { Padding(size - 1) } else { self.len = self.len * 8; SizeWriting(8) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len *= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md5/reader.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | list[index] |= (self.len as u8 as u32) << (8 * shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.len as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/md5/mod.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | let x = (2f64.powi(32) * (i as f64).sin().abs()) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn to_hex_string(bytes: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `list`. [INFO] [stderr] --> src/md5/reader.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | for index in 0..=15 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &mut list { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md5/reader.rs:39:48 [INFO] [stderr] | [INFO] [stderr] 39 | list[index] |= (item as u32) << (8 * shift); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(item)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/md5/reader.rs:48:79 [INFO] [stderr] | [INFO] [stderr] 48 | self.state = if size > 1 { Padding(size - 1) } else { self.len = self.len * 8; SizeWriting(8) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len *= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/md5/reader.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | list[index] |= (self.len as u8 as u32) << (8 * shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.len as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/md5/mod.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | let x = (2f64.powi(32) * (i as f64).sin().abs()) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | out.write(&util::to_hex_string(hash_vec).into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | out.write(&format!(" {}\n", filename).into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_md5`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | out.write(&util::to_hex_string(hash_vec).into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | out.write(&format!(" {}\n", filename).into_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_md5`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "089e012d8f2618a0cc16b5f63caf0856357d88f39a0cb77f1e224ec2433795e9"` [INFO] running `"docker" "rm" "-f" "089e012d8f2618a0cc16b5f63caf0856357d88f39a0cb77f1e224ec2433795e9"` [INFO] [stdout] 089e012d8f2618a0cc16b5f63caf0856357d88f39a0cb77f1e224ec2433795e9