[INFO] crate rust_decimal 0.10.2 is already in cache
[INFO] extracting crate rust_decimal 0.10.2 into work/ex/clippy-test-run/sources/stable/reg/rust_decimal/0.10.2
[INFO] extracting crate rust_decimal 0.10.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_decimal/0.10.2
[INFO] validating manifest of rust_decimal-0.10.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rust_decimal-0.10.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rust_decimal-0.10.2
[INFO] finished frobbing rust_decimal-0.10.2
[INFO] frobbed toml for rust_decimal-0.10.2 written to work/ex/clippy-test-run/sources/stable/reg/rust_decimal/0.10.2/Cargo.toml
[INFO] started frobbing rust_decimal-0.10.2
[INFO] finished frobbing rust_decimal-0.10.2
[INFO] frobbed toml for rust_decimal-0.10.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_decimal/0.10.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rust_decimal-0.10.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust_decimal/0.10.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e1199c1596478e5f9e020d8c34cb8b51429a72ae9f63e0146d471a176060148d
[INFO] running `"docker" "start" "-a" "e1199c1596478e5f9e020d8c34cb8b51429a72ae9f63e0146d471a176060148d"`
[INFO] [stderr]     Checking rust_decimal v0.10.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             flags: flags,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 |             lo: lo,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `lo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:180:13
[INFO] [stderr]     |
[INFO] [stderr] 180 |             mid: mid,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `mid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             hi: hi,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `hi`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/decimal.rs:1651:13
[INFO] [stderr]      |
[INFO] [stderr] 1651 |             flags: flags,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/decimal.rs:1669:13
[INFO] [stderr]      |
[INFO] [stderr] 1669 |             flags: flags,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             flags: flags,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 |             lo: lo,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `lo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:180:13
[INFO] [stderr]     |
[INFO] [stderr] 180 |             mid: mid,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `mid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/decimal.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             hi: hi,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `hi`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/decimal.rs:1651:13
[INFO] [stderr]      |
[INFO] [stderr] 1651 |             flags: flags,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/decimal.rs:1669:13
[INFO] [stderr]      |
[INFO] [stderr] 1669 |             flags: flags,
[INFO] [stderr]      |             ^^^^^^^^^^^^ help: replace it with: `flags`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/decimal.rs:2081:58
[INFO] [stderr]      |
[INFO] [stderr] 2081 |                     rem_lo = div_by_u32(&mut u64_result, 2500000000);
[INFO] [stderr]      |                                                          ^^^^^^^^^^ help: consider: `2_500_000_000`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/decimal.rs:2081:58
[INFO] [stderr]      |
[INFO] [stderr] 2081 |                     rem_lo = div_by_u32(&mut u64_result, 2500000000);
[INFO] [stderr]      |                                                          ^^^^^^^^^^ help: consider: `2_500_000_000`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/decimal.rs:205:33
[INFO] [stderr]     |
[INFO] [stderr] 205 |         let base = split.next().ok_or(err.clone())?;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/decimal.rs:206:38
[INFO] [stderr]     |
[INFO] [stderr] 206 |         let mut scale = split.next().ok_or(err.clone())?.to_string();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/decimal.rs:645:17
[INFO] [stderr]     |
[INFO] [stderr] 645 | /                 match order {
[INFO] [stderr] 646 | |                     Ordering::Greater => {
[INFO] [stderr] 647 | |                         add_internal(&mut value, &ONE_INTERNAL_REPR);
[INFO] [stderr] 648 | |                     }
[INFO] [stderr] 649 | |                     _ => {}
[INFO] [stderr] 650 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 645 |                 if let Ordering::Greater = order {
[INFO] [stderr] 646 |     add_internal(&mut value, &ONE_INTERNAL_REPR);
[INFO] [stderr] 647 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/decimal.rs:822:19
[INFO] [stderr]     |
[INFO] [stderr] 822 |               while exponent10 < 0 &&
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 823 | |                 (bits[2] != 0 || bits[1] != 0 || (bits[2] == 0 && bits[1] == 0 && (bits[0] & 0xFF00_0000) != 0))
[INFO] [stderr]     | |________________________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 822 |             while !(bits[2] == 0 && bits[1] == 0 && (bits[0] & 0xFF00_0000) == 0 || exponent10 >= 0)
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 822 |             while (bits[2] != 0 || bits[1] != 0 || (bits[0] & 0xFF00_0000) != 0) && exponent10 < 0
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1642:9
[INFO] [stderr]      |
[INFO] [stderr] 1642 | /         let value_copy: i32;
[INFO] [stderr] 1643 | |         if n >= 0 {
[INFO] [stderr] 1644 | |             flags = 0;
[INFO] [stderr] 1645 | |             value_copy = n;
[INFO] [stderr] ...    |
[INFO] [stderr] 1648 | |             value_copy = -n;
[INFO] [stderr] 1649 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let value_copy = if n >= 0 { ..; n } else { ..; -n };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1660:9
[INFO] [stderr]      |
[INFO] [stderr] 1660 | /         let value_copy: i64;
[INFO] [stderr] 1661 | |         if n >= 0 {
[INFO] [stderr] 1662 | |             flags = 0;
[INFO] [stderr] 1663 | |             value_copy = n;
[INFO] [stderr] ...    |
[INFO] [stderr] 1666 | |             value_copy = -n;
[INFO] [stderr] 1667 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let value_copy = if n >= 0 { ..; n } else { ..; -n };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1938:9
[INFO] [stderr]      |
[INFO] [stderr] 1938 | /         let carry;
[INFO] [stderr] 1939 | |         if !(my_negative ^ other_negative) {
[INFO] [stderr] 1940 | |             negative = my_negative;
[INFO] [stderr] 1941 | |             carry = add3_internal(&mut my, &ot);
[INFO] [stderr] ...    |
[INFO] [stderr] 1965 | |             carry = 0;
[INFO] [stderr] 1966 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let carry = if !(my_negative ^ other_negative) { ..; add3_internal(&mut my, &ot) } else { ..; 0 };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl
[INFO] [stderr]     --> src/decimal.rs:2022:32
[INFO] [stderr]      |
[INFO] [stderr] 2022 |             flags: other.flags ^ SIGN_MASK,
[INFO] [stderr]      |                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2046:27
[INFO] [stderr]      |
[INFO] [stderr] 2046 |         if self.is_zero() || other.is_zero() {
[INFO] [stderr]      |                           ^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2051:48
[INFO] [stderr]      |
[INFO] [stderr] 2051 |         let negative = self.is_sign_negative() ^ other.is_sign_negative();
[INFO] [stderr]      |                                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2055:44
[INFO] [stderr]      |
[INFO] [stderr] 2055 |         let mut final_scale = self.scale() + other.scale();
[INFO] [stderr]      |                                            ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:2077:17
[INFO] [stderr]      |
[INFO] [stderr] 2077 | /                 let mut power;
[INFO] [stderr] 2078 | |                 if final_scale > 9 {
[INFO] [stderr] 2079 | |                     // Since 10^10 doesn't fit into u32, we divide by 10^10/4
[INFO] [stderr] 2080 | |                     // and multiply the next divisor by 4.
[INFO] [stderr] ...    |
[INFO] [stderr] 2084 | |                     power = POWERS_10[final_scale as usize];
[INFO] [stderr] 2085 | |                 }
[INFO] [stderr]      | |_________________^ help: it is more idiomatic to write: `let <mut> power = if final_scale > 9 { ..; POWERS_10[final_scale as usize - 10] << 2 } else { POWERS_10[final_scale as usize] };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `my_index` is used to index `my`
[INFO] [stderr]     --> src/decimal.rs:2135:25
[INFO] [stderr]      |
[INFO] [stderr] 2135 |         for my_index in 0..to {
[INFO] [stderr]      |                         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]      |
[INFO] [stderr] 2135 |         for (my_index, <item>) in my.iter().enumerate().take(to) {
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `ot_index` is used to index `ot`
[INFO] [stderr]     --> src/decimal.rs:2136:29
[INFO] [stderr]      |
[INFO] [stderr] 2136 |             for ot_index in 0..to {
[INFO] [stderr]      |                             ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]      |
[INFO] [stderr] 2136 |             for (ot_index, <item>) in ot.iter().enumerate().take(to) {
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2140:62
[INFO] [stderr]      |
[INFO] [stderr] 2140 |                 for prod in product.iter_mut().skip(my_index + ot_index) {
[INFO] [stderr]      |                                                              ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2186:51
[INFO] [stderr]      |
[INFO] [stderr] 2186 |                 let digit: u64 = u64::from(*part) + 1;
[INFO] [stderr]      |                                                   ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2188:32
[INFO] [stderr]      |
[INFO] [stderr] 2188 |                 *part = (digit & 0xFFFF_FFFF) as u32;
[INFO] [stderr]      |                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2248:59
[INFO] [stderr]      |
[INFO] [stderr] 2248 |         let mut quotient_scale: i32 = self.scale() as i32 - other.scale() as i32;
[INFO] [stderr]      |                                                           ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2289:26
[INFO] [stderr]      |
[INFO] [stderr] 2289 |             if underflow || is_all_zero(&working_remainder) {
[INFO] [stderr]      |                          ^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2330:61
[INFO] [stderr]      |
[INFO] [stderr] 2330 |         let mut quotient_negative = self.is_sign_negative() ^ other.is_sign_negative();
[INFO] [stderr]      |                                                             ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2352:55
[INFO] [stderr]      |
[INFO] [stderr] 2352 |                     let digit: u64 = u64::from(*part) + 1;
[INFO] [stderr]      |                                                       ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2354:36
[INFO] [stderr]      |
[INFO] [stderr] 2354 |                     *part = (digit & 0xFFFF_FFFF) as u32;
[INFO] [stderr]      |                                    ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:2465:9
[INFO] [stderr]      |
[INFO] [stderr] 2465 | /         let right : &Decimal;
[INFO] [stderr] 2466 | |         if self_negative && other_negative {
[INFO] [stderr] 2467 | |             // Both are negative, so reverse cmp
[INFO] [stderr] 2468 | |             left = other;
[INFO] [stderr] ...    |
[INFO] [stderr] 2472 | |             right = other;
[INFO] [stderr] 2473 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let right = if self_negative && other_negative { ..; self } else { ..; other };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 12 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_decimal`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/decimal.rs:205:33
[INFO] [stderr]     |
[INFO] [stderr] 205 |         let base = split.next().ok_or(err.clone())?;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/decimal.rs:206:38
[INFO] [stderr]     |
[INFO] [stderr] 206 |         let mut scale = split.next().ok_or(err.clone())?.to_string();
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/decimal.rs:645:17
[INFO] [stderr]     |
[INFO] [stderr] 645 | /                 match order {
[INFO] [stderr] 646 | |                     Ordering::Greater => {
[INFO] [stderr] 647 | |                         add_internal(&mut value, &ONE_INTERNAL_REPR);
[INFO] [stderr] 648 | |                     }
[INFO] [stderr] 649 | |                     _ => {}
[INFO] [stderr] 650 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 645 |                 if let Ordering::Greater = order {
[INFO] [stderr] 646 |     add_internal(&mut value, &ONE_INTERNAL_REPR);
[INFO] [stderr] 647 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/decimal.rs:822:19
[INFO] [stderr]     |
[INFO] [stderr] 822 |               while exponent10 < 0 &&
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 823 | |                 (bits[2] != 0 || bits[1] != 0 || (bits[2] == 0 && bits[1] == 0 && (bits[0] & 0xFF00_0000) != 0))
[INFO] [stderr]     | |________________________________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 822 |             while !(bits[2] == 0 && bits[1] == 0 && (bits[0] & 0xFF00_0000) == 0 || exponent10 >= 0)
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 822 |             while (bits[2] != 0 || bits[1] != 0 || (bits[0] & 0xFF00_0000) != 0) && exponent10 < 0
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1642:9
[INFO] [stderr]      |
[INFO] [stderr] 1642 | /         let value_copy: i32;
[INFO] [stderr] 1643 | |         if n >= 0 {
[INFO] [stderr] 1644 | |             flags = 0;
[INFO] [stderr] 1645 | |             value_copy = n;
[INFO] [stderr] ...    |
[INFO] [stderr] 1648 | |             value_copy = -n;
[INFO] [stderr] 1649 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let value_copy = if n >= 0 { ..; n } else { ..; -n };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1660:9
[INFO] [stderr]      |
[INFO] [stderr] 1660 | /         let value_copy: i64;
[INFO] [stderr] 1661 | |         if n >= 0 {
[INFO] [stderr] 1662 | |             flags = 0;
[INFO] [stderr] 1663 | |             value_copy = n;
[INFO] [stderr] ...    |
[INFO] [stderr] 1666 | |             value_copy = -n;
[INFO] [stderr] 1667 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let value_copy = if n >= 0 { ..; n } else { ..; -n };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:1938:9
[INFO] [stderr]      |
[INFO] [stderr] 1938 | /         let carry;
[INFO] [stderr] 1939 | |         if !(my_negative ^ other_negative) {
[INFO] [stderr] 1940 | |             negative = my_negative;
[INFO] [stderr] 1941 | |             carry = add3_internal(&mut my, &ot);
[INFO] [stderr] ...    |
[INFO] [stderr] 1965 | |             carry = 0;
[INFO] [stderr] 1966 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let carry = if !(my_negative ^ other_negative) { ..; add3_internal(&mut my, &ot) } else { ..; 0 };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl
[INFO] [stderr]     --> src/decimal.rs:2022:32
[INFO] [stderr]      |
[INFO] [stderr] 2022 |             flags: other.flags ^ SIGN_MASK,
[INFO] [stderr]      |                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2046:27
[INFO] [stderr]      |
[INFO] [stderr] 2046 |         if self.is_zero() || other.is_zero() {
[INFO] [stderr]      |                           ^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2051:48
[INFO] [stderr]      |
[INFO] [stderr] 2051 |         let negative = self.is_sign_negative() ^ other.is_sign_negative();
[INFO] [stderr]      |                                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2055:44
[INFO] [stderr]      |
[INFO] [stderr] 2055 |         let mut final_scale = self.scale() + other.scale();
[INFO] [stderr]      |                                            ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:2077:17
[INFO] [stderr]      |
[INFO] [stderr] 2077 | /                 let mut power;
[INFO] [stderr] 2078 | |                 if final_scale > 9 {
[INFO] [stderr] 2079 | |                     // Since 10^10 doesn't fit into u32, we divide by 10^10/4
[INFO] [stderr] 2080 | |                     // and multiply the next divisor by 4.
[INFO] [stderr] ...    |
[INFO] [stderr] 2084 | |                     power = POWERS_10[final_scale as usize];
[INFO] [stderr] 2085 | |                 }
[INFO] [stderr]      | |_________________^ help: it is more idiomatic to write: `let <mut> power = if final_scale > 9 { ..; POWERS_10[final_scale as usize - 10] << 2 } else { POWERS_10[final_scale as usize] };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `my_index` is used to index `my`
[INFO] [stderr]     --> src/decimal.rs:2135:25
[INFO] [stderr]      |
[INFO] [stderr] 2135 |         for my_index in 0..to {
[INFO] [stderr]      |                         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]      |
[INFO] [stderr] 2135 |         for (my_index, <item>) in my.iter().enumerate().take(to) {
[INFO] [stderr]      |             ^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `ot_index` is used to index `ot`
[INFO] [stderr]     --> src/decimal.rs:2136:29
[INFO] [stderr]      |
[INFO] [stderr] 2136 |             for ot_index in 0..to {
[INFO] [stderr]      |                             ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]      |
[INFO] [stderr] 2136 |             for (ot_index, <item>) in ot.iter().enumerate().take(to) {
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2140:62
[INFO] [stderr]      |
[INFO] [stderr] 2140 |                 for prod in product.iter_mut().skip(my_index + ot_index) {
[INFO] [stderr]      |                                                              ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2186:51
[INFO] [stderr]      |
[INFO] [stderr] 2186 |                 let digit: u64 = u64::from(*part) + 1;
[INFO] [stderr]      |                                                   ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]     --> src/decimal.rs:2188:32
[INFO] [stderr]      |
[INFO] [stderr] 2188 |                 *part = (digit & 0xFFFF_FFFF) as u32;
[INFO] [stderr]      |                                ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2248:59
[INFO] [stderr]      |
[INFO] [stderr] 2248 |         let mut quotient_scale: i32 = self.scale() as i32 - other.scale() as i32;
[INFO] [stderr]      |                                                           ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2289:26
[INFO] [stderr]      |
[INFO] [stderr] 2289 |             if underflow || is_all_zero(&working_remainder) {
[INFO] [stderr]      |                          ^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2330:61
[INFO] [stderr]      |
[INFO] [stderr] 2330 |         let mut quotient_negative = self.is_sign_negative() ^ other.is_sign_negative();
[INFO] [stderr]      |                                                             ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2352:55
[INFO] [stderr]      |
[INFO] [stderr] 2352 |                     let digit: u64 = u64::from(*part) + 1;
[INFO] [stderr]      |                                                       ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Div` impl
[INFO] [stderr]     --> src/decimal.rs:2354:36
[INFO] [stderr]      |
[INFO] [stderr] 2354 |                     *part = (digit & 0xFFFF_FFFF) as u32;
[INFO] [stderr]      |                                    ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/decimal.rs:2465:9
[INFO] [stderr]      |
[INFO] [stderr] 2465 | /         let right : &Decimal;
[INFO] [stderr] 2466 | |         if self_negative && other_negative {
[INFO] [stderr] 2467 | |             // Both are negative, so reverse cmp
[INFO] [stderr] 2468 | |             left = other;
[INFO] [stderr] ...    |
[INFO] [stderr] 2472 | |             right = other;
[INFO] [stderr] 2473 | |         }
[INFO] [stderr]      | |_________^ help: it is more idiomatic to write: `let right = if self_negative && other_negative { ..; self } else { ..; other };`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 12 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_decimal`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e1199c1596478e5f9e020d8c34cb8b51429a72ae9f63e0146d471a176060148d"`
[INFO] running `"docker" "rm" "-f" "e1199c1596478e5f9e020d8c34cb8b51429a72ae9f63e0146d471a176060148d"`
[INFO] [stdout] e1199c1596478e5f9e020d8c34cb8b51429a72ae9f63e0146d471a176060148d