[INFO] crate rust-webvr-api 0.9.2 is already in cache [INFO] extracting crate rust-webvr-api 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/rust-webvr-api/0.9.2 [INFO] extracting crate rust-webvr-api 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-webvr-api/0.9.2 [INFO] validating manifest of rust-webvr-api-0.9.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-webvr-api-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-webvr-api-0.9.2 [INFO] finished frobbing rust-webvr-api-0.9.2 [INFO] frobbed toml for rust-webvr-api-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/rust-webvr-api/0.9.2/Cargo.toml [INFO] started frobbing rust-webvr-api-0.9.2 [INFO] finished frobbing rust-webvr-api-0.9.2 [INFO] frobbed toml for rust-webvr-api-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-webvr-api/0.9.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-webvr-api-0.9.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-webvr-api/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2ba95eec16c461afa7ecdd01d8fd727a79fb44ff41e1cf8b64efb46f4d7f16b [INFO] running `"docker" "start" "-a" "e2ba95eec16c461afa7ecdd01d8fd727a79fb44ff41e1cf8b64efb46f4d7f16b"` [INFO] [stderr] Checking rust-webvr-api v0.9.2 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/utils.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let mut z = f32::max(0.0, 1.0 - m[0][0] - m[1][1] + m[2][2]).sqrt() * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_gamepad.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | pressed: pressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/utils.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let mut z = f32::max(0.0, 1.0 - m[0][0] - m[1][1] + m[2][2]).sqrt() * 0.5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_framebuffer.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vr_gamepad.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | pressed: pressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | timespec.sec as f64 * 1000.0 + (timespec.nsec as f64 * 1e-6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out`. [INFO] [stderr] --> src/utils.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in out.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | out[i] = out[i] / det; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out[i] /= det` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/utils.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / fn determinant3x3(a1: f32, a2: f32, a3: f32, b1: f32, b2: f32, b3: f32, c1: f32, c2: f32, c3: f32) -> f32 { [INFO] [stderr] 103 | | a1 * determinant2x2(b2, b3, c2, c3) [INFO] [stderr] 104 | | - b1 * determinant2x2(a2, a3, c2, c3) [INFO] [stderr] 105 | | + c1 * determinant2x2(a2, a3, b2, b3) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utils.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | let m: &[[f32; 4]; 4] = unsafe { mem::transmute(matrix) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(matrix as *const [f32; 16] as *const [[f32; 4]; 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vr_frame_data.rs:47:38 [INFO] [stderr] | [INFO] [stderr] 47 | ptr::copy_nonoverlapping(mem::transmute(self), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self as *const vr_frame_data::VRFrameData as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vr_frame_data.rs:58:38 [INFO] [stderr] | [INFO] [stderr] 58 | mem::transmute(&mut result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut result as *mut vr_frame_data::VRFrameData as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/vr_event.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | PresentChange(VRDisplayData, bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/vr_event.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | PresentChange(VRDisplayData, bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | timespec.sec as f64 * 1000.0 + (timespec.nsec as f64 * 1e-6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(timespec.nsec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out`. [INFO] [stderr] --> src/utils.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in out.iter_mut().take(16) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | out[i] = out[i] / det; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out[i] /= det` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/utils.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | / fn determinant3x3(a1: f32, a2: f32, a3: f32, b1: f32, b2: f32, b3: f32, c1: f32, c2: f32, c3: f32) -> f32 { [INFO] [stderr] 103 | | a1 * determinant2x2(b2, b3, c2, c3) [INFO] [stderr] 104 | | - b1 * determinant2x2(a2, a3, c2, c3) [INFO] [stderr] 105 | | + c1 * determinant2x2(a2, a3, b2, b3) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utils.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | let m: &[[f32; 4]; 4] = unsafe { mem::transmute(matrix) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(matrix as *const [f32; 16] as *const [[f32; 4]; 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vr_frame_data.rs:47:38 [INFO] [stderr] | [INFO] [stderr] 47 | ptr::copy_nonoverlapping(mem::transmute(self), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self as *const vr_frame_data::VRFrameData as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/vr_frame_data.rs:58:38 [INFO] [stderr] | [INFO] [stderr] 58 | mem::transmute(&mut result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut result as *mut vr_frame_data::VRFrameData as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/vr_event.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | PresentChange(VRDisplayData, bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/vr_event.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | PresentChange(VRDisplayData, bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "e2ba95eec16c461afa7ecdd01d8fd727a79fb44ff41e1cf8b64efb46f4d7f16b"` [INFO] running `"docker" "rm" "-f" "e2ba95eec16c461afa7ecdd01d8fd727a79fb44ff41e1cf8b64efb46f4d7f16b"` [INFO] [stdout] e2ba95eec16c461afa7ecdd01d8fd727a79fb44ff41e1cf8b64efb46f4d7f16b