[INFO] crate rust-unify 0.1.0 is already in cache [INFO] extracting crate rust-unify 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust-unify/0.1.0 [INFO] extracting crate rust-unify 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-unify/0.1.0 [INFO] validating manifest of rust-unify-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-unify-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-unify-0.1.0 [INFO] finished frobbing rust-unify-0.1.0 [INFO] frobbed toml for rust-unify-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-unify/0.1.0/Cargo.toml [INFO] started frobbing rust-unify-0.1.0 [INFO] finished frobbing rust-unify-0.1.0 [INFO] frobbed toml for rust-unify-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-unify/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-unify-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-unify/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df0fcb7b4547192b386198ef98ba4ab40d314cea04b4e08cd735567ba4d4d63f [INFO] running `"docker" "start" "-a" "df0fcb7b4547192b386198ef98ba4ab40d314cea04b4e08cd735567ba4d4d63f"` [INFO] [stderr] Checking rust-unify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/robinsons.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match t { [INFO] [stderr] 18 | | &Term::Variable(_) => vec![t], [INFO] [stderr] 19 | | &Term::Composite(_, ref terms) => { [INFO] [stderr] 20 | | let mut v = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 26 | | _ => vec![], [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *t { [INFO] [stderr] 18 | Term::Variable(_) => vec![t], [INFO] [stderr] 19 | Term::Composite(_, ref terms) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/robinsons.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | s = subs.get(&s).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subs[&s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/robinsons.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | t = subs.get(&t).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subs[&t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Term::Variable(ref name) => write!(f, "{}", name), [INFO] [stderr] 21 | | &Term::Constant(ref value) => write!(f, "{}", value), [INFO] [stderr] 22 | | &Term::Composite(ref name, ref terms) => { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Term::Variable(ref name) => write!(f, "{}", name), [INFO] [stderr] 21 | Term::Constant(ref value) => write!(f, "{}", value), [INFO] [stderr] 22 | Term::Composite(ref name, ref terms) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/robinsons.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match t { [INFO] [stderr] 18 | | &Term::Variable(_) => vec![t], [INFO] [stderr] 19 | | &Term::Composite(_, ref terms) => { [INFO] [stderr] 20 | | let mut v = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 26 | | _ => vec![], [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *t { [INFO] [stderr] 18 | Term::Variable(_) => vec![t], [INFO] [stderr] 19 | Term::Composite(_, ref terms) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/robinsons.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | s = subs.get(&s).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subs[&s]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/robinsons.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | t = subs.get(&t).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&subs[&t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Term::Variable(ref name) => write!(f, "{}", name), [INFO] [stderr] 21 | | &Term::Constant(ref value) => write!(f, "{}", value), [INFO] [stderr] 22 | | &Term::Composite(ref name, ref terms) => { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Term::Variable(ref name) => write!(f, "{}", name), [INFO] [stderr] 21 | Term::Constant(ref value) => write!(f, "{}", value), [INFO] [stderr] 22 | Term::Composite(ref name, ref terms) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "df0fcb7b4547192b386198ef98ba4ab40d314cea04b4e08cd735567ba4d4d63f"` [INFO] running `"docker" "rm" "-f" "df0fcb7b4547192b386198ef98ba4ab40d314cea04b4e08cd735567ba4d4d63f"` [INFO] [stdout] df0fcb7b4547192b386198ef98ba4ab40d314cea04b4e08cd735567ba4d4d63f