[INFO] crate rust-sqlite 0.3.0 is already in cache [INFO] extracting crate rust-sqlite 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rust-sqlite/0.3.0 [INFO] extracting crate rust-sqlite 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-sqlite/0.3.0 [INFO] validating manifest of rust-sqlite-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-sqlite-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-sqlite-0.3.0 [INFO] finished frobbing rust-sqlite-0.3.0 [INFO] frobbed toml for rust-sqlite-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-sqlite/0.3.0/Cargo.toml [INFO] started frobbing rust-sqlite-0.3.0 [INFO] finished frobbing rust-sqlite-0.3.0 [INFO] frobbed toml for rust-sqlite-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-sqlite/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-sqlite-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-sqlite/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab9a497d724d15c059fc0136a77fea980deb0ba41d20a12da1998457f2f56b4b [INFO] running `"docker" "start" "-a" "ab9a497d724d15c059fc0136a77fea980deb0ba41d20a12da1998457f2f56b4b"` [INFO] [stderr] Checking rust-sqlite v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:275:41 [INFO] [stderr] | [INFO] [stderr] 275 | Ok((PreparedStatement { stmt: stmt , db: self.db.clone(), detailed: self.detailed }, offset)) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:275:41 [INFO] [stderr] | [INFO] [stderr] 275 | Ok((PreparedStatement { stmt: stmt , db: self.db.clone(), detailed: self.detailed }, offset)) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:700:9 [INFO] [stderr] | [INFO] [stderr] 700 | desc: desc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:701:9 [INFO] [stderr] | [INFO] [stderr] 701 | detail: detail [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `detail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | Ok(QueryResults { results: results, txform: txform }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:45 [INFO] [stderr] | [INFO] [stderr] 256 | Ok(QueryResults { results: results, txform: txform }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `txform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:700:9 [INFO] [stderr] | [INFO] [stderr] 700 | desc: desc, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:701:9 [INFO] [stderr] | [INFO] [stderr] 701 | detail: detail [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `detail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | Ok(QueryResults { results: results, txform: txform }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:45 [INFO] [stderr] | [INFO] [stderr] 256 | Ok(QueryResults { results: results, txform: txform }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `txform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | const OPEN_READONLY = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | const OPEN_READWRITE = 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | const OPEN_CREATE = 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | const OPEN_URI = 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | const OPEN_MEMORY = 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | const OPEN_NOMUTEX = 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | const OPEN_FULLMUTEX = 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | const OPEN_SHAREDCACHE = 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | const OPEN_PRIVATECACHE = 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | const OPEN_READONLY = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/core.rs:739:13 [INFO] [stderr] | [INFO] [stderr] 739 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/core.rs:738:23 [INFO] [stderr] | [INFO] [stderr] 738 | let res = db.prepare("select 1 + 1").map( |_s| () ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | const OPEN_READONLY = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | const OPEN_READWRITE = 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | const OPEN_CREATE = 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | const OPEN_URI = 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | const OPEN_MEMORY = 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | const OPEN_NOMUTEX = 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | const OPEN_FULLMUTEX = 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | const OPEN_SHAREDCACHE = 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | const OPEN_PRIVATECACHE = 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access/flags.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | const OPEN_READONLY = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | return Ok(x); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/core.rs:254:29 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn prepare<'db:'st, 'st>(&'db self, sql: &str) -> SqliteResult { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/core.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | pub fn prepare_with_offset<'db:'st, 'st>(&'db self, sql: &str) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:352:1 [INFO] [stderr] | [INFO] [stderr] 352 | / fn charstar_str<'a>(utf_bytes: &'a *const c_char) -> Option<&'a str> { [INFO] [stderr] 353 | | if *utf_bytes == ptr::null() { [INFO] [stderr] 354 | | return None; [INFO] [stderr] 355 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | Some( unsafe { str::from_utf8_unchecked(c_str.to_bytes()) } ) [INFO] [stderr] 359 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:352:32 [INFO] [stderr] | [INFO] [stderr] 352 | fn charstar_str<'a>(utf_bytes: &'a *const c_char) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `*const c_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/core.rs:353:8 [INFO] [stderr] | [INFO] [stderr] 353 | if *utf_bytes == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:363:1 [INFO] [stderr] | [INFO] [stderr] 363 | / pub fn str_charstar<'a>(s: &'a str) -> std_ffi::CString { [INFO] [stderr] 364 | | std_ffi::CString::new(s.as_bytes()).unwrap_or(std_ffi::CString::new("").unwrap()) [INFO] [stderr] 365 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:364:41 [INFO] [stderr] | [INFO] [stderr] 364 | std_ffi::CString::new(s.as_bytes()).unwrap_or(std_ffi::CString::new("").unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| std_ffi::CString::new("").unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core.rs:432:30 [INFO] [stderr] | [INFO] [stderr] 432 | self.detail_db().map(|db| DatabaseConnection::_errmsg(db)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DatabaseConnection::_errmsg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:437:18 [INFO] [stderr] | [INFO] [stderr] 437 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:444:18 [INFO] [stderr] | [INFO] [stderr] 444 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:451:18 [INFO] [stderr] | [INFO] [stderr] 451 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:458:18 [INFO] [stderr] | [INFO] [stderr] 458 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:467:18 [INFO] [stderr] | [INFO] [stderr] 467 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:480:18 [INFO] [stderr] | [INFO] [stderr] 480 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/core.rs:485:28 [INFO] [stderr] | [INFO] [stderr] 485 | let val = unsafe { mem::transmute(value.as_ptr()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_ptr() as *const libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | / pub fn column_str<'a>(&'a self, col: ColIx) -> Option<&'a str> { [INFO] [stderr] 649 | | self.column_slice(col).and_then(|slice| str::from_utf8(slice).ok() ) [INFO] [stderr] 650 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:658:5 [INFO] [stderr] | [INFO] [stderr] 658 | / pub fn column_slice<'a>(&'a self, col: ColIx) -> Option<&'a [u8]> { [INFO] [stderr] 659 | | let stmt = self.rows.statement.stmt; [INFO] [stderr] 660 | | let i_col = col as c_int; [INFO] [stderr] 661 | | let bs = unsafe { ffi::sqlite3_column_blob(stmt, i_col) } as *const ::libc::c_uchar; [INFO] [stderr] ... | [INFO] [stderr] 666 | | Some( unsafe { slice::from_raw_parts(bs, len) } ) [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/core.rs:662:12 [INFO] [stderr] | [INFO] [stderr] 662 | if bs == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core.rs:687:36 [INFO] [stderr] | [INFO] [stderr] 687 | let detail = detail_db.map(|db| DatabaseConnection::_errmsg(db)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DatabaseConnection::_errmsg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:85:50 [INFO] [stderr] | [INFO] [stderr] 85 | _ => FromSql::from_sql(row, col).map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(row.column_text(col).unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_text(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(row.column_blob(col).unwrap_or(Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_blob(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | let txt = row.column_text(col).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_text(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/access/mod.rs:54:60 [INFO] [stderr] | [INFO] [stderr] 54 | unsafe { ffi::sqlite3_open_v2(c_filename.as_ptr(), db, flags, ptr::null()) } [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-sqlite`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/core.rs:254:29 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn prepare<'db:'st, 'st>(&'db self, sql: &str) -> SqliteResult { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/core.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | pub fn prepare_with_offset<'db:'st, 'st>(&'db self, sql: &str) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:352:1 [INFO] [stderr] | [INFO] [stderr] 352 | / fn charstar_str<'a>(utf_bytes: &'a *const c_char) -> Option<&'a str> { [INFO] [stderr] 353 | | if *utf_bytes == ptr::null() { [INFO] [stderr] 354 | | return None; [INFO] [stderr] 355 | | } [INFO] [stderr] ... | [INFO] [stderr] 358 | | Some( unsafe { str::from_utf8_unchecked(c_str.to_bytes()) } ) [INFO] [stderr] 359 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:352:32 [INFO] [stderr] | [INFO] [stderr] 352 | fn charstar_str<'a>(utf_bytes: &'a *const c_char) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `*const c_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/core.rs:353:8 [INFO] [stderr] | [INFO] [stderr] 353 | if *utf_bytes == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:363:1 [INFO] [stderr] | [INFO] [stderr] 363 | / pub fn str_charstar<'a>(s: &'a str) -> std_ffi::CString { [INFO] [stderr] 364 | | std_ffi::CString::new(s.as_bytes()).unwrap_or(std_ffi::CString::new("").unwrap()) [INFO] [stderr] 365 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core.rs:364:41 [INFO] [stderr] | [INFO] [stderr] 364 | std_ffi::CString::new(s.as_bytes()).unwrap_or(std_ffi::CString::new("").unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| std_ffi::CString::new("").unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core.rs:432:30 [INFO] [stderr] | [INFO] [stderr] 432 | self.detail_db().map(|db| DatabaseConnection::_errmsg(db)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DatabaseConnection::_errmsg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:437:18 [INFO] [stderr] | [INFO] [stderr] 437 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:444:18 [INFO] [stderr] | [INFO] [stderr] 444 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:451:18 [INFO] [stderr] | [INFO] [stderr] 451 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:458:18 [INFO] [stderr] | [INFO] [stderr] 458 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:467:18 [INFO] [stderr] | [INFO] [stderr] 467 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:480:18 [INFO] [stderr] | [INFO] [stderr] 480 | let ix = i as c_int; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/core.rs:485:28 [INFO] [stderr] | [INFO] [stderr] 485 | let val = unsafe { mem::transmute(value.as_ptr()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.as_ptr() as *const libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | / pub fn column_str<'a>(&'a self, col: ColIx) -> Option<&'a str> { [INFO] [stderr] 649 | | self.column_slice(col).and_then(|slice| str::from_utf8(slice).ok() ) [INFO] [stderr] 650 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core.rs:658:5 [INFO] [stderr] | [INFO] [stderr] 658 | / pub fn column_slice<'a>(&'a self, col: ColIx) -> Option<&'a [u8]> { [INFO] [stderr] 659 | | let stmt = self.rows.statement.stmt; [INFO] [stderr] 660 | | let i_col = col as c_int; [INFO] [stderr] 661 | | let bs = unsafe { ffi::sqlite3_column_blob(stmt, i_col) } as *const ::libc::c_uchar; [INFO] [stderr] ... | [INFO] [stderr] 666 | | Some( unsafe { slice::from_raw_parts(bs, len) } ) [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/core.rs:662:12 [INFO] [stderr] | [INFO] [stderr] 662 | if bs == ptr::null() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core.rs:687:36 [INFO] [stderr] | [INFO] [stderr] 687 | let detail = detail_db.map(|db| DatabaseConnection::_errmsg(db)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DatabaseConnection::_errmsg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/core.rs:763:17 [INFO] [stderr] | [INFO] [stderr] 763 | / loop { [INFO] [stderr] 764 | | match rows.step() { [INFO] [stderr] 765 | | Ok(Some(ref mut row)) => { [INFO] [stderr] 766 | | count += 1; [INFO] [stderr] ... | [INFO] [stderr] 770 | | } [INFO] [stderr] 771 | | } [INFO] [stderr] | |_________________^ help: try: `while let Ok(Some(ref mut row)) = rows.step() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:85:50 [INFO] [stderr] | [INFO] [stderr] 85 | _ => FromSql::from_sql(row, col).map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(row.column_text(col).unwrap_or(String::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_text(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(row.column_blob(col).unwrap_or(Vec::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_blob(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/types.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | let txt = row.column_text(col).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `row.column_text(col).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/access/mod.rs:54:60 [INFO] [stderr] | [INFO] [stderr] 54 | unsafe { ffi::sqlite3_open_v2(c_filename.as_ptr(), db, flags, ptr::null()) } [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:520:17 [INFO] [stderr] | [INFO] [stderr] 520 | / loop { [INFO] [stderr] 521 | | match rows.step() { [INFO] [stderr] 522 | | Ok(Some(ref mut row)) => { [INFO] [stderr] 523 | | count += 1; [INFO] [stderr] ... | [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_________________^ help: try: `while let Ok(Some(ref mut row)) = rows.step() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-sqlite`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ab9a497d724d15c059fc0136a77fea980deb0ba41d20a12da1998457f2f56b4b"` [INFO] running `"docker" "rm" "-f" "ab9a497d724d15c059fc0136a77fea980deb0ba41d20a12da1998457f2f56b4b"` [INFO] [stdout] ab9a497d724d15c059fc0136a77fea980deb0ba41d20a12da1998457f2f56b4b