[INFO] crate rust-riemann_health 0.2.0 is already in cache [INFO] extracting crate rust-riemann_health 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rust-riemann_health/0.2.0 [INFO] extracting crate rust-riemann_health 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-riemann_health/0.2.0 [INFO] validating manifest of rust-riemann_health-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-riemann_health-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-riemann_health-0.2.0 [INFO] finished frobbing rust-riemann_health-0.2.0 [INFO] frobbed toml for rust-riemann_health-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-riemann_health/0.2.0/Cargo.toml [INFO] started frobbing rust-riemann_health-0.2.0 [INFO] finished frobbing rust-riemann_health-0.2.0 [INFO] frobbed toml for rust-riemann_health-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-riemann_health/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-riemann_health-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-riemann_health/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 691b19a020d7f3ad5814337b64072815cc0d670244362e421d4f9cd2537f39b9 [INFO] running `"docker" "start" "-a" "691b19a020d7f3ad5814337b64072815cc0d670244362e421d4f9cd2537f39b9"` [INFO] [stderr] Compiling protobuf v1.7.4 [INFO] [stderr] Compiling sys-info v0.5.6 [INFO] [stderr] Checking riemann_client v0.7.0 [INFO] [stderr] Checking rust-riemann_health v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / let connection ; [INFO] [stderr] 135 | | if matches.opt_present("c") { [INFO] [stderr] 136 | | connection = matches.opt_default("c", "localhost:5555").unwrap(); [INFO] [stderr] 137 | | [INFO] [stderr] ... | [INFO] [stderr] 140 | | connection = String::from("localhost:5555"); [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let connection = if matches.opt_present("c") { matches.opt_default("c", "localhost:5555").unwrap() } else { String::from("localhost:5555") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / let delay; [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | if matches.opt_present("d") { [INFO] [stderr] 149 | | delay = time::Duration::from_millis(matches.opt_default("d", "500").unwrap().parse::().unwrap()) ; [INFO] [stderr] ... | [INFO] [stderr] 152 | | delay = time::Duration::from_millis(500); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let delay = if matches.opt_present("d") { time::Duration::from_millis(matches.opt_default("d", "500").unwrap().parse::().unwrap()) } else { time::Duration::from_millis(500) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / let connection ; [INFO] [stderr] 135 | | if matches.opt_present("c") { [INFO] [stderr] 136 | | connection = matches.opt_default("c", "localhost:5555").unwrap(); [INFO] [stderr] 137 | | [INFO] [stderr] ... | [INFO] [stderr] 140 | | connection = String::from("localhost:5555"); [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let connection = if matches.opt_present("c") { matches.opt_default("c", "localhost:5555").unwrap() } else { String::from("localhost:5555") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / let delay; [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | if matches.opt_present("d") { [INFO] [stderr] 149 | | delay = time::Duration::from_millis(matches.opt_default("d", "500").unwrap().parse::().unwrap()) ; [INFO] [stderr] ... | [INFO] [stderr] 152 | | delay = time::Duration::from_millis(500); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let delay = if matches.opt_present("d") { time::Duration::from_millis(matches.opt_default("d", "500").unwrap().parse::().unwrap()) } else { time::Duration::from_millis(500) };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.47s [INFO] running `"docker" "inspect" "691b19a020d7f3ad5814337b64072815cc0d670244362e421d4f9cd2537f39b9"` [INFO] running `"docker" "rm" "-f" "691b19a020d7f3ad5814337b64072815cc0d670244362e421d4f9cd2537f39b9"` [INFO] [stdout] 691b19a020d7f3ad5814337b64072815cc0d670244362e421d4f9cd2537f39b9