[INFO] crate rust-mpfr 0.1.7 is already in cache [INFO] extracting crate rust-mpfr 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/rust-mpfr/0.1.7 [INFO] extracting crate rust-mpfr 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-mpfr/0.1.7 [INFO] validating manifest of rust-mpfr-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-mpfr-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-mpfr-0.1.7 [INFO] finished frobbing rust-mpfr-0.1.7 [INFO] frobbed toml for rust-mpfr-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/rust-mpfr/0.1.7/Cargo.toml [INFO] started frobbing rust-mpfr-0.1.7 [INFO] finished frobbing rust-mpfr-0.1.7 [INFO] frobbed toml for rust-mpfr-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-mpfr/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-mpfr-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-mpfr/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2a418a6650737fcde52262ae96ec26f7c82575d172cd482853a844489d437ee [INFO] running `"docker" "start" "-a" "b2a418a6650737fcde52262ae96ec26f7c82575d172cd482853a844489d437ee"` [INFO] [stderr] Checking rust-mpfr v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpfr.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | Mpfr { mpfr: mpfr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mpfr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpfr.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | Mpfr { mpfr: mpfr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mpfr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpfr.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | Mpfr { mpfr: mpfr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mpfr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpfr.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | Mpfr { mpfr: mpfr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mpfr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpfr::Mpfr` [INFO] [stderr] --> src/mpfr.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new() -> Mpfr { [INFO] [stderr] 168 | | unsafe { [INFO] [stderr] 169 | | let mut mpfr = uninitialized(); [INFO] [stderr] 170 | | mpfr_init(&mut mpfr); [INFO] [stderr] 171 | | Mpfr { mpfr: mpfr } [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | impl Default for mpfr::Mpfr { [INFO] [stderr] 167 | fn default() -> Self { [INFO] [stderr] 168 | Self::new() [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | let x: Mpfr = From::::from(1.234567); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.234_567` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | let y: Mpfr = From::::from(1.234567); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.234_567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | let z: Mpfr = From::::from(1.234568); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.234_568` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:27:38 [INFO] [stderr] | [INFO] [stderr] 27 | let x: Mpfr = From::::from(-1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | let z: Mpfr = From::::from(1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:139:37 [INFO] [stderr] | [INFO] [stderr] 139 | let b: Mpfr = From::::from(2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_459_045` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpfr::Mpfr` [INFO] [stderr] --> src/mpfr.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new() -> Mpfr { [INFO] [stderr] 168 | | unsafe { [INFO] [stderr] 169 | | let mut mpfr = uninitialized(); [INFO] [stderr] 170 | | mpfr_init(&mut mpfr); [INFO] [stderr] 171 | | Mpfr { mpfr: mpfr } [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 166 | impl Default for mpfr::Mpfr { [INFO] [stderr] 167 | fn default() -> Self { [INFO] [stderr] 168 | Self::new() [INFO] [stderr] 169 | } [INFO] [stderr] 170 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mpfr.rs:252:29 [INFO] [stderr] | [INFO] [stderr] 252 | exp as mpfr_exp_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/test.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert!(x <= x && x <= y && x <= z && y <= z); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `>=` [INFO] [stderr] --> src/test.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | assert!(z >= z && z >= y && z >= x && y >= x); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/test.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | x / y; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/test.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | x / y; [INFO] [stderr] | ^^^^^^ help: replace it with: `x;y;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::E` found. Consider using it directly [INFO] [stderr] --> src/test.rs:139:37 [INFO] [stderr] | [INFO] [stderr] 139 | let b: Mpfr = From::::from(2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(c, 0.1234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(c, 0.1234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-mpfr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b2a418a6650737fcde52262ae96ec26f7c82575d172cd482853a844489d437ee"` [INFO] running `"docker" "rm" "-f" "b2a418a6650737fcde52262ae96ec26f7c82575d172cd482853a844489d437ee"` [INFO] [stdout] b2a418a6650737fcde52262ae96ec26f7c82575d172cd482853a844489d437ee