[INFO] crate rust-monster 0.1.0 is already in cache [INFO] extracting crate rust-monster 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust-monster/0.1.0 [INFO] extracting crate rust-monster 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-monster/0.1.0 [INFO] validating manifest of rust-monster-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-monster-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-monster-0.1.0 [INFO] finished frobbing rust-monster-0.1.0 [INFO] frobbed toml for rust-monster-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-monster/0.1.0/Cargo.toml [INFO] started frobbing rust-monster-0.1.0 [INFO] finished frobbing rust-monster-0.1.0 [INFO] frobbed toml for rust-monster-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-monster/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-monster-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-monster/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75fbdf885ec94aa6571f6cb479432c4d2912a176d7fd05807f6bff8abd5eb10b [INFO] running `"docker" "start" "-a" "75fbdf885ec94aa6571f6cb479432c4d2912a176d7fd05807f6bff8abd5eb10b"` [INFO] [stderr] Checking rust-monster v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ga/ga_random.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ga/ga_core.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | const DEBUG_FLAG = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ga/ga_core.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | const DEBUG_FLAG = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ga/ga_population.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | gap [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ga/ga_population.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | let gap = GAPopulation [INFO] [stderr] | ___________________^ [INFO] [stderr] 52 | | { [INFO] [stderr] 53 | | population: p, [INFO] [stderr] 54 | | sort_order: order, [INFO] [stderr] ... | [INFO] [stderr] 58 | | is_scaled_sorted: false [INFO] [stderr] 59 | | }; [INFO] [stderr] | |___________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ga/ga_population.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return &mut self.population [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.population` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ga/ga_simple.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / if self.config.elitism() [INFO] [stderr] 157 | | { [INFO] [stderr] 158 | | if best_old_individual.fitness() > self.population.worst().fitness() [INFO] [stderr] 159 | | { [INFO] [stderr] 160 | | // population.swap_individual(best_old_individual, ...) [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | if self.config.elitism() && best_old_individual.fitness() > self.population.worst().fitness() { [INFO] [stderr] 157 | // population.swap_individual(best_old_individual, ...) [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `population` [INFO] [stderr] --> src/ga/ga_selectors.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | fn update(&mut self, population: &mut GAPopulation) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_population` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `pMutation` should have a snake case name such as `p_mutation` [INFO] [stderr] --> src/ga/ga_core.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | fn mutate(&mut self, pMutation : f32); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ga/ga_population.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | for ref mut ind in &mut self.population [INFO] [stderr] | ^^^^^^^^^^^ -------------------- help: try: `let ind = &mut &mut self.population;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ga/ga_simple.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / let mut new_ind = ind.clone(); [INFO] [stderr] 138 | | if self.rng_ctx.test_value(self.config.probability_crossover()) [INFO] [stderr] 139 | | { [INFO] [stderr] 140 | | let ind_2 = self.population.select(); [INFO] [stderr] 141 | | new_ind = ind.crossover(ind_2); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let new_ind = if self.rng_ctx.test_value(self.config.probability_crossover()) { ..; ind.crossover(ind_2) } else { ind.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_selectors.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if self.score_selection.score(population.individual(i, population_sort_basis)) != best_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.score_selection.score(population.individual(i, population_sort_basis)) - best_score).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_selectors.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if self.score_selection.score(population.individual(i, population_sort_basis)) != best_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ga/ga_selectors.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | best_count = best_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `best_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ga::ga_selectors::GAUniformSelector` [INFO] [stderr] --> src/ga/ga_selectors.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> GAUniformSelector [INFO] [stderr] 187 | | { [INFO] [stderr] 188 | | GAUniformSelector [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_selectors.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | if max_score == min_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(max_score - min_score).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_selectors.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | if max_score == min_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-monster`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ga/ga_core.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | const DEBUG_FLAG = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ga/ga_core.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | const DEBUG_FLAG = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ga/ga_population.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | gap [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ga/ga_population.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | let gap = GAPopulation [INFO] [stderr] | ___________________^ [INFO] [stderr] 52 | | { [INFO] [stderr] 53 | | population: p, [INFO] [stderr] 54 | | sort_order: order, [INFO] [stderr] ... | [INFO] [stderr] 58 | | is_scaled_sorted: false [INFO] [stderr] 59 | | }; [INFO] [stderr] | |___________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ga/ga_population.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return &mut self.population [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.population` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ga/ga_simple.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / if self.config.elitism() [INFO] [stderr] 157 | | { [INFO] [stderr] 158 | | if best_old_individual.fitness() > self.population.worst().fitness() [INFO] [stderr] 159 | | { [INFO] [stderr] 160 | | // population.swap_individual(best_old_individual, ...) [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | if self.config.elitism() && best_old_individual.fitness() > self.population.worst().fitness() { [INFO] [stderr] 157 | // population.swap_individual(best_old_individual, ...) [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `population` [INFO] [stderr] --> src/ga/ga_selectors.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | fn update(&mut self, population: &mut GAPopulation) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_population` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `pMutation` should have a snake case name such as `p_mutation` [INFO] [stderr] --> src/ga/ga_core.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | fn mutate(&mut self, pMutation : f32); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ga/ga_population.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | for ref mut ind in &mut self.population [INFO] [stderr] | ^^^^^^^^^^^ -------------------- help: try: `let ind = &mut &mut self.population;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_random.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(ga_ctx.gen::(), ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_random.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(ga_ctx.gen::(), ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_random.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | assert!(ga_ctx.gen::() != ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(ga_ctx.gen::() - ga_ctx_2.gen::()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_random.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | assert!(ga_ctx.gen::() != ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_random.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(ga_ctx.gen::(), ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_random.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(ga_ctx.gen::(), ga_ctx_2.gen::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ga/ga_simple.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / let mut new_ind = ind.clone(); [INFO] [stderr] 138 | | if self.rng_ctx.test_value(self.config.probability_crossover()) [INFO] [stderr] 139 | | { [INFO] [stderr] 140 | | let ind_2 = self.population.select(); [INFO] [stderr] 141 | | new_ind = ind.crossover(ind_2); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let new_ind = if self.rng_ctx.test_value(self.config.probability_crossover()) { ..; ind.crossover(ind_2) } else { ind.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_selectors.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if self.score_selection.score(population.individual(i, population_sort_basis)) != best_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.score_selection.score(population.individual(i, population_sort_basis)) - best_score).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_selectors.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if self.score_selection.score(population.individual(i, population_sort_basis)) != best_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ga/ga_selectors.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | best_count = best_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `best_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ga::ga_selectors::GAUniformSelector` [INFO] [stderr] --> src/ga/ga_selectors.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> GAUniformSelector [INFO] [stderr] 187 | | { [INFO] [stderr] 188 | | GAUniformSelector [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ga/ga_selectors.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | if max_score == min_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(max_score - min_score).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ga/ga_selectors.rs:253:12 [INFO] [stderr] | [INFO] [stderr] 253 | if max_score == min_score [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-monster`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "75fbdf885ec94aa6571f6cb479432c4d2912a176d7fd05807f6bff8abd5eb10b"` [INFO] running `"docker" "rm" "-f" "75fbdf885ec94aa6571f6cb479432c4d2912a176d7fd05807f6bff8abd5eb10b"` [INFO] [stdout] 75fbdf885ec94aa6571f6cb479432c4d2912a176d7fd05807f6bff8abd5eb10b