[INFO] crate rust-lzo 0.6.2 is already in cache [INFO] extracting crate rust-lzo 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/rust-lzo/0.6.2 [INFO] extracting crate rust-lzo 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-lzo/0.6.2 [INFO] validating manifest of rust-lzo-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lzo-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lzo-0.6.2 [INFO] finished frobbing rust-lzo-0.6.2 [INFO] frobbed toml for rust-lzo-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/rust-lzo/0.6.2/Cargo.toml [INFO] started frobbing rust-lzo-0.6.2 [INFO] finished frobbing rust-lzo-0.6.2 [INFO] frobbed toml for rust-lzo-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-lzo/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lzo-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-lzo/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40cf9dc1f45d0ac75eaa301009edd61b49f119410b889087d67d22d02235ec35 [INFO] running `"docker" "start" "-a" "40cf9dc1f45d0ac75eaa301009edd61b49f119410b889087d67d22d02235ec35"` [INFO] [stderr] Checking rust-lzo v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lzo1x_compress.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | 1isize + ((ip as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 82 | | ii as (isize) [INFO] [stderr] 83 | | ) / ::std::mem::size_of::() as (isize) >> 5i32) [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 81 | 1isize + (((ip as (isize)).wrapping_sub( [INFO] [stderr] 82 | ii as (isize) [INFO] [stderr] 83 | ) / ::std::mem::size_of::() as (isize)) >> 5i32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lzo1x_compress.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | t = (dv.wrapping_mul( [INFO] [stderr] | __________________^ [INFO] [stderr] 91 | | 0x1824429du32 [INFO] [stderr] 92 | | ) >> 32i32 - 13i32 & (1u32 << 13i32).wrapping_sub( [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 90 | t = (dv.wrapping_mul( [INFO] [stderr] 91 | 0x1824429du32 [INFO] [stderr] 92 | ) >> (32i32 - 13i32) & (1u32 << 13i32).wrapping_sub( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lzo1x_compress.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | 0x1824429du32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1824_429du32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lzo1x_compress.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | 1isize + ((ip as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 82 | | ii as (isize) [INFO] [stderr] 83 | | ) / ::std::mem::size_of::() as (isize) >> 5i32) [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 81 | 1isize + (((ip as (isize)).wrapping_sub( [INFO] [stderr] 82 | ii as (isize) [INFO] [stderr] 83 | ) / ::std::mem::size_of::() as (isize)) >> 5i32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lzo1x_compress.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | t = (dv.wrapping_mul( [INFO] [stderr] | __________________^ [INFO] [stderr] 91 | | 0x1824429du32 [INFO] [stderr] 92 | | ) >> 32i32 - 13i32 & (1u32 << 13i32).wrapping_sub( [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 90 | t = (dv.wrapping_mul( [INFO] [stderr] 91 | 0x1824429du32 [INFO] [stderr] 92 | ) >> (32i32 - 13i32) & (1u32 << 13i32).wrapping_sub( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lzo1x_compress.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | 0x1824429du32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1824_429du32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut input : *const u8 = p as (*const u8); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | mut v : u32, mut p : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | mut out_len : *mut usize, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | mut wrkmem : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:453:5 [INFO] [stderr] | [INFO] [stderr] 453 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:454:5 [INFO] [stderr] | [INFO] [stderr] 454 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:455:5 [INFO] [stderr] | [INFO] [stderr] 455 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:456:5 [INFO] [stderr] | [INFO] [stderr] 456 | mut out_len : *mut usize, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | mut wrkmem : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | let mut ll [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | let mut ll_end : usize = (ip as (usize)).wrapping_add(ll); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let mut input : *const u8 = p as (*const u8); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | mut out_len : *mut usize [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | let mut oe : *mut u8 = op.offset(t as (isize)); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:16:6 [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*input.offset(0isize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 17 | | 1isize [INFO] [stderr] 18 | | ) as (i32) << 8i32 | *input.offset( [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | i32::from(*input.offset( [INFO] [stderr] 17 | 1isize [INFO] [stderr] 18 | )) << 8i32 | *input.offset( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:18:61 [INFO] [stderr] | [INFO] [stderr] 18 | ) as (i32) << 8i32 | *input.offset( [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 19 | | 2isize [INFO] [stderr] 20 | | ) as (i32) << 16i32 | *input.offset( [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | ) as (i32) << 8i32 | i32::from(*input.offset( [INFO] [stderr] 19 | 2isize [INFO] [stderr] 20 | )) << 16i32 | *input.offset( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:20:84 [INFO] [stderr] | [INFO] [stderr] 20 | ) as (i32) << 16i32 | *input.offset( [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 21 | | 3isize [INFO] [stderr] 22 | | ) as (i32) << 24i32) as (u32) [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | ) as (i32) << 16i32 | i32::from(*input.offset( [INFO] [stderr] 21 | 3isize [INFO] [stderr] 22 | )) << 24i32) as (u32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:175:32 [INFO] [stderr] | [INFO] [stderr] 175 | if !(tt > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `tt <= 255usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:227:28 [INFO] [stderr] | [INFO] [stderr] 227 | if !(t >= 16usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `t < 16usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | if !({ [INFO] [stderr] | ________________________________^ [INFO] [stderr] 243 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 244 | | t [INFO] [stderr] 245 | | } > 0usize) { [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | if { [INFO] [stderr] 243 | t = t.wrapping_sub(1usize); [INFO] [stderr] 244 | t [INFO] [stderr] 245 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:355:32 [INFO] [stderr] | [INFO] [stderr] 355 | if !(m_len > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `m_len <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:399:32 [INFO] [stderr] | [INFO] [stderr] 399 | if !(m_len > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `m_len <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lzo1x_compress.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / unsafe extern fn lzo1x_1_do_compress( [INFO] [stderr] 48 | | mut in_ : *const u8, [INFO] [stderr] 49 | | mut in_len : usize, [INFO] [stderr] 50 | | mut out : *mut u8, [INFO] [stderr] ... | [INFO] [stderr] 448 | | ) / ::std::mem::size_of::() as (isize)) as (usize) [INFO] [stderr] 449 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/lzo1x_compress.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | / 'loop17: loop { [INFO] [stderr] 233 | | *{ [INFO] [stderr] 234 | | let _old = op; [INFO] [stderr] 235 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/lzo1x_compress.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | / 'loop14: loop { [INFO] [stderr] 192 | | put_unaligned( [INFO] [stderr] 193 | | get_unaligned( [INFO] [stderr] 194 | | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/lzo1x_compress.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / 'loop3: loop { [INFO] [stderr] 86 | | if ip >= ip_end { [INFO] [stderr] 87 | | break 'loop2; [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 440 | | } [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop42` [INFO] [stderr] --> src/lzo1x_compress.rs:354:25 [INFO] [stderr] | [INFO] [stderr] 354 | / 'loop42: loop { [INFO] [stderr] 355 | | if !(m_len > 255usize) { [INFO] [stderr] 356 | | break; [INFO] [stderr] 357 | | } [INFO] [stderr] ... | [INFO] [stderr] 363 | | } = 0u8; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop10` [INFO] [stderr] --> src/lzo1x_compress.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | / 'loop10: loop { [INFO] [stderr] 175 | | if !(tt > 255usize) { [INFO] [stderr] 176 | | break; [INFO] [stderr] 177 | | } [INFO] [stderr] ... | [INFO] [stderr] 183 | | } = 0u8; [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop35` [INFO] [stderr] --> src/lzo1x_compress.rs:398:25 [INFO] [stderr] | [INFO] [stderr] 398 | / 'loop35: loop { [INFO] [stderr] 399 | | if !(m_len > 255usize) { [INFO] [stderr] 400 | | break; [INFO] [stderr] 401 | | } [INFO] [stderr] ... | [INFO] [stderr] 407 | | } = 0u8; [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/lzo1x_compress.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | / 'loop22: loop { [INFO] [stderr] 261 | | if _currentBlock == 22 { [INFO] [stderr] 262 | | m_len = m_len.wrapping_add(1usize); [INFO] [stderr] 263 | | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_compress.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let in_end : *const u8 = in_.offset(in_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | = in_.offset(in_len as (isize)).offset(-20isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | ip = ip.offset( [INFO] [stderr] | __________^ [INFO] [stderr] 68 | | if ti < 4usize { [INFO] [stderr] 69 | | 4usize.wrapping_sub(ti) [INFO] [stderr] 70 | | } else { [INFO] [stderr] 71 | | 0usize [INFO] [stderr] 72 | | } as (isize) [INFO] [stderr] 73 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | ip = ip.add(if ti < 4usize { [INFO] [stderr] 68 | 4usize.wrapping_sub(ti) [INFO] [stderr] 69 | } else { [INFO] [stderr] 70 | 0usize [INFO] [stderr] 71 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | m_pos = in_.offset(*dict.offset(t as (isize)) as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dict.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | *dict.offset(t as (isize)) = ((ip as (isize)).wrapping_sub( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dict.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | op = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | / ii.offset( [INFO] [stderr] 136 | | 4isize [INFO] [stderr] 137 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | / ii.offset( [INFO] [stderr] 144 | | 8isize [INFO] [stderr] 145 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | / ii.offset(8isize).offset( [INFO] [stderr] 152 | | 4isize [INFO] [stderr] 153 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | / op.offset(8isize).offset( [INFO] [stderr] 156 | | 4isize [INFO] [stderr] 157 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | op = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:194:33 [INFO] [stderr] | [INFO] [stderr] 194 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:196:29 [INFO] [stderr] | [INFO] [stderr] 196 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:200:33 [INFO] [stderr] | [INFO] [stderr] 200 | / ii.offset( [INFO] [stderr] 201 | | 4isize [INFO] [stderr] 202 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:208:33 [INFO] [stderr] | [INFO] [stderr] 208 | / ii.offset( [INFO] [stderr] 209 | | 8isize [INFO] [stderr] 210 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:216:33 [INFO] [stderr] | [INFO] [stderr] 216 | / ii.offset(8isize).offset( [INFO] [stderr] 217 | | 4isize [INFO] [stderr] 218 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:220:29 [INFO] [stderr] | [INFO] [stderr] 220 | / op.offset(8isize).offset( [INFO] [stderr] 221 | | 4isize [INFO] [stderr] 222 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:253:16 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:253:57 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 254 | | m_len as (isize) [INFO] [stderr] 255 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == i32::from(*m_pos.offset( [INFO] [stderr] 254 | m_len as (isize) [INFO] [stderr] 255 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:253:58 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 254 | | m_len as (isize) [INFO] [stderr] 255 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:263:24 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:263:25 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:263:65 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 264 | | m_len as (isize) [INFO] [stderr] 265 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 264 | m_len as (isize) [INFO] [stderr] 265 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:263:66 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 264 | | m_len as (isize) [INFO] [stderr] 265 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:270:24 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:270:65 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 271 | | m_len as (isize) [INFO] [stderr] 272 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 271 | m_len as (isize) [INFO] [stderr] 272 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:270:66 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 271 | | m_len as (isize) [INFO] [stderr] 272 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:277:24 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:277:65 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 278 | | m_len as (isize) [INFO] [stderr] 279 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 278 | m_len as (isize) [INFO] [stderr] 279 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:277:66 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 278 | | m_len as (isize) [INFO] [stderr] 279 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:284:24 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:284:25 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:284:65 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 285 | | m_len as (isize) [INFO] [stderr] 286 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 285 | m_len as (isize) [INFO] [stderr] 286 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:284:66 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 285 | | m_len as (isize) [INFO] [stderr] 286 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:291:24 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:291:65 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 292 | | m_len as (isize) [INFO] [stderr] 293 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 292 | m_len as (isize) [INFO] [stderr] 293 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:291:66 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 292 | | m_len as (isize) [INFO] [stderr] 293 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:298:24 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:298:25 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:298:65 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 299 | | m_len as (isize) [INFO] [stderr] 300 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 299 | m_len as (isize) [INFO] [stderr] 300 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:298:66 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 299 | | m_len as (isize) [INFO] [stderr] 300 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:305:24 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:305:25 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:305:65 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 306 | | m_len as (isize) [INFO] [stderr] 307 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 306 | m_len as (isize) [INFO] [stderr] 307 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:305:66 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 306 | | m_len as (isize) [INFO] [stderr] 307 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:312:24 [INFO] [stderr] | [INFO] [stderr] 312 | if ip.offset(m_len as (isize)) >= ip_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:316:25 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:316:65 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 317 | | m_len as (isize) [INFO] [stderr] 318 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == i32::from(*m_pos.offset( [INFO] [stderr] 317 | m_len as (isize) [INFO] [stderr] 318 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:316:66 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 317 | | m_len as (isize) [INFO] [stderr] 318 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:327:26 [INFO] [stderr] | [INFO] [stderr] 327 | ip = ip.offset(m_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32i32` [INFO] [stderr] --> src/lzo1x_compress.rs:353:30 [INFO] [stderr] | [INFO] [stderr] 353 | } = (32i32 | 0i32) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:465:12 [INFO] [stderr] | [INFO] [stderr] 465 | if !(l > 20usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `l <= 20usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:520:20 [INFO] [stderr] | [INFO] [stderr] 520 | if !(tt > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `tt <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:603:20 [INFO] [stderr] | [INFO] [stderr] 603 | if !({ [INFO] [stderr] | ____________________^ [INFO] [stderr] 604 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 605 | | t [INFO] [stderr] 606 | | } > 0usize) { [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 603 | if { [INFO] [stderr] 604 | t = t.wrapping_sub(1usize); [INFO] [stderr] 605 | t [INFO] [stderr] 606 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop19` [INFO] [stderr] --> src/lzo1x_compress.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | / 'loop19: loop { [INFO] [stderr] 594 | | *{ [INFO] [stderr] 595 | | let _old = op; [INFO] [stderr] 596 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 608 | | } [INFO] [stderr] 609 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/lzo1x_compress.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop9: loop { [INFO] [stderr] 520 | | if !(tt > 255usize) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 528 | | } = 0u8; [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/lzo1x_compress.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / 'loop1: loop { [INFO] [stderr] 465 | | if !(l > 20usize) { [INFO] [stderr] 466 | | break; [INFO] [stderr] 467 | | } [INFO] [stderr] ... | [INFO] [stderr] 489 | | l = l.wrapping_sub(ll); [INFO] [stderr] 490 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop16` [INFO] [stderr] --> src/lzo1x_compress.rs:541:9 [INFO] [stderr] | [INFO] [stderr] 541 | / 'loop16: loop { [INFO] [stderr] 542 | | if _currentBlock == 16 { [INFO] [stderr] 543 | | put_unaligned( [INFO] [stderr] 544 | | get_unaligned( [INFO] [stderr] ... | [INFO] [stderr] 589 | | } [INFO] [stderr] 590 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_compress.rs:459:9 [INFO] [stderr] | [INFO] [stderr] 459 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:487:14 [INFO] [stderr] | [INFO] [stderr] 487 | ip = ip.offset(ll as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(ll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | op = op.offset(*out_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(*out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:495:15 [INFO] [stderr] | [INFO] [stderr] 495 | = in_.offset(in_len as (isize)).offset(-(t as (isize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:545:25 [INFO] [stderr] | [INFO] [stderr] 545 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:547:21 [INFO] [stderr] | [INFO] [stderr] 547 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:551:25 [INFO] [stderr] | [INFO] [stderr] 551 | / ii.offset( [INFO] [stderr] 552 | | 4isize [INFO] [stderr] 553 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:559:25 [INFO] [stderr] | [INFO] [stderr] 559 | / ii.offset( [INFO] [stderr] 560 | | 8isize [INFO] [stderr] 561 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:567:25 [INFO] [stderr] | [INFO] [stderr] 567 | / ii.offset(8isize).offset( [INFO] [stderr] 568 | | 4isize [INFO] [stderr] 569 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | / op.offset(8isize).offset( [INFO] [stderr] 572 | | 4isize [INFO] [stderr] 573 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:5:6 [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*input.offset(0isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:5:39 [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 6 | | 1isize [INFO] [stderr] 7 | | ) as (i32) << 8i32) as (u16) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | i32::from(*input.offset( [INFO] [stderr] 6 | 1isize [INFO] [stderr] 7 | )) << 8i32) as (u16) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if !(in_len < 3usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `in_len >= 3usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 49 | | ip as (isize) [INFO] [stderr] 50 | | ) / ::std::mem::size_of::( [INFO] [stderr] 51 | | ) as (isize)) as (usize) >= t.wrapping_add(3usize)) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 49 | ip as (isize) [INFO] [stderr] 50 | ) / ::std::mem::size_of::( [INFO] [stderr] 51 | ) as (isize)) as (usize) < t.wrapping_add(3usize) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 56 | | op as (isize) [INFO] [stderr] 57 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 56 | op as (isize) [INFO] [stderr] 57 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | if !(t > 0usize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `t <= 0usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 94 | | ip as (isize) [INFO] [stderr] 95 | | ) / ::std::mem::size_of::( [INFO] [stderr] 96 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 94 | ip as (isize) [INFO] [stderr] 95 | ) / ::std::mem::size_of::( [INFO] [stderr] 96 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:139:28 [INFO] [stderr] | [INFO] [stderr] 139 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 140 | | op as (isize) [INFO] [stderr] 141 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 140 | op as (isize) [INFO] [stderr] 141 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 188 | | ip as (isize) [INFO] [stderr] 189 | | ) / ::std::mem::size_of::( [INFO] [stderr] 190 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 187 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 188 | ip as (isize) [INFO] [stderr] 189 | ) / ::std::mem::size_of::( [INFO] [stderr] 190 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:214:28 [INFO] [stderr] | [INFO] [stderr] 214 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 215 | | ip as (isize) [INFO] [stderr] 216 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 215 | ip as (isize) [INFO] [stderr] 216 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:240:32 [INFO] [stderr] | [INFO] [stderr] 240 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 241 | | ip as (isize) [INFO] [stderr] 242 | | ) / ::std::mem::size_of::( [INFO] [stderr] 243 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 240 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 241 | ip as (isize) [INFO] [stderr] 242 | ) / ::std::mem::size_of::( [INFO] [stderr] 243 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | ip as (isize) [INFO] [stderr] 269 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 268 | ip as (isize) [INFO] [stderr] 269 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 292 | | op as (isize) [INFO] [stderr] 293 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 292 | op as (isize) [INFO] [stderr] 293 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:311:24 [INFO] [stderr] | [INFO] [stderr] 311 | if !(op < oe) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `op >= oe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 318 | | op as (isize) [INFO] [stderr] 319 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 318 | op as (isize) [INFO] [stderr] 319 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 324 | | ip as (isize) [INFO] [stderr] 325 | | ) / ::std::mem::size_of::( [INFO] [stderr] 326 | | ) as (isize)) as (usize) >= t.wrapping_add(3usize)) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 324 | ip as (isize) [INFO] [stderr] 325 | ) / ::std::mem::size_of::( [INFO] [stderr] 326 | ) as (isize)) as (usize) < t.wrapping_add(3usize) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:340:24 [INFO] [stderr] | [INFO] [stderr] 340 | if !({ [INFO] [stderr] | ________________________^ [INFO] [stderr] 341 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 342 | | t [INFO] [stderr] 343 | | } > 0usize) { [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 340 | if { [INFO] [stderr] 341 | t = t.wrapping_sub(1usize); [INFO] [stderr] 342 | t [INFO] [stderr] 343 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub unsafe extern fn lzo1x_decompress_safe( [INFO] [stderr] 12 | | mut in_ : *const u8, [INFO] [stderr] 13 | | mut in_len : usize, [INFO] [stderr] 14 | | mut out : *mut u8, [INFO] [stderr] ... | [INFO] [stderr] 387 | | -4i32 [INFO] [stderr] 388 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | / 'loop22: loop { [INFO] [stderr] 183 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 184 | | break; [INFO] [stderr] 185 | | } [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop43` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | / 'loop43: loop { [INFO] [stderr] 89 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 90 | | break; [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop49` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | / 'loop49: loop { [INFO] [stderr] 331 | | *{ [INFO] [stderr] 332 | | let _old = op; [INFO] [stderr] 333 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 345 | | } [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop12` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:235:25 [INFO] [stderr] | [INFO] [stderr] 235 | / 'loop12: loop { [INFO] [stderr] 236 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 237 | | break; [INFO] [stderr] 238 | | } [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop35` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:301:17 [INFO] [stderr] | [INFO] [stderr] 301 | / 'loop35: loop { [INFO] [stderr] 302 | | *{ [INFO] [stderr] 303 | | let _old = op; [INFO] [stderr] 304 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop6` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | / 'loop6: loop { [INFO] [stderr] 62 | | if !(t > 0usize) { [INFO] [stderr] 63 | | _currentBlock = 7; [INFO] [stderr] 64 | | break; [INFO] [stderr] ... | [INFO] [stderr] 75 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | let ip_end : *const u8 = in_.offset(in_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let op_end : *mut u8 = out.offset(*out_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(*out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if *ip as (i32) > 17i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | t = (*{ [INFO] [stderr] | __________________^ [INFO] [stderr] 31 | | let _old = ip; [INFO] [stderr] 32 | | ip = ip.offset(1isize); [INFO] [stderr] 33 | | _old [INFO] [stderr] 34 | | } as (i32) - 17i32) as (usize); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | t = (i32::from(*{ [INFO] [stderr] 31 | let _old = ip; [INFO] [stderr] 32 | ip = ip.offset(1isize); [INFO] [stderr] 33 | _old [INFO] [stderr] 34 | }) - 17i32) as (usize); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | -((*{ [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 130 | | let _old = ip; [INFO] [stderr] 131 | | ip = ip.offset(1isize); [INFO] [stderr] 132 | | _old [INFO] [stderr] 133 | | } as (i32) << 2i32) as (isize)) [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | -((i32::from(*{ [INFO] [stderr] 130 | let _old = ip; [INFO] [stderr] 131 | ip = ip.offset(1isize); [INFO] [stderr] 132 | _old [INFO] [stderr] 133 | }) << 2i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:155:40 [INFO] [stderr] | [INFO] [stderr] 155 | -((*{ [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 156 | | let _old = ip; [INFO] [stderr] 157 | | ip = ip.offset(1isize); [INFO] [stderr] 158 | | _old [INFO] [stderr] 159 | | } as (i32) << 2i32) as (isize)) [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | -((i32::from(*{ [INFO] [stderr] 156 | let _old = ip; [INFO] [stderr] 157 | ip = ip.offset(1isize); [INFO] [stderr] 158 | _old [INFO] [stderr] 159 | }) << 2i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:168:36 [INFO] [stderr] | [INFO] [stderr] 168 | -((*{ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 169 | | let _old = ip; [INFO] [stderr] 170 | | ip = ip.offset(1isize); [INFO] [stderr] 171 | | _old [INFO] [stderr] 172 | | } as (i32) << 3i32) as (isize)) [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 168 | -((i32::from(*{ [INFO] [stderr] 169 | let _old = ip; [INFO] [stderr] 170 | ip = ip.offset(1isize); [INFO] [stderr] 171 | _old [INFO] [stderr] 172 | }) << 3i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:183:34 [INFO] [stderr] | [INFO] [stderr] 183 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | next = next & 3usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next &= 3usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:236:34 [INFO] [stderr] | [INFO] [stderr] 236 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:279:21 [INFO] [stderr] | [INFO] [stderr] 279 | next = next & 3usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next &= 3usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:290:40 [INFO] [stderr] | [INFO] [stderr] 290 | let mut oe : *mut u8 = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:368:39 [INFO] [stderr] | [INFO] [stderr] 368 | } else if _currentBlock == 26 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 369 | | return -1i32; [INFO] [stderr] 370 | | } else if _currentBlock == 40 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:366:39 [INFO] [stderr] | [INFO] [stderr] 366 | } else if _currentBlock == 18 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 367 | | return -1i32; [INFO] [stderr] 368 | | } else if _currentBlock == 26 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let mut dst_len: usize = worst_compress(mem::size_of_val(&data)); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut input : *const u8 = p as (*const u8); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | mut v : u32, mut p : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant `OUT_OF_MEMORY` should have a camel case name such as `OutOfMemory` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | OUT_OF_MEMORY = -2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_COMPRESSIBLE` should have a camel case name such as `NotCompressible` [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | NOT_COMPRESSIBLE = -3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INPUT_OVERRUN` should have a camel case name such as `InputOverrun` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | INPUT_OVERRUN = -4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `OUTPUT_OVERRUN` should have a camel case name such as `OutputOverrun` [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | OUTPUT_OVERRUN = -5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LOOKBEHIND_OVERRUN` should have a camel case name such as `LookbehindOverrun` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | LOOKBEHIND_OVERRUN = -6, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EOF_NOT_FOUND` should have a camel case name such as `EofNotFound` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | EOF_NOT_FOUND = -7, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INPUT_NOT_CONSUMED` should have a camel case name such as `InputNotConsumed` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | INPUT_NOT_CONSUMED = -8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_YET_IMPLEMENTED` should have a camel case name such as `NotYetImplemented` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | NOT_YET_IMPLEMENTED = -9, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INVALID_ARGUMENT` should have a camel case name such as `InvalidArgument` [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | INVALID_ARGUMENT = -10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `LZOContext` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> LZOContext { [INFO] [stderr] 45 | | LZOContext { wrkmem: unsafe { libc::malloc(LZO1X_MEM_COMPRESS) } } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for LZOContext { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | mut out_len : *mut usize, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | mut wrkmem : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:453:5 [INFO] [stderr] | [INFO] [stderr] 453 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:454:5 [INFO] [stderr] | [INFO] [stderr] 454 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:455:5 [INFO] [stderr] | [INFO] [stderr] 455 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:456:5 [INFO] [stderr] | [INFO] [stderr] 456 | mut out_len : *mut usize, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | mut wrkmem : *mut ::std::os::raw::c_void [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | let mut ll [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_compress.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | let mut ll_end : usize = (ip as (usize)).wrapping_add(ll); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | mut p : *const ::std::os::raw::c_void [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let mut input : *const u8 = p as (*const u8); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-lzo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | mut in_ : *const u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | mut in_len : usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | mut out : *mut u8, [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | mut out_len : *mut usize [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | let mut ip_last : *const u8 = ip; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | let mut oe : *mut u8 = op.offset(t as (isize)); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:16:6 [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*input.offset(0isize))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 17 | | 1isize [INFO] [stderr] 18 | | ) as (i32) << 8i32 | *input.offset( [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | (*input.offset(0isize) as (i32) | i32::from(*input.offset( [INFO] [stderr] 17 | 1isize [INFO] [stderr] 18 | )) << 8i32 | *input.offset( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:18:61 [INFO] [stderr] | [INFO] [stderr] 18 | ) as (i32) << 8i32 | *input.offset( [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 19 | | 2isize [INFO] [stderr] 20 | | ) as (i32) << 16i32 | *input.offset( [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | ) as (i32) << 8i32 | i32::from(*input.offset( [INFO] [stderr] 19 | 2isize [INFO] [stderr] 20 | )) << 16i32 | *input.offset( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:20:84 [INFO] [stderr] | [INFO] [stderr] 20 | ) as (i32) << 16i32 | *input.offset( [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 21 | | 3isize [INFO] [stderr] 22 | | ) as (i32) << 24i32) as (u32) [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | ) as (i32) << 16i32 | i32::from(*input.offset( [INFO] [stderr] 21 | 3isize [INFO] [stderr] 22 | )) << 24i32) as (u32) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:175:32 [INFO] [stderr] | [INFO] [stderr] 175 | if !(tt > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `tt <= 255usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:227:28 [INFO] [stderr] | [INFO] [stderr] 227 | if !(t >= 16usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `t < 16usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | if !({ [INFO] [stderr] | ________________________________^ [INFO] [stderr] 243 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 244 | | t [INFO] [stderr] 245 | | } > 0usize) { [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | if { [INFO] [stderr] 243 | t = t.wrapping_sub(1usize); [INFO] [stderr] 244 | t [INFO] [stderr] 245 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:355:32 [INFO] [stderr] | [INFO] [stderr] 355 | if !(m_len > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `m_len <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:399:32 [INFO] [stderr] | [INFO] [stderr] 399 | if !(m_len > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `m_len <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lzo1x_compress.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / unsafe extern fn lzo1x_1_do_compress( [INFO] [stderr] 48 | | mut in_ : *const u8, [INFO] [stderr] 49 | | mut in_len : usize, [INFO] [stderr] 50 | | mut out : *mut u8, [INFO] [stderr] ... | [INFO] [stderr] 448 | | ) / ::std::mem::size_of::() as (isize)) as (usize) [INFO] [stderr] 449 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/lzo1x_compress.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | / 'loop17: loop { [INFO] [stderr] 233 | | *{ [INFO] [stderr] 234 | | let _old = op; [INFO] [stderr] 235 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/lzo1x_compress.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | / 'loop14: loop { [INFO] [stderr] 192 | | put_unaligned( [INFO] [stderr] 193 | | get_unaligned( [INFO] [stderr] 194 | | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/lzo1x_compress.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / 'loop3: loop { [INFO] [stderr] 86 | | if ip >= ip_end { [INFO] [stderr] 87 | | break 'loop2; [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 440 | | } [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop42` [INFO] [stderr] --> src/lzo1x_compress.rs:354:25 [INFO] [stderr] | [INFO] [stderr] 354 | / 'loop42: loop { [INFO] [stderr] 355 | | if !(m_len > 255usize) { [INFO] [stderr] 356 | | break; [INFO] [stderr] 357 | | } [INFO] [stderr] ... | [INFO] [stderr] 363 | | } = 0u8; [INFO] [stderr] 364 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop10` [INFO] [stderr] --> src/lzo1x_compress.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | / 'loop10: loop { [INFO] [stderr] 175 | | if !(tt > 255usize) { [INFO] [stderr] 176 | | break; [INFO] [stderr] 177 | | } [INFO] [stderr] ... | [INFO] [stderr] 183 | | } = 0u8; [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop35` [INFO] [stderr] --> src/lzo1x_compress.rs:398:25 [INFO] [stderr] | [INFO] [stderr] 398 | / 'loop35: loop { [INFO] [stderr] 399 | | if !(m_len > 255usize) { [INFO] [stderr] 400 | | break; [INFO] [stderr] 401 | | } [INFO] [stderr] ... | [INFO] [stderr] 407 | | } = 0u8; [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/lzo1x_compress.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | / 'loop22: loop { [INFO] [stderr] 261 | | if _currentBlock == 22 { [INFO] [stderr] 262 | | m_len = m_len.wrapping_add(1usize); [INFO] [stderr] 263 | | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_compress.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let in_end : *const u8 = in_.offset(in_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | = in_.offset(in_len as (isize)).offset(-20isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | ip = ip.offset( [INFO] [stderr] | __________^ [INFO] [stderr] 68 | | if ti < 4usize { [INFO] [stderr] 69 | | 4usize.wrapping_sub(ti) [INFO] [stderr] 70 | | } else { [INFO] [stderr] 71 | | 0usize [INFO] [stderr] 72 | | } as (isize) [INFO] [stderr] 73 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | ip = ip.add(if ti < 4usize { [INFO] [stderr] 68 | 4usize.wrapping_sub(ti) [INFO] [stderr] 69 | } else { [INFO] [stderr] 70 | 0usize [INFO] [stderr] 71 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | m_pos = in_.offset(*dict.offset(t as (isize)) as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dict.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | *dict.offset(t as (isize)) = ((ip as (isize)).wrapping_sub( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dict.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | op = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | / ii.offset( [INFO] [stderr] 136 | | 4isize [INFO] [stderr] 137 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | / ii.offset( [INFO] [stderr] 144 | | 8isize [INFO] [stderr] 145 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | / ii.offset(8isize).offset( [INFO] [stderr] 152 | | 4isize [INFO] [stderr] 153 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | / op.offset(8isize).offset( [INFO] [stderr] 156 | | 4isize [INFO] [stderr] 157 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | op = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:194:33 [INFO] [stderr] | [INFO] [stderr] 194 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:196:29 [INFO] [stderr] | [INFO] [stderr] 196 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:200:33 [INFO] [stderr] | [INFO] [stderr] 200 | / ii.offset( [INFO] [stderr] 201 | | 4isize [INFO] [stderr] 202 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:208:33 [INFO] [stderr] | [INFO] [stderr] 208 | / ii.offset( [INFO] [stderr] 209 | | 8isize [INFO] [stderr] 210 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:216:33 [INFO] [stderr] | [INFO] [stderr] 216 | / ii.offset(8isize).offset( [INFO] [stderr] 217 | | 4isize [INFO] [stderr] 218 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:220:29 [INFO] [stderr] | [INFO] [stderr] 220 | / op.offset(8isize).offset( [INFO] [stderr] 221 | | 4isize [INFO] [stderr] 222 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:253:16 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:253:57 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 254 | | m_len as (isize) [INFO] [stderr] 255 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == i32::from(*m_pos.offset( [INFO] [stderr] 254 | m_len as (isize) [INFO] [stderr] 255 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:253:58 [INFO] [stderr] | [INFO] [stderr] 253 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 254 | | m_len as (isize) [INFO] [stderr] 255 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:263:24 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:263:25 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:263:65 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 264 | | m_len as (isize) [INFO] [stderr] 265 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 264 | m_len as (isize) [INFO] [stderr] 265 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:263:66 [INFO] [stderr] | [INFO] [stderr] 263 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 264 | | m_len as (isize) [INFO] [stderr] 265 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:270:24 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:270:65 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 271 | | m_len as (isize) [INFO] [stderr] 272 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 271 | m_len as (isize) [INFO] [stderr] 272 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:270:66 [INFO] [stderr] | [INFO] [stderr] 270 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 271 | | m_len as (isize) [INFO] [stderr] 272 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:277:24 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:277:65 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 278 | | m_len as (isize) [INFO] [stderr] 279 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 278 | m_len as (isize) [INFO] [stderr] 279 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:277:66 [INFO] [stderr] | [INFO] [stderr] 277 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 278 | | m_len as (isize) [INFO] [stderr] 279 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:284:24 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:284:25 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:284:65 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 285 | | m_len as (isize) [INFO] [stderr] 286 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 285 | m_len as (isize) [INFO] [stderr] 286 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:284:66 [INFO] [stderr] | [INFO] [stderr] 284 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 285 | | m_len as (isize) [INFO] [stderr] 286 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:291:24 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:291:65 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 292 | | m_len as (isize) [INFO] [stderr] 293 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 292 | m_len as (isize) [INFO] [stderr] 293 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:291:66 [INFO] [stderr] | [INFO] [stderr] 291 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 292 | | m_len as (isize) [INFO] [stderr] 293 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:298:24 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:298:25 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:298:65 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 299 | | m_len as (isize) [INFO] [stderr] 300 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 299 | m_len as (isize) [INFO] [stderr] 300 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:298:66 [INFO] [stderr] | [INFO] [stderr] 298 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 299 | | m_len as (isize) [INFO] [stderr] 300 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:305:24 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:305:25 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:305:65 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 306 | | m_len as (isize) [INFO] [stderr] 307 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != i32::from(*m_pos.offset( [INFO] [stderr] 306 | m_len as (isize) [INFO] [stderr] 307 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:305:66 [INFO] [stderr] | [INFO] [stderr] 305 | if *ip.offset(m_len as (isize)) as (i32) != *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 306 | | m_len as (isize) [INFO] [stderr] 307 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:312:24 [INFO] [stderr] | [INFO] [stderr] 312 | if ip.offset(m_len as (isize)) >= ip_end { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*ip.offset(m_len as (isize)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:316:25 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_compress.rs:316:65 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 317 | | m_len as (isize) [INFO] [stderr] 318 | | ) as (i32) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == i32::from(*m_pos.offset( [INFO] [stderr] 317 | m_len as (isize) [INFO] [stderr] 318 | )) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:316:66 [INFO] [stderr] | [INFO] [stderr] 316 | if *ip.offset(m_len as (isize)) as (i32) == *m_pos.offset( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 317 | | m_len as (isize) [INFO] [stderr] 318 | | ) as (i32) { [INFO] [stderr] | |__________________________________________________________________^ help: try: `m_pos.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:327:26 [INFO] [stderr] | [INFO] [stderr] 327 | ip = ip.offset(m_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(m_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32i32` [INFO] [stderr] --> src/lzo1x_compress.rs:353:30 [INFO] [stderr] | [INFO] [stderr] 353 | } = (32i32 | 0i32) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:465:12 [INFO] [stderr] | [INFO] [stderr] 465 | if !(l > 20usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `l <= 20usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:520:20 [INFO] [stderr] | [INFO] [stderr] 520 | if !(tt > 255usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `tt <= 255usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_compress.rs:603:20 [INFO] [stderr] | [INFO] [stderr] 603 | if !({ [INFO] [stderr] | ____________________^ [INFO] [stderr] 604 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 605 | | t [INFO] [stderr] 606 | | } > 0usize) { [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 603 | if { [INFO] [stderr] 604 | t = t.wrapping_sub(1usize); [INFO] [stderr] 605 | t [INFO] [stderr] 606 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop19` [INFO] [stderr] --> src/lzo1x_compress.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | / 'loop19: loop { [INFO] [stderr] 594 | | *{ [INFO] [stderr] 595 | | let _old = op; [INFO] [stderr] 596 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 608 | | } [INFO] [stderr] 609 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/lzo1x_compress.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop9: loop { [INFO] [stderr] 520 | | if !(tt > 255usize) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 528 | | } = 0u8; [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/lzo1x_compress.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / 'loop1: loop { [INFO] [stderr] 465 | | if !(l > 20usize) { [INFO] [stderr] 466 | | break; [INFO] [stderr] 467 | | } [INFO] [stderr] ... | [INFO] [stderr] 489 | | l = l.wrapping_sub(ll); [INFO] [stderr] 490 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop16` [INFO] [stderr] --> src/lzo1x_compress.rs:541:9 [INFO] [stderr] | [INFO] [stderr] 541 | / 'loop16: loop { [INFO] [stderr] 542 | | if _currentBlock == 16 { [INFO] [stderr] 543 | | put_unaligned( [INFO] [stderr] 544 | | get_unaligned( [INFO] [stderr] ... | [INFO] [stderr] 589 | | } [INFO] [stderr] 590 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_compress.rs:459:9 [INFO] [stderr] | [INFO] [stderr] 459 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:487:14 [INFO] [stderr] | [INFO] [stderr] 487 | ip = ip.offset(ll as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ip.add(ll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | op = op.offset(*out_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(*out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_compress.rs:495:15 [INFO] [stderr] | [INFO] [stderr] 495 | = in_.offset(in_len as (isize)).offset(-(t as (isize))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:545:25 [INFO] [stderr] | [INFO] [stderr] 545 | ii as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:547:21 [INFO] [stderr] | [INFO] [stderr] 547 | op as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:551:25 [INFO] [stderr] | [INFO] [stderr] 551 | / ii.offset( [INFO] [stderr] 552 | | 4isize [INFO] [stderr] 553 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | op.offset(4isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:559:25 [INFO] [stderr] | [INFO] [stderr] 559 | / ii.offset( [INFO] [stderr] 560 | | 8isize [INFO] [stderr] 561 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | op.offset(8isize) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:567:25 [INFO] [stderr] | [INFO] [stderr] 567 | / ii.offset(8isize).offset( [INFO] [stderr] 568 | | 4isize [INFO] [stderr] 569 | | ) as (*const u32) as (*const ::std::os::raw::c_void) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/lzo1x_compress.rs:571:21 [INFO] [stderr] | [INFO] [stderr] 571 | / op.offset(8isize).offset( [INFO] [stderr] 572 | | 4isize [INFO] [stderr] 573 | | ) as (*mut u32) as (*mut ::std::os::raw::c_void) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:5:6 [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*input.offset(0isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:5:39 [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | *input.offset( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 6 | | 1isize [INFO] [stderr] 7 | | ) as (i32) << 8i32) as (u16) [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 5 | (*input.offset(0isize) as (i32) | i32::from(*input.offset( [INFO] [stderr] 6 | 1isize [INFO] [stderr] 7 | )) << 8i32) as (u16) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if !(in_len < 3usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `in_len >= 3usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 49 | | ip as (isize) [INFO] [stderr] 50 | | ) / ::std::mem::size_of::( [INFO] [stderr] 51 | | ) as (isize)) as (usize) >= t.wrapping_add(3usize)) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 49 | ip as (isize) [INFO] [stderr] 50 | ) / ::std::mem::size_of::( [INFO] [stderr] 51 | ) as (isize)) as (usize) < t.wrapping_add(3usize) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 56 | | op as (isize) [INFO] [stderr] 57 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 56 | op as (isize) [INFO] [stderr] 57 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | if !(t > 0usize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `t <= 0usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 94 | | ip as (isize) [INFO] [stderr] 95 | | ) / ::std::mem::size_of::( [INFO] [stderr] 96 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 94 | ip as (isize) [INFO] [stderr] 95 | ) / ::std::mem::size_of::( [INFO] [stderr] 96 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:139:28 [INFO] [stderr] | [INFO] [stderr] 139 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 140 | | op as (isize) [INFO] [stderr] 141 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 140 | op as (isize) [INFO] [stderr] 141 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 188 | | ip as (isize) [INFO] [stderr] 189 | | ) / ::std::mem::size_of::( [INFO] [stderr] 190 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 187 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 188 | ip as (isize) [INFO] [stderr] 189 | ) / ::std::mem::size_of::( [INFO] [stderr] 190 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:214:28 [INFO] [stderr] | [INFO] [stderr] 214 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 215 | | ip as (isize) [INFO] [stderr] 216 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 215 | ip as (isize) [INFO] [stderr] 216 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ip as (i32) != 0i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:240:32 [INFO] [stderr] | [INFO] [stderr] 240 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 241 | | ip as (isize) [INFO] [stderr] 242 | | ) / ::std::mem::size_of::( [INFO] [stderr] 243 | | ) as (isize)) as (usize) >= 1usize) { [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 240 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 241 | ip as (isize) [INFO] [stderr] 242 | ) / ::std::mem::size_of::( [INFO] [stderr] 243 | ) as (isize)) as (usize) < 1usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | ip as (isize) [INFO] [stderr] 269 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= 2usize) { [INFO] [stderr] | |_______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 268 | ip as (isize) [INFO] [stderr] 269 | ) / ::std::mem::size_of::() as (isize)) as (usize) < 2usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:291:20 [INFO] [stderr] | [INFO] [stderr] 291 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 292 | | op as (isize) [INFO] [stderr] 293 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 291 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 292 | op as (isize) [INFO] [stderr] 293 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:311:24 [INFO] [stderr] | [INFO] [stderr] 311 | if !(op < oe) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `op >= oe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | if !(((op_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 318 | | op as (isize) [INFO] [stderr] 319 | | ) / ::std::mem::size_of::() as (isize)) as (usize) >= t) { [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 317 | if ((op_end as (isize)).wrapping_sub( [INFO] [stderr] 318 | op as (isize) [INFO] [stderr] 319 | ) / ::std::mem::size_of::() as (isize)) as (usize) < t { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | if !(((ip_end as (isize)).wrapping_sub( [INFO] [stderr] | ____________________^ [INFO] [stderr] 324 | | ip as (isize) [INFO] [stderr] 325 | | ) / ::std::mem::size_of::( [INFO] [stderr] 326 | | ) as (isize)) as (usize) >= t.wrapping_add(3usize)) { [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | if ((ip_end as (isize)).wrapping_sub( [INFO] [stderr] 324 | ip as (isize) [INFO] [stderr] 325 | ) / ::std::mem::size_of::( [INFO] [stderr] 326 | ) as (isize)) as (usize) < t.wrapping_add(3usize) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:340:24 [INFO] [stderr] | [INFO] [stderr] 340 | if !({ [INFO] [stderr] | ________________________^ [INFO] [stderr] 341 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 342 | | t [INFO] [stderr] 343 | | } > 0usize) { [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 340 | if { [INFO] [stderr] 341 | t = t.wrapping_sub(1usize); [INFO] [stderr] 342 | t [INFO] [stderr] 343 | } <= 0usize { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / pub unsafe extern fn lzo1x_decompress_safe( [INFO] [stderr] 12 | | mut in_ : *const u8, [INFO] [stderr] 13 | | mut in_len : usize, [INFO] [stderr] 14 | | mut out : *mut u8, [INFO] [stderr] ... | [INFO] [stderr] 387 | | -4i32 [INFO] [stderr] 388 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | / 'loop22: loop { [INFO] [stderr] 183 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 184 | | break; [INFO] [stderr] 185 | | } [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop43` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | / 'loop43: loop { [INFO] [stderr] 89 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 90 | | break; [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop49` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | / 'loop49: loop { [INFO] [stderr] 331 | | *{ [INFO] [stderr] 332 | | let _old = op; [INFO] [stderr] 333 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 345 | | } [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop12` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:235:25 [INFO] [stderr] | [INFO] [stderr] 235 | / 'loop12: loop { [INFO] [stderr] 236 | | if !(*ip as (i32) == 0i32) { [INFO] [stderr] 237 | | break; [INFO] [stderr] 238 | | } [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop35` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:301:17 [INFO] [stderr] | [INFO] [stderr] 301 | / 'loop35: loop { [INFO] [stderr] 302 | | *{ [INFO] [stderr] 303 | | let _old = op; [INFO] [stderr] 304 | | op = op.offset(1isize); [INFO] [stderr] ... | [INFO] [stderr] 314 | | } [INFO] [stderr] 315 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop6` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | / 'loop6: loop { [INFO] [stderr] 62 | | if !(t > 0usize) { [INFO] [stderr] 63 | | _currentBlock = 7; [INFO] [stderr] 64 | | break; [INFO] [stderr] ... | [INFO] [stderr] 75 | | t = t.wrapping_sub(1usize); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: variable `_currentBlock` should have a snake case name such as `_current_block` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let mut _currentBlock; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | let ip_end : *const u8 = in_.offset(in_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `in_.add(in_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let op_end : *mut u8 = out.offset(*out_len as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(*out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if *ip as (i32) > 17i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | t = (*{ [INFO] [stderr] | __________________^ [INFO] [stderr] 31 | | let _old = ip; [INFO] [stderr] 32 | | ip = ip.offset(1isize); [INFO] [stderr] 33 | | _old [INFO] [stderr] 34 | | } as (i32) - 17i32) as (usize); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | t = (i32::from(*{ [INFO] [stderr] 31 | let _old = ip; [INFO] [stderr] 32 | ip = ip.offset(1isize); [INFO] [stderr] 33 | _old [INFO] [stderr] 34 | }) - 17i32) as (usize); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | -((*{ [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 130 | | let _old = ip; [INFO] [stderr] 131 | | ip = ip.offset(1isize); [INFO] [stderr] 132 | | _old [INFO] [stderr] 133 | | } as (i32) << 2i32) as (isize)) [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | -((i32::from(*{ [INFO] [stderr] 130 | let _old = ip; [INFO] [stderr] 131 | ip = ip.offset(1isize); [INFO] [stderr] 132 | _old [INFO] [stderr] 133 | }) << 2i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:155:40 [INFO] [stderr] | [INFO] [stderr] 155 | -((*{ [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 156 | | let _old = ip; [INFO] [stderr] 157 | | ip = ip.offset(1isize); [INFO] [stderr] 158 | | _old [INFO] [stderr] 159 | | } as (i32) << 2i32) as (isize)) [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | -((i32::from(*{ [INFO] [stderr] 156 | let _old = ip; [INFO] [stderr] 157 | ip = ip.offset(1isize); [INFO] [stderr] 158 | _old [INFO] [stderr] 159 | }) << 2i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:168:36 [INFO] [stderr] | [INFO] [stderr] 168 | -((*{ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 169 | | let _old = ip; [INFO] [stderr] 170 | | ip = ip.offset(1isize); [INFO] [stderr] 171 | | _old [INFO] [stderr] 172 | | } as (i32) << 3i32) as (isize)) [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 168 | -((i32::from(*{ [INFO] [stderr] 169 | let _old = ip; [INFO] [stderr] 170 | ip = ip.offset(1isize); [INFO] [stderr] 171 | _old [INFO] [stderr] 172 | }) << 3i32) as (isize)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:183:34 [INFO] [stderr] | [INFO] [stderr] 183 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | next = next & 3usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next &= 3usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:236:34 [INFO] [stderr] | [INFO] [stderr] 236 | if !(*ip as (i32) == 0i32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*ip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:279:21 [INFO] [stderr] | [INFO] [stderr] 279 | next = next & 3usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next &= 3usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:290:40 [INFO] [stderr] | [INFO] [stderr] 290 | let mut oe : *mut u8 = op.offset(t as (isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `op.add(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:368:39 [INFO] [stderr] | [INFO] [stderr] 368 | } else if _currentBlock == 26 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 369 | | return -1i32; [INFO] [stderr] 370 | | } else if _currentBlock == 40 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lzo1x_decompress_safe.rs:366:39 [INFO] [stderr] | [INFO] [stderr] 366 | } else if _currentBlock == 18 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 367 | | return -1i32; [INFO] [stderr] 368 | | } else if _currentBlock == 26 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: variant `OUT_OF_MEMORY` should have a camel case name such as `OutOfMemory` [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | OUT_OF_MEMORY = -2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_COMPRESSIBLE` should have a camel case name such as `NotCompressible` [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | NOT_COMPRESSIBLE = -3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INPUT_OVERRUN` should have a camel case name such as `InputOverrun` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | INPUT_OVERRUN = -4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `OUTPUT_OVERRUN` should have a camel case name such as `OutputOverrun` [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | OUTPUT_OVERRUN = -5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `LOOKBEHIND_OVERRUN` should have a camel case name such as `LookbehindOverrun` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | LOOKBEHIND_OVERRUN = -6, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `EOF_NOT_FOUND` should have a camel case name such as `EofNotFound` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | EOF_NOT_FOUND = -7, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INPUT_NOT_CONSUMED` should have a camel case name such as `InputNotConsumed` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | INPUT_NOT_CONSUMED = -8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `NOT_YET_IMPLEMENTED` should have a camel case name such as `NotYetImplemented` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | NOT_YET_IMPLEMENTED = -9, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `INVALID_ARGUMENT` should have a camel case name such as `InvalidArgument` [INFO] [stderr] --> src/lib.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | INVALID_ARGUMENT = -10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `LZOContext` [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> LZOContext { [INFO] [stderr] 45 | | LZOContext { wrkmem: unsafe { libc::malloc(LZO1X_MEM_COMPRESS) } } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for LZOContext { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-lzo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "40cf9dc1f45d0ac75eaa301009edd61b49f119410b889087d67d22d02235ec35"` [INFO] running `"docker" "rm" "-f" "40cf9dc1f45d0ac75eaa301009edd61b49f119410b889087d67d22d02235ec35"` [INFO] [stdout] 40cf9dc1f45d0ac75eaa301009edd61b49f119410b889087d67d22d02235ec35