[INFO] crate rust-kpdb 0.4.0 is already in cache [INFO] extracting crate rust-kpdb 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rust-kpdb/0.4.0 [INFO] extracting crate rust-kpdb 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-kpdb/0.4.0 [INFO] validating manifest of rust-kpdb-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-kpdb-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-kpdb-0.4.0 [INFO] finished frobbing rust-kpdb-0.4.0 [INFO] frobbed toml for rust-kpdb-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-kpdb/0.4.0/Cargo.toml [INFO] started frobbing rust-kpdb-0.4.0 [INFO] finished frobbing rust-kpdb-0.4.0 [INFO] frobbed toml for rust-kpdb-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-kpdb/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-kpdb-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-kpdb/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f76a9c4b46f2376b25b6b3c7c4b6f326319d9893d703ce8d6cee71463d09e7c8 [INFO] running `"docker" "start" "-a" "f76a9c4b46f2376b25b6b3c7c4b6f326319d9893d703ce8d6cee71463d09e7c8"` [INFO] [stderr] Checking secstr v0.3.1 [INFO] [stderr] Checking rust-kpdb v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | compression: compression, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | header_hash: header_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | master_cipher: master_cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | stream_cipher: stream_cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | transform_rounds: transform_rounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform_rounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kf_reader.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | comment: comment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | compression: compression, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | header_hash: header_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | master_cipher: master_cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | stream_cipher: stream_cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | transform_rounds: transform_rounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform_rounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:645:9 [INFO] [stderr] | [INFO] [stderr] 645 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_reader.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kf_reader.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/log_reader.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/log_writer.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:645:9 [INFO] [stderr] | [INFO] [stderr] 645 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | red: red, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | green: green, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | blue: blue, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/database.rs:538:13 [INFO] [stderr] | [INFO] [stderr] 538 | root_group: root_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/log_reader.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io/log_writer.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | red: red, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | green: green, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/color.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | blue: blue, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/database.rs:538:13 [INFO] [stderr] | [INFO] [stderr] 538 | root_group: root_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/key_file.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const GENERATOR_NAME: &'static str = "rust-kpdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | pub const HISTORY_MAX_SIZE_DEFAULT: i32 = 6291456; [INFO] [stderr] | ^^^^^^^ help: consider: `6_291_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | pub const ROOT_GROUP_NAME: &'static str = "Root"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | pub const ASSOCIATION_TAG: &'static str = "Association"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | pub const AUTO_TYPE_TAG: &'static str = "AutoType"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | pub const BACKGROUND_COLOR_TAG: &'static str = "BackgroundColor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | pub const BINARIES_TAG: &'static str = "Binaries"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | pub const BINARY_TAG: &'static str = "Binary"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | pub const COLOR_TAG: &'static str = "Color"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | pub const CREATION_TIME_TAG: &'static str = "CreationTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | pub const CUSTOM_DATA_TAG: &'static str = "CustomData"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | pub const CUSTOM_ICONS_TAG: &'static str = "CustomIcons"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | pub const CUSTOM_ICON_UUID_TAG: &'static str = "CustomIconUUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:106:46 [INFO] [stderr] | [INFO] [stderr] 106 | pub const DATABASE_DESCRIPTION_CHANGED_TAG: &'static str = "DatabaseDescriptionChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | pub const DATABASE_DESCRIPTION_TAG: &'static str = "DatabaseDescription"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | pub const DATABASE_NAME_CHANGED_TAG: &'static str = "DatabaseNameChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | pub const DATABASE_NAME_TAG: &'static str = "DatabaseName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | pub const DATA_TAG: &'static str = "Data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | pub const DATA_TRANSFER_OBFUSCATION_TAG: &'static str = "DataTransferObfuscation"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:112:44 [INFO] [stderr] | [INFO] [stderr] 112 | pub const DEFAULT_AUTO_TYPE_SEQUENCE_TAG: &'static str = "DefaultAutoTypeSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | pub const DEFAULT_SEQUENCE_TAG: &'static str = "DefaultSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:114:42 [INFO] [stderr] | [INFO] [stderr] 114 | pub const DEFAULT_USERNAME_CHANGED_TAG: &'static str = "DefaultUserNameChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:115:34 [INFO] [stderr] | [INFO] [stderr] 115 | pub const DEFAULT_USERNAME_TAG: &'static str = "DefaultUserName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | pub const ENABLED_TAG: &'static str = "Enabled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | pub const ENABLE_AUTO_TYPE_TAG: &'static str = "EnableAutoType"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | pub const ENABLE_SEARCHING_TAG: &'static str = "EnableSearching"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | pub const ENTRY_TAG: &'static str = "Entry"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:120:47 [INFO] [stderr] | [INFO] [stderr] 120 | pub const ENTRY_TEMPLATES_GROUP_CHANGED_TAG: &'static str = "EntryTemplatesGroupChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | pub const ENTRY_TEMPLATES_GROUP_TAG: &'static str = "EntryTemplatesGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | pub const EXPIRES_TAG: &'static str = "Expires"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | pub const EXPIRY_TIME_TAG: &'static str = "ExpiryTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | pub const FOREGROUND_COLOR_TAG: &'static str = "ForegroundColor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | pub const GENERATOR_TAG: &'static str = "Generator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | pub const GROUP_TAG: &'static str = "Group"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | pub const HEADER_HASH_TAG: &'static str = "HeaderHash"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:128:35 [INFO] [stderr] | [INFO] [stderr] 128 | pub const HISTORY_MAX_ITEMS_TAG: &'static str = "HistoryMaxItems"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | pub const HISTORY_MAX_SIZE_TAG: &'static str = "HistoryMaxSize"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | pub const HISTORY_TAG: &'static str = "History"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | pub const ICON_ID_TAG: &'static str = "IconID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:132:22 [INFO] [stderr] | [INFO] [stderr] 132 | pub const ICON_TAG: &'static str = "Icon"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | pub const IS_EXPANDED_TAG: &'static str = "IsExpanded"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | pub const ITEM_TAG: &'static str = "Item"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | pub const KEE_PASS_FILE_TAG: &'static str = "KeePassFile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:136:36 [INFO] [stderr] | [INFO] [stderr] 136 | pub const KEYSTROKE_SEQUENCE_TAG: &'static str = "KeystrokeSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | pub const KEY_TAG: &'static str = "Key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | pub const LAST_ACCESS_TIME_TAG: &'static str = "LastAccessTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | pub const LAST_MODIFICATION_TIME_TAG: &'static str = "LastModificationTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | pub const LAST_SELECTED_GROUP_TAG: &'static str = "LastSelectedGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:141:40 [INFO] [stderr] | [INFO] [stderr] 141 | pub const LAST_TOP_VISIBLE_ENTRY_TAG: &'static str = "LastTopVisibleEntry"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | pub const LAST_TOP_VISIBLE_GROUP_TAG: &'static str = "LastTopVisibleGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:143:34 [INFO] [stderr] | [INFO] [stderr] 143 | pub const LOCATION_CHANGED_TAG: &'static str = "LocationChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:144:42 [INFO] [stderr] | [INFO] [stderr] 144 | pub const MAINTENANCE_HISTORY_DAYS_TAG: &'static str = "MaintenanceHistoryDays"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | pub const MASTER_KEY_CHANGED_TAG: &'static str = "MasterKeyChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | pub const MASTER_KEY_CHANGE_FORCE_TAG: &'static str = "MasterKeyChangeForce"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | pub const MASTER_KEY_CHANGE_REC_TAG: &'static str = "MasterKeyChangeRec"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | pub const MEMORY_PROTECTION_TAG: &'static str = "MemoryProtection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:149:22 [INFO] [stderr] | [INFO] [stderr] 149 | pub const META_TAG: &'static str = "Meta"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:150:22 [INFO] [stderr] | [INFO] [stderr] 150 | pub const NAME_TAG: &'static str = "Name"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | pub const NOTES_TAG: &'static str = "Notes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | pub const OVERRIDE_URL_TAG: &'static str = "OverrideURL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | pub const PROTECT_NOTES_TAG: &'static str = "ProtectNotes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | pub const PROTECT_PASSWORD_TAG: &'static str = "ProtectPassword"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | pub const PROTECT_TITLE_TAG: &'static str = "ProtectTitle"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | pub const PROTECT_URL_TAG: &'static str = "ProtectURL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | pub const PROTECT_USERNAME_TAG: &'static str = "ProtectUserName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:158:37 [INFO] [stderr] | [INFO] [stderr] 158 | pub const RECYCLE_BIN_CHANGED_TAG: &'static str = "RecycleBinChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | pub const RECYCLE_BIN_ENABLED_TAG: &'static str = "RecycleBinEnabled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | pub const RECYCLE_BIN_UUID_TAG: &'static str = "RecycleBinUUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | pub const ROOT_TAG: &'static str = "Root"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:162:24 [INFO] [stderr] | [INFO] [stderr] 162 | pub const STRING_TAG: &'static str = "String"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | pub const TAGS_TAG: &'static str = "Tags"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | pub const TIMES_TAG: &'static str = "Times"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | pub const USAGE_COUNT_TAG: &'static str = "UsageCount"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:166:22 [INFO] [stderr] | [INFO] [stderr] 166 | pub const UUID_TAG: &'static str = "UUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | pub const VALUE_TAG: &'static str = "Value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | pub const WINDOW_TAG: &'static str = "Window"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:18:34 [INFO] [stderr] | [INFO] [stderr] 18 | pub const XML_KEY_FILE_VERSION: &'static str = "1.00"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub const KEY_FILE_TAG: &'static str = "KeyFile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | pub const META_TAG: &'static str = "Meta"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | pub const VERSION_TAG: &'static str = "Version"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | pub const KEY_TAG: &'static str = "Key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | pub const DATA_TAG: &'static str = "Data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/database.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | return Err(Error::UnhandledDbType(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnhandledDbType(buffer))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/database.rs:453:13 [INFO] [stderr] | [INFO] [stderr] 453 | return Err(Error::UnhandledDbType(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnhandledDbType(buffer))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const GENERATOR_NAME: &'static str = "rust-kpdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:21:43 [INFO] [stderr] | [INFO] [stderr] 21 | pub const HISTORY_MAX_SIZE_DEFAULT: i32 = 6291456; [INFO] [stderr] | ^^^^^^^ help: consider: `6_291_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:63:29 [INFO] [stderr] | [INFO] [stderr] 63 | pub const ROOT_GROUP_NAME: &'static str = "Root"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | pub const ASSOCIATION_TAG: &'static str = "Association"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | pub const AUTO_TYPE_TAG: &'static str = "AutoType"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | pub const BACKGROUND_COLOR_TAG: &'static str = "BackgroundColor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | pub const BINARIES_TAG: &'static str = "Binaries"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | pub const BINARY_TAG: &'static str = "Binary"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | pub const COLOR_TAG: &'static str = "Color"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | pub const CREATION_TIME_TAG: &'static str = "CreationTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:103:29 [INFO] [stderr] | [INFO] [stderr] 103 | pub const CUSTOM_DATA_TAG: &'static str = "CustomData"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | pub const CUSTOM_ICONS_TAG: &'static str = "CustomIcons"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | pub const CUSTOM_ICON_UUID_TAG: &'static str = "CustomIconUUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:106:46 [INFO] [stderr] | [INFO] [stderr] 106 | pub const DATABASE_DESCRIPTION_CHANGED_TAG: &'static str = "DatabaseDescriptionChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | pub const DATABASE_DESCRIPTION_TAG: &'static str = "DatabaseDescription"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | pub const DATABASE_NAME_CHANGED_TAG: &'static str = "DatabaseNameChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | pub const DATABASE_NAME_TAG: &'static str = "DatabaseName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:110:22 [INFO] [stderr] | [INFO] [stderr] 110 | pub const DATA_TAG: &'static str = "Data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | pub const DATA_TRANSFER_OBFUSCATION_TAG: &'static str = "DataTransferObfuscation"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:112:44 [INFO] [stderr] | [INFO] [stderr] 112 | pub const DEFAULT_AUTO_TYPE_SEQUENCE_TAG: &'static str = "DefaultAutoTypeSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | pub const DEFAULT_SEQUENCE_TAG: &'static str = "DefaultSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:114:42 [INFO] [stderr] | [INFO] [stderr] 114 | pub const DEFAULT_USERNAME_CHANGED_TAG: &'static str = "DefaultUserNameChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:115:34 [INFO] [stderr] | [INFO] [stderr] 115 | pub const DEFAULT_USERNAME_TAG: &'static str = "DefaultUserName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | pub const ENABLED_TAG: &'static str = "Enabled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | pub const ENABLE_AUTO_TYPE_TAG: &'static str = "EnableAutoType"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | pub const ENABLE_SEARCHING_TAG: &'static str = "EnableSearching"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | pub const ENTRY_TAG: &'static str = "Entry"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:120:47 [INFO] [stderr] | [INFO] [stderr] 120 | pub const ENTRY_TEMPLATES_GROUP_CHANGED_TAG: &'static str = "EntryTemplatesGroupChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | pub const ENTRY_TEMPLATES_GROUP_TAG: &'static str = "EntryTemplatesGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | pub const EXPIRES_TAG: &'static str = "Expires"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | pub const EXPIRY_TIME_TAG: &'static str = "ExpiryTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | pub const FOREGROUND_COLOR_TAG: &'static str = "ForegroundColor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | pub const GENERATOR_TAG: &'static str = "Generator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | pub const GROUP_TAG: &'static str = "Group"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | pub const HEADER_HASH_TAG: &'static str = "HeaderHash"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:128:35 [INFO] [stderr] | [INFO] [stderr] 128 | pub const HISTORY_MAX_ITEMS_TAG: &'static str = "HistoryMaxItems"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | pub const HISTORY_MAX_SIZE_TAG: &'static str = "HistoryMaxSize"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | pub const HISTORY_TAG: &'static str = "History"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | pub const ICON_ID_TAG: &'static str = "IconID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:132:22 [INFO] [stderr] | [INFO] [stderr] 132 | pub const ICON_TAG: &'static str = "Icon"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | pub const IS_EXPANDED_TAG: &'static str = "IsExpanded"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | pub const ITEM_TAG: &'static str = "Item"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:135:31 [INFO] [stderr] | [INFO] [stderr] 135 | pub const KEE_PASS_FILE_TAG: &'static str = "KeePassFile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:136:36 [INFO] [stderr] | [INFO] [stderr] 136 | pub const KEYSTROKE_SEQUENCE_TAG: &'static str = "KeystrokeSequence"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | pub const KEY_TAG: &'static str = "Key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | pub const LAST_ACCESS_TIME_TAG: &'static str = "LastAccessTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:139:40 [INFO] [stderr] | [INFO] [stderr] 139 | pub const LAST_MODIFICATION_TIME_TAG: &'static str = "LastModificationTime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | pub const LAST_SELECTED_GROUP_TAG: &'static str = "LastSelectedGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:141:40 [INFO] [stderr] | [INFO] [stderr] 141 | pub const LAST_TOP_VISIBLE_ENTRY_TAG: &'static str = "LastTopVisibleEntry"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:142:40 [INFO] [stderr] | [INFO] [stderr] 142 | pub const LAST_TOP_VISIBLE_GROUP_TAG: &'static str = "LastTopVisibleGroup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:143:34 [INFO] [stderr] | [INFO] [stderr] 143 | pub const LOCATION_CHANGED_TAG: &'static str = "LocationChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:144:42 [INFO] [stderr] | [INFO] [stderr] 144 | pub const MAINTENANCE_HISTORY_DAYS_TAG: &'static str = "MaintenanceHistoryDays"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:145:36 [INFO] [stderr] | [INFO] [stderr] 145 | pub const MASTER_KEY_CHANGED_TAG: &'static str = "MasterKeyChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | pub const MASTER_KEY_CHANGE_FORCE_TAG: &'static str = "MasterKeyChangeForce"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | pub const MASTER_KEY_CHANGE_REC_TAG: &'static str = "MasterKeyChangeRec"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:148:35 [INFO] [stderr] | [INFO] [stderr] 148 | pub const MEMORY_PROTECTION_TAG: &'static str = "MemoryProtection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:149:22 [INFO] [stderr] | [INFO] [stderr] 149 | pub const META_TAG: &'static str = "Meta"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:150:22 [INFO] [stderr] | [INFO] [stderr] 150 | pub const NAME_TAG: &'static str = "Name"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | pub const NOTES_TAG: &'static str = "Notes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:152:30 [INFO] [stderr] | [INFO] [stderr] 152 | pub const OVERRIDE_URL_TAG: &'static str = "OverrideURL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:153:31 [INFO] [stderr] | [INFO] [stderr] 153 | pub const PROTECT_NOTES_TAG: &'static str = "ProtectNotes"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | pub const PROTECT_PASSWORD_TAG: &'static str = "ProtectPassword"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | pub const PROTECT_TITLE_TAG: &'static str = "ProtectTitle"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | pub const PROTECT_URL_TAG: &'static str = "ProtectURL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | pub const PROTECT_USERNAME_TAG: &'static str = "ProtectUserName"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:158:37 [INFO] [stderr] | [INFO] [stderr] 158 | pub const RECYCLE_BIN_CHANGED_TAG: &'static str = "RecycleBinChanged"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | pub const RECYCLE_BIN_ENABLED_TAG: &'static str = "RecycleBinEnabled"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | pub const RECYCLE_BIN_UUID_TAG: &'static str = "RecycleBinUUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | pub const ROOT_TAG: &'static str = "Root"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:162:24 [INFO] [stderr] | [INFO] [stderr] 162 | pub const STRING_TAG: &'static str = "String"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | pub const TAGS_TAG: &'static str = "Tags"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | pub const TIMES_TAG: &'static str = "Times"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | pub const USAGE_COUNT_TAG: &'static str = "UsageCount"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:166:22 [INFO] [stderr] | [INFO] [stderr] 166 | pub const UUID_TAG: &'static str = "UUID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | pub const VALUE_TAG: &'static str = "Value"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kdb2.rs:168:24 [INFO] [stderr] | [INFO] [stderr] 168 | pub const WINDOW_TAG: &'static str = "Window"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:18:34 [INFO] [stderr] | [INFO] [stderr] 18 | pub const XML_KEY_FILE_VERSION: &'static str = "1.00"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub const KEY_FILE_TAG: &'static str = "KeyFile"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | pub const META_TAG: &'static str = "Meta"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | pub const VERSION_TAG: &'static str = "Version"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | pub const KEY_TAG: &'static str = "Key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format/kf.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | pub const DATA_TAG: &'static str = "Data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/database.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | return Err(Error::UnhandledDbType(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnhandledDbType(buffer))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/database.rs:453:13 [INFO] [stderr] | [INFO] [stderr] 453 | return Err(Error::UnhandledDbType(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnhandledDbType(buffer))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/database.rs:602:41 [INFO] [stderr] | [INFO] [stderr] 602 | assert_eq!(db.history_max_size, 6291456); [INFO] [stderr] | ^^^^^^^ help: consider: `6_291_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/xml_data.rs:181:43 [INFO] [stderr] | [INFO] [stderr] 181 | assert_eq!(data.history_max_size, 6291456); [INFO] [stderr] | ^^^^^^^ help: consider: `6_291_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/crypto/aes256.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / write_buffer [INFO] [stderr] 26 | | .take_read_buffer() [INFO] [stderr] 27 | | .take_remaining() [INFO] [stderr] 28 | | .iter() [INFO] [stderr] 29 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 25 | write_buffer [INFO] [stderr] 26 | .take_read_buffer() [INFO] [stderr] 27 | .take_remaining() [INFO] [stderr] 28 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/crypto/aes256.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | / write_buffer [INFO] [stderr] 52 | | .take_read_buffer() [INFO] [stderr] 53 | | .take_remaining() [INFO] [stderr] 54 | | .iter() [INFO] [stderr] 55 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 51 | write_buffer [INFO] [stderr] 52 | .take_read_buffer() [INFO] [stderr] 53 | .take_remaining() [INFO] [stderr] 54 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn encrypt(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | fn process(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/format/kdb2_reader.rs:190:12 [INFO] [stderr] | [INFO] [stderr] 190 | if data == &kdb2::AES_CIPHER_ID[..] { [INFO] [stderr] | ^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `kdb2::AES_CIPHER_ID[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:314:32 [INFO] [stderr] | [INFO] [stderr] 314 | fn read_xml_bytes(compression: &Compression, payload: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | fn read_bytes_size(reader: &mut R, size: &usize) -> Result> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format/kdb2_reader.rs:368:12 [INFO] [stderr] | [INFO] [stderr] 368 | header.ok_or(Error::MissingHeader(header_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingHeader(header_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:371:28 [INFO] [stderr] | [INFO] [stderr] 371 | fn decompress(compression: &Compression, data: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | try!(payload.write(&stream_start_bytes.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | try!(writer.write(&encrypted)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | try!(writer.write(&sha256::hash(&[data]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | try!(writer.write(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | try!(writer.write(&kdb2::FINAL_BLOCK_HASH)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | try!(writer.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_writer.rs:118:61 [INFO] [stderr] | [INFO] [stderr] 118 | fn write_compression(writer: &mut W, compression: &Compression) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | try!(writer.write(&common::DB_SIGNATURE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | try!(writer.write(&common::KDB2_SIGNATURE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_writer.rs:222:26 [INFO] [stderr] | [INFO] [stderr] 222 | fn compress(compression: &Compression, data: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kf_writer.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | try!(writer.write(key.key.unsecure())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kf_writer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | try!(writer.write(&hex.into_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match name.local_name.as_str() { [INFO] [stderr] 209 | | kdb2::GROUP_TAG => { [INFO] [stderr] 210 | | data.root_group = Some(try!(read_group(reader, cipher))); [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | _ => {} [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 208 | if let kdb2::GROUP_TAG = name.local_name.as_str() { [INFO] [stderr] 209 | data.root_group = Some(try!(read_group(reader, cipher))); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | / match name.local_name.as_str() { [INFO] [stderr] 236 | | kdb2::BINARY_TAG => { [INFO] [stderr] 237 | | let id = BinaryId(try!(get_id_attr_value(reader, &attributes))); [INFO] [stderr] 238 | | let compressed = try!(get_compressed_attr_value(reader, &attributes)); [INFO] [stderr] ... | [INFO] [stderr] 246 | | _ => {} [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | if let kdb2::BINARY_TAG = name.local_name.as_str() { [INFO] [stderr] 236 | let id = BinaryId(try!(get_id_attr_value(reader, &attributes))); [INFO] [stderr] 237 | let compressed = try!(get_compressed_attr_value(reader, &attributes)); [INFO] [stderr] 238 | let bytes = if compressed { [INFO] [stderr] 239 | try!(xml::read_gzip(reader)) [INFO] [stderr] 240 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match name.local_name.as_str() { [INFO] [stderr] 270 | | kdb2::ITEM_TAG => { [INFO] [stderr] 271 | | let (key, value) = try!(read_custom_data_item(reader)); [INFO] [stderr] 272 | | map.insert(key, value); [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let kdb2::ITEM_TAG = name.local_name.as_str() { [INFO] [stderr] 270 | let (key, value) = try!(read_custom_data_item(reader)); [INFO] [stderr] 271 | map.insert(key, value); [INFO] [stderr] 272 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | / match name.local_name.as_str() { [INFO] [stderr] 339 | | kdb2::ICON_TAG => { [INFO] [stderr] 340 | | let (uuid, data) = try!(read_custom_icon(reader)); [INFO] [stderr] 341 | | map.insert(uuid, data); [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | _ => {} [INFO] [stderr] 344 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 338 | if let kdb2::ICON_TAG = name.local_name.as_str() { [INFO] [stderr] 339 | let (uuid, data) = try!(read_custom_icon(reader)); [INFO] [stderr] 340 | map.insert(uuid, data); [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / match name.local_name.as_str() { [INFO] [stderr] 700 | | kdb2::ENTRY_TAG => { [INFO] [stderr] 701 | | list.push(try!(read_entry(reader, cipher, EntryState::History))); [INFO] [stderr] 702 | | } [INFO] [stderr] 703 | | _ => {} [INFO] [stderr] 704 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 699 | if let kdb2::ENTRY_TAG = name.local_name.as_str() { [INFO] [stderr] 700 | list.push(try!(read_entry(reader, cipher, EntryState::History))); [INFO] [stderr] 701 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:814:12 [INFO] [stderr] | [INFO] [stderr] 814 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:829:12 [INFO] [stderr] | [INFO] [stderr] 829 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | key: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | value: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:169:11 [INFO] [stderr] | [INFO] [stderr] 169 | icon: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:251:14 [INFO] [stderr] | [INFO] [stderr] 251 | entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:255:12 [INFO] [stderr] | [INFO] [stderr] 255 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:301:33 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn search_attr_value(attrs: &Vec, name: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/xml.rs:328:12 [INFO] [stderr] | [INFO] [stderr] 328 | value: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/xml.rs:406:67 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn write_string(writer: &mut EventWriter, value: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/xml.rs:415:12 [INFO] [stderr] | [INFO] [stderr] 415 | value: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:430:12 [INFO] [stderr] | [INFO] [stderr] 430 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:445:12 [INFO] [stderr] | [INFO] [stderr] 445 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types/color.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | } else if !hex.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | / pub fn get_entry<'a>(&'a self, uuid: EntryUuid) -> Option<&'a Entry> { [INFO] [stderr] 345 | | for group in self.root_group.iter() { [INFO] [stderr] 346 | | for entry in group.entries.iter() { [INFO] [stderr] 347 | | if entry.uuid == uuid { [INFO] [stderr] ... | [INFO] [stderr] 352 | | None [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:371:5 [INFO] [stderr] | [INFO] [stderr] 371 | / pub fn get_entry_mut<'a>(&'a mut self, uuid: EntryUuid) -> Option<&'a mut Entry> { [INFO] [stderr] 372 | | for group in self.root_group.iter_mut() { [INFO] [stderr] 373 | | for entry in group.entries.iter_mut() { [INFO] [stderr] 374 | | if entry.uuid == uuid { [INFO] [stderr] ... | [INFO] [stderr] 379 | | None [INFO] [stderr] 380 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | / pub fn get_group<'a>(&'a self, uuid: GroupUuid) -> Option<&'a Group> { [INFO] [stderr] 399 | | self.root_group.iter().find(|g| g.uuid == uuid) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | / pub fn get_group_mut<'a>(&'a mut self, uuid: GroupUuid) -> Option<&'a mut Group> { [INFO] [stderr] 419 | | self.root_group.iter_mut().find(|g| g.uuid == uuid) [INFO] [stderr] 420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/types/database.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | try!(reader.read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/types/database.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | try!(reader.read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/database.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | / match xml_data.header_hash { [INFO] [stderr] 486 | | Some(header_hash) => { [INFO] [stderr] 487 | | if meta_data.header_hash != header_hash { [INFO] [stderr] 488 | | return Err(Error::InvalidHeaderHash); [INFO] [stderr] ... | [INFO] [stderr] 491 | | None => {} [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 485 | if let Some(header_hash) = xml_data.header_hash { [INFO] [stderr] 486 | if meta_data.header_hash != header_hash { [INFO] [stderr] 487 | return Err(Error::InvalidHeaderHash); [INFO] [stderr] 488 | } [INFO] [stderr] 489 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/types/database.rs:545:47 [INFO] [stderr] | [INFO] [stderr] 545 | fn entry_contains_string(entry: &Entry, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/group.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match self.curr.take() { [INFO] [stderr] 325 | | Some(group) => { [INFO] [stderr] 326 | | for sub in group.groups.iter() { [INFO] [stderr] 327 | | self.todo.push_back(sub); [INFO] [stderr] ... | [INFO] [stderr] 330 | | None => {} [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 324 | if let Some(group) = self.curr.take() { [INFO] [stderr] 325 | for sub in group.groups.iter() { [INFO] [stderr] 326 | self.todo.push_back(sub); [INFO] [stderr] 327 | } [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/group.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | / match self.curr.take() { [INFO] [stderr] 359 | | Some(group) => { [INFO] [stderr] 360 | | for sub in group.groups.iter_mut() { [INFO] [stderr] 361 | | self.todo.push_back(sub); [INFO] [stderr] ... | [INFO] [stderr] 364 | | None => {} [INFO] [stderr] 365 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 358 | if let Some(group) = self.curr.take() { [INFO] [stderr] 359 | for sub in group.groups.iter_mut() { [INFO] [stderr] 360 | self.todo.push_back(sub); [INFO] [stderr] 361 | } [INFO] [stderr] 362 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/transformed_key.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let mut tmp_key = key.unsecure().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `key.unsecure()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-kpdb`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/crypto/aes256.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / write_buffer [INFO] [stderr] 26 | | .take_read_buffer() [INFO] [stderr] 27 | | .take_remaining() [INFO] [stderr] 28 | | .iter() [INFO] [stderr] 29 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 25 | write_buffer [INFO] [stderr] 26 | .take_read_buffer() [INFO] [stderr] 27 | .take_remaining() [INFO] [stderr] 28 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/crypto/aes256.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | / write_buffer [INFO] [stderr] 52 | | .take_read_buffer() [INFO] [stderr] 53 | | .take_remaining() [INFO] [stderr] 54 | | .iter() [INFO] [stderr] 55 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 51 | write_buffer [INFO] [stderr] 52 | .take_read_buffer() [INFO] [stderr] 53 | .take_remaining() [INFO] [stderr] 54 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn decrypt(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:22:45 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn encrypt(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypto/salsa20.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | fn process(cipher: &mut Salsa20, input: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/format/kdb2_reader.rs:190:12 [INFO] [stderr] | [INFO] [stderr] 190 | if data == &kdb2::AES_CIPHER_ID[..] { [INFO] [stderr] | ^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `kdb2::AES_CIPHER_ID[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:314:32 [INFO] [stderr] | [INFO] [stderr] 314 | fn read_xml_bytes(compression: &Compression, payload: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | fn read_bytes_size(reader: &mut R, size: &usize) -> Result> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/format/kdb2_reader.rs:363:5 [INFO] [stderr] | [INFO] [stderr] 363 | try!(reader.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format/kdb2_reader.rs:368:12 [INFO] [stderr] | [INFO] [stderr] 368 | header.ok_or(Error::MissingHeader(header_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingHeader(header_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_reader.rs:371:28 [INFO] [stderr] | [INFO] [stderr] 371 | fn decompress(compression: &Compression, data: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | try!(payload.write(&stream_start_bytes.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | try!(writer.write(&encrypted)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | try!(writer.write(&sha256::hash(&[data]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | try!(writer.write(data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | try!(writer.write(&kdb2::FINAL_BLOCK_HASH)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | try!(writer.write(bytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_writer.rs:118:61 [INFO] [stderr] | [INFO] [stderr] 118 | fn write_compression(writer: &mut W, compression: &Compression) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | try!(writer.write(&common::DB_SIGNATURE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kdb2_writer.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | try!(writer.write(&common::KDB2_SIGNATURE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/kdb2_writer.rs:222:26 [INFO] [stderr] | [INFO] [stderr] 222 | fn compress(compression: &Compression, data: &[u8]) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kf_writer.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | try!(writer.write(key.key.unsecure())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/format/kf_writer.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | try!(writer.write(&hex.into_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | / match name.local_name.as_str() { [INFO] [stderr] 209 | | kdb2::GROUP_TAG => { [INFO] [stderr] 210 | | data.root_group = Some(try!(read_group(reader, cipher))); [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | _ => {} [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 208 | if let kdb2::GROUP_TAG = name.local_name.as_str() { [INFO] [stderr] 209 | data.root_group = Some(try!(read_group(reader, cipher))); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | / match name.local_name.as_str() { [INFO] [stderr] 236 | | kdb2::BINARY_TAG => { [INFO] [stderr] 237 | | let id = BinaryId(try!(get_id_attr_value(reader, &attributes))); [INFO] [stderr] 238 | | let compressed = try!(get_compressed_attr_value(reader, &attributes)); [INFO] [stderr] ... | [INFO] [stderr] 246 | | _ => {} [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 235 | if let kdb2::BINARY_TAG = name.local_name.as_str() { [INFO] [stderr] 236 | let id = BinaryId(try!(get_id_attr_value(reader, &attributes))); [INFO] [stderr] 237 | let compressed = try!(get_compressed_attr_value(reader, &attributes)); [INFO] [stderr] 238 | let bytes = if compressed { [INFO] [stderr] 239 | try!(xml::read_gzip(reader)) [INFO] [stderr] 240 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | / match name.local_name.as_str() { [INFO] [stderr] 270 | | kdb2::ITEM_TAG => { [INFO] [stderr] 271 | | let (key, value) = try!(read_custom_data_item(reader)); [INFO] [stderr] 272 | | map.insert(key, value); [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let kdb2::ITEM_TAG = name.local_name.as_str() { [INFO] [stderr] 270 | let (key, value) = try!(read_custom_data_item(reader)); [INFO] [stderr] 271 | map.insert(key, value); [INFO] [stderr] 272 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | / match name.local_name.as_str() { [INFO] [stderr] 339 | | kdb2::ICON_TAG => { [INFO] [stderr] 340 | | let (uuid, data) = try!(read_custom_icon(reader)); [INFO] [stderr] 341 | | map.insert(uuid, data); [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | _ => {} [INFO] [stderr] 344 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 338 | if let kdb2::ICON_TAG = name.local_name.as_str() { [INFO] [stderr] 339 | let (uuid, data) = try!(read_custom_icon(reader)); [INFO] [stderr] 340 | map.insert(uuid, data); [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / match name.local_name.as_str() { [INFO] [stderr] 700 | | kdb2::ENTRY_TAG => { [INFO] [stderr] 701 | | list.push(try!(read_entry(reader, cipher, EntryState::History))); [INFO] [stderr] 702 | | } [INFO] [stderr] 703 | | _ => {} [INFO] [stderr] 704 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 699 | if let kdb2::ENTRY_TAG = name.local_name.as_str() { [INFO] [stderr] 700 | list.push(try!(read_entry(reader, cipher, EntryState::History))); [INFO] [stderr] 701 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:814:12 [INFO] [stderr] | [INFO] [stderr] 814 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_reader.rs:829:12 [INFO] [stderr] | [INFO] [stderr] 829 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | key: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | value: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:169:11 [INFO] [stderr] | [INFO] [stderr] 169 | icon: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/kdb2_xml_writer.rs:251:14 [INFO] [stderr] | [INFO] [stderr] 251 | entries: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:255:12 [INFO] [stderr] | [INFO] [stderr] 255 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:301:33 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn search_attr_value(attrs: &Vec, name: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/xml.rs:328:12 [INFO] [stderr] | [INFO] [stderr] 328 | value: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/xml.rs:406:67 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn write_string(writer: &mut EventWriter, value: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format/xml.rs:415:12 [INFO] [stderr] | [INFO] [stderr] 415 | value: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:430:12 [INFO] [stderr] | [INFO] [stderr] 430 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format/xml.rs:445:12 [INFO] [stderr] | [INFO] [stderr] 445 | attrs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/io/log_reader.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | target.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/io/log_reader.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | target.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/io/log_reader.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | target.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/io/log_reader.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | target.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/io/log_reader.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | target.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/io/log_writer.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | target.write(&[0, 1, 2, 3]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/io/log_writer.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | target.write(&[0, 1, 2, 3]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/io/log_writer.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | target.write(&[0, 1, 2, 3]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/io/log_writer.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | target.write(&[4, 5, 6, 7]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/io/log_writer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | target.write(&[8, 9, 10, 11]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types/color.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | } else if !hex.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/composite_key.rs:270:24 [INFO] [stderr] | [INFO] [stderr] 270 | let expected = array.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `array` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | / pub fn get_entry<'a>(&'a self, uuid: EntryUuid) -> Option<&'a Entry> { [INFO] [stderr] 345 | | for group in self.root_group.iter() { [INFO] [stderr] 346 | | for entry in group.entries.iter() { [INFO] [stderr] 347 | | if entry.uuid == uuid { [INFO] [stderr] ... | [INFO] [stderr] 352 | | None [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:371:5 [INFO] [stderr] | [INFO] [stderr] 371 | / pub fn get_entry_mut<'a>(&'a mut self, uuid: EntryUuid) -> Option<&'a mut Entry> { [INFO] [stderr] 372 | | for group in self.root_group.iter_mut() { [INFO] [stderr] 373 | | for entry in group.entries.iter_mut() { [INFO] [stderr] 374 | | if entry.uuid == uuid { [INFO] [stderr] ... | [INFO] [stderr] 379 | | None [INFO] [stderr] 380 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | / pub fn get_group<'a>(&'a self, uuid: GroupUuid) -> Option<&'a Group> { [INFO] [stderr] 399 | | self.root_group.iter().find(|g| g.uuid == uuid) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/types/database.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | / pub fn get_group_mut<'a>(&'a mut self, uuid: GroupUuid) -> Option<&'a mut Group> { [INFO] [stderr] 419 | | self.root_group.iter_mut().find(|g| g.uuid == uuid) [INFO] [stderr] 420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/types/database.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | try!(reader.read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/types/database.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | try!(reader.read(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/database.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | / match xml_data.header_hash { [INFO] [stderr] 486 | | Some(header_hash) => { [INFO] [stderr] 487 | | if meta_data.header_hash != header_hash { [INFO] [stderr] 488 | | return Err(Error::InvalidHeaderHash); [INFO] [stderr] ... | [INFO] [stderr] 491 | | None => {} [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 485 | if let Some(header_hash) = xml_data.header_hash { [INFO] [stderr] 486 | if meta_data.header_hash != header_hash { [INFO] [stderr] 487 | return Err(Error::InvalidHeaderHash); [INFO] [stderr] 488 | } [INFO] [stderr] 489 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/types/database.rs:545:47 [INFO] [stderr] | [INFO] [stderr] 545 | fn entry_contains_string(entry: &Entry, name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/types/database.rs:578:5 [INFO] [stderr] | [INFO] [stderr] 578 | / fn test_new_returns_correct_instance() { [INFO] [stderr] 579 | | let now = Utc::now(); [INFO] [stderr] 580 | | let key = CompositeKey::from_password("5pZ5mgpTkLCDaM46IuH7yGafZFIICyvC"); [INFO] [stderr] 581 | | let db = Database::new(&key); [INFO] [stderr] ... | [INFO] [stderr] 619 | | assert!(db.root_group.uuid != GroupUuid::nil()); [INFO] [stderr] 620 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/group.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match self.curr.take() { [INFO] [stderr] 325 | | Some(group) => { [INFO] [stderr] 326 | | for sub in group.groups.iter() { [INFO] [stderr] 327 | | self.todo.push_back(sub); [INFO] [stderr] ... | [INFO] [stderr] 330 | | None => {} [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 324 | if let Some(group) = self.curr.take() { [INFO] [stderr] 325 | for sub in group.groups.iter() { [INFO] [stderr] 326 | self.todo.push_back(sub); [INFO] [stderr] 327 | } [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/types/group.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | / match self.curr.take() { [INFO] [stderr] 359 | | Some(group) => { [INFO] [stderr] 360 | | for sub in group.groups.iter_mut() { [INFO] [stderr] 361 | | self.todo.push_back(sub); [INFO] [stderr] ... | [INFO] [stderr] 364 | | None => {} [INFO] [stderr] 365 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 358 | if let Some(group) = self.curr.take() { [INFO] [stderr] 359 | for sub in group.groups.iter_mut() { [INFO] [stderr] 360 | self.todo.push_back(sub); [INFO] [stderr] 361 | } [INFO] [stderr] 362 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/types/group.rs:386:32 [INFO] [stderr] | [INFO] [stderr] 386 | let group = Group::new(name.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 386 | let group = Group::new(&(*name).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 386 | let group = Group::new(&str::clone(name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `num` is used as a loop counter. Consider using `for (num, item) in root.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/types/group.rs:466:22 [INFO] [stderr] | [INFO] [stderr] 466 | for group in root.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `num` is used as a loop counter. Consider using `for (num, item) in root.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/types/group.rs:472:22 [INFO] [stderr] | [INFO] [stderr] 472 | for group in root.iter() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/master_key.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | let expected = array.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/stream_key.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | let target = StreamKey(expected.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/transformed_key.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let mut tmp_key = key.unsecure().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `key.unsecure()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/transformed_key.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | let expected = array.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/types/xml_data.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / fn test_default_returns_correct_instance() { [INFO] [stderr] 166 | | let now = Utc::now(); [INFO] [stderr] 167 | | let data = XmlData::default(); [INFO] [stderr] 168 | | assert_eq!(data.binaries, BinariesMap::new()); [INFO] [stderr] ... | [INFO] [stderr] 198 | | assert_eq!(data.root_group, None); [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 26 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-kpdb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f76a9c4b46f2376b25b6b3c7c4b6f326319d9893d703ce8d6cee71463d09e7c8"` [INFO] running `"docker" "rm" "-f" "f76a9c4b46f2376b25b6b3c7c4b6f326319d9893d703ce8d6cee71463d09e7c8"` [INFO] [stdout] f76a9c4b46f2376b25b6b3c7c4b6f326319d9893d703ce8d6cee71463d09e7c8