[INFO] crate rust-enum-derive 0.4.0 is already in cache [INFO] extracting crate rust-enum-derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rust-enum-derive/0.4.0 [INFO] extracting crate rust-enum-derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-enum-derive/0.4.0 [INFO] validating manifest of rust-enum-derive-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-enum-derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-enum-derive-0.4.0 [INFO] finished frobbing rust-enum-derive-0.4.0 [INFO] frobbed toml for rust-enum-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-enum-derive/0.4.0/Cargo.toml [INFO] started frobbing rust-enum-derive-0.4.0 [INFO] finished frobbing rust-enum-derive-0.4.0 [INFO] frobbed toml for rust-enum-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-enum-derive/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-enum-derive-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-enum-derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fe32b7dace90f6c0a81e49df40f2dbd092df0fbb1a178fda1199b75226236f9 [INFO] running `"docker" "start" "-a" "3fe32b7dace90f6c0a81e49df40f2dbd092df0fbb1a178fda1199b75226236f9"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `rust_enum_derive`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking rust-enum-derive v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | CEnum { i:i, s: String::from(s) } [INFO] [stderr] | ^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | CEnum { i:i, s: String::from(s) } [INFO] [stderr] | ^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | fn write(&self, w: &mut Write, name: &String, hex: bool, vec: &Vec) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:86:67 [INFO] [stderr] | [INFO] [stderr] 86 | fn write(&self, w: &mut Write, name: &String, hex: bool, vec: &Vec) -> Result<()>; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[CEnum]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:210:42 [INFO] [stderr] | [INFO] [stderr] 210 | fn write(&self, w: &mut Write, name: &String, derive: Option<&String>, hex: bool, vec: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:210:92 [INFO] [stderr] | [INFO] [stderr] 210 | fn write(&self, w: &mut Write, name: &String, derive: Option<&String>, hex: bool, vec: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[CEnum]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match derive [INFO] [stderr] 213 | | { [INFO] [stderr] 214 | | Some(s) => try!(write!(w, "#[derive({})]\n", s)), [INFO] [stderr] 215 | | None => (), [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = derive { try!(write!(w, "#[derive({})]\n", s)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | fn write(&self, w: &mut Write, name: &String, hex: bool, vec: &Vec) -> Result<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:86:67 [INFO] [stderr] | [INFO] [stderr] 86 | fn write(&self, w: &mut Write, name: &String, hex: bool, vec: &Vec) -> Result<()>; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[CEnum]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:293:31 [INFO] [stderr] | [INFO] [stderr] 293 | format!("rust-enum-derive wasn't a table"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"rust-enum-derive wasn't a table".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:340:14 [INFO] [stderr] | [INFO] [stderr] 340 | let re = match parse_enum { [INFO] [stderr] | ______________^ [INFO] [stderr] 341 | | true => Regex::new(r"^[:space:]*([[:alnum:]_]+)([:space:]*=[:space:]*([:graph:]+))?[:space:]*,").unwrap(), [INFO] [stderr] 342 | | false => Regex::new(r"^#define[:space:]+([:graph:]+)[:space:]+([:graph:]+)").unwrap(), [INFO] [stderr] 343 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if parse_enum { Regex::new(r"^[:space:]*([[:alnum:]_]+)([:space:]*=[:space:]*([:graph:]+))?[:space:]*,").unwrap() } else { Regex::new(r"^#define[:space:]+([:graph:]+)[:space:]+([:graph:]+)").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | let i: i32 = match parse_enum { [INFO] [stderr] | __________________________^ [INFO] [stderr] 351 | | true => match cap.at(3) { [INFO] [stderr] 352 | | Some(s) => get_num(s), [INFO] [stderr] 353 | | None => num, [INFO] [stderr] 354 | | }, [INFO] [stderr] 355 | | false => get_num(cap.at(2).unwrap()), [INFO] [stderr] 356 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 350 | let i: i32 = if parse_enum { match cap.at(3) { [INFO] [stderr] 351 | Some(s) => get_num(s), [INFO] [stderr] 352 | None => num, [INFO] [stderr] 353 | } } else { get_num(cap.at(2).unwrap()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:414:8 [INFO] [stderr] | [INFO] [stderr] 414 | if vi.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vi.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: function `test_CENum_order` should have a snake case name such as `test_cenum_order` [INFO] [stderr] --> src/lib.rs:506:1 [INFO] [stderr] | [INFO] [stderr] 506 | / fn test_CENum_order() { [INFO] [stderr] 507 | | let a = CEnum::new(0, ""); [INFO] [stderr] 508 | | let b = CEnum::new(1, ""); [INFO] [stderr] 509 | | let c = CEnum::new(2, ""); [INFO] [stderr] ... | [INFO] [stderr] 517 | | assert!(a == d); [INFO] [stderr] 518 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:210:42 [INFO] [stderr] | [INFO] [stderr] 210 | fn write(&self, w: &mut Write, name: &String, derive: Option<&String>, hex: bool, vec: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:210:92 [INFO] [stderr] | [INFO] [stderr] 210 | fn write(&self, w: &mut Write, name: &String, derive: Option<&String>, hex: bool, vec: &Vec) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[CEnum]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / match derive [INFO] [stderr] 213 | | { [INFO] [stderr] 214 | | Some(s) => try!(write!(w, "#[derive({})]\n", s)), [INFO] [stderr] 215 | | None => (), [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = derive { try!(write!(w, "#[derive({})]\n", s)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:293:31 [INFO] [stderr] | [INFO] [stderr] 293 | format!("rust-enum-derive wasn't a table"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"rust-enum-derive wasn't a table".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:340:14 [INFO] [stderr] | [INFO] [stderr] 340 | let re = match parse_enum { [INFO] [stderr] | ______________^ [INFO] [stderr] 341 | | true => Regex::new(r"^[:space:]*([[:alnum:]_]+)([:space:]*=[:space:]*([:graph:]+))?[:space:]*,").unwrap(), [INFO] [stderr] 342 | | false => Regex::new(r"^#define[:space:]+([:graph:]+)[:space:]+([:graph:]+)").unwrap(), [INFO] [stderr] 343 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if parse_enum { Regex::new(r"^[:space:]*([[:alnum:]_]+)([:space:]*=[:space:]*([:graph:]+))?[:space:]*,").unwrap() } else { Regex::new(r"^#define[:space:]+([:graph:]+)[:space:]+([:graph:]+)").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:350:26 [INFO] [stderr] | [INFO] [stderr] 350 | let i: i32 = match parse_enum { [INFO] [stderr] | __________________________^ [INFO] [stderr] 351 | | true => match cap.at(3) { [INFO] [stderr] 352 | | Some(s) => get_num(s), [INFO] [stderr] 353 | | None => num, [INFO] [stderr] 354 | | }, [INFO] [stderr] 355 | | false => get_num(cap.at(2).unwrap()), [INFO] [stderr] 356 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 350 | let i: i32 = if parse_enum { match cap.at(3) { [INFO] [stderr] 351 | Some(s) => get_num(s), [INFO] [stderr] 352 | None => num, [INFO] [stderr] 353 | } } else { get_num(cap.at(2).unwrap()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lib.rs:414:8 [INFO] [stderr] | [INFO] [stderr] 414 | if vi.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vi.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match traverse_dir(&input_dir, &output_dir) [INFO] [stderr] 115 | | { [INFO] [stderr] 116 | | Err(e) => panic!("{}", e), [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = traverse_dir(&input_dir, &output_dir) { panic!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | let file_path_in_ref = match file_path_in { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 127 | | Some(ref fp) => Some(fp), [INFO] [stderr] 128 | | None => None, [INFO] [stderr] 129 | | }; [INFO] [stderr] | |_________^ help: try this: `file_path_in.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | let file_path_out_ref = match file_path_out { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 137 | | Some(ref fp) => Some(fp), [INFO] [stderr] 138 | | None => None, [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `file_path_out.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match process(file_path_in_ref, file_path_out_ref, &file_args) [INFO] [stderr] 142 | | { [INFO] [stderr] 143 | | Err(e) => panic!("{}", e), [INFO] [stderr] 144 | | _ => () [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = process(file_path_in_ref, file_path_out_ref, &file_args) { panic!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match traverse_dir(&input_dir, &output_dir) [INFO] [stderr] 115 | | { [INFO] [stderr] 116 | | Err(e) => panic!("{}", e), [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = traverse_dir(&input_dir, &output_dir) { panic!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | let file_path_in_ref = match file_path_in { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 127 | | Some(ref fp) => Some(fp), [INFO] [stderr] 128 | | None => None, [INFO] [stderr] 129 | | }; [INFO] [stderr] | |_________^ help: try this: `file_path_in.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/main.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | let file_path_out_ref = match file_path_out { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 137 | | Some(ref fp) => Some(fp), [INFO] [stderr] 138 | | None => None, [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `file_path_out.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match process(file_path_in_ref, file_path_out_ref, &file_args) [INFO] [stderr] 142 | | { [INFO] [stderr] 143 | | Err(e) => panic!("{}", e), [INFO] [stderr] 144 | | _ => () [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = process(file_path_in_ref, file_path_out_ref, &file_args) { panic!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.56s [INFO] running `"docker" "inspect" "3fe32b7dace90f6c0a81e49df40f2dbd092df0fbb1a178fda1199b75226236f9"` [INFO] running `"docker" "rm" "-f" "3fe32b7dace90f6c0a81e49df40f2dbd092df0fbb1a178fda1199b75226236f9"` [INFO] [stdout] 3fe32b7dace90f6c0a81e49df40f2dbd092df0fbb1a178fda1199b75226236f9