[INFO] crate rust-consul 0.1.0 is already in cache [INFO] extracting crate rust-consul 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust-consul/0.1.0 [INFO] extracting crate rust-consul 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-consul/0.1.0 [INFO] validating manifest of rust-consul-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-consul-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-consul-0.1.0 [INFO] finished frobbing rust-consul-0.1.0 [INFO] frobbed toml for rust-consul-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-consul/0.1.0/Cargo.toml [INFO] started frobbing rust-consul-0.1.0 [INFO] finished frobbing rust-consul-0.1.0 [INFO] frobbed toml for rust-consul-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-consul/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-consul-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-consul/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a4c8406e2b4c11d974466945f1bda3b16c12b4bf54b60b647ae50c7f7797c29 [INFO] running `"docker" "start" "-a" "7a4c8406e2b4c11d974466945f1bda3b16c12b4bf54b60b647ae50c7f7797c29"` [INFO] [stderr] Checking rust-consul v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn from<'a>(headers: &'a Headers) -> Result { [INFO] [stderr] 198 | | headers.get::().ok_or(()).map(|res| res.clone()) [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:198:51 [INFO] [stderr] | [INFO] [stderr] 198 | headers.get::().ok_or(()).map(|res| res.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*res` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::clone_on_copy)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | fn add_to_uri(&self, uri: &Url) -> Url { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: large size difference between variants [INFO] [stderr] --> src/lib.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / PendingBody { [INFO] [stderr] 488 | | base_uri: Url, [INFO] [stderr] 489 | | client: Client, [INFO] [stderr] 490 | | error_state: ErrorState, [INFO] [stderr] ... | [INFO] [stderr] 493 | | body: BodyBuffer, [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::large_enum_variant)] implied by #[deny(warnings)] [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / PendingBody { [INFO] [stderr] 488 | | base_uri: Url, [INFO] [stderr] 489 | | client: Client, [INFO] [stderr] 490 | | error_state: ErrorState, [INFO] [stderr] ... | [INFO] [stderr] 493 | | body: BodyBuffer, [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:790:5 [INFO] [stderr] | [INFO] [stderr] 790 | / if let &JsonValue::Object(ref map) = value { [INFO] [stderr] 791 | | let mut out = Vec::with_capacity(map.len()); [INFO] [stderr] 792 | | for (k, v) in map.iter() { [INFO] [stderr] 793 | | if let &JsonValue::Array(ref _values) = v { [INFO] [stderr] ... | [INFO] [stderr] 803 | | Err(ParseError::UnexpectedJsonFormat) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_ref_pats)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 790 | if let JsonValue::Object(ref map) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:793:13 [INFO] [stderr] | [INFO] [stderr] 793 | / if let &JsonValue::Array(ref _values) = v { [INFO] [stderr] 794 | | if k != "consul" { [INFO] [stderr] 795 | | out.push(k.clone()); [INFO] [stderr] 796 | | } [INFO] [stderr] 797 | | } else { [INFO] [stderr] 798 | | return Err(ParseError::UnexpectedJsonFormat) [INFO] [stderr] 799 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 793 | if let JsonValue::Array(ref _values) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn from<'a>(headers: &'a Headers) -> Result { [INFO] [stderr] 198 | | headers.get::().ok_or(()).map(|res| res.clone()) [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:198:51 [INFO] [stderr] | [INFO] [stderr] 198 | headers.get::().ok_or(()).map(|res| res.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*res` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::clone_on_copy)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:201:18 [INFO] [stderr] | [INFO] [stderr] 201 | fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | fn add_to_uri(&self, uri: &Url) -> Url { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/lib.rs:875:28 [INFO] [stderr] | [INFO] [stderr] 875 | }).map_err(|e| Error::BodyParse(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::BodyParse` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: large size difference between variants [INFO] [stderr] --> src/lib.rs:892:5 [INFO] [stderr] | [INFO] [stderr] 892 | / PendingBody { [INFO] [stderr] 893 | | base_uri: Url, [INFO] [stderr] 894 | | client: Client, [INFO] [stderr] 895 | | headers: Headers, [INFO] [stderr] 896 | | body: BodyBuffer, [INFO] [stderr] 897 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:892:5 [INFO] [stderr] | [INFO] [stderr] 892 | / PendingBody { [INFO] [stderr] 893 | | base_uri: Url, [INFO] [stderr] 894 | | client: Client, [INFO] [stderr] 895 | | headers: Headers, [INFO] [stderr] 896 | | body: BodyBuffer, [INFO] [stderr] 897 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] error: large size difference between variants [INFO] [stderr] --> src/lib.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / PendingBody { [INFO] [stderr] 488 | | base_uri: Url, [INFO] [stderr] 489 | | client: Client, [INFO] [stderr] 490 | | error_state: ErrorState, [INFO] [stderr] ... | [INFO] [stderr] 493 | | body: BodyBuffer, [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::large_enum_variant)] implied by #[deny(warnings)] [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / PendingBody { [INFO] [stderr] 488 | | base_uri: Url, [INFO] [stderr] 489 | | client: Client, [INFO] [stderr] 490 | | error_state: ErrorState, [INFO] [stderr] ... | [INFO] [stderr] 493 | | body: BodyBuffer, [INFO] [stderr] 494 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:790:5 [INFO] [stderr] | [INFO] [stderr] 790 | / if let &JsonValue::Object(ref map) = value { [INFO] [stderr] 791 | | let mut out = Vec::with_capacity(map.len()); [INFO] [stderr] 792 | | for (k, v) in map.iter() { [INFO] [stderr] 793 | | if let &JsonValue::Array(ref _values) = v { [INFO] [stderr] ... | [INFO] [stderr] 803 | | Err(ParseError::UnexpectedJsonFormat) [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_ref_pats)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 790 | if let JsonValue::Object(ref map) = *value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:793:13 [INFO] [stderr] | [INFO] [stderr] 793 | / if let &JsonValue::Array(ref _values) = v { [INFO] [stderr] 794 | | if k != "consul" { [INFO] [stderr] 795 | | out.push(k.clone()); [INFO] [stderr] 796 | | } [INFO] [stderr] 797 | | } else { [INFO] [stderr] 798 | | return Err(ParseError::UnexpectedJsonFormat) [INFO] [stderr] 799 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 793 | if let JsonValue::Array(ref _values) = *v { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/lib.rs:875:28 [INFO] [stderr] | [INFO] [stderr] 875 | }).map_err(|e| Error::BodyParse(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::BodyParse` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-consul`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: large size difference between variants [INFO] [stderr] --> src/lib.rs:892:5 [INFO] [stderr] | [INFO] [stderr] 892 | / PendingBody { [INFO] [stderr] 893 | | base_uri: Url, [INFO] [stderr] 894 | | client: Client, [INFO] [stderr] 895 | | headers: Headers, [INFO] [stderr] 896 | | body: BodyBuffer, [INFO] [stderr] 897 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:892:5 [INFO] [stderr] | [INFO] [stderr] 892 | / PendingBody { [INFO] [stderr] 893 | | base_uri: Url, [INFO] [stderr] 894 | | client: Client, [INFO] [stderr] 895 | | headers: Headers, [INFO] [stderr] 896 | | body: BodyBuffer, [INFO] [stderr] 897 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-consul`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7a4c8406e2b4c11d974466945f1bda3b16c12b4bf54b60b647ae50c7f7797c29"` [INFO] running `"docker" "rm" "-f" "7a4c8406e2b4c11d974466945f1bda3b16c12b4bf54b60b647ae50c7f7797c29"` [INFO] [stdout] 7a4c8406e2b4c11d974466945f1bda3b16c12b4bf54b60b647ae50c7f7797c29