[INFO] crate rust-cgui 0.1.11 is already in cache [INFO] extracting crate rust-cgui 0.1.11 into work/ex/clippy-test-run/sources/stable/reg/rust-cgui/0.1.11 [INFO] extracting crate rust-cgui 0.1.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-cgui/0.1.11 [INFO] validating manifest of rust-cgui-0.1.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-cgui-0.1.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-cgui-0.1.11 [INFO] finished frobbing rust-cgui-0.1.11 [INFO] frobbed toml for rust-cgui-0.1.11 written to work/ex/clippy-test-run/sources/stable/reg/rust-cgui/0.1.11/Cargo.toml [INFO] started frobbing rust-cgui-0.1.11 [INFO] finished frobbing rust-cgui-0.1.11 [INFO] frobbed toml for rust-cgui-0.1.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-cgui/0.1.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-cgui-0.1.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-cgui/0.1.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cb5189dba35d376a915a74d0a990ef305c9e7414db3d1739aa2e9c92038d679 [INFO] running `"docker" "start" "-a" "1cb5189dba35d376a915a74d0a990ef305c9e7414db3d1739aa2e9c92038d679"` [INFO] [stderr] Checking scan_fmt v0.1.3 [INFO] [stderr] Checking rust-cgui v0.1.11 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | return CWin::new().to_ffi_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new().to_ffi_ptr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return CWin::new_detail(title_owned, width, height).to_ffi_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new_detail(title_owned, width, height).to_ffi_ptr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (*win_ptr).event_tick(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*win_ptr).event_tick()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | return cstr_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cstr_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:122:7 [INFO] [stderr] | [INFO] [stderr] 122 | return Some(first_char); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(first_char)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:251:7 [INFO] [stderr] | [INFO] [stderr] 251 | return cstr_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cstr_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Pixel` [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | use image::{ImageBuffer, Rgb, Pixel}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return CWin::new_detail("Untitled Window", 800, 600); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new_detail("Untitled Window", 800, 600)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / return CWin { [INFO] [stderr] 93 | | rep: CWinRep { [INFO] [stderr] 94 | | title: title, [INFO] [stderr] 95 | | width: width as usize, [INFO] [stderr] ... | [INFO] [stderr] 117 | | event_callbacks: vec![], [INFO] [stderr] 118 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | CWin { [INFO] [stderr] 93 | rep: CWinRep { [INFO] [stderr] 94 | title: title, [INFO] [stderr] 95 | width: width as usize, [INFO] [stderr] 96 | height: height as usize, [INFO] [stderr] 97 | pixels: ImageBuffer::new(width, height), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return Box::into_raw(boxed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::into_raw(boxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | return CWin::new().to_ffi_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new().to_ffi_ptr()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | return CWin::new_detail(title_owned, width, height).to_ffi_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new_detail(title_owned, width, height).to_ffi_ptr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ext.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return (*win_ptr).event_tick(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*win_ptr).event_tick()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | return cstr_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cstr_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:122:7 [INFO] [stderr] | [INFO] [stderr] 122 | return Some(first_char); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(first_char)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x11back.rs:251:7 [INFO] [stderr] | [INFO] [stderr] 251 | return cstr_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cstr_ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Pixel` [INFO] [stderr] --> src/lib.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | use image::{ImageBuffer, Rgb, Pixel}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return CWin::new_detail("Untitled Window", 800, 600); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CWin::new_detail("Untitled Window", 800, 600)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / return CWin { [INFO] [stderr] 93 | | rep: CWinRep { [INFO] [stderr] 94 | | title: title, [INFO] [stderr] 95 | | width: width as usize, [INFO] [stderr] ... | [INFO] [stderr] 117 | | event_callbacks: vec![], [INFO] [stderr] 118 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | CWin { [INFO] [stderr] 93 | rep: CWinRep { [INFO] [stderr] 94 | title: title, [INFO] [stderr] 95 | width: width as usize, [INFO] [stderr] 96 | height: height as usize, [INFO] [stderr] 97 | pixels: ImageBuffer::new(width, height), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return Box::into_raw(boxed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::into_raw(boxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_ffi_ptr(mut self) -> *mut CWin { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | CStr::from_ptr(title).to_str().unwrap().to_owned() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | let _data = Box::from_raw(win_ptr); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | (*win_ptr).add_callback(ffi_fun); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | (*win_ptr).call_callbacks(evt_str); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | (*win_ptr).event_loop(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | return (*win_ptr).event_tick(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | (*win_ptr).init(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | (*win_ptr).rep.exit_flag = val != 0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | (*win_ptr).redraw_dirty(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:113:7 [INFO] [stderr] | [INFO] [stderr] 113 | (*win_ptr).redraw_box(x1 as usize, y1 as usize, x2 as usize, y2 as usize); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:123:7 [INFO] [stderr] | [INFO] [stderr] 123 | (*win_ptr).write_px(x, y, [red as u8, green as u8, blue as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/x11back.rs:115:8 [INFO] [stderr] | [INFO] [stderr] 115 | if returned_data.to_bytes().len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `returned_data.to_bytes().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | ((color[0] as u64) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:202:14 [INFO] [stderr] | [INFO] [stderr] 202 | ((color[1] as u64) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(color[2] as u64)` [INFO] [stderr] --> src/x11back.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | ((color[2] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | ((color[2] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CWin` [INFO] [stderr] --> src/lib.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn new() -> CWin { [INFO] [stderr] 88 | | return CWin::new_detail("Untitled Window", 800, 600); [INFO] [stderr] 89 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | impl Default for CWin { [INFO] [stderr] 87 | fn default() -> Self { [INFO] [stderr] 88 | Self::new() [INFO] [stderr] 89 | } [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_ffi_ptr(mut self) -> *mut CWin { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | (c)(cwinrep, event_string.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `event_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_ffi_ptr(mut self) -> *mut CWin { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-cgui`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | CStr::from_ptr(title).to_str().unwrap().to_owned() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | let _data = Box::from_raw(win_ptr); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | (*win_ptr).add_callback(ffi_fun); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | (*win_ptr).call_callbacks(evt_str); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | (*win_ptr).event_loop(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | return (*win_ptr).event_tick(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | (*win_ptr).init(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | (*win_ptr).rep.exit_flag = val != 0; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | (*win_ptr).redraw_dirty(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:113:7 [INFO] [stderr] | [INFO] [stderr] 113 | (*win_ptr).redraw_box(x1 as usize, y1 as usize, x2 as usize, y2 as usize); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/ext.rs:123:7 [INFO] [stderr] | [INFO] [stderr] 123 | (*win_ptr).write_px(x, y, [red as u8, green as u8, blue as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/x11back.rs:115:8 [INFO] [stderr] | [INFO] [stderr] 115 | if returned_data.to_bytes().len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `returned_data.to_bytes().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:201:14 [INFO] [stderr] | [INFO] [stderr] 201 | ((color[0] as u64) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:202:14 [INFO] [stderr] | [INFO] [stderr] 202 | ((color[1] as u64) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(color[2] as u64)` [INFO] [stderr] --> src/x11back.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | ((color[2] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/x11back.rs:203:14 [INFO] [stderr] | [INFO] [stderr] 203 | ((color[2] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `CWin` [INFO] [stderr] --> src/lib.rs:87:3 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn new() -> CWin { [INFO] [stderr] 88 | | return CWin::new_detail("Untitled Window", 800, 600); [INFO] [stderr] 89 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | impl Default for CWin { [INFO] [stderr] 87 | fn default() -> Self { [INFO] [stderr] 88 | Self::new() [INFO] [stderr] 89 | } [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_ffi_ptr(mut self) -> *mut CWin { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | (c)(cwinrep, event_string.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `event_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-cgui`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1cb5189dba35d376a915a74d0a990ef305c9e7414db3d1739aa2e9c92038d679"` [INFO] running `"docker" "rm" "-f" "1cb5189dba35d376a915a74d0a990ef305c9e7414db3d1739aa2e9c92038d679"` [INFO] [stdout] 1cb5189dba35d376a915a74d0a990ef305c9e7414db3d1739aa2e9c92038d679