[INFO] crate rust-calculator 0.1.0 is already in cache
[INFO] extracting crate rust-calculator 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust-calculator/0.1.0
[INFO] extracting crate rust-calculator 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-calculator/0.1.0
[INFO] validating manifest of rust-calculator-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rust-calculator-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rust-calculator-0.1.0
[INFO] finished frobbing rust-calculator-0.1.0
[INFO] frobbed toml for rust-calculator-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-calculator/0.1.0/Cargo.toml
[INFO] started frobbing rust-calculator-0.1.0
[INFO] finished frobbing rust-calculator-0.1.0
[INFO] frobbed toml for rust-calculator-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-calculator/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rust-calculator-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-calculator/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c5abf16193570203f849ba4ec411d06ab6f066f5747c2a279d5666641c1b7493
[INFO] running `"docker" "start" "-a" "c5abf16193570203f849ba4ec411d06ab6f066f5747c2a279d5666641c1b7493"`
[INFO] [stderr]     Checking rust-calculator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/mod.rs:92:64
[INFO] [stderr]    |
[INFO] [stderr] 92 |                                 Ok(Box::new( ast::Assignment { name: name, value: expr}))
[INFO] [stderr]    |                                                                ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:153:21
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:158:21
[INFO] [stderr]     |
[INFO] [stderr] 158 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:163:21
[INFO] [stderr]     |
[INFO] [stderr] 163 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:168:21
[INFO] [stderr]     |
[INFO] [stderr] 168 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     println!("");
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 println!("");
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser/mod.rs:92:64
[INFO] [stderr]    |
[INFO] [stderr] 92 |                                 Ok(Box::new( ast::Assignment { name: name, value: expr}))
[INFO] [stderr]    |                                                                ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:153:21
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:158:21
[INFO] [stderr]     |
[INFO] [stderr] 158 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:163:21
[INFO] [stderr]     |
[INFO] [stderr] 163 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser/mod.rs:168:21
[INFO] [stderr]     |
[INFO] [stderr] 168 |                     arg: arg
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:34:21
[INFO] [stderr]    |
[INFO] [stderr] 34 |                     println!("");
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 println!("");
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/parser/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         p
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/parser/mod.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |           let p = Parser {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 18 | |             current: EOF,
[INFO] [stderr] 19 | |             peeked: None,
[INFO] [stderr] 20 | |             lexer: l
[INFO] [stderr] 21 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/parser/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         p
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/parser/mod.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |           let p = Parser {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 18 | |             current: EOF,
[INFO] [stderr] 19 | |             peeked: None,
[INFO] [stderr] 20 | |             lexer: l
[INFO] [stderr] 21 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/parser/ast.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 | /         match res {
[INFO] [stderr] 159 | |             Some(x) => println!("{}", x),
[INFO] [stderr] 160 | |             None => {}
[INFO] [stderr] 161 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(x) = res { println!("{}", x) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/parser/ast.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match val {
[INFO] [stderr] 188 | |             Some(x) => { env.insert(self.name.clone(), x); }
[INFO] [stderr] 189 | |             None => {}
[INFO] [stderr] 190 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(x) = val { env.insert(self.name.clone(), x); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/token.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     match t {
[INFO] [stderr] 49 | |         &EOF => true,
[INFO] [stderr] 50 | |         _ => false
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |     match *t {
[INFO] [stderr] 49 |         EOF => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if input.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/parser/ast.rs:158:9
[INFO] [stderr]     |
[INFO] [stderr] 158 | /         match res {
[INFO] [stderr] 159 | |             Some(x) => println!("{}", x),
[INFO] [stderr] 160 | |             None => {}
[INFO] [stderr] 161 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(x) = res { println!("{}", x) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/parser/ast.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match val {
[INFO] [stderr] 188 | |             Some(x) => { env.insert(self.name.clone(), x); }
[INFO] [stderr] 189 | |             None => {}
[INFO] [stderr] 190 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(x) = val { env.insert(self.name.clone(), x); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/token.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     match t {
[INFO] [stderr] 49 | |         &EOF => true,
[INFO] [stderr] 50 | |         _ => false
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |     match *t {
[INFO] [stderr] 49 |         EOF => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if input.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.81s
[INFO] running `"docker" "inspect" "c5abf16193570203f849ba4ec411d06ab6f066f5747c2a279d5666641c1b7493"`
[INFO] running `"docker" "rm" "-f" "c5abf16193570203f849ba4ec411d06ab6f066f5747c2a279d5666641c1b7493"`
[INFO] [stdout] c5abf16193570203f849ba4ec411d06ab6f066f5747c2a279d5666641c1b7493