[INFO] crate rust-argon2-ffi 0.1.0 is already in cache [INFO] extracting crate rust-argon2-ffi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust-argon2-ffi/0.1.0 [INFO] extracting crate rust-argon2-ffi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-argon2-ffi/0.1.0 [INFO] validating manifest of rust-argon2-ffi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-argon2-ffi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-argon2-ffi-0.1.0 [INFO] finished frobbing rust-argon2-ffi-0.1.0 [INFO] frobbed toml for rust-argon2-ffi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-argon2-ffi/0.1.0/Cargo.toml [INFO] started frobbing rust-argon2-ffi-0.1.0 [INFO] finished frobbing rust-argon2-ffi-0.1.0 [INFO] frobbed toml for rust-argon2-ffi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-argon2-ffi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-argon2-ffi-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-argon2-ffi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9af41801bf43f5749b5e4cae22693acee07c4cd6906a70ec32f61d53db9102b7 [INFO] running `"docker" "start" "-a" "9af41801bf43f5749b5e4cae22693acee07c4cd6906a70ec32f61d53db9102b7"` [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking rust-argon2 v0.3.0 [INFO] [stderr] Checking rust-argon2-ffi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:788:9 [INFO] [stderr] | [INFO] [stderr] 788 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:789:9 [INFO] [stderr] | [INFO] [stderr] 789 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:790:9 [INFO] [stderr] | [INFO] [stderr] 790 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:792:9 [INFO] [stderr] | [INFO] [stderr] 792 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:793:9 [INFO] [stderr] | [INFO] [stderr] 793 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:794:9 [INFO] [stderr] | [INFO] [stderr] 794 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:788:9 [INFO] [stderr] | [INFO] [stderr] 788 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:789:9 [INFO] [stderr] | [INFO] [stderr] 789 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:790:9 [INFO] [stderr] | [INFO] [stderr] 790 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:792:9 [INFO] [stderr] | [INFO] [stderr] 792 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:793:9 [INFO] [stderr] | [INFO] [stderr] 793 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:794:9 [INFO] [stderr] | [INFO] [stderr] 794 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:802:9 [INFO] [stderr] | [INFO] [stderr] 802 | return Err(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:810:9 [INFO] [stderr] | [INFO] [stderr] 810 | return Err(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:424:56 [INFO] [stderr] | [INFO] [stderr] 424 | ptr::copy_nonoverlapping(vec.as_ptr(), out, vec.len()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:754:1 [INFO] [stderr] | [INFO] [stderr] 754 | / fn mk_config<'a>( [INFO] [stderr] 755 | | variant: u32, [INFO] [stderr] 756 | | version: u32, [INFO] [stderr] 757 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 797 | | }) [INFO] [stderr] 798 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-argon2-ffi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:802:9 [INFO] [stderr] | [INFO] [stderr] 802 | return Err(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:810:9 [INFO] [stderr] | [INFO] [stderr] 810 | return Err(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:829:25 [INFO] [stderr] | [INFO] [stderr] 829 | const ARGON2D_ENC: &'static [u8] = b"$argon2d$v=19$m=4096,t=3,p=1$c29tZXNhbHQ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:832:25 [INFO] [stderr] | [INFO] [stderr] 832 | const ARGON2I_ENC: &'static [u8] = b"$argon2i$v=19$m=4096,t=3,p=1$c29tZXNhbHQ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:835:26 [INFO] [stderr] | [INFO] [stderr] 835 | const ARGON2ID_ENC: &'static [u8] = b"$argon2id$v=19$m=4096,t=3,p=1$c29tZXNhbHQ\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:850:17 [INFO] [stderr] | [INFO] [stderr] 850 | const PWD: &'static [u8] = b"password"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:852:27 [INFO] [stderr] | [INFO] [stderr] 852 | const PWD_INCORRECT: &'static [u8] = b"wrong"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:854:18 [INFO] [stderr] | [INFO] [stderr] 854 | const SALT: &'static [u8] = b"somesalt"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:856:24 [INFO] [stderr] | [INFO] [stderr] 856 | const SALT_SHORT: &'static [u8] = b"salt"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:424:56 [INFO] [stderr] | [INFO] [stderr] 424 | ptr::copy_nonoverlapping(vec.as_ptr(), out, vec.len()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:754:1 [INFO] [stderr] | [INFO] [stderr] 754 | / fn mk_config<'a>( [INFO] [stderr] 755 | | variant: u32, [INFO] [stderr] 756 | | version: u32, [INFO] [stderr] 757 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 797 | | }) [INFO] [stderr] 798 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-argon2-ffi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9af41801bf43f5749b5e4cae22693acee07c4cd6906a70ec32f61d53db9102b7"` [INFO] running `"docker" "rm" "-f" "9af41801bf43f5749b5e4cae22693acee07c4cd6906a70ec32f61d53db9102b7"` [INFO] [stdout] 9af41801bf43f5749b5e4cae22693acee07c4cd6906a70ec32f61d53db9102b7