[INFO] crate rust-argon2 0.3.0 is already in cache [INFO] extracting crate rust-argon2 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rust-argon2/0.3.0 [INFO] extracting crate rust-argon2 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-argon2/0.3.0 [INFO] validating manifest of rust-argon2-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-argon2-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-argon2-0.3.0 [INFO] finished frobbing rust-argon2-0.3.0 [INFO] frobbed toml for rust-argon2-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-argon2/0.3.0/Cargo.toml [INFO] started frobbing rust-argon2-0.3.0 [INFO] finished frobbing rust-argon2-0.3.0 [INFO] frobbed toml for rust-argon2-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-argon2/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-argon2-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rust-argon2/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fd2bca1423efcaba07e2ec5978810b5d5b3ec4f732d9c2398f550b5c366bb0c [INFO] running `"docker" "start" "-a" "8fd2bca1423efcaba07e2ec5978810b5d5b3ec4f732d9c2398f550b5c366bb0c"` [INFO] [stderr] Checking rust-argon2 v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/argon2.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:402:9 [INFO] [stderr] | [INFO] [stderr] 402 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:466:9 [INFO] [stderr] | [INFO] [stderr] 466 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:605:9 [INFO] [stderr] | [INFO] [stderr] 605 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:607:9 [INFO] [stderr] | [INFO] [stderr] 607 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:608:9 [INFO] [stderr] | [INFO] [stderr] 608 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:681:9 [INFO] [stderr] | [INFO] [stderr] 681 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:682:9 [INFO] [stderr] | [INFO] [stderr] 682 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:683:9 [INFO] [stderr] | [INFO] [stderr] 683 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | lane_length: lane_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lane_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | memory_blocks: memory_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `memory_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | pwd: pwd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | segment_length: segment_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/argon2.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:400:9 [INFO] [stderr] | [INFO] [stderr] 400 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:402:9 [INFO] [stderr] | [INFO] [stderr] 402 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:466:9 [INFO] [stderr] | [INFO] [stderr] 466 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:605:9 [INFO] [stderr] | [INFO] [stderr] 605 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:607:9 [INFO] [stderr] | [INFO] [stderr] 607 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:608:9 [INFO] [stderr] | [INFO] [stderr] 608 | lanes: lanes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lanes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | secret: secret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | ad: ad, [INFO] [stderr] | ^^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:681:9 [INFO] [stderr] | [INFO] [stderr] 681 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:682:9 [INFO] [stderr] | [INFO] [stderr] 682 | mem_cost: mem_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argon2.rs:683:9 [INFO] [stderr] | [INFO] [stderr] 683 | time_cost: time_cost, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_cost` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | lane_length: lane_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lane_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | memory_blocks: memory_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `memory_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | pwd: pwd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | segment_length: segment_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | salt: salt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoding.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | blocks: blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub const MAX_LANES: u32 = 0x00FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | pub const MAX_HASH_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | pub const MAX_MEMORY: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub const MAX_TIME: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | pub const MAX_PWD_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | pub const MAX_AD_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | pub const MAX_SALT_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | pub const MAX_SECRET_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let m = 0xFFFFFFFFu64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/core.rs:302:28 [INFO] [stderr] | [INFO] [stderr] 302 | let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:310:46 [INFO] [stderr] | [INFO] [stderr] 310 | let pseudo_rand_u32 = (pseudo_rand & 0xFFFFFFFF) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 323 | | if position.pass == 0 { [INFO] [stderr] 324 | | fill_block(prev_block, ref_block, &mut curr_block, false); [INFO] [stderr] 325 | | } else { [INFO] [stderr] 326 | | fill_block(prev_block, ref_block, &mut curr_block, true); [INFO] [stderr] 327 | | } [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | } else if position.pass == 0 { [INFO] [stderr] 323 | fill_block(prev_block, ref_block, &mut curr_block, false); [INFO] [stderr] 324 | } else { [INFO] [stderr] 325 | fill_block(prev_block, ref_block, &mut curr_block, true); [INFO] [stderr] 326 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:404:16 [INFO] [stderr] | [INFO] [stderr] 404 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 405 | | if same_lane { [INFO] [stderr] 406 | | // The same lane => add current segment [INFO] [stderr] 407 | | position.slice * context.segment_length + position.index - 1 [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | } else if same_lane { [INFO] [stderr] 405 | // The same lane => add current segment [INFO] [stderr] 406 | position.slice * context.segment_length + position.index - 1 [INFO] [stderr] 407 | } else { [INFO] [stderr] 408 | if position.index == 0 { [INFO] [stderr] 409 | position.slice * context.segment_length - 1 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:408:20 [INFO] [stderr] | [INFO] [stderr] 408 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 409 | | if position.index == 0 { [INFO] [stderr] 410 | | position.slice * context.segment_length - 1 [INFO] [stderr] 411 | | } else { [INFO] [stderr] 412 | | position.slice * context.segment_length [INFO] [stderr] 413 | | } [INFO] [stderr] 414 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 408 | } else if position.index == 0 { [INFO] [stderr] 409 | position.slice * context.segment_length - 1 [INFO] [stderr] 410 | } else { [INFO] [stderr] 411 | position.slice * context.segment_length [INFO] [stderr] 412 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:420:16 [INFO] [stderr] | [INFO] [stderr] 420 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 421 | | if position.index == 0 { [INFO] [stderr] 422 | | context.lane_length - context.segment_length - 1 [INFO] [stderr] 423 | | } else { [INFO] [stderr] 424 | | context.lane_length - context.segment_length [INFO] [stderr] 425 | | } [INFO] [stderr] 426 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | } else if position.index == 0 { [INFO] [stderr] 421 | context.lane_length - context.segment_length - 1 [INFO] [stderr] 422 | } else { [INFO] [stderr] 423 | context.lane_length - context.segment_length [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core.rs:430:25 [INFO] [stderr] | [INFO] [stderr] 430 | relative_position = relative_position * relative_position >> 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(relative_position * relative_position) >> 32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core.rs:431:52 [INFO] [stderr] | [INFO] [stderr] 431 | relative_position = reference_area_size - 1 - (reference_area_size * relative_position >> 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(reference_area_size * relative_position) >> 32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Err(Error::DecodingFail); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::DecodingFail)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | pub const MAX_LANES: u32 = 0x00FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | pub const MAX_HASH_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | pub const MAX_MEMORY: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub const MAX_TIME: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | pub const MAX_PWD_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | pub const MAX_AD_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | pub const MAX_SALT_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | pub const MAX_SECRET_LENGTH: u32 = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let m = 0xFFFFFFFFu64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/core.rs:302:28 [INFO] [stderr] | [INFO] [stderr] 302 | let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:310:46 [INFO] [stderr] | [INFO] [stderr] 310 | let pseudo_rand_u32 = (pseudo_rand & 0xFFFFFFFF) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 323 | | if position.pass == 0 { [INFO] [stderr] 324 | | fill_block(prev_block, ref_block, &mut curr_block, false); [INFO] [stderr] 325 | | } else { [INFO] [stderr] 326 | | fill_block(prev_block, ref_block, &mut curr_block, true); [INFO] [stderr] 327 | | } [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | } else if position.pass == 0 { [INFO] [stderr] 323 | fill_block(prev_block, ref_block, &mut curr_block, false); [INFO] [stderr] 324 | } else { [INFO] [stderr] 325 | fill_block(prev_block, ref_block, &mut curr_block, true); [INFO] [stderr] 326 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:404:16 [INFO] [stderr] | [INFO] [stderr] 404 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 405 | | if same_lane { [INFO] [stderr] 406 | | // The same lane => add current segment [INFO] [stderr] 407 | | position.slice * context.segment_length + position.index - 1 [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | } else if same_lane { [INFO] [stderr] 405 | // The same lane => add current segment [INFO] [stderr] 406 | position.slice * context.segment_length + position.index - 1 [INFO] [stderr] 407 | } else { [INFO] [stderr] 408 | if position.index == 0 { [INFO] [stderr] 409 | position.slice * context.segment_length - 1 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:408:20 [INFO] [stderr] | [INFO] [stderr] 408 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 409 | | if position.index == 0 { [INFO] [stderr] 410 | | position.slice * context.segment_length - 1 [INFO] [stderr] 411 | | } else { [INFO] [stderr] 412 | | position.slice * context.segment_length [INFO] [stderr] 413 | | } [INFO] [stderr] 414 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 408 | } else if position.index == 0 { [INFO] [stderr] 409 | position.slice * context.segment_length - 1 [INFO] [stderr] 410 | } else { [INFO] [stderr] 411 | position.slice * context.segment_length [INFO] [stderr] 412 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/core.rs:420:16 [INFO] [stderr] | [INFO] [stderr] 420 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 421 | | if position.index == 0 { [INFO] [stderr] 422 | | context.lane_length - context.segment_length - 1 [INFO] [stderr] 423 | | } else { [INFO] [stderr] 424 | | context.lane_length - context.segment_length [INFO] [stderr] 425 | | } [INFO] [stderr] 426 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 420 | } else if position.index == 0 { [INFO] [stderr] 421 | context.lane_length - context.segment_length - 1 [INFO] [stderr] 422 | } else { [INFO] [stderr] 423 | context.lane_length - context.segment_length [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core.rs:430:25 [INFO] [stderr] | [INFO] [stderr] 430 | relative_position = relative_position * relative_position >> 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(relative_position * relative_position) >> 32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/core.rs:431:52 [INFO] [stderr] | [INFO] [stderr] 431 | relative_position = reference_area_size - 1 - (reference_area_size * relative_position >> 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(reference_area_size * relative_position) >> 32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return Err(Error::DecodingFail); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::DecodingFail)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encoding.rs:393:77 [INFO] [stderr] | [INFO] [stderr] 393 | let tests = vec![(1, 1), (10, 2), (110, 3), (1230, 4), (12340, 5), (123457, 6)]; [INFO] [stderr] | ^^^^^^ help: consider: `123_457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn hash_encoded_old( [INFO] [stderr] 174 | | variant: Variant, [INFO] [stderr] 175 | | version: Version, [INFO] [stderr] 176 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 197 | | hash_encoded(pwd, salt, &config) [INFO] [stderr] 198 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:245:1 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn hash_encoded_std( [INFO] [stderr] 246 | | variant: Variant, [INFO] [stderr] 247 | | version: Version, [INFO] [stderr] 248 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 266 | | hash_encoded(pwd, salt, &config) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:382:1 [INFO] [stderr] | [INFO] [stderr] 382 | / pub fn hash_raw_old( [INFO] [stderr] 383 | | variant: Variant, [INFO] [stderr] 384 | | version: Version, [INFO] [stderr] 385 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 406 | | hash_raw(pwd, salt, &config) [INFO] [stderr] 407 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:454:1 [INFO] [stderr] | [INFO] [stderr] 454 | / pub fn hash_raw_std( [INFO] [stderr] 455 | | variant: Variant, [INFO] [stderr] 456 | | version: Version, [INFO] [stderr] 457 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 475 | | hash_raw(pwd, salt, &config) [INFO] [stderr] 476 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:590:1 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn verify_raw_old( [INFO] [stderr] 591 | | variant: Variant, [INFO] [stderr] 592 | | version: Version, [INFO] [stderr] 593 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 614 | | verify_raw(pwd, salt, hash, &config) [INFO] [stderr] 615 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:669:1 [INFO] [stderr] | [INFO] [stderr] 669 | / pub fn verify_raw_std( [INFO] [stderr] 670 | | variant: Variant, [INFO] [stderr] 671 | | version: Version, [INFO] [stderr] 672 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 690 | | verify_raw(pwd, salt, hash, &config) [INFO] [stderr] 691 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/block.rs:20:57 [INFO] [stderr] | [INFO] [stderr] 20 | let bytes: &[u8; common::BLOCK_SIZE] = unsafe { mem::transmute(&self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.0 as *const [u64; 128] as *const [u8; 1024])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/block.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | let bytes: &mut [u8; common::BLOCK_SIZE] = unsafe { mem::transmute(&mut self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.0 as *mut [u64; 128] as *mut [u8; 1024])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | } else if config.mem_cost > common::MAX_MEMORY { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because common::MAX_MEMORY is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | } else if config.time_cost > common::MAX_TIME { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because common::MAX_TIME is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | } else if config.hash_length > common::MAX_HASH_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because common::MAX_HASH_LENGTH is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:253:26 [INFO] [stderr] | [INFO] [stderr] 253 | input_block[0] = position.pass as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.pass)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:254:26 [INFO] [stderr] | [INFO] [stderr] 254 | input_block[1] = position.lane as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:255:26 [INFO] [stderr] | [INFO] [stderr] 255 | input_block[2] = position.slice as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:256:26 [INFO] [stderr] | [INFO] [stderr] 256 | input_block[3] = context.memory_blocks as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.memory_blocks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | input_block[4] = context.config.time_cost as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.config.time_cost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/core.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | / let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] 303 | | if (position.pass == 0) && (position.slice == 0) { [INFO] [stderr] 304 | | // Can not reference other lanes yet [INFO] [stderr] 305 | | ref_lane = position.lane as u64; [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ref_lane = if (position.pass == 0) && (position.slice == 0) { position.lane as u64 } else { ((pseudo_rand >> 32)) % context.config.lanes as u64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:302:52 [INFO] [stderr] | [INFO] [stderr] 302 | let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.config.lanes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:305:24 [INFO] [stderr] | [INFO] [stderr] 305 | ref_lane = position.lane as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:311:37 [INFO] [stderr] | [INFO] [stderr] 311 | let same_lane = ref_lane == (position.lane as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | let index = context.lane_length as u64 * ref_lane + ref_index as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.lane_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:315:61 [INFO] [stderr] | [INFO] [stderr] 315 | let index = context.lane_length as u64 * ref_lane + ref_index as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let ref prev_block = memory[prev_offset]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------- help: try: `let prev_block = &memory[prev_offset];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core.rs:319:17 [INFO] [stderr] | [INFO] [stderr] 319 | let ref ref_block = memory[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------------- help: try: `let ref_block = &memory[index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:356:18 [INFO] [stderr] | [INFO] [stderr] 356 | context.pwd.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `context.pwd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:358:18 [INFO] [stderr] | [INFO] [stderr] 358 | context.salt.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | context.config.secret.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.config.secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:362:18 [INFO] [stderr] | [INFO] [stderr] 362 | context.config.ad.as_ref()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.config.ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:428:31 [INFO] [stderr] | [INFO] [stderr] 428 | let reference_area_size = reference_area_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reference_area_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:429:33 [INFO] [stderr] | [INFO] [stderr] 429 | let mut relative_position = pseudo_rand as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pseudo_rand)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:443:26 [INFO] [stderr] | [INFO] [stderr] 443 | let start_position = start_position as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(start_position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:446:45 [INFO] [stderr] | [INFO] [stderr] 446 | ((start_position + relative_position) % context.lane_length as u64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.lane_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/core.rs:459:1 [INFO] [stderr] | [INFO] [stderr] 459 | / fn p( [INFO] [stderr] 460 | | v0: &mut u64, [INFO] [stderr] 461 | | v1: &mut u64, [INFO] [stderr] 462 | | v2: &mut u64, [INFO] [stderr] ... | [INFO] [stderr] 484 | | g(v3, v4, v9, v14); [INFO] [stderr] 485 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encoding.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | pub fn encode_string(context: &Context, hash: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn as_lowercase_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn as_uppercase_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/variant.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn from_str(str: &str) -> Result { [INFO] [stderr] 60 | | match str { [INFO] [stderr] 61 | | "Argon2d" => Ok(Variant::Argon2d), [INFO] [stderr] 62 | | "Argon2i" => Ok(Variant::Argon2i), [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn from_str(str: &str) -> Result { [INFO] [stderr] 31 | | match str { [INFO] [stderr] 32 | | "16" => Ok(Version::Version10), [INFO] [stderr] 33 | | "19" => Ok(Version::Version13), [INFO] [stderr] 34 | | _ => Err(Error::DecodingFail), [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-argon2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn hash_encoded_old( [INFO] [stderr] 174 | | variant: Variant, [INFO] [stderr] 175 | | version: Version, [INFO] [stderr] 176 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 197 | | hash_encoded(pwd, salt, &config) [INFO] [stderr] 198 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:245:1 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn hash_encoded_std( [INFO] [stderr] 246 | | variant: Variant, [INFO] [stderr] 247 | | version: Version, [INFO] [stderr] 248 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 266 | | hash_encoded(pwd, salt, &config) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:382:1 [INFO] [stderr] | [INFO] [stderr] 382 | / pub fn hash_raw_old( [INFO] [stderr] 383 | | variant: Variant, [INFO] [stderr] 384 | | version: Version, [INFO] [stderr] 385 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 406 | | hash_raw(pwd, salt, &config) [INFO] [stderr] 407 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:454:1 [INFO] [stderr] | [INFO] [stderr] 454 | / pub fn hash_raw_std( [INFO] [stderr] 455 | | variant: Variant, [INFO] [stderr] 456 | | version: Version, [INFO] [stderr] 457 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 475 | | hash_raw(pwd, salt, &config) [INFO] [stderr] 476 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/argon2.rs:590:1 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn verify_raw_old( [INFO] [stderr] 591 | | variant: Variant, [INFO] [stderr] 592 | | version: Version, [INFO] [stderr] 593 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 614 | | verify_raw(pwd, salt, hash, &config) [INFO] [stderr] 615 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/argon2.rs:669:1 [INFO] [stderr] | [INFO] [stderr] 669 | / pub fn verify_raw_std( [INFO] [stderr] 670 | | variant: Variant, [INFO] [stderr] 671 | | version: Version, [INFO] [stderr] 672 | | mem_cost: u32, [INFO] [stderr] ... | [INFO] [stderr] 690 | | verify_raw(pwd, salt, hash, &config) [INFO] [stderr] 691 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/block.rs:20:57 [INFO] [stderr] | [INFO] [stderr] 20 | let bytes: &[u8; common::BLOCK_SIZE] = unsafe { mem::transmute(&self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.0 as *const [u64; 128] as *const [u8; 1024])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/block.rs:26:61 [INFO] [stderr] | [INFO] [stderr] 26 | let bytes: &mut [u8; common::BLOCK_SIZE] = unsafe { mem::transmute(&mut self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.0 as *mut [u64; 128] as *mut [u8; 1024])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | } else if config.mem_cost > common::MAX_MEMORY { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because common::MAX_MEMORY is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | } else if config.time_cost > common::MAX_TIME { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because common::MAX_TIME is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/context.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | } else if config.hash_length > common::MAX_HASH_LENGTH { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because common::MAX_HASH_LENGTH is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:253:26 [INFO] [stderr] | [INFO] [stderr] 253 | input_block[0] = position.pass as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.pass)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:254:26 [INFO] [stderr] | [INFO] [stderr] 254 | input_block[1] = position.lane as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:255:26 [INFO] [stderr] | [INFO] [stderr] 255 | input_block[2] = position.slice as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:256:26 [INFO] [stderr] | [INFO] [stderr] 256 | input_block[3] = context.memory_blocks as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.memory_blocks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | input_block[4] = context.config.time_cost as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.config.time_cost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/core.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | / let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] 303 | | if (position.pass == 0) && (position.slice == 0) { [INFO] [stderr] 304 | | // Can not reference other lanes yet [INFO] [stderr] 305 | | ref_lane = position.lane as u64; [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ref_lane = if (position.pass == 0) && (position.slice == 0) { position.lane as u64 } else { ((pseudo_rand >> 32)) % context.config.lanes as u64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:302:52 [INFO] [stderr] | [INFO] [stderr] 302 | let mut ref_lane = ((pseudo_rand >> 32)) % context.config.lanes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.config.lanes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:305:24 [INFO] [stderr] | [INFO] [stderr] 305 | ref_lane = position.lane as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:311:37 [INFO] [stderr] | [INFO] [stderr] 311 | let same_lane = ref_lane == (position.lane as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(position.lane)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:315:21 [INFO] [stderr] | [INFO] [stderr] 315 | let index = context.lane_length as u64 * ref_lane + ref_index as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.lane_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:315:61 [INFO] [stderr] | [INFO] [stderr] 315 | let index = context.lane_length as u64 * ref_lane + ref_index as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(ref_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let ref prev_block = memory[prev_offset]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------- help: try: `let prev_block = &memory[prev_offset];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core.rs:319:17 [INFO] [stderr] | [INFO] [stderr] 319 | let ref ref_block = memory[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------------- help: try: `let ref_block = &memory[index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:356:18 [INFO] [stderr] | [INFO] [stderr] 356 | context.pwd.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `context.pwd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:358:18 [INFO] [stderr] | [INFO] [stderr] 358 | context.salt.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.salt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | context.config.secret.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.config.secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/core.rs:362:18 [INFO] [stderr] | [INFO] [stderr] 362 | context.config.ad.as_ref()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `context.config.ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:428:31 [INFO] [stderr] | [INFO] [stderr] 428 | let reference_area_size = reference_area_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(reference_area_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:429:33 [INFO] [stderr] | [INFO] [stderr] 429 | let mut relative_position = pseudo_rand as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pseudo_rand)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:443:26 [INFO] [stderr] | [INFO] [stderr] 443 | let start_position = start_position as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(start_position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:446:45 [INFO] [stderr] | [INFO] [stderr] 446 | ((start_position + relative_position) % context.lane_length as u64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(context.lane_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/core.rs:459:1 [INFO] [stderr] | [INFO] [stderr] 459 | / fn p( [INFO] [stderr] 460 | | v0: &mut u64, [INFO] [stderr] 461 | | v1: &mut u64, [INFO] [stderr] 462 | | v2: &mut u64, [INFO] [stderr] ... | [INFO] [stderr] 484 | | g(v3, v4, v9, v14); [INFO] [stderr] 485 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/encoding.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | pub fn encode_string(context: &Context, hash: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn as_lowercase_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn as_uppercase_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/variant.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn from_str(str: &str) -> Result { [INFO] [stderr] 60 | | match str { [INFO] [stderr] 61 | | "Argon2d" => Ok(Variant::Argon2d), [INFO] [stderr] 62 | | "Argon2i" => Ok(Variant::Argon2i), [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn from_str(str: &str) -> Result { [INFO] [stderr] 31 | | match str { [INFO] [stderr] 32 | | "16" => Ok(Version::Version10), [INFO] [stderr] 33 | | "19" => Ok(Version::Version13), [INFO] [stderr] 34 | | _ => Err(Error::DecodingFail), [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-argon2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8fd2bca1423efcaba07e2ec5978810b5d5b3ec4f732d9c2398f550b5c366bb0c"` [INFO] running `"docker" "rm" "-f" "8fd2bca1423efcaba07e2ec5978810b5d5b3ec4f732d9c2398f550b5c366bb0c"` [INFO] [stdout] 8fd2bca1423efcaba07e2ec5978810b5d5b3ec4f732d9c2398f550b5c366bb0c