[INFO] crate rusqlite 0.15.0 is already in cache [INFO] extracting crate rusqlite 0.15.0 into work/ex/clippy-test-run/sources/stable/reg/rusqlite/0.15.0 [INFO] extracting crate rusqlite 0.15.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusqlite/0.15.0 [INFO] validating manifest of rusqlite-0.15.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusqlite-0.15.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusqlite-0.15.0 [INFO] removed 3 missing tests [INFO] finished frobbing rusqlite-0.15.0 [INFO] frobbed toml for rusqlite-0.15.0 written to work/ex/clippy-test-run/sources/stable/reg/rusqlite/0.15.0/Cargo.toml [INFO] started frobbing rusqlite-0.15.0 [INFO] removed 3 missing tests [INFO] finished frobbing rusqlite-0.15.0 [INFO] frobbed toml for rusqlite-0.15.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusqlite/0.15.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusqlite-0.15.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusqlite/0.15.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47f05e45f60fe0d347cc65d7f466bcd86c3c39448465f18cb5287709b9760fdb [INFO] running `"docker" "start" "-a" "47f05e45f60fe0d347cc65d7f466bcd86c3c39448465f18cb5287709b9760fdb"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/vtab.rs [INFO] [stderr] * /opt/crater/workdir/tests/deny_single_threaded_sqlite_config.rs [INFO] [stderr] * /opt/crater/workdir/tests/config_log.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking rusqlite v0.15.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/row.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | #[cfg_attr(feature = "cargo-clippy", allow(should_implement_trait))] // cannot implement Iterator [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub const NO_PARAMS: &'static [&'static ToSql] = &[]; [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static ToSql]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | pub const NO_PARAMS: &'static [&'static ToSql] = &[]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&ToSql` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #[allow(enum_variant_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/row.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | #[cfg_attr(feature = "cargo-clippy", allow(should_implement_trait))] // cannot implement Iterator [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:222:16 [INFO] [stderr] | [INFO] [stderr] 222 | &[-2147483649, 2147483648], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_649` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:222:28 [INFO] [stderr] | [INFO] [stderr] 222 | &[-2147483649, 2147483648], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:223:16 [INFO] [stderr] | [INFO] [stderr] 223 | &[-2147483648, -1, 0, 1, 2147483647], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:223:38 [INFO] [stderr] | [INFO] [stderr] 223 | &[-2147483648, -1, 0, 1, 2147483647], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:227:44 [INFO] [stderr] | [INFO] [stderr] 227 | check_ranges::(&db, &[-2, -1, 4294967296], &[0, 1, 4294967295]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/from_sql.rs:227:65 [INFO] [stderr] | [INFO] [stderr] 227 | check_ranges::(&db, &[-2, -1, 4294967296], &[0, 1, 4294967295]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/time.rs:52:41 [INFO] [stderr] | [INFO] [stderr] 52 | ts_vec.push(time::Timespec::new(1500391124, 1_000_000)); //July 18, 2017 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_500_391_124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/time.rs:53:41 [INFO] [stderr] | [INFO] [stderr] 53 | ts_vec.push(time::Timespec::new(2000000000, 2_000_000)); //May 18, 2033 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/time.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | ts_vec.push(time::Timespec::new(3000000000, 999_999_999)); //January 24, 2065 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/time.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | ts_vec.push(time::Timespec::new(10000000000, 0)); //November 20, 2286 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub const NO_PARAMS: &'static [&'static ToSql] = &[]; [INFO] [stderr] | -^^^^^^^----------------- help: consider removing `'static`: `&[&'static ToSql]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | pub const NO_PARAMS: &'static [&'static ToSql] = &[]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&ToSql` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/statement.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | / match rows.next() { [INFO] [stderr] 372 | | Some(_) => true, [INFO] [stderr] 373 | | None => false, [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____________^ help: try this: `rows.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicPtr instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:810:38 [INFO] [stderr] | [INFO] [stderr] 810 | interrupt_lock: Arc::new(Mutex::new(db)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/statement.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | / match rows.next() { [INFO] [stderr] 372 | | Some(_) => true, [INFO] [stderr] 373 | | None => false, [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____________^ help: try this: `rows.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/statement.rs:797:13 [INFO] [stderr] | [INFO] [stderr] 797 | Err(_) => panic!("invalid Err"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rusqlite`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/types/mod.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / fn test_mismatched_types() { [INFO] [stderr] 230 | | fn is_invalid_column_type(err: Error) -> bool { [INFO] [stderr] 231 | | match err { [INFO] [stderr] 232 | | Error::InvalidColumnType(_, _) => true, [INFO] [stderr] ... | [INFO] [stderr] 346 | | )); [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicPtr instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:810:38 [INFO] [stderr] | [INFO] [stderr] 810 | interrupt_lock: Arc::new(Mutex::new(db)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:1132:13 [INFO] [stderr] | [INFO] [stderr] 1132 | / let _ = tx1 [INFO] [stderr] 1133 | | .query_row("SELECT x FROM foo LIMIT 1", NO_PARAMS, |_| ()) [INFO] [stderr] 1134 | | .unwrap(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:1135:13 [INFO] [stderr] | [INFO] [stderr] 1135 | / let _ = tx2 [INFO] [stderr] 1136 | | .query_row("SELECT x FROM foo LIMIT 1", NO_PARAMS, |_| ()) [INFO] [stderr] 1137 | | .unwrap(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1566:16 [INFO] [stderr] | [INFO] [stderr] 1566 | if i != tries - 1 && !result.is_err() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i != tries - 1 && result.is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:1534:17 [INFO] [stderr] | [INFO] [stderr] 1534 | (0..100_000).into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..100_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "47f05e45f60fe0d347cc65d7f466bcd86c3c39448465f18cb5287709b9760fdb"` [INFO] running `"docker" "rm" "-f" "47f05e45f60fe0d347cc65d7f466bcd86c3c39448465f18cb5287709b9760fdb"` [INFO] [stdout] 47f05e45f60fe0d347cc65d7f466bcd86c3c39448465f18cb5287709b9760fdb