[INFO] crate rusoto_serverlessrepo 0.35.0 is already in cache [INFO] extracting crate rusoto_serverlessrepo 0.35.0 into work/ex/clippy-test-run/sources/stable/reg/rusoto_serverlessrepo/0.35.0 [INFO] extracting crate rusoto_serverlessrepo 0.35.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_serverlessrepo/0.35.0 [INFO] validating manifest of rusoto_serverlessrepo-0.35.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusoto_serverlessrepo-0.35.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusoto_serverlessrepo-0.35.0 [INFO] finished frobbing rusoto_serverlessrepo-0.35.0 [INFO] frobbed toml for rusoto_serverlessrepo-0.35.0 written to work/ex/clippy-test-run/sources/stable/reg/rusoto_serverlessrepo/0.35.0/Cargo.toml [INFO] started frobbing rusoto_serverlessrepo-0.35.0 [INFO] finished frobbing rusoto_serverlessrepo-0.35.0 [INFO] frobbed toml for rusoto_serverlessrepo-0.35.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_serverlessrepo/0.35.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusoto_serverlessrepo-0.35.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusoto_serverlessrepo/0.35.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dea1f96221d45316dc98a68f5473c66ad346e929b7fbf8d814fa2b015d962e65 [INFO] running `"docker" "start" "-a" "dea1f96221d45316dc98a68f5473c66ad346e929b7fbf8d814fa2b015d962e65"` [INFO] [stderr] Checking rusoto_mock v0.29.0 [INFO] [stderr] Checking rusoto_serverlessrepo v0.35.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:2108:13 [INFO] [stderr] | [INFO] [stderr] 2108 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:2125:13 [INFO] [stderr] | [INFO] [stderr] 2125 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/rusoto_mock-0.29.0/src/lib.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | body: Box::new(once(Ok(self.body.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rusoto_core::ByteStream`, found struct `std::boxed::Box` [INFO] [stderr] | [INFO] [stderr] = note: expected type `rusoto_core::ByteStream` [INFO] [stderr] found type `std::boxed::Box, _>>` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `rusoto_mock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:888:9 [INFO] [stderr] | [INFO] [stderr] 888 | return CreateApplicationError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CreateApplicationError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1012:9 [INFO] [stderr] | [INFO] [stderr] 1012 | return CreateApplicationVersionError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CreateApplicationVersionError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1135:9 [INFO] [stderr] | [INFO] [stderr] 1135 | return CreateCloudFormationChangeSetError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CreateCloudFormationChangeSetError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1259:9 [INFO] [stderr] | [INFO] [stderr] 1259 | return DeleteApplicationError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeleteApplicationError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1380:9 [INFO] [stderr] | [INFO] [stderr] 1380 | return GetApplicationError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetApplicationError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1500:9 [INFO] [stderr] | [INFO] [stderr] 1500 | return GetApplicationPolicyError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetApplicationPolicyError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1624:9 [INFO] [stderr] | [INFO] [stderr] 1624 | return ListApplicationVersionsError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListApplicationVersionsError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1739:9 [INFO] [stderr] | [INFO] [stderr] 1739 | return ListApplicationsError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListApplicationsError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1858:9 [INFO] [stderr] | [INFO] [stderr] 1858 | return PutApplicationPolicyError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PutApplicationPolicyError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1983:9 [INFO] [stderr] | [INFO] [stderr] 1983 | return UpdateApplicationError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UpdateApplicationError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2158:21 [INFO] [stderr] | [INFO] [stderr] 2158 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2156:25 [INFO] [stderr] | [INFO] [stderr] 2156 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2202:21 [INFO] [stderr] | [INFO] [stderr] 2202 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2200:25 [INFO] [stderr] | [INFO] [stderr] 2200 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2244:21 [INFO] [stderr] | [INFO] [stderr] 2244 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2241:25 [INFO] [stderr] | [INFO] [stderr] 2241 | / serde_json::from_slice::(&body) [INFO] [stderr] 2242 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2273:21 [INFO] [stderr] | [INFO] [stderr] 2273 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2271:34 [INFO] [stderr] | [INFO] [stderr] 2271 | let result = ::std::mem::drop(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2318:21 [INFO] [stderr] | [INFO] [stderr] 2318 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2316:34 [INFO] [stderr] | [INFO] [stderr] 2316 | let result = serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2358:21 [INFO] [stderr] | [INFO] [stderr] 2358 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2356:25 [INFO] [stderr] | [INFO] [stderr] 2356 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2406:21 [INFO] [stderr] | [INFO] [stderr] 2406 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2404:25 [INFO] [stderr] | [INFO] [stderr] 2404 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2448:21 [INFO] [stderr] | [INFO] [stderr] 2448 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2446:34 [INFO] [stderr] | [INFO] [stderr] 2446 | let result = serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2493:21 [INFO] [stderr] | [INFO] [stderr] 2493 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2491:25 [INFO] [stderr] | [INFO] [stderr] 2491 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/generated.rs:2535:21 [INFO] [stderr] | [INFO] [stderr] 2535 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/generated.rs:2533:25 [INFO] [stderr] | [INFO] [stderr] 2533 | serde_json::from_slice::(&body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/generated.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(warnings)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(warnings)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/generated.rs:2271:21 [INFO] [stderr] | [INFO] [stderr] 2271 | let result = ::std::mem::drop(response); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusoto_serverlessrepo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dea1f96221d45316dc98a68f5473c66ad346e929b7fbf8d814fa2b015d962e65"` [INFO] running `"docker" "rm" "-f" "dea1f96221d45316dc98a68f5473c66ad346e929b7fbf8d814fa2b015d962e65"` [INFO] [stdout] dea1f96221d45316dc98a68f5473c66ad346e929b7fbf8d814fa2b015d962e65