[INFO] crate rusoto_fms 0.35.0 is already in cache [INFO] extracting crate rusoto_fms 0.35.0 into work/ex/clippy-test-run/sources/stable/reg/rusoto_fms/0.35.0 [INFO] extracting crate rusoto_fms 0.35.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_fms/0.35.0 [INFO] validating manifest of rusoto_fms-0.35.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusoto_fms-0.35.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusoto_fms-0.35.0 [INFO] finished frobbing rusoto_fms-0.35.0 [INFO] frobbed toml for rusoto_fms-0.35.0 written to work/ex/clippy-test-run/sources/stable/reg/rusoto_fms/0.35.0/Cargo.toml [INFO] started frobbing rusoto_fms-0.35.0 [INFO] finished frobbing rusoto_fms-0.35.0 [INFO] frobbed toml for rusoto_fms-0.35.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_fms/0.35.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusoto_fms-0.35.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusoto_fms/0.35.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7e78cfbd54bfdd70c75ef197c0eb0a037d9117eb3252288cb5f3ae11484a3dd [INFO] running `"docker" "start" "-a" "a7e78cfbd54bfdd70c75ef197c0eb0a037d9117eb3252288cb5f3ae11484a3dd"` [INFO] [stderr] Checking rusoto_mock v0.29.0 [INFO] [stderr] Checking rusoto_fms v0.35.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:1599:13 [INFO] [stderr] | [INFO] [stderr] 1599 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:1616:13 [INFO] [stderr] | [INFO] [stderr] 1616 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/rusoto_mock-0.29.0/src/lib.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | body: Box::new(once(Ok(self.body.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rusoto_core::ByteStream`, found struct `std::boxed::Box` [INFO] [stderr] | [INFO] [stderr] = note: expected type `rusoto_core::ByteStream` [INFO] [stderr] found type `std::boxed::Box, _>>` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `rusoto_mock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:437:9 [INFO] [stderr] | [INFO] [stderr] 437 | return AssociateAdminAccountError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `AssociateAdminAccountError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:538:9 [INFO] [stderr] | [INFO] [stderr] 538 | return DeleteNotificationChannelError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeleteNotificationChannelError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:632:9 [INFO] [stderr] | [INFO] [stderr] 632 | return DeletePolicyError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeletePolicyError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:728:9 [INFO] [stderr] | [INFO] [stderr] 728 | return DisassociateAdminAccountError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DisassociateAdminAccountError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:822:9 [INFO] [stderr] | [INFO] [stderr] 822 | return GetAdminAccountError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetAdminAccountError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:909:9 [INFO] [stderr] | [INFO] [stderr] 909 | return GetComplianceDetailError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetComplianceDetailError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1006:9 [INFO] [stderr] | [INFO] [stderr] 1006 | return GetNotificationChannelError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetNotificationChannelError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1100:9 [INFO] [stderr] | [INFO] [stderr] 1100 | return GetPolicyError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetPolicyError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1187:9 [INFO] [stderr] | [INFO] [stderr] 1187 | return ListComplianceStatusError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListComplianceStatusError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1285:9 [INFO] [stderr] | [INFO] [stderr] 1285 | return ListPoliciesError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListPoliciesError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1382:9 [INFO] [stderr] | [INFO] [stderr] 1382 | return PutNotificationChannelError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PutNotificationChannelError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1481:9 [INFO] [stderr] | [INFO] [stderr] 1481 | return PutPolicyError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PutPolicyError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/generated.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(warnings)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(warnings)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:415:58 [INFO] [stderr] | [INFO] [stderr] 415 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:513:58 [INFO] [stderr] | [INFO] [stderr] 513 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:613:58 [INFO] [stderr] | [INFO] [stderr] 613 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:705:58 [INFO] [stderr] | [INFO] [stderr] 705 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:803:58 [INFO] [stderr] | [INFO] [stderr] 803 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:893:58 [INFO] [stderr] | [INFO] [stderr] 893 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:983:58 [INFO] [stderr] | [INFO] [stderr] 983 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1081:58 [INFO] [stderr] | [INFO] [stderr] 1081 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1171:58 [INFO] [stderr] | [INFO] [stderr] 1171 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1263:58 [INFO] [stderr] | [INFO] [stderr] 1263 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1359:58 [INFO] [stderr] | [INFO] [stderr] 1359 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1459:58 [INFO] [stderr] | [INFO] [stderr] 1459 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/generated.rs:1636:37 [INFO] [stderr] | [INFO] [stderr] 1636 | Box::new(future::ok(::std::mem::drop(response))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1636 | Box::new(future::ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/generated.rs:1657:37 [INFO] [stderr] | [INFO] [stderr] 1657 | Box::new(future::ok(::std::mem::drop(response))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1657 | Box::new(future::ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/generated.rs:1677:37 [INFO] [stderr] | [INFO] [stderr] 1677 | Box::new(future::ok(::std::mem::drop(response))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1677 | Box::new(future::ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/generated.rs:1699:37 [INFO] [stderr] | [INFO] [stderr] 1699 | Box::new(future::ok(::std::mem::drop(response))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1699 | Box::new(future::ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/generated.rs:1935:37 [INFO] [stderr] | [INFO] [stderr] 1935 | Box::new(future::ok(::std::mem::drop(response))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1935 | Box::new(future::ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusoto_fms`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a7e78cfbd54bfdd70c75ef197c0eb0a037d9117eb3252288cb5f3ae11484a3dd"` [INFO] running `"docker" "rm" "-f" "a7e78cfbd54bfdd70c75ef197c0eb0a037d9117eb3252288cb5f3ae11484a3dd"` [INFO] [stdout] a7e78cfbd54bfdd70c75ef197c0eb0a037d9117eb3252288cb5f3ae11484a3dd