[INFO] crate rusoto_firehose 0.35.0 is already in cache [INFO] extracting crate rusoto_firehose 0.35.0 into work/ex/clippy-test-run/sources/stable/reg/rusoto_firehose/0.35.0 [INFO] extracting crate rusoto_firehose 0.35.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_firehose/0.35.0 [INFO] validating manifest of rusoto_firehose-0.35.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusoto_firehose-0.35.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusoto_firehose-0.35.0 [INFO] finished frobbing rusoto_firehose-0.35.0 [INFO] frobbed toml for rusoto_firehose-0.35.0 written to work/ex/clippy-test-run/sources/stable/reg/rusoto_firehose/0.35.0/Cargo.toml [INFO] started frobbing rusoto_firehose-0.35.0 [INFO] finished frobbing rusoto_firehose-0.35.0 [INFO] frobbed toml for rusoto_firehose-0.35.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_firehose/0.35.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusoto_firehose-0.35.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusoto_firehose/0.35.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18c27f09bbd6a8ff06be3e200d08474edfd5713bf4caf7554e3eef6568e91bbe [INFO] running `"docker" "start" "-a" "18c27f09bbd6a8ff06be3e200d08474edfd5713bf4caf7554e3eef6568e91bbe"` [INFO] [stderr] Checking rusoto_mock v0.29.0 [INFO] [stderr] Checking rusoto_firehose v0.35.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:2371:13 [INFO] [stderr] | [INFO] [stderr] 2371 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:2388:13 [INFO] [stderr] | [INFO] [stderr] 2388 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/rusoto_mock-0.29.0/src/lib.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | body: Box::new(once(Ok(self.body.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rusoto_core::ByteStream`, found struct `std::boxed::Box` [INFO] [stderr] | [INFO] [stderr] = note: expected type `rusoto_core::ByteStream` [INFO] [stderr] found type `std::boxed::Box, _>>` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `rusoto_mock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1420:9 [INFO] [stderr] | [INFO] [stderr] 1420 | return CreateDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CreateDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1509:9 [INFO] [stderr] | [INFO] [stderr] 1509 | return DeleteDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeleteDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1594:9 [INFO] [stderr] | [INFO] [stderr] 1594 | return DescribeDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DescribeDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1671:9 [INFO] [stderr] | [INFO] [stderr] 1671 | return ListDeliveryStreamsError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListDeliveryStreamsError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1768:9 [INFO] [stderr] | [INFO] [stderr] 1768 | return ListTagsForDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListTagsForDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1862:9 [INFO] [stderr] | [INFO] [stderr] 1862 | return PutRecordError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PutRecordError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1954:9 [INFO] [stderr] | [INFO] [stderr] 1954 | return PutRecordBatchError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PutRecordBatchError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:2051:9 [INFO] [stderr] | [INFO] [stderr] 2051 | return TagDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TagDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:2151:9 [INFO] [stderr] | [INFO] [stderr] 2151 | return UntagDeliveryStreamError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UntagDeliveryStreamError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:2253:9 [INFO] [stderr] | [INFO] [stderr] 2253 | return UpdateDestinationError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UpdateDestinationError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/generated.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(warnings)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(warnings)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1401:58 [INFO] [stderr] | [INFO] [stderr] 1401 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1493:58 [INFO] [stderr] | [INFO] [stderr] 1493 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1579:58 [INFO] [stderr] | [INFO] [stderr] 1579 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1661:58 [INFO] [stderr] | [INFO] [stderr] 1661 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generated.rs:1664:13 [INFO] [stderr] | [INFO] [stderr] 1664 | / match *error_type { [INFO] [stderr] 1665 | | "ValidationException" => { [INFO] [stderr] 1666 | | return ListDeliveryStreamsError::Validation(error_message.to_string()) [INFO] [stderr] 1667 | | } [INFO] [stderr] 1668 | | _ => {} [INFO] [stderr] 1669 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1664 | if let "ValidationException" = *error_type { [INFO] [stderr] 1665 | return ListDeliveryStreamsError::Validation(error_message.to_string()) [INFO] [stderr] 1666 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1743:58 [INFO] [stderr] | [INFO] [stderr] 1743 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1843:58 [INFO] [stderr] | [INFO] [stderr] 1843 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1935:58 [INFO] [stderr] | [INFO] [stderr] 1935 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:2029:58 [INFO] [stderr] | [INFO] [stderr] 2029 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:2129:58 [INFO] [stderr] | [INFO] [stderr] 2129 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:2229:58 [INFO] [stderr] | [INFO] [stderr] 2229 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusoto_firehose`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "18c27f09bbd6a8ff06be3e200d08474edfd5713bf4caf7554e3eef6568e91bbe"` [INFO] running `"docker" "rm" "-f" "18c27f09bbd6a8ff06be3e200d08474edfd5713bf4caf7554e3eef6568e91bbe"` [INFO] [stdout] 18c27f09bbd6a8ff06be3e200d08474edfd5713bf4caf7554e3eef6568e91bbe