[INFO] crate rusoto_athena 0.35.0 is already in cache [INFO] extracting crate rusoto_athena 0.35.0 into work/ex/clippy-test-run/sources/stable/reg/rusoto_athena/0.35.0 [INFO] extracting crate rusoto_athena 0.35.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_athena/0.35.0 [INFO] validating manifest of rusoto_athena-0.35.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusoto_athena-0.35.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusoto_athena-0.35.0 [INFO] finished frobbing rusoto_athena-0.35.0 [INFO] frobbed toml for rusoto_athena-0.35.0 written to work/ex/clippy-test-run/sources/stable/reg/rusoto_athena/0.35.0/Cargo.toml [INFO] started frobbing rusoto_athena-0.35.0 [INFO] finished frobbing rusoto_athena-0.35.0 [INFO] frobbed toml for rusoto_athena-0.35.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusoto_athena/0.35.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusoto_athena-0.35.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rusoto_athena/0.35.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 177a1f4c4c8302ee58875f514631f984380d115c7f63aa300488e42ce194b3a4 [INFO] running `"docker" "start" "-a" "177a1f4c4c8302ee58875f514631f984380d115c7f63aa300488e42ce194b3a4"` [INFO] [stderr] Checking rusoto_mock v0.29.0 [INFO] [stderr] Checking rusoto_athena v0.35.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:1551:13 [INFO] [stderr] | [INFO] [stderr] 1551 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generated.rs:1568:13 [INFO] [stderr] | [INFO] [stderr] 1568 | region: region, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `region` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> /opt/crater/cargo-home/registry/src/github.com-1ecc6299db9ec823/rusoto_mock-0.29.0/src/lib.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | body: Box::new(once(Ok(self.body.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rusoto_core::ByteStream`, found struct `std::boxed::Box` [INFO] [stderr] | [INFO] [stderr] = note: expected type `rusoto_core::ByteStream` [INFO] [stderr] found type `std::boxed::Box, _>>` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `rusoto_mock`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:550:9 [INFO] [stderr] | [INFO] [stderr] 550 | return BatchGetNamedQueryError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BatchGetNamedQueryError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:638:9 [INFO] [stderr] | [INFO] [stderr] 638 | return BatchGetQueryExecutionError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BatchGetQueryExecutionError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:726:9 [INFO] [stderr] | [INFO] [stderr] 726 | return CreateNamedQueryError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CreateNamedQueryError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:812:9 [INFO] [stderr] | [INFO] [stderr] 812 | return DeleteNamedQueryError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeleteNamedQueryError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:898:9 [INFO] [stderr] | [INFO] [stderr] 898 | return GetNamedQueryError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetNamedQueryError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:984:9 [INFO] [stderr] | [INFO] [stderr] 984 | return GetQueryExecutionError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetQueryExecutionError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1072:9 [INFO] [stderr] | [INFO] [stderr] 1072 | return GetQueryResultsError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GetQueryResultsError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1158:9 [INFO] [stderr] | [INFO] [stderr] 1158 | return ListNamedQueriesError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListNamedQueriesError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1244:9 [INFO] [stderr] | [INFO] [stderr] 1244 | return ListQueryExecutionsError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ListQueryExecutionsError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1337:9 [INFO] [stderr] | [INFO] [stderr] 1337 | return StartQueryExecutionError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StartQueryExecutionError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generated.rs:1426:9 [INFO] [stderr] | [INFO] [stderr] 1426 | return StopQueryExecutionError::Unknown(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StopQueryExecutionError::Unknown(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/generated.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #[allow(warnings)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(warnings)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:534:58 [INFO] [stderr] | [INFO] [stderr] 534 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:622:58 [INFO] [stderr] | [INFO] [stderr] 622 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:710:58 [INFO] [stderr] | [INFO] [stderr] 710 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:796:58 [INFO] [stderr] | [INFO] [stderr] 796 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:882:58 [INFO] [stderr] | [INFO] [stderr] 882 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:968:58 [INFO] [stderr] | [INFO] [stderr] 968 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1056:58 [INFO] [stderr] | [INFO] [stderr] 1056 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1142:58 [INFO] [stderr] | [INFO] [stderr] 1142 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1228:58 [INFO] [stderr] | [INFO] [stderr] 1228 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1318:58 [INFO] [stderr] | [INFO] [stderr] 1318 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generated.rs:1410:58 [INFO] [stderr] | [INFO] [stderr] 1410 | let pieces: Vec<&str> = raw_error_type.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusoto_athena`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "177a1f4c4c8302ee58875f514631f984380d115c7f63aa300488e42ce194b3a4"` [INFO] running `"docker" "rm" "-f" "177a1f4c4c8302ee58875f514631f984380d115c7f63aa300488e42ce194b3a4"` [INFO] [stdout] 177a1f4c4c8302ee58875f514631f984380d115c7f63aa300488e42ce194b3a4