[INFO] crate rush_pat 0.1.0 is already in cache [INFO] extracting crate rush_pat 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rush_pat/0.1.0 [INFO] extracting crate rush_pat 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rush_pat/0.1.0 [INFO] validating manifest of rush_pat-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rush_pat-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rush_pat-0.1.0 [INFO] finished frobbing rush_pat-0.1.0 [INFO] frobbed toml for rush_pat-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rush_pat/0.1.0/Cargo.toml [INFO] started frobbing rush_pat-0.1.0 [INFO] finished frobbing rush_pat-0.1.0 [INFO] frobbed toml for rush_pat-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rush_pat/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rush_pat-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rush_pat/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12a35acc24bd7a2f6de482159ae997e00cb22b252f772dd976b4e9e6030cd903 [INFO] running `"docker" "start" "-a" "12a35acc24bd7a2f6de482159ae997e00cb22b252f772dd976b4e9e6030cd903"` [INFO] [stderr] Checking rush_pat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subsume.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self == Same || self == Contains [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self == Same || self == Contains` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subsume.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self == Same || self == ContainedBy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self == Same || self == ContainedBy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/range.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subsume.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self == Same || self == Contains [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self == Same || self == Contains` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subsume.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return self == Same || self == ContainedBy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self == Same || self == ContainedBy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/range.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/range.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &All => true, [INFO] [stderr] 36 | | &FromInt(i) => [INFO] [stderr] 37 | | if let Ok(v) = str::parse::(o) { [INFO] [stderr] ... | [INFO] [stderr] 62 | | &WithinStr(ref l, ref r) => (o >= l.as_ref()) && (o <= r.as_ref()), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | All => true, [INFO] [stderr] 36 | FromInt(i) => [INFO] [stderr] 37 | if let Ok(v) = str::parse::(o) { [INFO] [stderr] 38 | i <= v [INFO] [stderr] 39 | } else { false }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &FromInt(i) => FromStr(i.to_string()), [INFO] [stderr] 75 | | &TillInt(i) => TillStr(i64_to_maxwidth_string(i)), [INFO] [stderr] 76 | | &WithinInt(l, r) => WithinStr(l.to_string(), i64_to_maxwidth_string(r)), [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => self.clone(), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | FromInt(i) => FromStr(i.to_string()), [INFO] [stderr] 75 | TillInt(i) => TillStr(i64_to_maxwidth_string(i)), [INFO] [stderr] 76 | WithinInt(l, r) => WithinStr(l.to_string(), i64_to_maxwidth_string(r)), [INFO] [stderr] 77 | FromAscii(c) => FromStr((c as char).to_string()), [INFO] [stderr] 78 | TillAscii(c) => TillStr((c as char).to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self { [INFO] [stderr] 94 | | &All => write!(f, "..."), [INFO] [stderr] 95 | | &FromInt(i) => write!(f, "{}...", i), [INFO] [stderr] 96 | | &TillInt(i) => write!(f, "...{}", i), [INFO] [stderr] ... | [INFO] [stderr] 103 | | &WithinStr(ref l, ref r) => write!(f, "{}...{}", l, r), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | match *self { [INFO] [stderr] 94 | All => write!(f, "..."), [INFO] [stderr] 95 | FromInt(i) => write!(f, "{}...", i), [INFO] [stderr] 96 | TillInt(i) => write!(f, "...{}", i), [INFO] [stderr] 97 | WithinInt(l, r) => write!(f, "{}...{}", l, r), [INFO] [stderr] 98 | FromAscii(c) => write!(f, "{}...", c), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/range.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut sign = 1; [INFO] [stderr] 165 | | if low < 0 && high < 0 { [INFO] [stderr] 166 | | ::std::mem::swap(&mut low, &mut high); [INFO] [stderr] 167 | | neg = 1; [INFO] [stderr] 168 | | sign = -1; [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sign = if low < 0 && high < 0 { ..; -1 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/range.rs:279:14 [INFO] [stderr] | [INFO] [stderr] 279 | Some('0' as u8 + (i as u8)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/subsume.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | let mut ret = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/range.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/subsume.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if inter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `inter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &All => true, [INFO] [stderr] 36 | | &FromInt(i) => [INFO] [stderr] 37 | | if let Ok(v) = str::parse::(o) { [INFO] [stderr] ... | [INFO] [stderr] 62 | | &WithinStr(ref l, ref r) => (o >= l.as_ref()) && (o <= r.as_ref()), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | All => true, [INFO] [stderr] 36 | FromInt(i) => [INFO] [stderr] 37 | if let Ok(v) = str::parse::(o) { [INFO] [stderr] 38 | i <= v [INFO] [stderr] 39 | } else { false }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &FromInt(i) => FromStr(i.to_string()), [INFO] [stderr] 75 | | &TillInt(i) => TillStr(i64_to_maxwidth_string(i)), [INFO] [stderr] 76 | | &WithinInt(l, r) => WithinStr(l.to_string(), i64_to_maxwidth_string(r)), [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => self.clone(), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | FromInt(i) => FromStr(i.to_string()), [INFO] [stderr] 75 | TillInt(i) => TillStr(i64_to_maxwidth_string(i)), [INFO] [stderr] 76 | WithinInt(l, r) => WithinStr(l.to_string(), i64_to_maxwidth_string(r)), [INFO] [stderr] 77 | FromAscii(c) => FromStr((c as char).to_string()), [INFO] [stderr] 78 | TillAscii(c) => TillStr((c as char).to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/range.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self { [INFO] [stderr] 94 | | &All => write!(f, "..."), [INFO] [stderr] 95 | | &FromInt(i) => write!(f, "{}...", i), [INFO] [stderr] 96 | | &TillInt(i) => write!(f, "...{}", i), [INFO] [stderr] ... | [INFO] [stderr] 103 | | &WithinStr(ref l, ref r) => write!(f, "{}...{}", l, r), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | match *self { [INFO] [stderr] 94 | All => write!(f, "..."), [INFO] [stderr] 95 | FromInt(i) => write!(f, "{}...", i), [INFO] [stderr] 96 | TillInt(i) => write!(f, "...{}", i), [INFO] [stderr] 97 | WithinInt(l, r) => write!(f, "{}...{}", l, r), [INFO] [stderr] 98 | FromAscii(c) => write!(f, "{}...", c), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/range.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut sign = 1; [INFO] [stderr] 165 | | if low < 0 && high < 0 { [INFO] [stderr] 166 | | ::std::mem::swap(&mut low, &mut high); [INFO] [stderr] 167 | | neg = 1; [INFO] [stderr] 168 | | sign = -1; [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sign = if low < 0 && high < 0 { ..; -1 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/range.rs:279:14 [INFO] [stderr] | [INFO] [stderr] 279 | Some('0' as u8 + (i as u8)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/subsume.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | let mut ret = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/subsume.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if inter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `inter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.04s [INFO] running `"docker" "inspect" "12a35acc24bd7a2f6de482159ae997e00cb22b252f772dd976b4e9e6030cd903"` [INFO] running `"docker" "rm" "-f" "12a35acc24bd7a2f6de482159ae997e00cb22b252f772dd976b4e9e6030cd903"` [INFO] [stdout] 12a35acc24bd7a2f6de482159ae997e00cb22b252f772dd976b4e9e6030cd903