[INFO] crate rurl 0.1.1 is already in cache [INFO] extracting crate rurl 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rurl/0.1.1 [INFO] extracting crate rurl 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rurl/0.1.1 [INFO] validating manifest of rurl-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rurl-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rurl-0.1.1 [INFO] finished frobbing rurl-0.1.1 [INFO] frobbed toml for rurl-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rurl/0.1.1/Cargo.toml [INFO] started frobbing rurl-0.1.1 [INFO] finished frobbing rurl-0.1.1 [INFO] frobbed toml for rurl-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rurl/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rurl-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rurl/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 808ddc867d244aec837ca7a40493be88275097ecb4cffd81f59dd4f0dab951e2 [INFO] running `"docker" "start" "-a" "808ddc867d244aec837ca7a40493be88275097ecb4cffd81f59dd4f0dab951e2"` [INFO] [stderr] Checking rurl v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/decode.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 32 | | if percent_counter == 2 { [INFO] [stderr] 33 | | percent_counter -= 1; [INFO] [stderr] 34 | | percent_string.push(c); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | else if percent_counter == 2 { [INFO] [stderr] 32 | percent_counter -= 1; [INFO] [stderr] 33 | percent_string.push(c); [INFO] [stderr] 34 | } [INFO] [stderr] 35 | else { [INFO] [stderr] 36 | percent_counter -= 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:94:8 [INFO] [stderr] | [INFO] [stderr] 94 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 95 | | if c == '/' { [INFO] [stderr] 96 | | break; [INFO] [stderr] 97 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | else if c == '/' { [INFO] [stderr] 95 | break; [INFO] [stderr] 96 | } [INFO] [stderr] 97 | //Compliant with RFC 1738 - 3.1 [INFO] [stderr] 98 | else { [INFO] [stderr] 99 | scheme_string = "".to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:127:8 [INFO] [stderr] | [INFO] [stderr] 127 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 128 | | if RE.is_match(&c.to_string()) == false { [INFO] [stderr] 129 | | net_string.push(c); [INFO] [stderr] 130 | | } [INFO] [stderr] ... | [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | else if RE.is_match(&c.to_string()) == false { [INFO] [stderr] 128 | net_string.push(c); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | else { [INFO] [stderr] 131 | break; [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:155:8 [INFO] [stderr] | [INFO] [stderr] 155 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 156 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 157 | | break; [INFO] [stderr] 158 | | } [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 156 | break; [INFO] [stderr] 157 | } [INFO] [stderr] 158 | else{ [INFO] [stderr] 159 | path_string.push(c); [INFO] [stderr] 160 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:182:8 [INFO] [stderr] | [INFO] [stderr] 182 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 183 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 184 | | break; [INFO] [stderr] 185 | | } [INFO] [stderr] ... | [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 183 | break; [INFO] [stderr] 184 | } [INFO] [stderr] 185 | else{ [INFO] [stderr] 186 | param_string.push(c); [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:209:8 [INFO] [stderr] | [INFO] [stderr] 209 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 210 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 211 | | break; [INFO] [stderr] 212 | | } [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 209 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 210 | break; [INFO] [stderr] 211 | } [INFO] [stderr] 212 | else{ [INFO] [stderr] 213 | query_string.push(c); [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:236:8 [INFO] [stderr] | [INFO] [stderr] 236 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 237 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 238 | | break; [INFO] [stderr] 239 | | } [INFO] [stderr] ... | [INFO] [stderr] 242 | | } [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 237 | break; [INFO] [stderr] 238 | } [INFO] [stderr] 239 | else{ [INFO] [stderr] 240 | frag_string.push(c); [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/decode.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 32 | | if percent_counter == 2 { [INFO] [stderr] 33 | | percent_counter -= 1; [INFO] [stderr] 34 | | percent_string.push(c); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | else if percent_counter == 2 { [INFO] [stderr] 32 | percent_counter -= 1; [INFO] [stderr] 33 | percent_string.push(c); [INFO] [stderr] 34 | } [INFO] [stderr] 35 | else { [INFO] [stderr] 36 | percent_counter -= 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:94:8 [INFO] [stderr] | [INFO] [stderr] 94 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 95 | | if c == '/' { [INFO] [stderr] 96 | | break; [INFO] [stderr] 97 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | else if c == '/' { [INFO] [stderr] 95 | break; [INFO] [stderr] 96 | } [INFO] [stderr] 97 | //Compliant with RFC 1738 - 3.1 [INFO] [stderr] 98 | else { [INFO] [stderr] 99 | scheme_string = "".to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:127:8 [INFO] [stderr] | [INFO] [stderr] 127 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 128 | | if RE.is_match(&c.to_string()) == false { [INFO] [stderr] 129 | | net_string.push(c); [INFO] [stderr] 130 | | } [INFO] [stderr] ... | [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | else if RE.is_match(&c.to_string()) == false { [INFO] [stderr] 128 | net_string.push(c); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | else { [INFO] [stderr] 131 | break; [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:155:8 [INFO] [stderr] | [INFO] [stderr] 155 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 156 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 157 | | break; [INFO] [stderr] 158 | | } [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 156 | break; [INFO] [stderr] 157 | } [INFO] [stderr] 158 | else{ [INFO] [stderr] 159 | path_string.push(c); [INFO] [stderr] 160 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:182:8 [INFO] [stderr] | [INFO] [stderr] 182 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 183 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 184 | | break; [INFO] [stderr] 185 | | } [INFO] [stderr] ... | [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 183 | break; [INFO] [stderr] 184 | } [INFO] [stderr] 185 | else{ [INFO] [stderr] 186 | param_string.push(c); [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:209:8 [INFO] [stderr] | [INFO] [stderr] 209 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 210 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 211 | | break; [INFO] [stderr] 212 | | } [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 209 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 210 | break; [INFO] [stderr] 211 | } [INFO] [stderr] 212 | else{ [INFO] [stderr] 213 | query_string.push(c); [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parsing/parse.rs:236:8 [INFO] [stderr] | [INFO] [stderr] 236 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 237 | | if RE.is_match(&c.to_string()) { [INFO] [stderr] 238 | | break; [INFO] [stderr] 239 | | } [INFO] [stderr] ... | [INFO] [stderr] 242 | | } [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | else if RE.is_match(&c.to_string()) { [INFO] [stderr] 237 | break; [INFO] [stderr] 238 | } [INFO] [stderr] 239 | else{ [INFO] [stderr] 240 | frag_string.push(c); [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsing/parse.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | let mut scheme_extra : usize = 0; [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | if purl.scheme.len() != 0{ [INFO] [stderr] 23 | | scheme_extra = 3; [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let scheme_extra = if purl.scheme.len() != 0 { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | if purl.scheme.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.scheme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | if purl.scheme.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.scheme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | if purl.params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | if purl.query.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.query.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | if purl.frag.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.frag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_scheme(url: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:86:6 [INFO] [stderr] | [INFO] [stderr] 86 | if col_flag == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!col_flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | if col_flag == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!col_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | fn get_net_loc(url: &String, mut scheme_len: usize) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | if RE.is_match(&c.to_string()) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!RE.is_match(&c.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | fn get_path(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:149:6 [INFO] [stderr] | [INFO] [stderr] 149 | if path_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | fn get_params(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:177:6 [INFO] [stderr] | [INFO] [stderr] 177 | if param_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!param_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_query(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if query_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!query_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:222:19 [INFO] [stderr] | [INFO] [stderr] 222 | fn get_frag(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:231:6 [INFO] [stderr] | [INFO] [stderr] 231 | if frag_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!frag_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:249:20 [INFO] [stderr] | [INFO] [stderr] 249 | fn cut_start(url : &String, mut del_len : usize) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parsing/parse.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | let mut scheme_extra : usize = 0; [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | if purl.scheme.len() != 0{ [INFO] [stderr] 23 | | scheme_extra = 3; [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let scheme_extra = if purl.scheme.len() != 0 { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | if purl.scheme.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.scheme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | if purl.scheme.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.scheme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | if purl.params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | if purl.query.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.query.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parsing/parse.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | if purl.frag.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!purl.frag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | fn get_scheme(url: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:86:6 [INFO] [stderr] | [INFO] [stderr] 86 | if col_flag == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!col_flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | if col_flag == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!col_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | fn get_net_loc(url: &String, mut scheme_len: usize) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | if RE.is_match(&c.to_string()) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!RE.is_match(&c.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | fn get_path(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:149:6 [INFO] [stderr] | [INFO] [stderr] 149 | if path_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | fn get_params(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:177:6 [INFO] [stderr] | [INFO] [stderr] 177 | if param_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!param_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:195:20 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_query(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if query_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!query_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:222:19 [INFO] [stderr] | [INFO] [stderr] 222 | fn get_frag(url : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/parsing/parse.rs:231:6 [INFO] [stderr] | [INFO] [stderr] 231 | if frag_flag == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!frag_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parsing/parse.rs:249:20 [INFO] [stderr] | [INFO] [stderr] 249 | fn cut_start(url : &String, mut del_len : usize) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "808ddc867d244aec837ca7a40493be88275097ecb4cffd81f59dd4f0dab951e2"` [INFO] running `"docker" "rm" "-f" "808ddc867d244aec837ca7a40493be88275097ecb4cffd81f59dd4f0dab951e2"` [INFO] [stdout] 808ddc867d244aec837ca7a40493be88275097ecb4cffd81f59dd4f0dab951e2