[INFO] crate ruplicity 0.2.2 is already in cache [INFO] extracting crate ruplicity 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/ruplicity/0.2.2 [INFO] extracting crate ruplicity 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruplicity/0.2.2 [INFO] validating manifest of ruplicity-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ruplicity-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ruplicity-0.2.2 [INFO] finished frobbing ruplicity-0.2.2 [INFO] frobbed toml for ruplicity-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/ruplicity/0.2.2/Cargo.toml [INFO] started frobbing ruplicity-0.2.2 [INFO] finished frobbing ruplicity-0.2.2 [INFO] frobbed toml for ruplicity-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruplicity/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ruplicity-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ruplicity/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eec4debdb2024b8dd417f6a8114c931a7f8a89997cbb0b086cd8d99cc42c1bed [INFO] running `"docker" "start" "-a" "eec4debdb2024b8dd417f6a8114c931a7f8a89997cbb0b086cd8d99cc42c1bed"` [INFO] [stderr] Checking try_opt v0.1.1 [INFO] [stderr] Checking tabwriter v0.1.25 [INFO] [stderr] Checking tar v0.3.4 [INFO] [stderr] Checking ruplicity v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:197:60 [INFO] [stderr] | [INFO] [stderr] 197 | fnm::Type::FullSig{ time, .. } => Type::Full { time: time }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | tp: tp, [INFO] [stderr] | ^^^^^^ help: replace it with: `tp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | partial: partial, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `partial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | fullset: fullset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fullset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | size_hint: size_hint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:227:29 [INFO] [stderr] | [INFO] [stderr] 227 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:680:17 [INFO] [stderr] | [INFO] [stderr] 680 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:682:17 [INFO] [stderr] | [INFO] [stderr] 682 | uname: uname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `uname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:683:17 [INFO] [stderr] | [INFO] [stderr] 683 | gname: gname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:685:17 [INFO] [stderr] | [INFO] [stderr] 685 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | backend: backend, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | collections: collections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | signatures: signatures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signatures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | set_iter: set_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/file_naming.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:197:60 [INFO] [stderr] | [INFO] [stderr] 197 | fnm::Type::FullSig{ time, .. } => Type::Full { time: time }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | tp: tp, [INFO] [stderr] | ^^^^^^ help: replace it with: `tp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | partial: partial, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `partial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | fullset: fullset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fullset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collections/mod.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | size_hint: size_hint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:227:29 [INFO] [stderr] | [INFO] [stderr] 227 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:680:17 [INFO] [stderr] | [INFO] [stderr] 680 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:682:17 [INFO] [stderr] | [INFO] [stderr] 682 | uname: uname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `uname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:683:17 [INFO] [stderr] | [INFO] [stderr] 683 | gname: gname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `gname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/signatures.rs:685:17 [INFO] [stderr] | [INFO] [stderr] 685 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | backend: backend, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | collections: collections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | signatures: signatures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signatures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | set_iter: set_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `set_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / macro_rules! gen_setters( [INFO] [stderr] 31 | | ($target:ty, $($field:ident : $t:ty),+) => ($( [INFO] [stderr] 32 | | impl $target { [INFO] [stderr] 33 | | /// Sets the field to the provided value and returns [INFO] [stderr] ... | [INFO] [stderr] 40 | | )+) [INFO] [stderr] 41 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/signatures.rs:604:17 [INFO] [stderr] | [INFO] [stderr] 604 | if magic != 0x72730136 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0136` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/collections/file_naming.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/collections/file_naming.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/tarext.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut filename = Vec::with_capacity(cap); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; cap]` [INFO] [stderr] 57 | filename.resize(cap, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/tarext.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match entry.read(&mut filename) { [INFO] [stderr] 59 | | Ok(e) => e, [INFO] [stderr] 60 | | Err(e) => { [INFO] [stderr] 61 | | return Some(Err(e)); [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tarext.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | fn noslash(b: &u8) -> u8 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: type could implement `Copy`; consider adding `impl Copy` [INFO] [stderr] --> src/collections/file_naming.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub enum Type { [INFO] [stderr] 21 | | Full { [INFO] [stderr] 22 | | time: Timespec, [INFO] [stderr] 23 | | volume_number: i32, [INFO] [stderr] ... | [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | #![deny(missing_copy_implementations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/collections/file_naming.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | .or(self.check_sig(&lower_fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.check_sig(&lower_fname))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/collections/file_naming.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | .or(self.check_inc(&lower_fname)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.check_inc(&lower_fname))` [INFO] [stderr] | [INFO] [stderr] warning: unused macro definition [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] --> src/macros.rs:30:1 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 30 | / macro_rules! gen_setters( [INFO] [stderr] 31 | | ($target:ty, $($field:ident : $t:ty),+) => ($( [INFO] [stderr] 32 | | impl $target { [INFO] [stderr] 33 | | /// Sets the field to the provided value and returns [INFO] [stderr] ... | [INFO] [stderr] 40 | | )+) [INFO] [stderr] 41 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/signatures.rs:604:17 [INFO] [stderr] | [INFO] [stderr] 604 | if magic != 0x72730136 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0136` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/signatures.rs:774:50 [INFO] [stderr] | [INFO] [stderr] 774 | vec![vec![0, 0, 0, 0, 0, 30, 30, 0, 456, 3500000, 75650, 456, 0, 0, 11, 11, 0], [INFO] [stderr] | ^^^^^^^ help: consider: `3_500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/signatures.rs:775:47 [INFO] [stderr] | [INFO] [stderr] 775 | vec![0, 0, 456, 30, 0, 13, 0, 0, 3500001, 6, 75656, 456, 0, 0, 11, 11, 0], [INFO] [stderr] | ^^^^^^^ help: consider: `3_500_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/signatures.rs:776:36 [INFO] [stderr] | [INFO] [stderr] 776 | vec![0, 0, 30, 30, 0, 3500000, 75650, 456, 0, 0, 11, 11, 0]] [INFO] [stderr] | ^^^^^^^ help: consider: `3_500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | time.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:308:33 [INFO] [stderr] | [INFO] [stderr] 308 | self.end_time = end_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:317:37 [INFO] [stderr] | [INFO] [stderr] 317 | self.end_time = end_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/collections/mod.rs:360:58 [INFO] [stderr] | [INFO] [stderr] 360 | .map(|i| i.volumes_paths.len()) [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 361 | | .fold(0, |a, i| a + i); [INFO] [stderr] | |________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `collections::Collections` [INFO] [stderr] --> src/collections/mod.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn new() -> Self { [INFO] [stderr] 474 | | Collections { [INFO] [stderr] 475 | | backup_chains: Vec::new(), [INFO] [stderr] 476 | | sig_chains: Vec::new(), [INFO] [stderr] 477 | | } [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/collections/mod.rs:560:24 [INFO] [stderr] | [INFO] [stderr] 560 | if let Some(_) = rejected_set { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 561 | | // TODO: add to orphaned sets [INFO] [stderr] 562 | | } [INFO] [stderr] | |_________________- help: try this: `if rejected_set.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signatures::Chain` [INFO] [stderr] --> src/signatures.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Self { [INFO] [stderr] 137 | | Chain { [INFO] [stderr] 138 | | num_snapshots: 0, [INFO] [stderr] 139 | | files: Vec::new(), [INFO] [stderr] 140 | | ug_map: UserGroupMap::new(), [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | impl Default for signatures::Chain { [INFO] [stderr] 135 | fn default() -> Self { [INFO] [stderr] 136 | Self::new() [INFO] [stderr] 137 | } [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/signatures.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | if !old_snapshots.next().is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old_snapshots.next().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/collections/file_naming.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ruplicity`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/collections/file_naming.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/tarext.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 56 | let mut filename = Vec::with_capacity(cap); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; cap]` [INFO] [stderr] 57 | filename.resize(cap, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/tarext.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match entry.read(&mut filename) { [INFO] [stderr] 59 | | Ok(e) => e, [INFO] [stderr] 60 | | Err(e) => { [INFO] [stderr] 61 | | return Some(Err(e)); [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tarext.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | fn noslash(b: &u8) -> u8 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: type could implement `Copy`; consider adding `impl Copy` [INFO] [stderr] --> src/collections/file_naming.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub enum Type { [INFO] [stderr] 21 | | Full { [INFO] [stderr] 22 | | time: Timespec, [INFO] [stderr] 23 | | volume_number: i32, [INFO] [stderr] ... | [INFO] [stderr] 47 | | }, [INFO] [stderr] 48 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | #![deny(missing_copy_implementations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/collections/file_naming.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | .or(self.check_sig(&lower_fname)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.check_sig(&lower_fname))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/collections/file_naming.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | .or(self.check_inc(&lower_fname)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.check_inc(&lower_fname))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | time.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:308:33 [INFO] [stderr] | [INFO] [stderr] 308 | self.end_time = end_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collections/mod.rs:317:37 [INFO] [stderr] | [INFO] [stderr] 317 | self.end_time = end_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/collections/mod.rs:360:58 [INFO] [stderr] | [INFO] [stderr] 360 | .map(|i| i.volumes_paths.len()) [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 361 | | .fold(0, |a, i| a + i); [INFO] [stderr] | |________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `collections::Collections` [INFO] [stderr] --> src/collections/mod.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn new() -> Self { [INFO] [stderr] 474 | | Collections { [INFO] [stderr] 475 | | backup_chains: Vec::new(), [INFO] [stderr] 476 | | sig_chains: Vec::new(), [INFO] [stderr] 477 | | } [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/collections/mod.rs:560:24 [INFO] [stderr] | [INFO] [stderr] 560 | if let Some(_) = rejected_set { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 561 | | // TODO: add to orphaned sets [INFO] [stderr] 562 | | } [INFO] [stderr] | |_________________- help: try this: `if rejected_set.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signatures::Chain` [INFO] [stderr] --> src/signatures.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Self { [INFO] [stderr] 137 | | Chain { [INFO] [stderr] 138 | | num_snapshots: 0, [INFO] [stderr] 139 | | files: Vec::new(), [INFO] [stderr] 140 | | ug_map: UserGroupMap::new(), [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | impl Default for signatures::Chain { [INFO] [stderr] 135 | fn default() -> Self { [INFO] [stderr] 136 | Self::new() [INFO] [stderr] 137 | } [INFO] [stderr] 138 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/signatures.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | if !old_snapshots.next().is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old_snapshots.next().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ruplicity`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eec4debdb2024b8dd417f6a8114c931a7f8a89997cbb0b086cd8d99cc42c1bed"` [INFO] running `"docker" "rm" "-f" "eec4debdb2024b8dd417f6a8114c931a7f8a89997cbb0b086cd8d99cc42c1bed"` [INFO] [stdout] eec4debdb2024b8dd417f6a8114c931a7f8a89997cbb0b086cd8d99cc42c1bed