[INFO] crate runwhen 0.0.3 is already in cache [INFO] extracting crate runwhen 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/runwhen/0.0.3 [INFO] extracting crate runwhen 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runwhen/0.0.3 [INFO] validating manifest of runwhen-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of runwhen-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing runwhen-0.0.3 [INFO] finished frobbing runwhen-0.0.3 [INFO] frobbed toml for runwhen-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/runwhen/0.0.3/Cargo.toml [INFO] started frobbing runwhen-0.0.3 [INFO] finished frobbing runwhen-0.0.3 [INFO] frobbed toml for runwhen-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runwhen/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting runwhen-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/runwhen/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22531fbc158895770f4e23e74694c2fe6c1d6bbcbe388c3b207c1ab213d90bcf [INFO] running `"docker" "start" "-a" "22531fbc158895770f4e23e74694c2fe6c1d6bbcbe388c3b207c1ab213d90bcf"` [INFO] [stderr] Checking humantime v1.0.0 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking notify v3.0.1 [INFO] [stderr] Checking runwhen v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | poll_duration: poll_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | max_repeat: max_repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | test_cmd: test_cmd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `test_cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | negate: negate, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `negate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | poll_duration: poll_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | max_repeat: max_repeat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_repeat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | test_cmd: test_cmd, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `test_cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | negate: negate, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `negate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | cmd: cmd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: missing fragment specifier [INFO] [stderr] --> <::clap::macros::clap_app macros>:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | @ arg ( $ arg : expr ) $ modes : tt ! $ ident $ ( $ tail : tt ) * ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(missing_fragment_specifier)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #40107 [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/exec.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / return match exec.output() { [INFO] [stderr] 52 | | Ok(out) => match out.status.code() { [INFO] [stderr] 53 | | Some(val) => Ok(val), [INFO] [stderr] 54 | | None => Ok(0), [INFO] [stderr] ... | [INFO] [stderr] 57 | | Err(_) => Err(CommandError::new("Error running command")), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match exec.output() { [INFO] [stderr] 52 | Ok(out) => match out.status.code() { [INFO] [stderr] 53 | Some(val) => Ok(val), [INFO] [stderr] 54 | None => Ok(0), [INFO] [stderr] 55 | }, [INFO] [stderr] 56 | // TODO(jeremy): We should not swallow this error. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: missing fragment specifier [INFO] [stderr] --> <::clap::macros::clap_app macros>:84:47 [INFO] [stderr] | [INFO] [stderr] 84 | @ arg ( $ arg : expr ) $ modes : tt ! $ ident $ ( $ tail : tt ) * ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(missing_fragment_specifier)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #40107 [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `runwhen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/exec.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / return match exec.output() { [INFO] [stderr] 52 | | Ok(out) => match out.status.code() { [INFO] [stderr] 53 | | Some(val) => Ok(val), [INFO] [stderr] 54 | | None => Ok(0), [INFO] [stderr] ... | [INFO] [stderr] 57 | | Err(_) => Err(CommandError::new("Error running command")), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match exec.output() { [INFO] [stderr] 52 | Ok(out) => match out.status.code() { [INFO] [stderr] 53 | Some(val) => Ok(val), [INFO] [stderr] 54 | None => Ok(0), [INFO] [stderr] 55 | }, [INFO] [stderr] 56 | // TODO(jeremy): We should not swallow this error. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `runwhen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "22531fbc158895770f4e23e74694c2fe6c1d6bbcbe388c3b207c1ab213d90bcf"` [INFO] running `"docker" "rm" "-f" "22531fbc158895770f4e23e74694c2fe6c1d6bbcbe388c3b207c1ab213d90bcf"` [INFO] [stdout] 22531fbc158895770f4e23e74694c2fe6c1d6bbcbe388c3b207c1ab213d90bcf