[INFO] crate runtime-loop 0.0.3 is already in cache [INFO] extracting crate runtime-loop 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/runtime-loop/0.0.3 [INFO] extracting crate runtime-loop 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runtime-loop/0.0.3 [INFO] validating manifest of runtime-loop-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of runtime-loop-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing runtime-loop-0.0.3 [INFO] finished frobbing runtime-loop-0.0.3 [INFO] frobbed toml for runtime-loop-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/runtime-loop/0.0.3/Cargo.toml [INFO] started frobbing runtime-loop-0.0.3 [INFO] finished frobbing runtime-loop-0.0.3 [INFO] frobbed toml for runtime-loop-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runtime-loop/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting runtime-loop-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/runtime-loop/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4885ed626585743731ba8d72930cb96086e725b3647b07a8ffc5bc9546badb6 [INFO] running `"docker" "start" "-a" "e4885ed626585743731ba8d72930cb96086e725b3647b07a8ffc5bc9546badb6"` [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking runtime-loop v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RuntimeLoop` [INFO] [stderr] --> src/lib.rs:133:2 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 134 | | RuntimeLoop{ pool: ThreadPool::new(num_cpus::get()), [INFO] [stderr] 135 | | //shared_observers: HashMap::new(), //TODO for version 0.2.0 [INFO] [stderr] 136 | | observers: HashMap::new(), [INFO] [stderr] 137 | | cancel_flag: Arc::new(AtomicBool::new(false))} [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:156:15 [INFO] [stderr] | [INFO] [stderr] 156 | while self.cancel_flag.load(Ordering::Relaxed) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cancel_flag.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RuntimeLoop` [INFO] [stderr] --> src/lib.rs:133:2 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 134 | | RuntimeLoop{ pool: ThreadPool::new(num_cpus::get()), [INFO] [stderr] 135 | | //shared_observers: HashMap::new(), //TODO for version 0.2.0 [INFO] [stderr] 136 | | observers: HashMap::new(), [INFO] [stderr] 137 | | cancel_flag: Arc::new(AtomicBool::new(false))} [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:156:15 [INFO] [stderr] | [INFO] [stderr] 156 | while self.cancel_flag.load(Ordering::Relaxed) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.cancel_flag.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.16s [INFO] running `"docker" "inspect" "e4885ed626585743731ba8d72930cb96086e725b3647b07a8ffc5bc9546badb6"` [INFO] running `"docker" "rm" "-f" "e4885ed626585743731ba8d72930cb96086e725b3647b07a8ffc5bc9546badb6"` [INFO] [stdout] e4885ed626585743731ba8d72930cb96086e725b3647b07a8ffc5bc9546badb6