[INFO] crate runny 1.2.5 is already in cache [INFO] extracting crate runny 1.2.5 into work/ex/clippy-test-run/sources/stable/reg/runny/1.2.5 [INFO] extracting crate runny 1.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runny/1.2.5 [INFO] validating manifest of runny-1.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of runny-1.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing runny-1.2.5 [INFO] finished frobbing runny-1.2.5 [INFO] frobbed toml for runny-1.2.5 written to work/ex/clippy-test-run/sources/stable/reg/runny/1.2.5/Cargo.toml [INFO] started frobbing runny-1.2.5 [INFO] finished frobbing runny-1.2.5 [INFO] frobbed toml for runny-1.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runny/1.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting runny-1.2.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/runny/1.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fda54b46634aaafdfdd64a0ae8c6da2dc1e9ec6c03ef6da3fae5140083784fc [INFO] running `"docker" "start" "-a" "6fda54b46634aaafdfdd64a0ae8c6da2dc1e9ec6c03ef6da3fae5140083784fc"` [INFO] [stderr] Compiling user32-sys v0.2.0 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking runny v1.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | child_pid: child_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | term_delay: term_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `term_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | term_thr: term_thr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `term_thr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | wait_thr: wait_thr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `wait_thr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | child_pid: child_pid, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | term_delay: term_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `term_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | term_thr: term_thr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `term_thr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/running.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | wait_thr: wait_thr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `wait_thr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/running.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match self { [INFO] [stderr] 86 | | &RunningError::RunningIoError(ref e) => write!(f, "Running I/O error: {:?}", e), [INFO] [stderr] 87 | | #[cfg(unix)] [INFO] [stderr] 88 | | &RunningError::RunningNixError(ref e) => write!(f, "Running Nix error: {:?}", e), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *self { [INFO] [stderr] 86 | RunningError::RunningIoError(ref e) => write!(f, "Running I/O error: {:?}", e), [INFO] [stderr] 87 | #[cfg(unix)] [INFO] [stderr] 88 | RunningError::RunningNixError(ref e) => write!(f, "Running Nix error: {:?}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &RunnyError::RunnyIoError(ref e) => write!(f, "I/O error: {:?}", e), [INFO] [stderr] 53 | | &RunnyError::NoCommandSpecified => write!(f, "No command was specified"), [INFO] [stderr] 54 | | #[cfg(unix)] [INFO] [stderr] 55 | | &RunnyError::NixError(ref e) => write!(f, "Nix library error: {:?}", e), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | RunnyError::RunnyIoError(ref e) => write!(f, "I/O error: {:?}", e), [INFO] [stderr] 53 | RunnyError::NoCommandSpecified => write!(f, "No command was specified"), [INFO] [stderr] 54 | #[cfg(unix)] [INFO] [stderr] 55 | RunnyError::NixError(ref e) => write!(f, "Nix library error: {:?}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/running.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match self { [INFO] [stderr] 86 | | &RunningError::RunningIoError(ref e) => write!(f, "Running I/O error: {:?}", e), [INFO] [stderr] 87 | | #[cfg(unix)] [INFO] [stderr] 88 | | &RunningError::RunningNixError(ref e) => write!(f, "Running Nix error: {:?}", e), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *self { [INFO] [stderr] 86 | RunningError::RunningIoError(ref e) => write!(f, "Running I/O error: {:?}", e), [INFO] [stderr] 87 | #[cfg(unix)] [INFO] [stderr] 88 | RunningError::RunningNixError(ref e) => write!(f, "Running Nix error: {:?}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &RunnyError::RunnyIoError(ref e) => write!(f, "I/O error: {:?}", e), [INFO] [stderr] 53 | | &RunnyError::NoCommandSpecified => write!(f, "No command was specified"), [INFO] [stderr] 54 | | #[cfg(unix)] [INFO] [stderr] 55 | | &RunnyError::NixError(ref e) => write!(f, "Nix library error: {:?}", e), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | RunnyError::RunnyIoError(ref e) => write!(f, "I/O error: {:?}", e), [INFO] [stderr] 53 | RunnyError::NoCommandSpecified => write!(f, "No command was specified"), [INFO] [stderr] 54 | #[cfg(unix)] [INFO] [stderr] 55 | RunnyError::NixError(ref e) => write!(f, "Nix library error: {:?}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.66s [INFO] running `"docker" "inspect" "6fda54b46634aaafdfdd64a0ae8c6da2dc1e9ec6c03ef6da3fae5140083784fc"` [INFO] running `"docker" "rm" "-f" "6fda54b46634aaafdfdd64a0ae8c6da2dc1e9ec6c03ef6da3fae5140083784fc"` [INFO] [stdout] 6fda54b46634aaafdfdd64a0ae8c6da2dc1e9ec6c03ef6da3fae5140083784fc