[INFO] crate runner 0.3.7 is already in cache
[INFO] extracting crate runner 0.3.7 into work/ex/clippy-test-run/sources/stable/reg/runner/0.3.7
[INFO] extracting crate runner 0.3.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runner/0.3.7
[INFO] validating manifest of runner-0.3.7 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of runner-0.3.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing runner-0.3.7
[INFO] finished frobbing runner-0.3.7
[INFO] frobbed toml for runner-0.3.7 written to work/ex/clippy-test-run/sources/stable/reg/runner/0.3.7/Cargo.toml
[INFO] started frobbing runner-0.3.7
[INFO] finished frobbing runner-0.3.7
[INFO] frobbed toml for runner-0.3.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/runner/0.3.7/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting runner-0.3.7 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/runner/0.3.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9f802a075d7bb898fae1b2f0bce036c69aaad67ddf98e52eef7f6a6cc369f1fa
[INFO] running `"docker" "start" "-a" "9f802a075d7bb898fae1b2f0bce036c69aaad67ddf98e52eef7f6a6cc369f1fa"`
[INFO] [stderr]     Checking easy-shortcuts v0.3.0
[INFO] [stderr]     Checking lapp v0.4.0
[INFO] [stderr]     Checking runner v0.3.7 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:177:21
[INFO] [stderr]     |
[INFO] [stderr] 177 |                     package: package,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     crate_name: crate_name,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |                     features: features,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `features`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/meta.rs:206:13
[INFO] [stderr]     |
[INFO] [stderr] 206 | /             write!(f,"{},{},{},{},{},{},{}\n",
[INFO] [stderr] 207 | |                 e.package,e.crate_name,e.version,e.features,
[INFO] [stderr] 208 | |                 e.debug_name,e.release_name,
[INFO] [stderr] 209 | |                 e.path.display()
[INFO] [stderr] 210 | |             ).or_die("i/o?");
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:730:17
[INFO] [stderr]     |
[INFO] [stderr] 730 |                 write!(deps,"{}=\"{}\"\n",name,vs)
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:732:16
[INFO] [stderr]     |
[INFO] [stderr] 732 |                write!(deps,"{}={{path=\"{}\"}}\n",name,vs)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:799:9
[INFO] [stderr]     |
[INFO] [stderr] 799 |         write!(f,"{}\n",crate_alias).or_die("cannot write to runner alias file");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:177:21
[INFO] [stderr]     |
[INFO] [stderr] 177 |                     package: package,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `package`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |                     crate_name: crate_name,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/meta.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |                     features: features,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `features`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/meta.rs:206:13
[INFO] [stderr]     |
[INFO] [stderr] 206 | /             write!(f,"{},{},{},{},{},{},{}\n",
[INFO] [stderr] 207 | |                 e.package,e.crate_name,e.version,e.features,
[INFO] [stderr] 208 | |                 e.debug_name,e.release_name,
[INFO] [stderr] 209 | |                 e.path.display()
[INFO] [stderr] 210 | |             ).or_die("i/o?");
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:730:17
[INFO] [stderr]     |
[INFO] [stderr] 730 |                 write!(deps,"{}=\"{}\"\n",name,vs)
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:732:16
[INFO] [stderr]     |
[INFO] [stderr] 732 |                write!(deps,"{}={{path=\"{}\"}}\n",name,vs)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:799:9
[INFO] [stderr]     |
[INFO] [stderr] 799 |         write!(f,"{}\n",crate_alias).or_die("cannot write to runner alias file");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/crate_utils.rs:24:6
[INFO] [stderr]    |
[INFO] [stderr] 24 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 25 | |     if let Ok(full_path) = p.canonicalize() {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::suspicious_else_formatting)] on by default
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:18:6
[INFO] [stderr]    |
[INFO] [stderr] 18 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 19 | |     if let Ok(ed) = env::var("EDITOR") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:21:6
[INFO] [stderr]    |
[INFO] [stderr] 21 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 22 | |     // MacOS open will NOT open random text files, so vim it is...
[INFO] [stderr] 23 | |     if cfg!(target_os = "macos") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:25:6
[INFO] [stderr]    |
[INFO] [stderr] 25 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 26 | |     if cfg!(target_os = "windows") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:232:10
[INFO] [stderr]     |
[INFO] [stderr] 232 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 233 | |         if doc {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:243:10
[INFO] [stderr]     |
[INFO] [stderr] 243 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 244 | |         if cleanup {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:246:10
[INFO] [stderr]     |
[INFO] [stderr] 246 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 247 | |         if crates {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:295:10
[INFO] [stderr]     |
[INFO] [stderr] 295 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 296 | |         if compile { // either a cargo directory or a Rust source file
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:336:6
[INFO] [stderr]     |
[INFO] [stderr] 336 |       } else
[INFO] [stderr]     |  ______^
[INFO] [stderr] 337 | |     if b("iterator") {
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:340:6
[INFO] [stderr]     |
[INFO] [stderr] 340 |       } else
[INFO] [stderr]     |  ______^
[INFO] [stderr] 341 | |     if b("lines") {
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:703:16
[INFO] [stderr]     |
[INFO] [stderr] 703 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 704 | |             if let Some((name,path)) = maybe_cargo_dir(&c) {
[INFO] [stderr] 705 | |                 // hello - this is a local Cargo project!
[INFO] [stderr] 706 | |                 (name, path.to_str().unwrap().to_string(),false)
[INFO] [stderr] ...   |
[INFO] [stderr] 709 | |             }
[INFO] [stderr] 710 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 703 |         } else if let Some((name,path)) = maybe_cargo_dir(&c) {
[INFO] [stderr] 704 |     // hello - this is a local Cargo project!
[INFO] [stderr] 705 |     (name, path.to_str().unwrap().to_string(),false)
[INFO] [stderr] 706 | } else { // latest version of crate
[INFO] [stderr] 707 |     (c.to_string(), '*'.to_string(),true)
[INFO] [stderr] 708 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:715:5
[INFO] [stderr]     |
[INFO] [stderr] 715 | /     if ! exists {
[INFO] [stderr] 716 | |         if ! cargo(&["new","--bin",STATIC_CACHE]) {
[INFO] [stderr] 717 | |             es::quit("cannot create static cache");
[INFO] [stderr] 718 | |         }
[INFO] [stderr] 719 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 715 |     if ! exists && ! cargo(&["new","--bin",STATIC_CACHE]) {
[INFO] [stderr] 716 |     es::quit("cannot create static cache");
[INFO] [stderr] 717 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:859:14
[INFO] [stderr]     |
[INFO] [stderr] 859 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 860 | |             if line.starts_with("extern ") || line.starts_with("use ") {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:866:14
[INFO] [stderr]     |
[INFO] [stderr] 866 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 867 | |             if line.starts_with("#![") {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:871:14
[INFO] [stderr]     |
[INFO] [stderr] 871 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 872 | |             if line.len() > 0 {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/crate_utils.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         env::home_dir().or_die("no home!").join(".cargo")
[INFO] [stderr]    |         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/crate_utils.rs:24:6
[INFO] [stderr]    |
[INFO] [stderr] 24 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 25 | |     if let Ok(full_path) = p.canonicalize() {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::suspicious_else_formatting)] on by default
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:18:6
[INFO] [stderr]    |
[INFO] [stderr] 18 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 19 | |     if let Ok(ed) = env::var("EDITOR") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:21:6
[INFO] [stderr]    |
[INFO] [stderr] 21 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 22 | |     // MacOS open will NOT open random text files, so vim it is...
[INFO] [stderr] 23 | |     if cfg!(target_os = "macos") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]   --> src/platform.rs:25:6
[INFO] [stderr]    |
[INFO] [stderr] 25 |       } else
[INFO] [stderr]    |  ______^
[INFO] [stderr] 26 | |     if cfg!(target_os = "windows") {
[INFO] [stderr]    | |____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:232:10
[INFO] [stderr]     |
[INFO] [stderr] 232 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 233 | |         if doc {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:243:10
[INFO] [stderr]     |
[INFO] [stderr] 243 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 244 | |         if cleanup {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:246:10
[INFO] [stderr]     |
[INFO] [stderr] 246 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 247 | |         if crates {
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:295:10
[INFO] [stderr]     |
[INFO] [stderr] 295 |           } else
[INFO] [stderr]     |  __________^
[INFO] [stderr] 296 | |         if compile { // either a cargo directory or a Rust source file
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:336:6
[INFO] [stderr]     |
[INFO] [stderr] 336 |       } else
[INFO] [stderr]     |  ______^
[INFO] [stderr] 337 | |     if b("iterator") {
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:340:6
[INFO] [stderr]     |
[INFO] [stderr] 340 |       } else
[INFO] [stderr]     |  ______^
[INFO] [stderr] 341 | |     if b("lines") {
[INFO] [stderr]     | |____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:703:16
[INFO] [stderr]     |
[INFO] [stderr] 703 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 704 | |             if let Some((name,path)) = maybe_cargo_dir(&c) {
[INFO] [stderr] 705 | |                 // hello - this is a local Cargo project!
[INFO] [stderr] 706 | |                 (name, path.to_str().unwrap().to_string(),false)
[INFO] [stderr] ...   |
[INFO] [stderr] 709 | |             }
[INFO] [stderr] 710 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 703 |         } else if let Some((name,path)) = maybe_cargo_dir(&c) {
[INFO] [stderr] 704 |     // hello - this is a local Cargo project!
[INFO] [stderr] 705 |     (name, path.to_str().unwrap().to_string(),false)
[INFO] [stderr] 706 | } else { // latest version of crate
[INFO] [stderr] 707 |     (c.to_string(), '*'.to_string(),true)
[INFO] [stderr] 708 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:715:5
[INFO] [stderr]     |
[INFO] [stderr] 715 | /     if ! exists {
[INFO] [stderr] 716 | |         if ! cargo(&["new","--bin",STATIC_CACHE]) {
[INFO] [stderr] 717 | |             es::quit("cannot create static cache");
[INFO] [stderr] 718 | |         }
[INFO] [stderr] 719 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 715 |     if ! exists && ! cargo(&["new","--bin",STATIC_CACHE]) {
[INFO] [stderr] 716 |     es::quit("cannot create static cache");
[INFO] [stderr] 717 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:859:14
[INFO] [stderr]     |
[INFO] [stderr] 859 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 860 | |             if line.starts_with("extern ") || line.starts_with("use ") {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:866:14
[INFO] [stderr]     |
[INFO] [stderr] 866 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 867 | |             if line.starts_with("#![") {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: this is an `else if` but the formatting might hide it
[INFO] [stderr]    --> src/main.rs:871:14
[INFO] [stderr]     |
[INFO] [stderr] 871 |               } else
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 872 | |             if line.len() > 0 {
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this lint, remove the `else` or remove the new line between `else` and `if`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/crate_utils.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         env::home_dir().or_die("no home!").join(".cargo")
[INFO] [stderr]    |         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/strutil.rs:13:48
[INFO] [stderr]    |
[INFO] [stderr] 13 |         let end = s.find(|c:char| ! &until(c)).unwrap_or(s.len());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:125:12
[INFO] [stderr]     |
[INFO] [stderr] 125 |         if v.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if maybe_names.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!maybe_names.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 if entries.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entries.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/main.rs:148:1
[INFO] [stderr]     |
[INFO] [stderr] 148 | / fn main() {
[INFO] [stderr] 149 | |     let mut args = lapp::Args::new(USAGE);
[INFO] [stderr] 150 | |     args.parse_spec().or_die("bad spec");
[INFO] [stderr] 151 | |     let env = Path::new("env.rs");
[INFO] [stderr] ...   |
[INFO] [stderr] 473 | |         .or_then_die(|e| format!("can't run program {:?}: {}",program,e));
[INFO] [stderr] 474 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:177:25
[INFO] [stderr]     |
[INFO] [stderr] 177 |     let exe_suffix = if EXE_SUFFIX.len() > 0 {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!EXE_SUFFIX.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:195:8
[INFO] [stderr]     |
[INFO] [stderr] 195 |     if aliases.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aliases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:208:8
[INFO] [stderr]     |
[INFO] [stderr] 208 |     if crates.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/main.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 | /             if let Some(name) = maybe_argument.ok() {
[INFO] [stderr] 251 | |                 crates.push(name);
[INFO] [stderr] 252 | |                 crates.extend(args.get_strings("args"));
[INFO] [stderr] 253 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(name)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:390:12
[INFO] [stderr]     |
[INFO] [stderr] 390 |         if wild_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!wild_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:393:12
[INFO] [stderr]     |
[INFO] [stderr] 393 |         if macro_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!macro_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:512:17
[INFO] [stderr]     |
[INFO] [stderr] 512 |     for f in if explicit_features.len() > 0 {explicit_features} else {features} {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!explicit_features.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:548:30
[INFO] [stderr]     |
[INFO] [stderr] 548 |     if state.build_static && extern_crates.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extern_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/strutil.rs:13:48
[INFO] [stderr]    |
[INFO] [stderr] 13 |         let end = s.find(|c:char| ! &until(c)).unwrap_or(s.len());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:790:8
[INFO] [stderr]     |
[INFO] [stderr] 790 |     if aliases.len() == 0 { return; }
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `aliases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:826:12
[INFO] [stderr]     |
[INFO] [stderr] 826 |         if extern_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extern_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:872:16
[INFO] [stderr]     |
[INFO] [stderr] 872 |             if line.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:125:12
[INFO] [stderr]     |
[INFO] [stderr] 125 |         if v.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if maybe_names.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!maybe_names.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/meta.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 if entries.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!entries.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/main.rs:148:1
[INFO] [stderr]     |
[INFO] [stderr] 148 | / fn main() {
[INFO] [stderr] 149 | |     let mut args = lapp::Args::new(USAGE);
[INFO] [stderr] 150 | |     args.parse_spec().or_die("bad spec");
[INFO] [stderr] 151 | |     let env = Path::new("env.rs");
[INFO] [stderr] ...   |
[INFO] [stderr] 473 | |         .or_then_die(|e| format!("can't run program {:?}: {}",program,e));
[INFO] [stderr] 474 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:177:25
[INFO] [stderr]     |
[INFO] [stderr] 177 |     let exe_suffix = if EXE_SUFFIX.len() > 0 {
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!EXE_SUFFIX.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:195:8
[INFO] [stderr]     |
[INFO] [stderr] 195 |     if aliases.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aliases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:208:8
[INFO] [stderr]     |
[INFO] [stderr] 208 |     if crates.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/main.rs:250:13
[INFO] [stderr]     |
[INFO] [stderr] 250 | /             if let Some(name) = maybe_argument.ok() {
[INFO] [stderr] 251 | |                 crates.push(name);
[INFO] [stderr] 252 | |                 crates.extend(args.get_strings("args"));
[INFO] [stderr] 253 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(name)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:390:12
[INFO] [stderr]     |
[INFO] [stderr] 390 |         if wild_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!wild_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:393:12
[INFO] [stderr]     |
[INFO] [stderr] 393 |         if macro_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!macro_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:512:17
[INFO] [stderr]     |
[INFO] [stderr] 512 |     for f in if explicit_features.len() > 0 {explicit_features} else {features} {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!explicit_features.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:548:30
[INFO] [stderr]     |
[INFO] [stderr] 548 |     if state.build_static && extern_crates.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extern_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:790:8
[INFO] [stderr]     |
[INFO] [stderr] 790 |     if aliases.len() == 0 { return; }
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `aliases.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:826:12
[INFO] [stderr]     |
[INFO] [stderr] 826 |         if extern_crates.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!extern_crates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:872:16
[INFO] [stderr]     |
[INFO] [stderr] 872 |             if line.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.76s
[INFO] running `"docker" "inspect" "9f802a075d7bb898fae1b2f0bce036c69aaad67ddf98e52eef7f6a6cc369f1fa"`
[INFO] running `"docker" "rm" "-f" "9f802a075d7bb898fae1b2f0bce036c69aaad67ddf98e52eef7f6a6cc369f1fa"`
[INFO] [stdout] 9f802a075d7bb898fae1b2f0bce036c69aaad67ddf98e52eef7f6a6cc369f1fa