[INFO] crate rundo_types 0.4.0 is already in cache [INFO] extracting crate rundo_types 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rundo_types/0.4.0 [INFO] extracting crate rundo_types 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rundo_types/0.4.0 [INFO] validating manifest of rundo_types-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rundo_types-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rundo_types-0.4.0 [INFO] finished frobbing rundo_types-0.4.0 [INFO] frobbed toml for rundo_types-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rundo_types/0.4.0/Cargo.toml [INFO] started frobbing rundo_types-0.4.0 [INFO] finished frobbing rundo_types-0.4.0 [INFO] frobbed toml for rundo_types-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rundo_types/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rundo_types-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rundo_types/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3f626e04da51d1b84dfa304e153d190d7ddc8e2e4026d4d0491cc513da70420 [INFO] running `"docker" "start" "-a" "e3f626e04da51d1b84dfa304e153d190d7ddc8e2e4026d4d0491cc513da70420"` [INFO] [stderr] Checking rundo_types v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/string_type.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return ops; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ops` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let uop = match uop { [INFO] [stderr] | ___________________^ [INFO] [stderr] 81 | | &StrOP::Ins { idx, ref value } => { [INFO] [stderr] 82 | | let nidx = (idx as isize) + *base; [INFO] [stderr] 83 | | *base += value.len() as isize; [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 80 | let uop = match *uop { [INFO] [stderr] 81 | StrOP::Ins { idx, ref value } => { [INFO] [stderr] 82 | let nidx = (idx as isize) + *base; [INFO] [stderr] 83 | *base += value.len() as isize; [INFO] [stderr] 84 | StrOP::Del { [INFO] [stderr] 85 | idx: nidx as usize, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | acc + match x { [INFO] [stderr] | _____________^ [INFO] [stderr] 121 | | &StrOP::Ins { ref value, .. } => value.len() as isize, [INFO] [stderr] 122 | | &StrOP::Del { ref value, .. } => -(value.len() as isize), [INFO] [stderr] 123 | | &StrOP::Chg { [INFO] [stderr] 124 | | ref from, ref to, .. [INFO] [stderr] 125 | | } => to.len() as isize - from.len() as isize, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | acc + match *x { [INFO] [stderr] 121 | StrOP::Ins { ref value, .. } => value.len() as isize, [INFO] [stderr] 122 | StrOP::Del { ref value, .. } => -(value.len() as isize), [INFO] [stderr] 123 | StrOP::Chg { [INFO] [stderr] 124 | ref from, ref to, .. [INFO] [stderr] 125 | } => to.len() as isize - from.len() as isize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:133:7 [INFO] [stderr] | [INFO] [stderr] 133 | / match uop { [INFO] [stderr] 134 | | &StrOP::Ins { idx, ref value } => { [INFO] [stderr] 135 | | newstr += &self.value[base..idx]; [INFO] [stderr] 136 | | newstr += value; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | match *uop { [INFO] [stderr] 134 | StrOP::Ins { idx, ref value } => { [INFO] [stderr] 135 | newstr += &self.value[base..idx]; [INFO] [stderr] 136 | newstr += value; [INFO] [stderr] 137 | base = idx; [INFO] [stderr] 138 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/string_type.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return ops; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ops` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/primitive_type.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | type_test!(3.0, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let uop = match uop { [INFO] [stderr] | ___________________^ [INFO] [stderr] 81 | | &StrOP::Ins { idx, ref value } => { [INFO] [stderr] 82 | | let nidx = (idx as isize) + *base; [INFO] [stderr] 83 | | *base += value.len() as isize; [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 80 | let uop = match *uop { [INFO] [stderr] 81 | StrOP::Ins { idx, ref value } => { [INFO] [stderr] 82 | let nidx = (idx as isize) + *base; [INFO] [stderr] 83 | *base += value.len() as isize; [INFO] [stderr] 84 | StrOP::Del { [INFO] [stderr] 85 | idx: nidx as usize, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | acc + match x { [INFO] [stderr] | _____________^ [INFO] [stderr] 121 | | &StrOP::Ins { ref value, .. } => value.len() as isize, [INFO] [stderr] 122 | | &StrOP::Del { ref value, .. } => -(value.len() as isize), [INFO] [stderr] 123 | | &StrOP::Chg { [INFO] [stderr] 124 | | ref from, ref to, .. [INFO] [stderr] 125 | | } => to.len() as isize - from.len() as isize, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | acc + match *x { [INFO] [stderr] 121 | StrOP::Ins { ref value, .. } => value.len() as isize, [INFO] [stderr] 122 | StrOP::Del { ref value, .. } => -(value.len() as isize), [INFO] [stderr] 123 | StrOP::Chg { [INFO] [stderr] 124 | ref from, ref to, .. [INFO] [stderr] 125 | } => to.len() as isize - from.len() as isize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/string_type.rs:133:7 [INFO] [stderr] | [INFO] [stderr] 133 | / match uop { [INFO] [stderr] 134 | | &StrOP::Ins { idx, ref value } => { [INFO] [stderr] 135 | | newstr += &self.value[base..idx]; [INFO] [stderr] 136 | | newstr += value; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | match *uop { [INFO] [stderr] 134 | StrOP::Ins { idx, ref value } => { [INFO] [stderr] 135 | newstr += &self.value[base..idx]; [INFO] [stderr] 136 | newstr += value; [INFO] [stderr] 137 | base = idx; [INFO] [stderr] 138 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rundo_types`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e3f626e04da51d1b84dfa304e153d190d7ddc8e2e4026d4d0491cc513da70420"` [INFO] running `"docker" "rm" "-f" "e3f626e04da51d1b84dfa304e153d190d7ddc8e2e4026d4d0491cc513da70420"` [INFO] [stdout] e3f626e04da51d1b84dfa304e153d190d7ddc8e2e4026d4d0491cc513da70420