[INFO] crate ruma-signatures 0.4.1 is already in cache [INFO] extracting crate ruma-signatures 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/ruma-signatures/0.4.1 [INFO] extracting crate ruma-signatures 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruma-signatures/0.4.1 [INFO] validating manifest of ruma-signatures-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ruma-signatures-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ruma-signatures-0.4.1 [INFO] finished frobbing ruma-signatures-0.4.1 [INFO] frobbed toml for ruma-signatures-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/ruma-signatures/0.4.1/Cargo.toml [INFO] started frobbing ruma-signatures-0.4.1 [INFO] finished frobbing ruma-signatures-0.4.1 [INFO] frobbed toml for ruma-signatures-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruma-signatures/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ruma-signatures-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ruma-signatures/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef27104e6358abcc21561de656e22f3eebf35f67f4140f37391d0c0cbbdb9acb [INFO] running `"docker" "start" "-a" "ef27104e6358abcc21561de656e22f3eebf35f67f4140f37391d0c0cbbdb9acb"` [INFO] [stderr] Checking ruma-signatures v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:644:17 [INFO] [stderr] | [INFO] [stderr] 644 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | signatures: signatures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signatures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:644:17 [INFO] [stderr] | [INFO] [stderr] 644 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | signatures: signatures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signatures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:681:24 [INFO] [stderr] | [INFO] [stderr] 681 | const PUBLIC_KEY: &'static str = "XGX0JRS2Af3be3knz2fBiRbApjm2Dh61gXDJA8kcJNI"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:682:25 [INFO] [stderr] | [INFO] [stderr] 682 | const PRIVATE_KEY: &'static str = "YJDBA9Xnr2sVqXD9Vj7XVUnmFZcZrlw8Md7kMW+3XA0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:684:34 [INFO] [stderr] | [INFO] [stderr] 684 | const EMPTY_JSON_SIGNATURE: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:686:36 [INFO] [stderr] | [INFO] [stderr] 686 | const MINIMAL_JSON_SIGNATURE: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ed25519Verifier` [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn new() -> Self { [INFO] [stderr] 363 | | Ed25519Verifier [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 263 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `Signatures` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:462:1 [INFO] [stderr] | [INFO] [stderr] 462 | / impl Signatures { [INFO] [stderr] 463 | | /// Initializes a new empty Signatures. [INFO] [stderr] 464 | | pub fn new() -> Self { [INFO] [stderr] 465 | | Signatures { [INFO] [stderr] ... | [INFO] [stderr] 512 | | } [INFO] [stderr] 513 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Signatures` [INFO] [stderr] --> src/lib.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn new() -> Self { [INFO] [stderr] 465 | | Signatures { [INFO] [stderr] 466 | | map: HashMap::new(), [INFO] [stderr] 467 | | } [INFO] [stderr] 468 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:548:20 [INFO] [stderr] | [INFO] [stderr] 548 | if let Err(_) = signatures.insert(&server_name, signature_set) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 549 | | return Err(M::Error::invalid_value(Unexpected::Str(&server_name), &self)); [INFO] [stderr] 550 | | } [INFO] [stderr] | |_____________- help: try this: `if signatures.insert(&server_name, signature_set).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: item `SignatureSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:557:1 [INFO] [stderr] | [INFO] [stderr] 557 | / impl SignatureSet { [INFO] [stderr] 558 | | /// Initializes a new empty SignatureSet. [INFO] [stderr] 559 | | pub fn new() -> Self { [INFO] [stderr] 560 | | SignatureSet { [INFO] [stderr] ... | [INFO] [stderr] 591 | | } [INFO] [stderr] 592 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SignatureSet` [INFO] [stderr] --> src/lib.rs:559:5 [INFO] [stderr] | [INFO] [stderr] 559 | / pub fn new() -> Self { [INFO] [stderr] 560 | | SignatureSet { [INFO] [stderr] 561 | | set: HashSet::new(), [INFO] [stderr] 562 | | } [INFO] [stderr] 563 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 316 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ed25519Verifier` [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn new() -> Self { [INFO] [stderr] 363 | | Ed25519Verifier [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 263 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `Signatures` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:462:1 [INFO] [stderr] | [INFO] [stderr] 462 | / impl Signatures { [INFO] [stderr] 463 | | /// Initializes a new empty Signatures. [INFO] [stderr] 464 | | pub fn new() -> Self { [INFO] [stderr] 465 | | Signatures { [INFO] [stderr] ... | [INFO] [stderr] 512 | | } [INFO] [stderr] 513 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Signatures` [INFO] [stderr] --> src/lib.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn new() -> Self { [INFO] [stderr] 465 | | Signatures { [INFO] [stderr] 466 | | map: HashMap::new(), [INFO] [stderr] 467 | | } [INFO] [stderr] 468 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:548:20 [INFO] [stderr] | [INFO] [stderr] 548 | if let Err(_) = signatures.insert(&server_name, signature_set) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 549 | | return Err(M::Error::invalid_value(Unexpected::Str(&server_name), &self)); [INFO] [stderr] 550 | | } [INFO] [stderr] | |_____________- help: try this: `if signatures.insert(&server_name, signature_set).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: item `SignatureSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:557:1 [INFO] [stderr] | [INFO] [stderr] 557 | / impl SignatureSet { [INFO] [stderr] 558 | | /// Initializes a new empty SignatureSet. [INFO] [stderr] 559 | | pub fn new() -> Self { [INFO] [stderr] 560 | | SignatureSet { [INFO] [stderr] ... | [INFO] [stderr] 591 | | } [INFO] [stderr] 592 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SignatureSet` [INFO] [stderr] --> src/lib.rs:559:5 [INFO] [stderr] | [INFO] [stderr] 559 | / pub fn new() -> Self { [INFO] [stderr] 560 | | SignatureSet { [INFO] [stderr] 561 | | set: HashSet::new(), [INFO] [stderr] 562 | | } [INFO] [stderr] 563 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 316 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `"docker" "inspect" "ef27104e6358abcc21561de656e22f3eebf35f67f4140f37391d0c0cbbdb9acb"` [INFO] running `"docker" "rm" "-f" "ef27104e6358abcc21561de656e22f3eebf35f67f4140f37391d0c0cbbdb9acb"` [INFO] [stdout] ef27104e6358abcc21561de656e22f3eebf35f67f4140f37391d0c0cbbdb9acb