[INFO] crate rubygems_api 0.2.0 is already in cache [INFO] extracting crate rubygems_api 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rubygems_api/0.2.0 [INFO] extracting crate rubygems_api 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubygems_api/0.2.0 [INFO] validating manifest of rubygems_api-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rubygems_api-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rubygems_api-0.2.0 [INFO] finished frobbing rubygems_api-0.2.0 [INFO] frobbed toml for rubygems_api-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rubygems_api/0.2.0/Cargo.toml [INFO] started frobbing rubygems_api-0.2.0 [INFO] finished frobbing rubygems_api-0.2.0 [INFO] frobbed toml for rubygems_api-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubygems_api/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rubygems_api-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rubygems_api/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fc917ca72051fbcb3f0734566a498d2051f1edb5de5d4dc42701cda2c69fe4e [INFO] running `"docker" "start" "-a" "3fc917ca72051fbcb3f0734566a498d2051f1edb5de5d4dc42701cda2c69fe4e"` [INFO] [stderr] Compiling cargo-husky v1.3.0 [INFO] [stderr] Checking rubygems_api v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SyncClient` [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Self { [INFO] [stderr] 95 | | SyncClient { [INFO] [stderr] 96 | | client: reqwest::Client::new(), [INFO] [stderr] 97 | | base_url: Url::parse("https://rubygems.org/api/v1/gems/").unwrap(), [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for SyncClient { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SyncClient` [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Self { [INFO] [stderr] 95 | | SyncClient { [INFO] [stderr] 96 | | client: reqwest::Client::new(), [INFO] [stderr] 97 | | base_url: Url::parse("https://rubygems.org/api/v1/gems/").unwrap(), [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for SyncClient { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | assert!(gem_info.name.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!gem_info.name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(gem_info_deps.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!gem_info_deps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.87s [INFO] running `"docker" "inspect" "3fc917ca72051fbcb3f0734566a498d2051f1edb5de5d4dc42701cda2c69fe4e"` [INFO] running `"docker" "rm" "-f" "3fc917ca72051fbcb3f0734566a498d2051f1edb5de5d4dc42701cda2c69fe4e"` [INFO] [stdout] 3fc917ca72051fbcb3f0734566a498d2051f1edb5de5d4dc42701cda2c69fe4e