[INFO] crate rubrail 0.7.0 is already in cache [INFO] extracting crate rubrail 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/rubrail/0.7.0 [INFO] extracting crate rubrail 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubrail/0.7.0 [INFO] validating manifest of rubrail-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rubrail-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rubrail-0.7.0 [INFO] finished frobbing rubrail-0.7.0 [INFO] frobbed toml for rubrail-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/rubrail/0.7.0/Cargo.toml [INFO] started frobbing rubrail-0.7.0 [INFO] finished frobbing rubrail-0.7.0 [INFO] frobbed toml for rubrail-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubrail/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rubrail-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rubrail/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 591ec71a4b6276738606d9f748ef56403215628958be750997cf30db02589b6f [INFO] running `"docker" "start" "-a" "591ec71a4b6276738606d9f748ef56403215628958be750997cf30db02589b6f"` [INFO] [stderr] Compiling rubrail v0.7.0 (/opt/crater/workdir) [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking fruitbasket v0.6.0 [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:316:44 [INFO] [stderr] | [INFO] [stderr] 316 | fn add_items_to_bar(&mut self, bar_id: &BarId, items: Vec) {} [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BarId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:353:56 [INFO] [stderr] | [INFO] [stderr] 353 | text: Option<&str>, bar_id: &BarId) -> ItemId {0} [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BarId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:380:42 [INFO] [stderr] | [INFO] [stderr] 380 | fn update_label(&mut self, label_id: &ItemId, text: &str) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:391:48 [INFO] [stderr] | [INFO] [stderr] 391 | fn update_label_width(&mut self, label_id: &ItemId, width: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | fn select_scrubber_item(&mut self, scrub_id: &ItemId, index: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:438:46 [INFO] [stderr] | [INFO] [stderr] 438 | fn refresh_scrubber(&mut self, scrub_id: &ItemId) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:458:49 [INFO] [stderr] | [INFO] [stderr] 458 | fn add_item_tap_gesture(&mut self, item_id: &ItemId, taps: u32, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:473:48 [INFO] [stderr] | [INFO] [stderr] 473 | fn add_item_swipe_gesture(&mut self, item: &ItemId, cb: SwipeCb) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:558:39 [INFO] [stderr] | [INFO] [stderr] 558 | fn update_button(&mut self, item: &ItemId, image: Option<&TouchbarImage>, text: Option<&str>) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:569:50 [INFO] [stderr] | [INFO] [stderr] 569 | fn update_button_width(&mut self, button_id: &ItemId, width: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | fn update_slider(&mut self, id: &ItemId, value: f64) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/dummy.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dummy.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | pub unsafe fn set_bg_color(_item: &ItemId, _r: f64, _g: f64, _b: f64, _alpha: f64) { } [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dummy.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | pub unsafe fn set_text_color(_item: &ItemId, _r: f64, _g: f64, _b: f64, _alpha: f64) { } [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rubrail`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:316:44 [INFO] [stderr] | [INFO] [stderr] 316 | fn add_items_to_bar(&mut self, bar_id: &BarId, items: Vec) {} [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BarId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:353:56 [INFO] [stderr] | [INFO] [stderr] 353 | text: Option<&str>, bar_id: &BarId) -> ItemId {0} [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `BarId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:380:42 [INFO] [stderr] | [INFO] [stderr] 380 | fn update_label(&mut self, label_id: &ItemId, text: &str) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:391:48 [INFO] [stderr] | [INFO] [stderr] 391 | fn update_label_width(&mut self, label_id: &ItemId, width: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | fn select_scrubber_item(&mut self, scrub_id: &ItemId, index: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:438:46 [INFO] [stderr] | [INFO] [stderr] 438 | fn refresh_scrubber(&mut self, scrub_id: &ItemId) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:458:49 [INFO] [stderr] | [INFO] [stderr] 458 | fn add_item_tap_gesture(&mut self, item_id: &ItemId, taps: u32, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:473:48 [INFO] [stderr] | [INFO] [stderr] 473 | fn add_item_swipe_gesture(&mut self, item: &ItemId, cb: SwipeCb) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:558:39 [INFO] [stderr] | [INFO] [stderr] 558 | fn update_button(&mut self, item: &ItemId, image: Option<&TouchbarImage>, text: Option<&str>) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:569:50 [INFO] [stderr] | [INFO] [stderr] 569 | fn update_button_width(&mut self, button_id: &ItemId, width: u32) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interface.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | fn update_slider(&mut self, id: &ItemId, value: f64) {} [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/dummy.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dummy.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | pub unsafe fn set_bg_color(_item: &ItemId, _r: f64, _g: f64, _b: f64, _alpha: f64) { } [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dummy.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | pub unsafe fn set_text_color(_item: &ItemId, _r: f64, _g: f64, _b: f64, _alpha: f64) { } [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `ItemId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rubrail`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "591ec71a4b6276738606d9f748ef56403215628958be750997cf30db02589b6f"` [INFO] running `"docker" "rm" "-f" "591ec71a4b6276738606d9f748ef56403215628958be750997cf30db02589b6f"` [INFO] [stdout] 591ec71a4b6276738606d9f748ef56403215628958be750997cf30db02589b6f