[INFO] crate rubbish 0.1.0 is already in cache
[INFO] extracting crate rubbish 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rubbish/0.1.0
[INFO] extracting crate rubbish 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubbish/0.1.0
[INFO] validating manifest of rubbish-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rubbish-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rubbish-0.1.0
[INFO] finished frobbing rubbish-0.1.0
[INFO] frobbed toml for rubbish-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rubbish/0.1.0/Cargo.toml
[INFO] started frobbing rubbish-0.1.0
[INFO] finished frobbing rubbish-0.1.0
[INFO] frobbed toml for rubbish-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rubbish/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rubbish-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rubbish/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 22502f4707b08c4ccbb8a7f0ee746971384ebe1287e09cf2b5d0457989ad131c
[INFO] running `"docker" "start" "-a" "22502f4707b08c4ccbb8a7f0ee746971384ebe1287e09cf2b5d0457989ad131c"`
[INFO] [stderr]     Checking bincode v0.6.1
[INFO] [stderr]     Checking rubbish v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs/tree.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             root: root,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs/tree.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |                     children: children,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fs/tree.rs:194:29
[INFO] [stderr]     |
[INFO] [stderr] 194 |                             data: data,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs/tree.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             root: root,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fs/tree.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |                     children: children,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fs/tree.rs:194:29
[INFO] [stderr]     |
[INFO] [stderr] 194 |                             data: data,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/hash.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/content.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return (hash, Content(encoded, PhantomData));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(hash, Content(encoded, PhantomData))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/storage.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/fs/tree.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |         return Ok(Tree{root: SubTree::Resolved(Arc::new(iter))});
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Tree{root: SubTree::Resolved(Arc::new(iter))})`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/hash.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/content.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |         return (hash, Content(encoded, PhantomData));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(hash, Content(encoded, PhantomData))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/storage.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cas/localstorage.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/fs/commit.rs:94:23
[INFO] [stderr]    |
[INFO] [stderr] 94 |     const ROOT_HASH: &'static str = "4e4792b3a91c2cea55575345f94bb20c2d6b8d62a34f7e6099e7fd3a40944836";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/fs/tree.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |         return Ok(Tree{root: SubTree::Resolved(Arc::new(iter))});
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Tree{root: SubTree::Resolved(Arc::new(iter))})`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cas/hash.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn for_bytes(bytes: &Vec<u8>) -> Hash {
[INFO] [stderr]    |                             ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cas::storage::Storage<T>`
[INFO] [stderr]   --> src/cas/storage.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Storage<T> {
[INFO] [stderr] 22 | |         Storage { map: HashMap::new() }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/fs/commit.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 | /             match parent {
[INFO] [stderr] 68 | |                 &Parent::Unresolved(ref hash) => {
[INFO] [stderr] 69 | |                     parent_hashes.push(hash.clone());
[INFO] [stderr] 70 | |                 },
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |                 }
[INFO] [stderr] 74 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |             match *parent {
[INFO] [stderr] 68 |                 Parent::Unresolved(ref hash) => {
[INFO] [stderr] 69 |                     parent_hashes.push(hash.clone());
[INFO] [stderr] 70 |                 },
[INFO] [stderr] 71 |                 Parent::Resolved(ref commit) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/fs/tree.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         match subtree {
[INFO] [stderr] 46 | |             &SubTree::Unresolved(ref hash) => hash.clone(),
[INFO] [stderr] 47 | |             &SubTree::Resolved(ref node) => {
[INFO] [stderr] 48 | |                 let mut children = vec![];
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             }
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         match *subtree {
[INFO] [stderr] 46 |             SubTree::Unresolved(ref hash) => hash.clone(),
[INFO] [stderr] 47 |             SubTree::Resolved(ref node) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/fs/tree.rs:54:35
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     let subtree = node.children.get(name).unwrap();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.children[name]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/fs/tree.rs:156:15
[INFO] [stderr]     |
[INFO] [stderr] 156 |         while node_stack.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node_stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/fs/tree.rs:161:37
[INFO] [stderr]     |
[INFO] [stderr] 161 |             if iter.data == None && iter.children.len() == 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iter.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/fs/tree.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 | /         match self {
[INFO] [stderr] 178 | |             &SubTree::Unresolved(ref hash) => {
[INFO] [stderr] 179 | |                 if let Some(obj) = storage.retrieve(hash) {
[INFO] [stderr] 180 | |                     if let Object::Tree{data, children} = obj {
[INFO] [stderr] ...   |
[INFO] [stderr] 207 | |             },
[INFO] [stderr] 208 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 177 |         match *self {
[INFO] [stderr] 178 |             SubTree::Unresolved(ref hash) => {
[INFO] [stderr] 179 |                 if let Some(obj) = storage.retrieve(hash) {
[INFO] [stderr] 180 |                     if let Object::Tree{data, children} = obj {
[INFO] [stderr] 181 |                         let mut childmap = HashMap::new();
[INFO] [stderr] 182 |                         for (name, hash) in children {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cas/hash.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn for_bytes(bytes: &Vec<u8>) -> Hash {
[INFO] [stderr]    |                             ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cas::storage::Storage<T>`
[INFO] [stderr]   --> src/cas/storage.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     pub fn new() -> Storage<T> {
[INFO] [stderr] 22 | |         Storage { map: HashMap::new() }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cas::localstorage::LocalStorage<T>`
[INFO] [stderr]   --> src/cas/localstorage.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> LocalStorage<T> {
[INFO] [stderr] 17 | |         LocalStorage { map: HashMap::new() }
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/fs/commit.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 | /             match parent {
[INFO] [stderr] 68 | |                 &Parent::Unresolved(ref hash) => {
[INFO] [stderr] 69 | |                     parent_hashes.push(hash.clone());
[INFO] [stderr] 70 | |                 },
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |                 }
[INFO] [stderr] 74 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |             match *parent {
[INFO] [stderr] 68 |                 Parent::Unresolved(ref hash) => {
[INFO] [stderr] 69 |                     parent_hashes.push(hash.clone());
[INFO] [stderr] 70 |                 },
[INFO] [stderr] 71 |                 Parent::Resolved(ref commit) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/fs/commit.rs:108:40
[INFO] [stderr]     |
[INFO] [stderr] 108 |             let tree = try!(tree.write(&mut storage, &["x", "y"], "Y".to_string()));
[INFO] [stderr]     |                                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/fs/commit.rs:109:40
[INFO] [stderr]     |
[INFO] [stderr] 109 |             let tree = try!(tree.write(&mut storage, &["x", "z"], "Z".to_string()));
[INFO] [stderr]     |                                        ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/fs/tree.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         match subtree {
[INFO] [stderr] 46 | |             &SubTree::Unresolved(ref hash) => hash.clone(),
[INFO] [stderr] 47 | |             &SubTree::Resolved(ref node) => {
[INFO] [stderr] 48 | |                 let mut children = vec![];
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             }
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         match *subtree {
[INFO] [stderr] 46 |             SubTree::Unresolved(ref hash) => hash.clone(),
[INFO] [stderr] 47 |             SubTree::Resolved(ref node) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/fs/tree.rs:54:35
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     let subtree = node.children.get(name).unwrap();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.children[name]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/fs/tree.rs:156:15
[INFO] [stderr]     |
[INFO] [stderr] 156 |         while node_stack.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node_stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/fs/tree.rs:161:37
[INFO] [stderr]     |
[INFO] [stderr] 161 |             if iter.data == None && iter.children.len() == 0 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `iter.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/fs/tree.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 | /         match self {
[INFO] [stderr] 178 | |             &SubTree::Unresolved(ref hash) => {
[INFO] [stderr] 179 | |                 if let Some(obj) = storage.retrieve(hash) {
[INFO] [stderr] 180 | |                     if let Object::Tree{data, children} = obj {
[INFO] [stderr] ...   |
[INFO] [stderr] 207 | |             },
[INFO] [stderr] 208 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 177 |         match *self {
[INFO] [stderr] 178 |             SubTree::Unresolved(ref hash) => {
[INFO] [stderr] 179 |                 if let Some(obj) = storage.retrieve(hash) {
[INFO] [stderr] 180 |                     if let Object::Tree{data, children} = obj {
[INFO] [stderr] 181 |                         let mut childmap = HashMap::new();
[INFO] [stderr] 182 |                         for (name, hash) in children {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/fs/tree.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 | /         match subtree {
[INFO] [stderr] 227 | |             &SubTree::Unresolved(ref hash) => format!("<{}>", hash.to_hex()),
[INFO] [stderr] 228 | |             &SubTree::Resolved(ref node) => {
[INFO] [stderr] 229 | |                 let mut keys = node.children.keys().collect::<Vec<&String>>();
[INFO] [stderr] ...   |
[INFO] [stderr] 235 | |             }
[INFO] [stderr] 236 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 226 |         match *subtree {
[INFO] [stderr] 227 |             SubTree::Unresolved(ref hash) => format!("<{}>", hash.to_hex()),
[INFO] [stderr] 228 |             SubTree::Resolved(ref node) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/fs/tree.rs:232:64
[INFO] [stderr]     |
[INFO] [stderr] 232 |                     .map(|k| format!("{}: {}", k, rep_subtree(&node.children.get(&k[..]).unwrap())))
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.children[&k[..]]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.57s
[INFO] running `"docker" "inspect" "22502f4707b08c4ccbb8a7f0ee746971384ebe1287e09cf2b5d0457989ad131c"`
[INFO] running `"docker" "rm" "-f" "22502f4707b08c4ccbb8a7f0ee746971384ebe1287e09cf2b5d0457989ad131c"`
[INFO] [stdout] 22502f4707b08c4ccbb8a7f0ee746971384ebe1287e09cf2b5d0457989ad131c