[INFO] crate rtt 0.4.4 is already in cache [INFO] extracting crate rtt 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/rtt/0.4.4 [INFO] extracting crate rtt 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtt/0.4.4 [INFO] validating manifest of rtt-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rtt-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rtt-0.4.4 [INFO] finished frobbing rtt-0.4.4 [INFO] frobbed toml for rtt-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/rtt/0.4.4/Cargo.toml [INFO] started frobbing rtt-0.4.4 [INFO] finished frobbing rtt-0.4.4 [INFO] frobbed toml for rtt-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtt/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rtt-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rtt/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcaf64c14efe3cf3c8f50fbcb66066d3b93f86a817ebdd2aeae56bb58ca450f3 [INFO] running `"docker" "start" "-a" "fcaf64c14efe3cf3c8f50fbcb66066d3b93f86a817ebdd2aeae56bb58ca450f3"` [INFO] [stderr] Checking rtt v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::rtt::vec_slist::EmptyRandomTree` [INFO] [stderr] --> src/util/rtt/vec_slist.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> EmptyRandomTree { [INFO] [stderr] 17 | | EmptyRandomTree { [INFO] [stderr] 18 | | _marker: PhantomData, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | let () = trans.prepare_sample(&mut self.rtt, self.node_ref)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/lib.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | let () = trans.no_transition(&mut self.rtt, self.node_ref)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/rect_maze.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::rtt::vec_slist::EmptyRandomTree` [INFO] [stderr] --> src/util/rtt/vec_slist.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> EmptyRandomTree { [INFO] [stderr] 17 | | EmptyRandomTree { [INFO] [stderr] 18 | | _marker: PhantomData, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | let () = trans.prepare_sample(&mut self.rtt, self.node_ref)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/lib.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | let () = trans.no_transition(&mut self.rtt, self.node_ref)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `maze` [INFO] [stderr] --> examples/rect_maze.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | for row in 0 .. height { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for (row, ) in maze.iter().enumerate().take(height) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/rect_maze.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | source: source.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/rect_maze.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | target: target.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/rect_maze.rs:191:1 [INFO] [stderr] | [INFO] [stderr] 191 | / fn find_cell<'a>(cell: u8, map: Map<'a>, height: usize, width: usize) -> Option { [INFO] [stderr] 192 | | for row in 0 .. height { [INFO] [stderr] 193 | | for col in 0 .. min(width, map[row].len()) { [INFO] [stderr] 194 | | if map[row][col] == cell { [INFO] [stderr] ... | [INFO] [stderr] 199 | | None [INFO] [stderr] 200 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `map` [INFO] [stderr] --> examples/rect_maze.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | for row in 0 .. height { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 192 | for (row, ) in map.iter().enumerate().take(height) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.34s [INFO] running `"docker" "inspect" "fcaf64c14efe3cf3c8f50fbcb66066d3b93f86a817ebdd2aeae56bb58ca450f3"` [INFO] running `"docker" "rm" "-f" "fcaf64c14efe3cf3c8f50fbcb66066d3b93f86a817ebdd2aeae56bb58ca450f3"` [INFO] [stdout] fcaf64c14efe3cf3c8f50fbcb66066d3b93f86a817ebdd2aeae56bb58ca450f3