[INFO] crate rtrace 1.0.0 is already in cache [INFO] extracting crate rtrace 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/rtrace/1.0.0 [INFO] extracting crate rtrace 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtrace/1.0.0 [INFO] validating manifest of rtrace-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rtrace-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rtrace-1.0.0 [INFO] finished frobbing rtrace-1.0.0 [INFO] frobbed toml for rtrace-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/rtrace/1.0.0/Cargo.toml [INFO] started frobbing rtrace-1.0.0 [INFO] finished frobbing rtrace-1.0.0 [INFO] frobbed toml for rtrace-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtrace/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rtrace-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rtrace/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c44ebeceea73ff4f971c77d143a7b12083d100435e77cdca48bd5e9698d2236 [INFO] running `"docker" "start" "-a" "6c44ebeceea73ff4f971c77d143a7b12083d100435e77cdca48bd5e9698d2236"` [INFO] [stderr] Checking rtrace v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rust/primitive.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let r = 0.5 + 255.0 * v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | let g = h.pos.dot(&s.directional_light); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | let p = r.pos + (r.dir.mulfed(h.distance)) + *h.pos.mulf(h.distance * f32::EPSILON.sqrt()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rust/primitive.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let r = 0.5 + 255.0 * v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | let g = h.pos.dot(&s.directional_light); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/rust/render.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | let p = r.pos + (r.dir.mulfed(h.distance)) + *h.pos.mulf(h.distance * f32::EPSILON.sqrt()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust/render.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return o.l >= self.l && o.b >= self.b && o.t <= self.t && o.r <= self.r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `o.l >= self.l && o.b >= self.b && o.t <= self.t && o.r <= self.r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/rust/render.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | c[0] = scale(p.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust/render.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | return 1.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust/render.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | return 0.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rust/vec.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | self.x = self.x * m; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x *= m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rust/vec.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.y = self.y * m; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y *= m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rust/vec.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.z = self.z * m; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.z *= m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn width(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn height(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn area(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn contains(&self, o: &ImageRegion) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn contains(&self, o: &ImageRegion) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageRegion` [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] | [INFO] [stderr] --> src/rust/lib.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn buffer_offset(&self, x: u16, y: u16) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | fn new(r: &ImageRegion) -> RGBABuffer { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ImageRegion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:218:29 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn render_region(o: &RenderOptions, scene: &Scene, buf: &mut RGBABuffer) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `RenderOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:219:19 [INFO] [stderr] | [INFO] [stderr] 219 | let ssf = o.samples_per_pixel as RFloat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(o.samples_per_pixel)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | let width = o.width as RFloat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(o.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | let height = o.height as RFloat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(o.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:238:36 [INFO] [stderr] | [INFO] [stderr] 238 | let xres = x as RFloat + ssx as RFloat / ssf; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:238:50 [INFO] [stderr] | [INFO] [stderr] 238 | let xres = x as RFloat + ssx as RFloat / ssf; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(ssx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:239:36 [INFO] [stderr] | [INFO] [stderr] 239 | let yres = y as RFloat + ssy as RFloat / ssf; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:239:50 [INFO] [stderr] | [INFO] [stderr] 239 | let yres = y as RFloat + ssy as RFloat / ssf; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(ssy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rust/render.rs:260:22 [INFO] [stderr] | [INFO] [stderr] 260 | pub fn render(o: &RenderOptions, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `RenderOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/rust/render.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | tx.send(b).ok().expect("Channel should be open !"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: Could not compile `rtrace`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:399:29 [INFO] [stderr] | [INFO] [stderr] 399 | let avg = ((b[0] as f32 + b[1] as f32 + b[2] as f32) / 3.0f32) as u8; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(b[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:399:43 [INFO] [stderr] | [INFO] [stderr] 399 | let avg = ((b[0] as f32 + b[1] as f32 + b[2] as f32) / 3.0f32) as u8; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(b[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/rust/render.rs:399:57 [INFO] [stderr] | [INFO] [stderr] 399 | let avg = ((b[0] as f32 + b[1] as f32 + b[2] as f32) / 3.0f32) as u8; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(b[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/rust/render.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | out.write(&[avg]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rtrace`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c44ebeceea73ff4f971c77d143a7b12083d100435e77cdca48bd5e9698d2236"` [INFO] running `"docker" "rm" "-f" "6c44ebeceea73ff4f971c77d143a7b12083d100435e77cdca48bd5e9698d2236"` [INFO] [stdout] 6c44ebeceea73ff4f971c77d143a7b12083d100435e77cdca48bd5e9698d2236