[INFO] crate rtop 0.0.3 is already in cache
[INFO] extracting crate rtop 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/rtop/0.0.3
[INFO] extracting crate rtop 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtop/0.0.3
[INFO] validating manifest of rtop-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rtop-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rtop-0.0.3
[INFO] finished frobbing rtop-0.0.3
[INFO] frobbed toml for rtop-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/rtop/0.0.3/Cargo.toml
[INFO] started frobbing rtop-0.0.3
[INFO] finished frobbing rtop-0.0.3
[INFO] frobbed toml for rtop-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtop/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rtop-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rtop/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fa90c6f94bbe8f267e30d633a5f1a60b4f27697fba98279b8652d629ad175a66
[INFO] running `"docker" "start" "-a" "fa90c6f94bbe8f267e30d633a5f1a60b4f27697fba98279b8652d629ad175a66"`
[INFO] [stderr]    Compiling sysinfo v0.5.8
[INFO] [stderr]     Checking tui v0.2.3
[INFO] [stderr]     Checking stderrlog v0.3.0
[INFO] [stderr]     Checking rtop v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `AsU32`, `NetworkExt`, `Pid`, `Process`, `ProcessorExt`, `Processor`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:5:21
[INFO] [stderr]   |
[INFO] [stderr] 5 | use self::sysinfo::{Pid, Disk, Processor, Process, System, ProcessExt,
[INFO] [stderr]   |                     ^^^        ^^^^^^^^^  ^^^^^^^
[INFO] [stderr] 6 |                     SystemExt, DiskExt, ProcessorExt, NetworkExt, AsU32};
[INFO] [stderr]   |                                         ^^^^^^^^^^^^  ^^^^^^^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `BarChart`, `Block`, `Borders`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:7:20
[INFO] [stderr]   |
[INFO] [stderr] 7 | use tui::widgets::{BarChart, Block, Borders, Widget};
[INFO] [stderr]   |                    ^^^^^^^^  ^^^^^  ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Color`, `Modifier`, `Style`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 | use tui::style::{Color, Modifier, Style};
[INFO] [stderr]   |                  ^^^^^  ^^^^^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rtop/ui/panels/network.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |                 .max(1000000)
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rtop/ui/panels/network.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 .max(1000000)
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Axis`, `Chart`, `Dataset`, `Marker`
[INFO] [stderr]  --> src/rtop/ui/panels/disks.rs:5:20
[INFO] [stderr]   |
[INFO] [stderr] 5 | use tui::widgets::{Axis, Block, BarChart, Borders, Chart, Dataset, Marker, Widget};
[INFO] [stderr]   |                    ^^^^                            ^^^^^  ^^^^^^^  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]   --> src/rtop/ui/panels/disks.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let gauge_width: u16 = (100 / num_drives);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rtop/app.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `AsU32`, `NetworkExt`, `Pid`, `Process`, `ProcessorExt`, `Processor`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:5:21
[INFO] [stderr]   |
[INFO] [stderr] 5 | use self::sysinfo::{Pid, Disk, Processor, Process, System, ProcessExt,
[INFO] [stderr]   |                     ^^^        ^^^^^^^^^  ^^^^^^^
[INFO] [stderr] 6 |                     SystemExt, DiskExt, ProcessorExt, NetworkExt, AsU32};
[INFO] [stderr]   |                                         ^^^^^^^^^^^^  ^^^^^^^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `BarChart`, `Block`, `Borders`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:7:20
[INFO] [stderr]   |
[INFO] [stderr] 7 | use tui::widgets::{BarChart, Block, Borders, Widget};
[INFO] [stderr]   |                    ^^^^^^^^  ^^^^^  ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Color`, `Modifier`, `Style`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 | use tui::style::{Color, Modifier, Style};
[INFO] [stderr]   |                  ^^^^^  ^^^^^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rtop/ui/panels/network.rs:22:22
[INFO] [stderr]    |
[INFO] [stderr] 22 |                 .max(1000000)
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rtop/ui/panels/network.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 .max(1000000)
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Axis`, `Chart`, `Dataset`, `Marker`
[INFO] [stderr]  --> src/rtop/ui/panels/disks.rs:5:20
[INFO] [stderr]   |
[INFO] [stderr] 5 | use tui::widgets::{Axis, Block, BarChart, Borders, Chart, Dataset, Marker, Widget};
[INFO] [stderr]   |                    ^^^^                            ^^^^^  ^^^^^^^  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]   --> src/rtop/ui/panels/disks.rs:11:28
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let gauge_width: u16 = (100 / num_drives);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rtop/app.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ProcessExt`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:5:60
[INFO] [stderr]   |
[INFO] [stderr] 5 | use self::sysinfo::{Pid, Disk, Processor, Process, System, ProcessExt,
[INFO] [stderr]   |                                                            ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Widget`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:7:46
[INFO] [stderr]   |
[INFO] [stderr] 7 | use tui::widgets::{BarChart, Block, Borders, Widget};
[INFO] [stderr]   |                                              ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]   --> src/rtop/datastreams/diskmonitor.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     max_history_len: usize,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `system_info`
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     system_info: System,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]   --> src/rtop/datastreams/networkmonitor.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     max_history_len: usize,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]  --> src/rtop/datastreams/processmonitor.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     max_history_len: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `render_tab_bar`
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:34:1
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn render_tab_bar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `text_panel`
[INFO] [stderr]  --> src/rtop/ui/panels/text.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn text_panel(t: &mut Terminal<MouseBackend>, area: &Rect) {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Bell`
[INFO] [stderr]  --> src/rtop/cmd.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 |     Bell,
[INFO] [stderr]   |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ProcessExt`
[INFO] [stderr]  --> src/rtop/datastreams/diskmonitor.rs:5:60
[INFO] [stderr]   |
[INFO] [stderr] 5 | use self::sysinfo::{Pid, Disk, Processor, Process, System, ProcessExt,
[INFO] [stderr]   |                                                            ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Widget`
[INFO] [stderr]  --> src/rtop/ui/renderer/charts.rs:7:46
[INFO] [stderr]   |
[INFO] [stderr] 7 | use tui::widgets::{BarChart, Block, Borders, Widget};
[INFO] [stderr]   |                                              ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 | /             match self.cpu_core_info.last() {
[INFO] [stderr] 38 | |                 Some(entry) => {
[INFO] [stderr] 39 | |                     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr] 40 | |                     while history.len() >= self.max_history_len {
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |                 None => {},
[INFO] [stderr] 46 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 37 |             if let Some(entry) = self.cpu_core_info.last() {
[INFO] [stderr] 38 |     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr] 39 |     while history.len() >= self.max_history_len {
[INFO] [stderr] 40 |         history.remove(0);
[INFO] [stderr] 41 |     }
[INFO] [stderr] 42 |     history.push(entry.1);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:39:81
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![0.0; self.max_history_len])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/datastreams/processmonitor.rs:29:32
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn parse_process_info(pid: &Pid, process: &Process) -> (u32, String, f32, u64) {
[INFO] [stderr]    |                                ^^^^ help: consider passing by value instead: `Pid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:14:64
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub fn render(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) -> Result<(), io::Error> {
[INFO] [stderr]    |                                                                ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:34:68
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn render_tab_bar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:44:68
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn draw_first_tab(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:55:73
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn render_bottom_thrid(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:66:69
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn draw_second_tab(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                     ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:74:50
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 ["Server", "Location", "Status"].into_iter(),
[INFO] [stderr]    |                                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/charts.rs:12:71
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn render_charts(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                       ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/charts.rs:23:61
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn sidebar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                             ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/text.rs:7:57
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn text_panel(t: &mut Terminal<MouseBackend>, area: &Rect) {
[INFO] [stderr]   |                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/cpuusage.rs:9:81
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn cpu_usage_history_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                                 ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/rtop/ui/panels/cpuusage.rs:11:48
[INFO] [stderr]    |
[INFO] [stderr] 11 |                                     .map(|x| {(x.0.clone(), (x.1).0.clone(), (x.1).1.clone())})
[INFO] [stderr]    |                                                ^^^^^^^^^^^ help: try dereferencing it: `*x.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/panels/processes.rs:11:73
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn processes_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/rtop/ui/panels/processes.rs:18:49
[INFO] [stderr]    |
[INFO] [stderr] 18 |         ["PID", "Command", "%CPU▲", "Mem (KB)"].into_iter(),
[INFO] [stderr]    |                                                 ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/memoryswapusage.rs:9:84
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn mem_and_swap_history_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/network.rs:8:76
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn network_info_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                            ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/disks.rs:9:74
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn disk_usage_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                          ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `drive_num` is used to index `chunks`
[INFO] [stderr]   --> src/rtop/ui/panels/disks.rs:24:30
[INFO] [stderr]    |
[INFO] [stderr] 24 |             for drive_num in 0..app.disk_info.disk_usage.len() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |             for (drive_num, <item>) in chunks.iter().enumerate().take(app.disk_info.disk_usage.len()) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/rtop/app.rs:137:63
[INFO] [stderr]     |
[INFO] [stderr] 137 |                                         .map(|x| (x.0 as f64, x.1.clone() as f64))
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x.1.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:137:63
[INFO] [stderr]     |
[INFO] [stderr] 137 |                                         .map(|x| (x.0 as f64, x.1.clone() as f64))
[INFO] [stderr]     |                                                               ^^^^^^^^^^^ help: try dereferencing it: `*x.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/rtop/app.rs:146:29
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                             match s.parse::<u32>() {
[INFO] [stderr] 147 | |                                 Ok(num) => {core_num = num},
[INFO] [stderr] 148 | |                                 Err(_) => (), 
[INFO] [stderr] 149 | |                             }
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Ok(num) = s.parse::<u32>() {core_num = num}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:165:98
[INFO] [stderr]     |
[INFO] [stderr] 165 |                                                                         .map(|(i, u)| (i as f64, u.clone()))
[INFO] [stderr]     |                                                                                                  ^^^^^^^^^ help: try dereferencing it: `*u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:173:96
[INFO] [stderr]     |
[INFO] [stderr] 173 |                                                                       .map(|(i, u)| (i as f64, u.clone()))
[INFO] [stderr]     |                                                                                                ^^^^^^^^^ help: try dereferencing it: `*u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:74:21
[INFO] [stderr]    |
[INFO] [stderr] 74 | /                     match app.input_handler(input) {
[INFO] [stderr] 75 | |                         Some(command) => {
[INFO] [stderr] 76 | |                             match command {
[INFO] [stderr] 77 | |                                 Cmd::Quit => {break},
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |                         None => (),
[INFO] [stderr] 82 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 74 |                     if let Some(command) = app.input_handler(input) {
[INFO] [stderr] 75 |     match command {
[INFO] [stderr] 76 |         Cmd::Quit => {break},
[INFO] [stderr] 77 |         _ => (),
[INFO] [stderr] 78 |     }
[INFO] [stderr] 79 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:76:29
[INFO] [stderr]    |
[INFO] [stderr] 76 | /                             match command {
[INFO] [stderr] 77 | |                                 Cmd::Quit => {break},
[INFO] [stderr] 78 | |                                 _ => (),
[INFO] [stderr] 79 | |                             }
[INFO] [stderr]    | |_____________________________^ help: try this: `if let Cmd::Quit = command {break}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rtop`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]   --> src/rtop/datastreams/diskmonitor.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     max_history_len: usize,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `system_info`
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     system_info: System,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]   --> src/rtop/datastreams/networkmonitor.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     max_history_len: usize,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `max_history_len`
[INFO] [stderr]  --> src/rtop/datastreams/processmonitor.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     max_history_len: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `render_tab_bar`
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:34:1
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn render_tab_bar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `text_panel`
[INFO] [stderr]  --> src/rtop/ui/panels/text.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn text_panel(t: &mut Terminal<MouseBackend>, area: &Rect) {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Bell`
[INFO] [stderr]  --> src/rtop/cmd.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 |     Bell,
[INFO] [stderr]   |     ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 | /             match self.cpu_core_info.last() {
[INFO] [stderr] 38 | |                 Some(entry) => {
[INFO] [stderr] 39 | |                     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr] 40 | |                     while history.len() >= self.max_history_len {
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |                 None => {},
[INFO] [stderr] 46 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 37 |             if let Some(entry) = self.cpu_core_info.last() {
[INFO] [stderr] 38 |     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr] 39 |     while history.len() >= self.max_history_len {
[INFO] [stderr] 40 |         history.remove(0);
[INFO] [stderr] 41 |     }
[INFO] [stderr] 42 |     history.push(entry.1);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/rtop/datastreams/cpumonitor.rs:39:81
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     let history = self.cpu_usage_history.entry(entry.0.clone()).or_insert(vec![0.0; self.max_history_len]);
[INFO] [stderr]    |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![0.0; self.max_history_len])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/datastreams/processmonitor.rs:29:32
[INFO] [stderr]    |
[INFO] [stderr] 29 |     fn parse_process_info(pid: &Pid, process: &Process) -> (u32, String, f32, u64) {
[INFO] [stderr]    |                                ^^^^ help: consider passing by value instead: `Pid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:14:64
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub fn render(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) -> Result<(), io::Error> {
[INFO] [stderr]    |                                                                ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:34:68
[INFO] [stderr]    |
[INFO] [stderr] 34 | fn render_tab_bar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:44:68
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn draw_first_tab(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:55:73
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn render_bottom_thrid(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:66:69
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn draw_second_tab(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                     ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/rtop/ui/renderer/render.rs:74:50
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 ["Server", "Location", "Status"].into_iter(),
[INFO] [stderr]    |                                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/charts.rs:12:71
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn render_charts(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                       ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/renderer/charts.rs:23:61
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn sidebar(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                             ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/text.rs:7:57
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn text_panel(t: &mut Terminal<MouseBackend>, area: &Rect) {
[INFO] [stderr]   |                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/cpuusage.rs:9:81
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn cpu_usage_history_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                                 ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/rtop/ui/panels/cpuusage.rs:11:48
[INFO] [stderr]    |
[INFO] [stderr] 11 |                                     .map(|x| {(x.0.clone(), (x.1).0.clone(), (x.1).1.clone())})
[INFO] [stderr]    |                                                ^^^^^^^^^^^ help: try dereferencing it: `*x.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/rtop/ui/panels/processes.rs:11:73
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn processes_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]    |                                                                         ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/rtop/ui/panels/processes.rs:18:49
[INFO] [stderr]    |
[INFO] [stderr] 18 |         ["PID", "Command", "%CPU▲", "Mem (KB)"].into_iter(),
[INFO] [stderr]    |                                                 ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/memoryswapusage.rs:9:84
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn mem_and_swap_history_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                                    ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/network.rs:8:76
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn network_info_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                            ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/rtop/ui/panels/disks.rs:9:74
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn disk_usage_panel(t: &mut Terminal<MouseBackend>, app: &App, area: &Rect) {
[INFO] [stderr]   |                                                                          ^^^^^ help: consider passing by value instead: `Rect`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `drive_num` is used to index `chunks`
[INFO] [stderr]   --> src/rtop/ui/panels/disks.rs:24:30
[INFO] [stderr]    |
[INFO] [stderr] 24 |             for drive_num in 0..app.disk_info.disk_usage.len() {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |             for (drive_num, <item>) in chunks.iter().enumerate().take(app.disk_info.disk_usage.len()) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/rtop/app.rs:137:63
[INFO] [stderr]     |
[INFO] [stderr] 137 |                                         .map(|x| (x.0 as f64, x.1.clone() as f64))
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x.1.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:137:63
[INFO] [stderr]     |
[INFO] [stderr] 137 |                                         .map(|x| (x.0 as f64, x.1.clone() as f64))
[INFO] [stderr]     |                                                               ^^^^^^^^^^^ help: try dereferencing it: `*x.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/rtop/app.rs:146:29
[INFO] [stderr]     |
[INFO] [stderr] 146 | /                             match s.parse::<u32>() {
[INFO] [stderr] 147 | |                                 Ok(num) => {core_num = num},
[INFO] [stderr] 148 | |                                 Err(_) => (), 
[INFO] [stderr] 149 | |                             }
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Ok(num) = s.parse::<u32>() {core_num = num}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:165:98
[INFO] [stderr]     |
[INFO] [stderr] 165 |                                                                         .map(|(i, u)| (i as f64, u.clone()))
[INFO] [stderr]     |                                                                                                  ^^^^^^^^^ help: try dereferencing it: `*u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/rtop/app.rs:173:96
[INFO] [stderr]     |
[INFO] [stderr] 173 |                                                                       .map(|(i, u)| (i as f64, u.clone()))
[INFO] [stderr]     |                                                                                                ^^^^^^^^^ help: try dereferencing it: `*u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:74:21
[INFO] [stderr]    |
[INFO] [stderr] 74 | /                     match app.input_handler(input) {
[INFO] [stderr] 75 | |                         Some(command) => {
[INFO] [stderr] 76 | |                             match command {
[INFO] [stderr] 77 | |                                 Cmd::Quit => {break},
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |                         None => (),
[INFO] [stderr] 82 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 74 |                     if let Some(command) = app.input_handler(input) {
[INFO] [stderr] 75 |     match command {
[INFO] [stderr] 76 |         Cmd::Quit => {break},
[INFO] [stderr] 77 |         _ => (),
[INFO] [stderr] 78 |     }
[INFO] [stderr] 79 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:76:29
[INFO] [stderr]    |
[INFO] [stderr] 76 | /                             match command {
[INFO] [stderr] 77 | |                                 Cmd::Quit => {break},
[INFO] [stderr] 78 | |                                 _ => (),
[INFO] [stderr] 79 | |                             }
[INFO] [stderr]    | |_____________________________^ help: try this: `if let Cmd::Quit = command {break}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rtop`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "fa90c6f94bbe8f267e30d633a5f1a60b4f27697fba98279b8652d629ad175a66"`
[INFO] running `"docker" "rm" "-f" "fa90c6f94bbe8f267e30d633a5f1a60b4f27697fba98279b8652d629ad175a66"`
[INFO] [stdout] fa90c6f94bbe8f267e30d633a5f1a60b4f27697fba98279b8652d629ad175a66