[INFO] crate rsudo_support 0.1.5 is already in cache
[INFO] extracting crate rsudo_support 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/rsudo_support/0.1.5
[INFO] extracting crate rsudo_support 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsudo_support/0.1.5
[INFO] validating manifest of rsudo_support-0.1.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rsudo_support-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rsudo_support-0.1.5
[INFO] finished frobbing rsudo_support-0.1.5
[INFO] frobbed toml for rsudo_support-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/rsudo_support/0.1.5/Cargo.toml
[INFO] started frobbing rsudo_support-0.1.5
[INFO] finished frobbing rsudo_support-0.1.5
[INFO] frobbed toml for rsudo_support-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsudo_support/0.1.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rsudo_support-0.1.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsudo_support/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bf4be44db510c3c33c3e9296d7132eaef3d686603ceb0f698aaa654d4b824c01
[INFO] running `"docker" "start" "-a" "bf4be44db510c3c33c3e9296d7132eaef3d686603ceb0f698aaa654d4b824c01"`
[INFO] [stderr]     Checking rsudo_support v0.1.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket.rs:23:30
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return RsudoSocket { socket: socket };
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/socket.rs:23:30
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return RsudoSocket { socket: socket };
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/socket.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return RsudoSocket { socket: socket };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RsudoSocket { socket: socket }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/socket.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         return RsudoSocket { socket: socket };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RsudoSocket { socket: socket }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:32:6
[INFO] [stderr]    |
[INFO] [stderr] 32 |           match file.read_to_string(&mut content) {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 33 | |             Err(error) => panic!("couldn't read {}: {:?}", &path, error),
[INFO] [stderr] 34 | |             Ok(_) => {}
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(error) = file.read_to_string(&mut content) { panic!("couldn't read {}: {:?}", &path, error) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/config.rs:53:69
[INFO] [stderr]    |
[INFO] [stderr] 53 |                     let user_whitelist = config_user.iter().filter(|x| &x.name == filter).map(|x| &x.binary).collect::<Vec<_>>();
[INFO] [stderr]    |                                                                        -------^^^^^^^^^^
[INFO] [stderr]    |                                                                        |
[INFO] [stderr]    |                                                                        help: use the left value directly: `x.name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/config.rs:55:18
[INFO] [stderr]    |
[INFO] [stderr] 55 |                       if user_whitelist.contains(&&command.to_string()) {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 56 | |                         true
[INFO] [stderr] 57 | |                     } else {
[INFO] [stderr] 58 | |                         false
[INFO] [stderr] 59 | |                     }
[INFO] [stderr]    | |_____________________^ help: you can reduce it to: `user_whitelist.contains(&&command.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/config.rs:68:71
[INFO] [stderr]    |
[INFO] [stderr] 68 |                     let group_whitelist = config_group.iter().filter(|x| &x.name == filter).map(|x| &x.binary).collect::<Vec<_>>();
[INFO] [stderr]    |                                                                          -------^^^^^^^^^^
[INFO] [stderr]    |                                                                          |
[INFO] [stderr]    |                                                                          help: use the left value directly: `x.name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/config.rs:70:18
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       if group_whitelist.contains(&&command.to_string()) {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 71 | |                         true
[INFO] [stderr] 72 | |                     } else {
[INFO] [stderr] 73 | |                         false
[INFO] [stderr] 74 | |                     }
[INFO] [stderr]    | |_____________________^ help: you can reduce it to: `group_whitelist.contains(&&command.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:32:6
[INFO] [stderr]    |
[INFO] [stderr] 32 |           match file.read_to_string(&mut content) {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 33 | |             Err(error) => panic!("couldn't read {}: {:?}", &path, error),
[INFO] [stderr] 34 | |             Ok(_) => {}
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(error) = file.read_to_string(&mut content) { panic!("couldn't read {}: {:?}", &path, error) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/config.rs:53:69
[INFO] [stderr]    |
[INFO] [stderr] 53 |                     let user_whitelist = config_user.iter().filter(|x| &x.name == filter).map(|x| &x.binary).collect::<Vec<_>>();
[INFO] [stderr]    |                                                                        -------^^^^^^^^^^
[INFO] [stderr]    |                                                                        |
[INFO] [stderr]    |                                                                        help: use the left value directly: `x.name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/config.rs:55:18
[INFO] [stderr]    |
[INFO] [stderr] 55 |                       if user_whitelist.contains(&&command.to_string()) {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 56 | |                         true
[INFO] [stderr] 57 | |                     } else {
[INFO] [stderr] 58 | |                         false
[INFO] [stderr] 59 | |                     }
[INFO] [stderr]    | |_____________________^ help: you can reduce it to: `user_whitelist.contains(&&command.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/config.rs:68:71
[INFO] [stderr]    |
[INFO] [stderr] 68 |                     let group_whitelist = config_group.iter().filter(|x| &x.name == filter).map(|x| &x.binary).collect::<Vec<_>>();
[INFO] [stderr]    |                                                                          -------^^^^^^^^^^
[INFO] [stderr]    |                                                                          |
[INFO] [stderr]    |                                                                          help: use the left value directly: `x.name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/config.rs:70:18
[INFO] [stderr]    |
[INFO] [stderr] 70 |                       if group_whitelist.contains(&&command.to_string()) {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 71 | |                         true
[INFO] [stderr] 72 | |                     } else {
[INFO] [stderr] 73 | |                         false
[INFO] [stderr] 74 | |                     }
[INFO] [stderr]    | |_____________________^ help: you can reduce it to: `group_whitelist.contains(&&command.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.27s
[INFO] running `"docker" "inspect" "bf4be44db510c3c33c3e9296d7132eaef3d686603ceb0f698aaa654d4b824c01"`
[INFO] running `"docker" "rm" "-f" "bf4be44db510c3c33c3e9296d7132eaef3d686603ceb0f698aaa654d4b824c01"`
[INFO] [stdout] bf4be44db510c3c33c3e9296d7132eaef3d686603ceb0f698aaa654d4b824c01