[INFO] crate rsudo-rs_support 0.1.0 is already in cache [INFO] extracting crate rsudo-rs_support 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rsudo-rs_support/0.1.0 [INFO] extracting crate rsudo-rs_support 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsudo-rs_support/0.1.0 [INFO] validating manifest of rsudo-rs_support-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsudo-rs_support-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsudo-rs_support-0.1.0 [INFO] finished frobbing rsudo-rs_support-0.1.0 [INFO] frobbed toml for rsudo-rs_support-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rsudo-rs_support/0.1.0/Cargo.toml [INFO] started frobbing rsudo-rs_support-0.1.0 [INFO] finished frobbing rsudo-rs_support-0.1.0 [INFO] frobbed toml for rsudo-rs_support-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsudo-rs_support/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsudo-rs_support-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsudo-rs_support/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cc6ff0ed75b1bedb29756fafaf06d25748045bc956ecc9d5c00927d28823ca6 [INFO] running `"docker" "start" "-a" "2cc6ff0ed75b1bedb29756fafaf06d25748045bc956ecc9d5c00927d28823ca6"` [INFO] [stderr] Checking rsudo-rs_support v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/socket.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | return RsudoSocket { socket: socket }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/socket.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | return RsudoSocket { socket: socket }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return RsudoSocket { socket: socket }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RsudoSocket { socket: socket }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RsudoSocket` [INFO] [stderr] --> src/socket.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct RsudoSocket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/socket.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(path: &str) -> RsudoSocket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/socket.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn read(&mut self) -> (i32, String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/socket.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn write(&mut self, op: i32, payload: &str) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return RsudoSocket { socket: socket }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RsudoSocket { socket: socket }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RsudoSocket` [INFO] [stderr] --> src/socket.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct RsudoSocket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/socket.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(path: &str) -> RsudoSocket { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/socket.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn read(&mut self) -> (i32, String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/socket.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn write(&mut self, op: i32, payload: &str) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "2cc6ff0ed75b1bedb29756fafaf06d25748045bc956ecc9d5c00927d28823ca6"` [INFO] running `"docker" "rm" "-f" "2cc6ff0ed75b1bedb29756fafaf06d25748045bc956ecc9d5c00927d28823ca6"` [INFO] [stdout] 2cc6ff0ed75b1bedb29756fafaf06d25748045bc956ecc9d5c00927d28823ca6