[INFO] crate rstest 0.2.2 is already in cache [INFO] extracting crate rstest 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/rstest/0.2.2 [INFO] extracting crate rstest 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rstest/0.2.2 [INFO] validating manifest of rstest-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rstest-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rstest-0.2.2 [INFO] finished frobbing rstest-0.2.2 [INFO] frobbed toml for rstest-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/rstest/0.2.2/Cargo.toml [INFO] started frobbing rstest-0.2.2 [INFO] finished frobbing rstest-0.2.2 [INFO] frobbed toml for rstest-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rstest/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rstest-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rstest/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46e542eb6ad15e11ac33a79294772c7e0ada3e5cc652ec61fc6f721ac32c617f [INFO] running `"docker" "start" "-a" "46e542eb6ad15e11ac33a79294772c7e0ada3e5cc652ec61fc6f721ac32c617f"` [INFO] [stderr] Checking temp_testdir v0.2.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking rstest v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match meta { [INFO] [stderr] 139 | | Meta(m) => { [INFO] [stderr] 140 | | if let Some(item) = parse_meta_item(m) { [INFO] [stderr] 141 | | match item { [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | if let Meta(m) = meta { [INFO] [stderr] 139 | if let Some(item) = parse_meta_item(m) { [INFO] [stderr] 140 | match item { [INFO] [stderr] 141 | Arg(arg) => args.push(arg), [INFO] [stderr] 142 | Case(case) => cases.push(case), [INFO] [stderr] 143 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / if let &syn::FnArg::Captured(ref a) = arg { [INFO] [stderr] 182 | | let fixture = resolver [INFO] [stderr] 183 | | .resolve(arg).map(|e| e.clone()) [INFO] [stderr] 184 | | .unwrap_or_else(|| default_fixture_name(a)); [INFO] [stderr] ... | [INFO] [stderr] 187 | | None [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 181 | if let syn::FnArg::Captured(ref a) = *arg { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | let fixture = resolver [INFO] [stderr] | _______________________^ [INFO] [stderr] 183 | | .resolve(arg).map(|e| e.clone()) [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 182 | let fixture = resolver [INFO] [stderr] 183 | .resolve(arg).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | fn new(args: &Vec, case: &'a TestCase) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Ident]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | / self.0.get(&arg_name(arg).to_string()) [INFO] [stderr] 211 | | .map(|&a| a) [INFO] [stderr] | |____________________________^ help: Consider calling the dedicated `cloned` method: `self.0.get(&arg_name(arg).to_string()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Checking toml_edit v0.1.3 [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match meta { [INFO] [stderr] 139 | | Meta(m) => { [INFO] [stderr] 140 | | if let Some(item) = parse_meta_item(m) { [INFO] [stderr] 141 | | match item { [INFO] [stderr] ... | [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | if let Meta(m) = meta { [INFO] [stderr] 139 | if let Some(item) = parse_meta_item(m) { [INFO] [stderr] 140 | match item { [INFO] [stderr] 141 | Arg(arg) => args.push(arg), [INFO] [stderr] 142 | Case(case) => cases.push(case), [INFO] [stderr] 143 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / if let &syn::FnArg::Captured(ref a) = arg { [INFO] [stderr] 182 | | let fixture = resolver [INFO] [stderr] 183 | | .resolve(arg).map(|e| e.clone()) [INFO] [stderr] 184 | | .unwrap_or_else(|| default_fixture_name(a)); [INFO] [stderr] ... | [INFO] [stderr] 187 | | None [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 181 | if let syn::FnArg::Captured(ref a) = *arg { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | let fixture = resolver [INFO] [stderr] | _______________________^ [INFO] [stderr] 183 | | .resolve(arg).map(|e| e.clone()) [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 182 | let fixture = resolver [INFO] [stderr] 183 | .resolve(arg).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | fn new(args: &Vec, case: &'a TestCase) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Ident]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | / self.0.get(&arg_name(arg).to_string()) [INFO] [stderr] 211 | | .map(|&a| a) [INFO] [stderr] | |____________________________^ help: Consider calling the dedicated `cloned` method: `self.0.get(&arg_name(arg).to_string()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | / if let &syn::Item::Fn(ref item_fn) = item { [INFO] [stderr] 364 | | item_fn.decl.inputs.iter() [INFO] [stderr] 365 | | } else { [INFO] [stderr] 366 | | panic!("Wrong ast!") [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 363 | if let syn::Item::Fn(ref item_fn) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/prj/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / File::create(path) [INFO] [stderr] 136 | | .expect("cannot update Cargo.toml") [INFO] [stderr] 137 | | .write(doc.to_string().as_bytes()) [INFO] [stderr] 138 | | .expect("cannot write Cargo.toml"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/utils/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &Ok(ref s) => s.as_ref().to_owned(), [INFO] [stderr] 66 | | &Fail(ref s) => s.as_ref().to_owned() [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | Ok(ref s) => s.as_ref().to_owned(), [INFO] [stderr] 66 | Fail(ref s) => s.as_ref().to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/utils/mod.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | assert_in!(output, format!("failures:")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failures:".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/utils/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | self.0.iter().filter(|r| r.is_fail()).next().is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|r| r.is_fail()).next()` with `find(|r| r.is_fail())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rstest`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/prj/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / File::create(path) [INFO] [stderr] 136 | | .expect("cannot update Cargo.toml") [INFO] [stderr] 137 | | .write(doc.to_string().as_bytes()) [INFO] [stderr] 138 | | .expect("cannot write Cargo.toml"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/utils/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &Ok(ref s) => s.as_ref().to_owned(), [INFO] [stderr] 66 | | &Fail(ref s) => s.as_ref().to_owned() [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | Ok(ref s) => s.as_ref().to_owned(), [INFO] [stderr] 66 | Fail(ref s) => s.as_ref().to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/utils/mod.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | assert_in!(output, format!("failures:")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failures:".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> tests/utils/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | self.0.iter().filter(|r| r.is_fail()).next().is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|r| r.is_fail()).next()` with `find(|r| r.is_fail())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rstest`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "46e542eb6ad15e11ac33a79294772c7e0ada3e5cc652ec61fc6f721ac32c617f"` [INFO] running `"docker" "rm" "-f" "46e542eb6ad15e11ac33a79294772c7e0ada3e5cc652ec61fc6f721ac32c617f"` [INFO] [stdout] 46e542eb6ad15e11ac33a79294772c7e0ada3e5cc652ec61fc6f721ac32c617f