[INFO] crate rspotify 0.2.5 is already in cache
[INFO] extracting crate rspotify 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/rspotify/0.2.5
[INFO] extracting crate rspotify 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspotify/0.2.5
[INFO] validating manifest of rspotify-0.2.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rspotify-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rspotify-0.2.5
[INFO] finished frobbing rspotify-0.2.5
[INFO] frobbed toml for rspotify-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/rspotify/0.2.5/Cargo.toml
[INFO] started frobbing rspotify-0.2.5
[INFO] finished frobbing rspotify-0.2.5
[INFO] frobbed toml for rspotify-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspotify/0.2.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rspotify-0.2.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rspotify/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7a87ee2497fb86efecf836a609412c898afb4d711fbdcb01cc5fdb1698e518c1
[INFO] running `"docker" "start" "-a" "7a87ee2497fb86efecf836a609412c898afb4d711fbdcb01cc5fdb1698e518c1"`
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]     Checking tokio v0.1.15
[INFO] [stderr]     Checking dotenv v0.10.1
[INFO] [stderr]     Checking hyper v0.12.23
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking reqwest v0.9.9
[INFO] [stderr]     Checking rspotify v0.2.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             client_id: client_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             client_secret: client_secret,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 |             client_id: client_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             client_secret: client_secret,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             redirect_uri: redirect_uri,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redirect_uri`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             client_id: client_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             client_secret: client_secret,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 |             client_id: client_id,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             client_secret: client_secret,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/spotify/oauth2.rs:205:13
[INFO] [stderr]     |
[INFO] [stderr] 205 |             redirect_uri: redirect_uri,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redirect_uri`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/spotify/oauth2.rs:288:24
[INFO] [stderr]     |
[INFO] [stderr] 288 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 289 | |                     if self.is_token_expired(&token_info) {
[INFO] [stderr] 290 | |                         if let Some(refresh_token) = token_info.refresh_token {
[INFO] [stderr] 291 | |                             self.refresh_access_token(&refresh_token)
[INFO] [stderr] ...   |
[INFO] [stderr] 297 | |                     }
[INFO] [stderr] 298 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 } else if self.is_token_expired(&token_info) {
[INFO] [stderr] 289 |     if let Some(refresh_token) = token_info.refresh_token {
[INFO] [stderr] 290 |         self.refresh_access_token(&refresh_token)
[INFO] [stderr] 291 |     } else {
[INFO] [stderr] 292 |         None
[INFO] [stderr] 293 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/spotify/model/offset.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return Some(Offset { position: Some(position), uri: None })
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: Some(position), uri: None })`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/spotify/model/offset.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return Some(Offset { position: None, uri: Some(uri) })
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: None, uri: Some(uri) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/spotify/oauth2.rs:288:24
[INFO] [stderr]     |
[INFO] [stderr] 288 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 289 | |                     if self.is_token_expired(&token_info) {
[INFO] [stderr] 290 | |                         if let Some(refresh_token) = token_info.refresh_token {
[INFO] [stderr] 291 | |                             self.refresh_access_token(&refresh_token)
[INFO] [stderr] ...   |
[INFO] [stderr] 297 | |                     }
[INFO] [stderr] 298 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 } else if self.is_token_expired(&token_info) {
[INFO] [stderr] 289 |     if let Some(refresh_token) = token_info.refresh_token {
[INFO] [stderr] 290 |         self.refresh_access_token(&refresh_token)
[INFO] [stderr] 291 |     } else {
[INFO] [stderr] 292 |         None
[INFO] [stderr] 293 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/spotify/oauth2.rs:496:25
[INFO] [stderr]     |
[INFO] [stderr] 496 |             .expires_at(1515841743)
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider: `1_515_841_743`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/spotify/model/offset.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return Some(Offset { position: Some(position), uri: None })
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: Some(position), uri: None })`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/spotify/model/offset.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return Some(Offset { position: None, uri: Some(uri) })
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: None, uri: Some(uri) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/spotify/oauth2.rs:86:50
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn set_expires_at(&mut self, expires_at: &i64) {
[INFO] [stderr]    |                                                  ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/spotify/oauth2.rs:250:45
[INFO] [stderr]     |
[INFO] [stderr] 250 |           } else if self.client_id.is_empty() {
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 251 | |             true
[INFO] [stderr] 252 | |         } else {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/spotify/oauth2.rs:248:58
[INFO] [stderr]     |
[INFO] [stderr] 248 |           let empty_flag = if self.redirect_uri.is_empty() {
[INFO] [stderr]     |  __________________________________________________________^
[INFO] [stderr] 249 | |             true
[INFO] [stderr] 250 | |         } else if self.client_id.is_empty() {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:284:26
[INFO] [stderr]     |
[INFO] [stderr] 284 |                           .expect(&format!("convert [{:?}] to json failed",
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 285 | |                                         self.cache_path.display()));
[INFO] [stderr]     | |___________________________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("convert [{:?}] to json failed", self.cache_path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:421:10
[INFO] [stderr]     |
[INFO] [stderr] 421 |         .expect(&format!("create file {:?} error", path.display()));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create file {:?} error", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:423:10
[INFO] [stderr]     |
[INFO] [stderr] 423 |           .expect(&format!("clear original spoitfy-token-cache file [{:?}] failed",
[INFO] [stderr]     |  __________^
[INFO] [stderr] 424 | |                         path.display()));
[INFO] [stderr]     | |________________________________________^ help: try this: `unwrap_or_else(|_| panic!("clear original spoitfy-token-cache file [{:?}] failed", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/spotify/util.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 | V: Debug+ToString>(map: &HashMap<K, V>) -> String{
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 33 | pub fn convert_map_to_string<K: Debug + Eq + Hash+ ToString,
[INFO] [stderr] 34 | V: Debug+ToString, S: ::std::hash::BuildHasher>(map: &HashMap<K, V, S>) -> String{
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/spotify/senum.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn from_str(s: &str) -> Option<AlbumType> {
[INFO] [stderr] 14 | |         match s {
[INFO] [stderr] 15 | |             "album" => Some(AlbumType::Album),
[INFO] [stderr] 16 | |             "single" => Some(AlbumType::Single),
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/spotify/senum.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn from_str(s: &str) -> Option<Type> {
[INFO] [stderr] 55 | |         match s {
[INFO] [stderr] 56 | |             "artist" => Some(Type::Artist),
[INFO] [stderr] 57 | |             "album" => Some(Type::Album),
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         }
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/spotify/senum.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     pub fn from_str(s: &str) -> Option<TimeRange> {
[INFO] [stderr] 98  | |         match s {
[INFO] [stderr] 99  | |             "long_term" => Some(TimeRange::LongTerm),
[INFO] [stderr] 100 | |             "medium_term" => Some(TimeRange::MediumTerm),
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |         }
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/spotify/senum.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_str(s: &str) -> Option<Country> {
[INFO] [stderr] 379 | |         match s {
[INFO] [stderr] 380 | |             "AF" => Some(Country::Afghanistan),
[INFO] [stderr] 381 | |             "AX" => Some(Country::AlandIslands),
[INFO] [stderr] ...   |
[INFO] [stderr] 631 | |         }
[INFO] [stderr] 632 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/spotify/oauth2.rs:86:50
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn set_expires_at(&mut self, expires_at: &i64) {
[INFO] [stderr]    |                                                  ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/spotify/oauth2.rs:250:45
[INFO] [stderr]     |
[INFO] [stderr] 250 |           } else if self.client_id.is_empty() {
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 251 | |             true
[INFO] [stderr] 252 | |         } else {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/spotify/oauth2.rs:248:58
[INFO] [stderr]     |
[INFO] [stderr] 248 |           let empty_flag = if self.redirect_uri.is_empty() {
[INFO] [stderr]     |  __________________________________________________________^
[INFO] [stderr] 249 | |             true
[INFO] [stderr] 250 | |         } else if self.client_id.is_empty() {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:284:26
[INFO] [stderr]     |
[INFO] [stderr] 284 |                           .expect(&format!("convert [{:?}] to json failed",
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 285 | |                                         self.cache_path.display()));
[INFO] [stderr]     | |___________________________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("convert [{:?}] to json failed", self.cache_path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:421:10
[INFO] [stderr]     |
[INFO] [stderr] 421 |         .expect(&format!("create file {:?} error", path.display()));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create file {:?} error", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/spotify/oauth2.rs:423:10
[INFO] [stderr]     |
[INFO] [stderr] 423 |           .expect(&format!("clear original spoitfy-token-cache file [{:?}] failed",
[INFO] [stderr]     |  __________^
[INFO] [stderr] 424 | |                         path.display()));
[INFO] [stderr]     | |________________________________________^ help: try this: `unwrap_or_else(|_| panic!("clear original spoitfy-token-cache file [{:?}] failed", path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]     --> src/spotify/senum.rs:1157:5
[INFO] [stderr]      |
[INFO] [stderr] 1157 | /     pub fn from_str(s: &str) -> Option<RepeatState> {
[INFO] [stderr] 1158 | |         match s {
[INFO] [stderr] 1159 | |             "off" => Some(RepeatState::Off),
[INFO] [stderr] 1160 | |             "track" => Some(RepeatState::Track),
[INFO] [stderr] ...    |
[INFO] [stderr] 1163 | |         }
[INFO] [stderr] 1164 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]     --> src/spotify/senum.rs:1185:5
[INFO] [stderr]      |
[INFO] [stderr] 1185 | /     pub fn from_str(s: &str) -> Option<SearchType> {
[INFO] [stderr] 1186 | |         match s {
[INFO] [stderr] 1187 | |             "artist" => Some(SearchType::Artist),
[INFO] [stderr] 1188 | |             "album" => Some(SearchType::Album),
[INFO] [stderr] ...    |
[INFO] [stderr] 1192 | |         }
[INFO] [stderr] 1193 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference
[INFO] [stderr]     --> src/spotify/client.rs:1662:47
[INFO] [stderr]      |
[INFO] [stderr] 1662 |         let id = spotify.get_id(Type::Artist, &mut artist_id);
[INFO] [stderr]      |                                               ^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference
[INFO] [stderr]     --> src/spotify/client.rs:1668:54
[INFO] [stderr]      |
[INFO] [stderr] 1668 |                         &spotify.get_id(Type::Album, &mut artist_id_a)
[INFO] [stderr]      |                                                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference
[INFO] [stderr]     --> src/spotify/client.rs:1675:55
[INFO] [stderr]      |
[INFO] [stderr] 1675 |                         &spotify.get_id(Type::Artist, &mut artist_id_b)
[INFO] [stderr]      |                                                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference
[INFO] [stderr]     --> src/spotify/client.rs:1682:55
[INFO] [stderr]      |
[INFO] [stderr] 1682 |                         &spotify.get_id(Type::Artist, &mut artist_id_c)
[INFO] [stderr]      |                                                       ^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference
[INFO] [stderr]     --> src/spotify/client.rs:1688:57
[INFO] [stderr]      |
[INFO] [stderr] 1688 |                         &spotify.get_id(Type::Playlist, &mut playlist_id)
[INFO] [stderr]      |                                                         ^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/spotify/util.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 | V: Debug+ToString>(map: &HashMap<K, V>) -> String{
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 33 | pub fn convert_map_to_string<K: Debug + Eq + Hash+ ToString,
[INFO] [stderr] 34 | V: Debug+ToString, S: ::std::hash::BuildHasher>(map: &HashMap<K, V, S>) -> String{
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/spotify/senum.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn from_str(s: &str) -> Option<AlbumType> {
[INFO] [stderr] 14 | |         match s {
[INFO] [stderr] 15 | |             "album" => Some(AlbumType::Album),
[INFO] [stderr] 16 | |             "single" => Some(AlbumType::Single),
[INFO] [stderr] ...  |
[INFO] [stderr] 20 | |         }
[INFO] [stderr] 21 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/spotify/senum.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn from_str(s: &str) -> Option<Type> {
[INFO] [stderr] 55 | |         match s {
[INFO] [stderr] 56 | |             "artist" => Some(Type::Artist),
[INFO] [stderr] 57 | |             "album" => Some(Type::Album),
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |         }
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/spotify/senum.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     pub fn from_str(s: &str) -> Option<TimeRange> {
[INFO] [stderr] 98  | |         match s {
[INFO] [stderr] 99  | |             "long_term" => Some(TimeRange::LongTerm),
[INFO] [stderr] 100 | |             "medium_term" => Some(TimeRange::MediumTerm),
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |         }
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/spotify/senum.rs:378:5
[INFO] [stderr]     |
[INFO] [stderr] 378 | /     pub fn from_str(s: &str) -> Option<Country> {
[INFO] [stderr] 379 | |         match s {
[INFO] [stderr] 380 | |             "AF" => Some(Country::Afghanistan),
[INFO] [stderr] 381 | |             "AX" => Some(Country::AlandIslands),
[INFO] [stderr] ...   |
[INFO] [stderr] 631 | |         }
[INFO] [stderr] 632 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]     --> src/spotify/senum.rs:1157:5
[INFO] [stderr]      |
[INFO] [stderr] 1157 | /     pub fn from_str(s: &str) -> Option<RepeatState> {
[INFO] [stderr] 1158 | |         match s {
[INFO] [stderr] 1159 | |             "off" => Some(RepeatState::Off),
[INFO] [stderr] 1160 | |             "track" => Some(RepeatState::Track),
[INFO] [stderr] ...    |
[INFO] [stderr] 1163 | |         }
[INFO] [stderr] 1164 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name
[INFO] [stderr]     --> src/spotify/senum.rs:1185:5
[INFO] [stderr]      |
[INFO] [stderr] 1185 | /     pub fn from_str(s: &str) -> Option<SearchType> {
[INFO] [stderr] 1186 | |         match s {
[INFO] [stderr] 1187 | |             "artist" => Some(SearchType::Artist),
[INFO] [stderr] 1188 | |             "album" => Some(SearchType::Album),
[INFO] [stderr] ...    |
[INFO] [stderr] 1192 | |         }
[INFO] [stderr] 1193 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rspotify`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rspotify`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "7a87ee2497fb86efecf836a609412c898afb4d711fbdcb01cc5fdb1698e518c1"`
[INFO] running `"docker" "rm" "-f" "7a87ee2497fb86efecf836a609412c898afb4d711fbdcb01cc5fdb1698e518c1"`
[INFO] [stdout] 7a87ee2497fb86efecf836a609412c898afb4d711fbdcb01cc5fdb1698e518c1