[INFO] crate rspirv 0.5.4 is already in cache [INFO] extracting crate rspirv 0.5.4 into work/ex/clippy-test-run/sources/stable/reg/rspirv/0.5.4 [INFO] extracting crate rspirv 0.5.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspirv/0.5.4 [INFO] validating manifest of rspirv-0.5.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rspirv-0.5.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rspirv-0.5.4 [INFO] finished frobbing rspirv-0.5.4 [INFO] frobbed toml for rspirv-0.5.4 written to work/ex/clippy-test-run/sources/stable/reg/rspirv/0.5.4/Cargo.toml [INFO] started frobbing rspirv-0.5.4 [INFO] finished frobbing rspirv-0.5.4 [INFO] frobbed toml for rspirv-0.5.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspirv/0.5.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rspirv-0.5.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rspirv/0.5.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73ebdac454ab27d9a25471e13291e08a186aeca404f06f04683c4dc836380763 [INFO] running `"docker" "start" "-a" "73ebdac454ab27d9a25471e13291e08a186aeca404f06f04683c4dc836380763"` [INFO] [stderr] Compiling derive_more v0.7.1 [INFO] [stderr] Checking rspirv v0.5.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> binary/decoder.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/decoder.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/decoder.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/error.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> binary/parser.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | consumer: consumer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/parser.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | bound: bound, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | result_type: result_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | result_id: result_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | operands: operands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sr/constants.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | ConstantToken { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sr/types.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | TypeToken { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> binary/decoder.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/decoder.rs:272:5 [INFO] [stderr] | [INFO] [stderr] 272 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/decoder.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/error.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> binary/parser.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | consumer: consumer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> binary/parser.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | bound: bound, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bound` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | result_type: result_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | result_id: result_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> mr/constructs.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | operands: operands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sr/constants.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | ConstantToken { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> sr/types.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | TypeToken { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | generator: 0x000f0000, // TODO: lower 16-bit: tool version number [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | let tool = (self.generator & 0xffff0000) >> 16; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | let mut low = u32_to_bytes((val & 0xffffffff) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | let mut high = u32_to_bytes(((val >> 32) & 0xffffffff) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/version.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | (((version & 0xff0000) >> 16) as u8, ((version & 0xff00) >> 8) as u8) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/assemble.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | 0x000f0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/assemble.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | 0x000f0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(Ok(0x78563412), d.word()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:279:28 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(Ok(vec![0x78563412, 0xefcdab90]), d.words(2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:279:40 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(Ok(vec![0x78563412, 0xefcdab90]), d.words(2)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xefcd_ab90` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:280:28 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(Ok(vec![0x67452301]), d.words(1)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6745_2301` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:281:28 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(Ok(vec![0xbadcfe89]), d.words(1)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbadc_fe89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:326:56 [INFO] [stderr] | [INFO] [stderr] 326 | assert_eq!(Err(Error::ExecutionModelUnknown(0, 0xdeadbeef)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:360:23 [INFO] [stderr] | [INFO] [stderr] 360 | assert_eq!(Ok(0x78563412), d.word()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:388:23 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(Ok(0xffffffff), d.word()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:391:23 [INFO] [stderr] | [INFO] [stderr] 391 | assert_eq!(Ok(0xffffffff), d.word()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:402:23 [INFO] [stderr] | [INFO] [stderr] 402 | assert_eq!(Ok(0xffffffff), d.word()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/decoder.rs:419:23 [INFO] [stderr] | [INFO] [stderr] 419 | assert_eq!(Ok(0xefcdab9078563412), d.int64()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xefcd_ab90_7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:934:51 [INFO] [stderr] | [INFO] [stderr] 934 | assert_eq!(vec![mr::Operand::LiteralInt32(0x78563412)], inst.operands); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:960:51 [INFO] [stderr] | [INFO] [stderr] 960 | assert_eq!(vec![mr::Operand::LiteralInt64(0xefcdab9078563412)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xefcd_ab90_7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:1163:26 [INFO] [stderr] | [INFO] [stderr] 1163 | let words = vec![0x07230203, 0x01000000, 0, 0, 0, 0x00020011, 0x00000016]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0723_0203` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:1163:38 [INFO] [stderr] | [INFO] [stderr] 1163 | let words = vec![0x07230203, 0x01000000, 0, 0, 0, 0x00020011, 0x00000016]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:1163:59 [INFO] [stderr] | [INFO] [stderr] 1163 | let words = vec![0x07230203, 0x01000000, 0, 0, 0, 0x00020011, 0x00000016]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> binary/parser.rs:1163:71 [INFO] [stderr] | [INFO] [stderr] 1163 | let words = vec![0x07230203, 0x01000000, 0, 0, 0, 0x00020011, 0x00000016]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | generator: 0x000f0000, // TODO: lower 16-bit: tool version number [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:209:38 [INFO] [stderr] | [INFO] [stderr] 209 | let tool = (self.generator & 0xffff0000) >> 16; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:302:46 [INFO] [stderr] | [INFO] [stderr] 302 | assert_eq!(mr::Operand::LiteralInt64(128934u64), [INFO] [stderr] | ^^^^^^^^^ help: consider: `128_934u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> mr/constructs.rs:303:38 [INFO] [stderr] | [INFO] [stderr] 303 | mr::Operand::from(128934u64)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `128_934u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | let mut low = u32_to_bytes((val & 0xffffffff) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | let mut high = u32_to_bytes(((val >> 32) & 0xffffffff) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:77:63 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(vec![0x12, 0x34, 0x56, 0x78], u32_to_bytes(0x78563412)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | u64_to_bytes(0xefcdab9078563412)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xefcd_ab90_7856_3412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(0x78563412u32, bytes_to_u32_le(&[0x12, 0x34, 0x56, 0x78])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x7856_3412u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/num.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(0x563412u32, bytes_to_u32_le(&[0x12, 0x34, 0x56])); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0056_3412u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> utils/version.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | (((version & 0xff0000) >> 16) as u8, ((version & 0xff00) >> 8) as u8) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | (word << 8) | (self.bytes[self.offset - i - 1]) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((self.bytes[self.offset - i - 1]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(((high as u64) << 32) | (low as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:205:36 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(((high as u64) << 32) | (low as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> binary/decoder.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(unsafe { mem::transmute::(val) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | let val = ((high as u64) << 32) | (low as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:220:43 [INFO] [stderr] | [INFO] [stderr] 220 | let val = ((high as u64) << 32) | (low as u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> binary/decoder.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | Ok(unsafe { mem::transmute::(val) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | spirv::ImageOperands::from_bits(word).ok_or(Error::ImageOperandsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageOperandsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:36:52 [INFO] [stderr] | [INFO] [stderr] 36 | spirv::FPFastMathMode::from_bits(word).ok_or(Error::FPFastMathModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FPFastMathModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:46:54 [INFO] [stderr] | [INFO] [stderr] 46 | spirv::SelectionControl::from_bits(word).ok_or(Error::SelectionControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SelectionControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:56:49 [INFO] [stderr] | [INFO] [stderr] 56 | spirv::LoopControl::from_bits(word).ok_or(Error::LoopControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::LoopControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | spirv::FunctionControl::from_bits(word).ok_or(Error::FunctionControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FunctionControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:76:53 [INFO] [stderr] | [INFO] [stderr] 76 | spirv::MemorySemantics::from_bits(word).ok_or(Error::MemorySemanticsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemorySemanticsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | spirv::MemoryAccess::from_bits(word).ok_or(Error::MemoryAccessUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemoryAccessUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | spirv::KernelProfilingInfo::from_bits(word).ok_or(Error::KernelProfilingInfoUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::KernelProfilingInfoUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:106:51 [INFO] [stderr] | [INFO] [stderr] 106 | spirv::SourceLanguage::from_u32(word).ok_or(Error::SourceLanguageUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SourceLanguageUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:116:51 [INFO] [stderr] | [INFO] [stderr] 116 | spirv::ExecutionModel::from_u32(word).ok_or(Error::ExecutionModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ExecutionModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | spirv::AddressingModel::from_u32(word).ok_or(Error::AddressingModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::AddressingModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:136:48 [INFO] [stderr] | [INFO] [stderr] 136 | spirv::MemoryModel::from_u32(word).ok_or(Error::MemoryModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemoryModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:146:50 [INFO] [stderr] | [INFO] [stderr] 146 | spirv::ExecutionMode::from_u32(word).ok_or(Error::ExecutionModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ExecutionModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:156:49 [INFO] [stderr] | [INFO] [stderr] 156 | spirv::StorageClass::from_u32(word).ok_or(Error::StorageClassUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::StorageClassUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | spirv::Dim::from_u32(word).ok_or(Error::DimUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::DimUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:176:58 [INFO] [stderr] | [INFO] [stderr] 176 | spirv::SamplerAddressingMode::from_u32(word).ok_or(Error::SamplerAddressingModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SamplerAddressingModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:186:54 [INFO] [stderr] | [INFO] [stderr] 186 | spirv::SamplerFilterMode::from_u32(word).ok_or(Error::SamplerFilterModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SamplerFilterModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:196:48 [INFO] [stderr] | [INFO] [stderr] 196 | spirv::ImageFormat::from_u32(word).ok_or(Error::ImageFormatUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageFormatUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:206:54 [INFO] [stderr] | [INFO] [stderr] 206 | spirv::ImageChannelOrder::from_u32(word).ok_or(Error::ImageChannelOrderUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageChannelOrderUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:216:57 [INFO] [stderr] | [INFO] [stderr] 216 | spirv::ImageChannelDataType::from_u32(word).ok_or(Error::ImageChannelDataTypeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageChannelDataTypeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:226:51 [INFO] [stderr] | [INFO] [stderr] 226 | spirv::FPRoundingMode::from_u32(word).ok_or(Error::FPRoundingModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FPRoundingModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:236:48 [INFO] [stderr] | [INFO] [stderr] 236 | spirv::LinkageType::from_u32(word).ok_or(Error::LinkageTypeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::LinkageTypeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:246:52 [INFO] [stderr] | [INFO] [stderr] 246 | spirv::AccessQualifier::from_u32(word).ok_or(Error::AccessQualifierUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::AccessQualifierUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:256:63 [INFO] [stderr] | [INFO] [stderr] 256 | spirv::FunctionParameterAttribute::from_u32(word).ok_or(Error::FunctionParameterAttributeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FunctionParameterAttributeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:266:47 [INFO] [stderr] | [INFO] [stderr] 266 | spirv::Decoration::from_u32(word).ok_or(Error::DecorationUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::DecorationUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:276:44 [INFO] [stderr] | [INFO] [stderr] 276 | spirv::BuiltIn::from_u32(word).ok_or(Error::BuiltInUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::BuiltInUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:286:42 [INFO] [stderr] | [INFO] [stderr] 286 | spirv::Scope::from_u32(word).ok_or(Error::ScopeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ScopeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:296:51 [INFO] [stderr] | [INFO] [stderr] 296 | spirv::GroupOperation::from_u32(word).ok_or(Error::GroupOperationUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::GroupOperationUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:306:55 [INFO] [stderr] | [INFO] [stderr] 306 | spirv::KernelEnqueueFlags::from_u32(word).ok_or(Error::KernelEnqueueFlagsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::KernelEnqueueFlagsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:316:47 [INFO] [stderr] | [INFO] [stderr] 316 | spirv::Capability::from_u32(word).ok_or(Error::CapabilityUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::CapabilityUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/builder.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | Ok(self.module.functions.push(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 200 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/builder.rs:255:12 [INFO] [stderr] | [INFO] [stderr] 255 | Ok(self.function.as_mut().unwrap().basic_blocks.push( [INFO] [stderr] | ____________^ [INFO] [stderr] 256 | | self.basic_block.take().unwrap(), [INFO] [stderr] 257 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 255 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_type.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn type_image(&mut self, sampled_type: spirv::Word, dim: spirv::Dim, depth: u32, arrayed: u32, ms: u32, sampled: u32, image_format: spirv::ImageFormat, access_qualifier: Option) -> spirv::Word { [INFO] [stderr] 64 | | let id = self.id(); [INFO] [stderr] 65 | | self.module.types_global_values.push(mr::Instruction::new(spirv::Op::TypeImage, None, Some(id), vec![mr::Operand::IdRef(sampled_type), mr::Operand::Dim(dim), mr::Operand::LiteralInt32(depth), mr::Operand::LiteralInt32(arrayed), mr::Operand::LiteralInt32(ms), mr::Operand::LiteralInt32(sampled), mr::Operand::ImageFormat(image_format)])); [INFO] [stderr] 66 | | if let Some(v) = access_qualifier { [INFO] [stderr] ... | [INFO] [stderr] 69 | | id [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 118 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | / pub fn image_sample_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 403 | | if self.basic_block.is_none() { [INFO] [stderr] 404 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 405 | | } [INFO] [stderr] ... | [INFO] [stderr] 416 | | Ok(_id) [INFO] [stderr] 417 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / pub fn image_sample_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 421 | | if self.basic_block.is_none() { [INFO] [stderr] 422 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 423 | | } [INFO] [stderr] ... | [INFO] [stderr] 431 | | Ok(_id) [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:468:5 [INFO] [stderr] | [INFO] [stderr] 468 | / pub fn image_sample_proj_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 469 | | if self.basic_block.is_none() { [INFO] [stderr] 470 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 471 | | } [INFO] [stderr] ... | [INFO] [stderr] 482 | | Ok(_id) [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | / pub fn image_sample_proj_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 487 | | if self.basic_block.is_none() { [INFO] [stderr] 488 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 489 | | } [INFO] [stderr] ... | [INFO] [stderr] 497 | | Ok(_id) [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / pub fn image_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, component: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 520 | | if self.basic_block.is_none() { [INFO] [stderr] 521 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 533 | | Ok(_id) [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | / pub fn image_dref_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 538 | | if self.basic_block.is_none() { [INFO] [stderr] 539 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 540 | | } [INFO] [stderr] ... | [INFO] [stderr] 551 | | Ok(_id) [INFO] [stderr] 552 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:582:12 [INFO] [stderr] | [INFO] [stderr] 582 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 582 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1328:19 [INFO] [stderr] | [INFO] [stderr] 1328 | pub fn is_nan(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1342:19 [INFO] [stderr] | [INFO] [stderr] 1342 | pub fn is_inf(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1356:22 [INFO] [stderr] | [INFO] [stderr] 1356 | pub fn is_finite(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1370:22 [INFO] [stderr] | [INFO] [stderr] 1370 | pub fn is_normal(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2131:12 [INFO] [stderr] | [INFO] [stderr] 2131 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2140:12 [INFO] [stderr] | [INFO] [stderr] 2140 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2140 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2149:12 [INFO] [stderr] | [INFO] [stderr] 2149 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2149 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2158:12 [INFO] [stderr] | [INFO] [stderr] 2158 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2158 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2167:12 [INFO] [stderr] | [INFO] [stderr] 2167 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2167 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2176:12 [INFO] [stderr] | [INFO] [stderr] 2176 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2176 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2199:12 [INFO] [stderr] | [INFO] [stderr] 2199 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2199 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2217:5 [INFO] [stderr] | [INFO] [stderr] 2217 | / pub fn atomic_compare_exchange(&mut self, result_type: spirv::Word, result_id: Option, pointer: spirv::Word, scope: spirv::Word, equal: spirv::Word, unequal: spirv::Word, value: spirv::Word, comparator: spirv::Word) -> BuildResult { [INFO] [stderr] 2218 | | if self.basic_block.is_none() { [INFO] [stderr] 2219 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2220 | | } [INFO] [stderr] ... | [INFO] [stderr] 2227 | | Ok(_id) [INFO] [stderr] 2228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2231:5 [INFO] [stderr] | [INFO] [stderr] 2231 | / pub fn atomic_compare_exchange_weak(&mut self, result_type: spirv::Word, result_id: Option, pointer: spirv::Word, scope: spirv::Word, equal: spirv::Word, unequal: spirv::Word, value: spirv::Word, comparator: spirv::Word) -> BuildResult { [INFO] [stderr] 2232 | | if self.basic_block.is_none() { [INFO] [stderr] 2233 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2234 | | } [INFO] [stderr] ... | [INFO] [stderr] 2241 | | Ok(_id) [INFO] [stderr] 2242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2423:12 [INFO] [stderr] | [INFO] [stderr] 2423 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2423 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2432:12 [INFO] [stderr] | [INFO] [stderr] 2432 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2432 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2441:12 [INFO] [stderr] | [INFO] [stderr] 2441 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2441 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2450:12 [INFO] [stderr] | [INFO] [stderr] 2450 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2450 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2454:5 [INFO] [stderr] | [INFO] [stderr] 2454 | / pub fn group_async_copy(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, destination: spirv::Word, source: spirv::Word, num_elements: spirv::Word, stride: spirv::Word, event: spirv::Word) -> BuildResult { [INFO] [stderr] 2455 | | if self.basic_block.is_none() { [INFO] [stderr] 2456 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2457 | | } [INFO] [stderr] ... | [INFO] [stderr] 2464 | | Ok(_id) [INFO] [stderr] 2465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2473:12 [INFO] [stderr] | [INFO] [stderr] 2473 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2473 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2659:5 [INFO] [stderr] | [INFO] [stderr] 2659 | / pub fn reserved_read_pipe(&mut self, result_type: spirv::Word, result_id: Option, pipe: spirv::Word, reserve_id: spirv::Word, index: spirv::Word, pointer: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2660 | | if self.basic_block.is_none() { [INFO] [stderr] 2661 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2662 | | } [INFO] [stderr] ... | [INFO] [stderr] 2669 | | Ok(_id) [INFO] [stderr] 2670 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2673:5 [INFO] [stderr] | [INFO] [stderr] 2673 | / pub fn reserved_write_pipe(&mut self, result_type: spirv::Word, result_id: Option, pipe: spirv::Word, reserve_id: spirv::Word, index: spirv::Word, pointer: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2674 | | if self.basic_block.is_none() { [INFO] [stderr] 2675 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2676 | | } [INFO] [stderr] ... | [INFO] [stderr] 2683 | | Ok(_id) [INFO] [stderr] 2684 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2720:12 [INFO] [stderr] | [INFO] [stderr] 2720 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2720 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2729:12 [INFO] [stderr] | [INFO] [stderr] 2729 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2729 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:2733:32 [INFO] [stderr] | [INFO] [stderr] 2733 | pub fn is_valid_reserve_id(&mut self, result_type: spirv::Word, result_id: Option, reserve_id: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2775:5 [INFO] [stderr] | [INFO] [stderr] 2775 | / pub fn group_reserve_read_pipe_packets(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, pipe: spirv::Word, num_packets: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2776 | | if self.basic_block.is_none() { [INFO] [stderr] 2777 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2778 | | } [INFO] [stderr] ... | [INFO] [stderr] 2785 | | Ok(_id) [INFO] [stderr] 2786 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2789:5 [INFO] [stderr] | [INFO] [stderr] 2789 | / pub fn group_reserve_write_pipe_packets(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, pipe: spirv::Word, num_packets: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2790 | | if self.basic_block.is_none() { [INFO] [stderr] 2791 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2792 | | } [INFO] [stderr] ... | [INFO] [stderr] 2799 | | Ok(_id) [INFO] [stderr] 2800 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2808:12 [INFO] [stderr] | [INFO] [stderr] 2808 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2808 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2817:12 [INFO] [stderr] | [INFO] [stderr] 2817 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2817 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2835:5 [INFO] [stderr] | [INFO] [stderr] 2835 | / pub fn enqueue_kernel>(&mut self, result_type: spirv::Word, result_id: Option, queue: spirv::Word, flags: spirv::Word, nd_range: spirv::Word, num_events: spirv::Word, wait_events: spirv::Word, ret_event: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word, local_size: T) -> BuildResult { [INFO] [stderr] 2836 | | if self.basic_block.is_none() { [INFO] [stderr] 2837 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2838 | | } [INFO] [stderr] ... | [INFO] [stderr] 2848 | | Ok(_id) [INFO] [stderr] 2849 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2852:5 [INFO] [stderr] | [INFO] [stderr] 2852 | / pub fn get_kernel_ndrange_sub_group_count(&mut self, result_type: spirv::Word, result_id: Option, nd_range: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 2853 | | if self.basic_block.is_none() { [INFO] [stderr] 2854 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2855 | | } [INFO] [stderr] ... | [INFO] [stderr] 2862 | | Ok(_id) [INFO] [stderr] 2863 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2866:5 [INFO] [stderr] | [INFO] [stderr] 2866 | / pub fn get_kernel_ndrange_max_sub_group_size(&mut self, result_type: spirv::Word, result_id: Option, nd_range: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 2867 | | if self.basic_block.is_none() { [INFO] [stderr] 2868 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2869 | | } [INFO] [stderr] ... | [INFO] [stderr] 2876 | | Ok(_id) [INFO] [stderr] 2877 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2913:12 [INFO] [stderr] | [INFO] [stderr] 2913 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2913 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2922:12 [INFO] [stderr] | [INFO] [stderr] 2922 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2922 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:2940:27 [INFO] [stderr] | [INFO] [stderr] 2940 | pub fn is_valid_event(&mut self, result_type: spirv::Word, result_id: Option, event: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2959:12 [INFO] [stderr] | [INFO] [stderr] 2959 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2959 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2968:12 [INFO] [stderr] | [INFO] [stderr] 2968 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2968 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3033:5 [INFO] [stderr] | [INFO] [stderr] 3033 | / pub fn image_sparse_sample_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3034 | | if self.basic_block.is_none() { [INFO] [stderr] 3035 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3036 | | } [INFO] [stderr] ... | [INFO] [stderr] 3047 | | Ok(_id) [INFO] [stderr] 3048 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3051:5 [INFO] [stderr] | [INFO] [stderr] 3051 | / pub fn image_sparse_sample_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 3052 | | if self.basic_block.is_none() { [INFO] [stderr] 3053 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3054 | | } [INFO] [stderr] ... | [INFO] [stderr] 3062 | | Ok(_id) [INFO] [stderr] 3063 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3099:5 [INFO] [stderr] | [INFO] [stderr] 3099 | / pub fn image_sparse_sample_proj_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3100 | | if self.basic_block.is_none() { [INFO] [stderr] 3101 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3102 | | } [INFO] [stderr] ... | [INFO] [stderr] 3113 | | Ok(_id) [INFO] [stderr] 3114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3117:5 [INFO] [stderr] | [INFO] [stderr] 3117 | / pub fn image_sparse_sample_proj_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 3118 | | if self.basic_block.is_none() { [INFO] [stderr] 3119 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3120 | | } [INFO] [stderr] ... | [INFO] [stderr] 3128 | | Ok(_id) [INFO] [stderr] 3129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3150:5 [INFO] [stderr] | [INFO] [stderr] 3150 | / pub fn image_sparse_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, component: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3151 | | if self.basic_block.is_none() { [INFO] [stderr] 3152 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3153 | | } [INFO] [stderr] ... | [INFO] [stderr] 3164 | | Ok(_id) [INFO] [stderr] 3165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3168:5 [INFO] [stderr] | [INFO] [stderr] 3168 | / pub fn image_sparse_dref_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3169 | | if self.basic_block.is_none() { [INFO] [stderr] 3170 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3171 | | } [INFO] [stderr] ... | [INFO] [stderr] 3182 | | Ok(_id) [INFO] [stderr] 3183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:3219:12 [INFO] [stderr] | [INFO] [stderr] 3219 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 3219 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3269:5 [INFO] [stderr] | [INFO] [stderr] 3269 | / pub fn get_kernel_local_size_for_subgroup_count(&mut self, result_type: spirv::Word, result_id: Option, subgroup_count: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 3270 | | if self.basic_block.is_none() { [INFO] [stderr] 3271 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3272 | | } [INFO] [stderr] ... | [INFO] [stderr] 3279 | | Ok(_id) [INFO] [stderr] 3280 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:3316:12 [INFO] [stderr] | [INFO] [stderr] 3316 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 3316 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:4143:12 [INFO] [stderr] | [INFO] [stderr] 4143 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4143 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:4166:12 [INFO] [stderr] | [INFO] [stderr] 4166 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4166 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | (word << 8) | (self.bytes[self.offset - i - 1]) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((self.bytes[self.offset - i - 1]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(((high as u64) << 32) | (low as u64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:205:36 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(((high as u64) << 32) | (low as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> binary/decoder.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(unsafe { mem::transmute::(val) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | let val = ((high as u64) << 32) | (low as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> binary/decoder.rs:220:43 [INFO] [stderr] | [INFO] [stderr] 220 | let val = ((high as u64) << 32) | (low as u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> binary/decoder.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | Ok(unsafe { mem::transmute::(val) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | spirv::ImageOperands::from_bits(word).ok_or(Error::ImageOperandsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageOperandsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:36:52 [INFO] [stderr] | [INFO] [stderr] 36 | spirv::FPFastMathMode::from_bits(word).ok_or(Error::FPFastMathModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FPFastMathModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:46:54 [INFO] [stderr] | [INFO] [stderr] 46 | spirv::SelectionControl::from_bits(word).ok_or(Error::SelectionControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SelectionControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:56:49 [INFO] [stderr] | [INFO] [stderr] 56 | spirv::LoopControl::from_bits(word).ok_or(Error::LoopControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::LoopControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | spirv::FunctionControl::from_bits(word).ok_or(Error::FunctionControlUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FunctionControlUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:76:53 [INFO] [stderr] | [INFO] [stderr] 76 | spirv::MemorySemantics::from_bits(word).ok_or(Error::MemorySemanticsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemorySemanticsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | spirv::MemoryAccess::from_bits(word).ok_or(Error::MemoryAccessUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemoryAccessUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | spirv::KernelProfilingInfo::from_bits(word).ok_or(Error::KernelProfilingInfoUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::KernelProfilingInfoUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:106:51 [INFO] [stderr] | [INFO] [stderr] 106 | spirv::SourceLanguage::from_u32(word).ok_or(Error::SourceLanguageUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SourceLanguageUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> mr/constructs.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | self.version = ((major as u32) << 16) | ((minor as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> mr/constructs.rs:199:50 [INFO] [stderr] | [INFO] [stderr] 199 | self.version = ((major as u32) << 16) | ((minor as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:116:51 [INFO] [stderr] | [INFO] [stderr] 116 | spirv::ExecutionModel::from_u32(word).ok_or(Error::ExecutionModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ExecutionModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | spirv::AddressingModel::from_u32(word).ok_or(Error::AddressingModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::AddressingModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:136:48 [INFO] [stderr] | [INFO] [stderr] 136 | spirv::MemoryModel::from_u32(word).ok_or(Error::MemoryModelUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MemoryModelUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:146:50 [INFO] [stderr] | [INFO] [stderr] 146 | spirv::ExecutionMode::from_u32(word).ok_or(Error::ExecutionModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ExecutionModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:156:49 [INFO] [stderr] | [INFO] [stderr] 156 | spirv::StorageClass::from_u32(word).ok_or(Error::StorageClassUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::StorageClassUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | spirv::Dim::from_u32(word).ok_or(Error::DimUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::DimUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:176:58 [INFO] [stderr] | [INFO] [stderr] 176 | spirv::SamplerAddressingMode::from_u32(word).ok_or(Error::SamplerAddressingModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SamplerAddressingModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:186:54 [INFO] [stderr] | [INFO] [stderr] 186 | spirv::SamplerFilterMode::from_u32(word).ok_or(Error::SamplerFilterModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::SamplerFilterModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:196:48 [INFO] [stderr] | [INFO] [stderr] 196 | spirv::ImageFormat::from_u32(word).ok_or(Error::ImageFormatUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageFormatUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:206:54 [INFO] [stderr] | [INFO] [stderr] 206 | spirv::ImageChannelOrder::from_u32(word).ok_or(Error::ImageChannelOrderUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageChannelOrderUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:216:57 [INFO] [stderr] | [INFO] [stderr] 216 | spirv::ImageChannelDataType::from_u32(word).ok_or(Error::ImageChannelDataTypeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ImageChannelDataTypeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:226:51 [INFO] [stderr] | [INFO] [stderr] 226 | spirv::FPRoundingMode::from_u32(word).ok_or(Error::FPRoundingModeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FPRoundingModeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:236:48 [INFO] [stderr] | [INFO] [stderr] 236 | spirv::LinkageType::from_u32(word).ok_or(Error::LinkageTypeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::LinkageTypeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:246:52 [INFO] [stderr] | [INFO] [stderr] 246 | spirv::AccessQualifier::from_u32(word).ok_or(Error::AccessQualifierUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::AccessQualifierUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:256:63 [INFO] [stderr] | [INFO] [stderr] 256 | spirv::FunctionParameterAttribute::from_u32(word).ok_or(Error::FunctionParameterAttributeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::FunctionParameterAttributeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:266:47 [INFO] [stderr] | [INFO] [stderr] 266 | spirv::Decoration::from_u32(word).ok_or(Error::DecorationUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::DecorationUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:276:44 [INFO] [stderr] | [INFO] [stderr] 276 | spirv::BuiltIn::from_u32(word).ok_or(Error::BuiltInUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::BuiltInUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:286:42 [INFO] [stderr] | [INFO] [stderr] 286 | spirv::Scope::from_u32(word).ok_or(Error::ScopeUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::ScopeUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:296:51 [INFO] [stderr] | [INFO] [stderr] 296 | spirv::GroupOperation::from_u32(word).ok_or(Error::GroupOperationUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::GroupOperationUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:306:55 [INFO] [stderr] | [INFO] [stderr] 306 | spirv::KernelEnqueueFlags::from_u32(word).ok_or(Error::KernelEnqueueFlagsUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::KernelEnqueueFlagsUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> binary/decode_operand.rs:316:47 [INFO] [stderr] | [INFO] [stderr] 316 | spirv::Capability::from_u32(word).ok_or(Error::CapabilityUnknown(self.offset - WORD_NUM_BYTES, word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::CapabilityUnknown(self.offset - WORD_NUM_BYTES, word))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> sr/constants.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub(in sr) fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sr::context::Context` [INFO] [stderr] --> sr/context.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Context { [INFO] [stderr] 40 | | Context { [INFO] [stderr] 41 | | types: vec![], [INFO] [stderr] 42 | | constants: vec![], [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> sr/type_creation.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn type_image( [INFO] [stderr] 102 | | &mut self, [INFO] [stderr] 103 | | sampled_type: TypeToken, [INFO] [stderr] 104 | | dim: spirv::Dim, [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> binary/decoder.rs:367:5 [INFO] [stderr] | [INFO] [stderr] 367 | / fn test_limit() { [INFO] [stderr] 368 | | let mut v = vec![]; [INFO] [stderr] 369 | | for _ in 0..12 { [INFO] [stderr] 370 | | v.push(0xff); [INFO] [stderr] ... | [INFO] [stderr] 412 | | assert_eq!(Err(Error::StreamExpected(12)), d.word()); [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> sr/types.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | pub(in sr) fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> utils/num.rs:60:30 [INFO] [stderr] | [INFO] [stderr] 60 | word = (word << 8) | (values[len - i - 1] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(values[len - i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/builder.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | Ok(self.module.functions.push(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 200 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/builder.rs:255:12 [INFO] [stderr] | [INFO] [stderr] 255 | Ok(self.function.as_mut().unwrap().basic_blocks.push( [INFO] [stderr] | ____________^ [INFO] [stderr] 256 | | self.basic_block.take().unwrap(), [INFO] [stderr] 257 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 255 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_type.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn type_image(&mut self, sampled_type: spirv::Word, dim: spirv::Dim, depth: u32, arrayed: u32, ms: u32, sampled: u32, image_format: spirv::ImageFormat, access_qualifier: Option) -> spirv::Word { [INFO] [stderr] 64 | | let id = self.id(); [INFO] [stderr] 65 | | self.module.types_global_values.push(mr::Instruction::new(spirv::Op::TypeImage, None, Some(id), vec![mr::Operand::IdRef(sampled_type), mr::Operand::Dim(dim), mr::Operand::LiteralInt32(depth), mr::Operand::LiteralInt32(arrayed), mr::Operand::LiteralInt32(ms), mr::Operand::LiteralInt32(sampled), mr::Operand::ImageFormat(image_format)])); [INFO] [stderr] 66 | | if let Some(v) = access_qualifier { [INFO] [stderr] ... | [INFO] [stderr] 69 | | id [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 118 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | / pub fn image_sample_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 403 | | if self.basic_block.is_none() { [INFO] [stderr] 404 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 405 | | } [INFO] [stderr] ... | [INFO] [stderr] 416 | | Ok(_id) [INFO] [stderr] 417 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / pub fn image_sample_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 421 | | if self.basic_block.is_none() { [INFO] [stderr] 422 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 423 | | } [INFO] [stderr] ... | [INFO] [stderr] 431 | | Ok(_id) [INFO] [stderr] 432 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:468:5 [INFO] [stderr] | [INFO] [stderr] 468 | / pub fn image_sample_proj_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 469 | | if self.basic_block.is_none() { [INFO] [stderr] 470 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 471 | | } [INFO] [stderr] ... | [INFO] [stderr] 482 | | Ok(_id) [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | / pub fn image_sample_proj_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 487 | | if self.basic_block.is_none() { [INFO] [stderr] 488 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 489 | | } [INFO] [stderr] ... | [INFO] [stderr] 497 | | Ok(_id) [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:519:5 [INFO] [stderr] | [INFO] [stderr] 519 | / pub fn image_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, component: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 520 | | if self.basic_block.is_none() { [INFO] [stderr] 521 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 533 | | Ok(_id) [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | / pub fn image_dref_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 538 | | if self.basic_block.is_none() { [INFO] [stderr] 539 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 540 | | } [INFO] [stderr] ... | [INFO] [stderr] 551 | | Ok(_id) [INFO] [stderr] 552 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:582:12 [INFO] [stderr] | [INFO] [stderr] 582 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 582 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1328:19 [INFO] [stderr] | [INFO] [stderr] 1328 | pub fn is_nan(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1342:19 [INFO] [stderr] | [INFO] [stderr] 1342 | pub fn is_inf(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1356:22 [INFO] [stderr] | [INFO] [stderr] 1356 | pub fn is_finite(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:1370:22 [INFO] [stderr] | [INFO] [stderr] 1370 | pub fn is_normal(&mut self, result_type: spirv::Word, result_id: Option, x: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2131:12 [INFO] [stderr] | [INFO] [stderr] 2131 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2140:12 [INFO] [stderr] | [INFO] [stderr] 2140 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2140 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2149:12 [INFO] [stderr] | [INFO] [stderr] 2149 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2149 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2158:12 [INFO] [stderr] | [INFO] [stderr] 2158 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2158 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2167:12 [INFO] [stderr] | [INFO] [stderr] 2167 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2167 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2176:12 [INFO] [stderr] | [INFO] [stderr] 2176 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2176 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2199:12 [INFO] [stderr] | [INFO] [stderr] 2199 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2199 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2217:5 [INFO] [stderr] | [INFO] [stderr] 2217 | / pub fn atomic_compare_exchange(&mut self, result_type: spirv::Word, result_id: Option, pointer: spirv::Word, scope: spirv::Word, equal: spirv::Word, unequal: spirv::Word, value: spirv::Word, comparator: spirv::Word) -> BuildResult { [INFO] [stderr] 2218 | | if self.basic_block.is_none() { [INFO] [stderr] 2219 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2220 | | } [INFO] [stderr] ... | [INFO] [stderr] 2227 | | Ok(_id) [INFO] [stderr] 2228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2231:5 [INFO] [stderr] | [INFO] [stderr] 2231 | / pub fn atomic_compare_exchange_weak(&mut self, result_type: spirv::Word, result_id: Option, pointer: spirv::Word, scope: spirv::Word, equal: spirv::Word, unequal: spirv::Word, value: spirv::Word, comparator: spirv::Word) -> BuildResult { [INFO] [stderr] 2232 | | if self.basic_block.is_none() { [INFO] [stderr] 2233 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2234 | | } [INFO] [stderr] ... | [INFO] [stderr] 2241 | | Ok(_id) [INFO] [stderr] 2242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2423:12 [INFO] [stderr] | [INFO] [stderr] 2423 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2423 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2432:12 [INFO] [stderr] | [INFO] [stderr] 2432 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2432 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2441:12 [INFO] [stderr] | [INFO] [stderr] 2441 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2441 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2450:12 [INFO] [stderr] | [INFO] [stderr] 2450 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2450 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2454:5 [INFO] [stderr] | [INFO] [stderr] 2454 | / pub fn group_async_copy(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, destination: spirv::Word, source: spirv::Word, num_elements: spirv::Word, stride: spirv::Word, event: spirv::Word) -> BuildResult { [INFO] [stderr] 2455 | | if self.basic_block.is_none() { [INFO] [stderr] 2456 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2457 | | } [INFO] [stderr] ... | [INFO] [stderr] 2464 | | Ok(_id) [INFO] [stderr] 2465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2473:12 [INFO] [stderr] | [INFO] [stderr] 2473 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2473 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2659:5 [INFO] [stderr] | [INFO] [stderr] 2659 | / pub fn reserved_read_pipe(&mut self, result_type: spirv::Word, result_id: Option, pipe: spirv::Word, reserve_id: spirv::Word, index: spirv::Word, pointer: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2660 | | if self.basic_block.is_none() { [INFO] [stderr] 2661 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2662 | | } [INFO] [stderr] ... | [INFO] [stderr] 2669 | | Ok(_id) [INFO] [stderr] 2670 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2673:5 [INFO] [stderr] | [INFO] [stderr] 2673 | / pub fn reserved_write_pipe(&mut self, result_type: spirv::Word, result_id: Option, pipe: spirv::Word, reserve_id: spirv::Word, index: spirv::Word, pointer: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2674 | | if self.basic_block.is_none() { [INFO] [stderr] 2675 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2676 | | } [INFO] [stderr] ... | [INFO] [stderr] 2683 | | Ok(_id) [INFO] [stderr] 2684 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2720:12 [INFO] [stderr] | [INFO] [stderr] 2720 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2720 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2729:12 [INFO] [stderr] | [INFO] [stderr] 2729 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2729 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:2733:32 [INFO] [stderr] | [INFO] [stderr] 2733 | pub fn is_valid_reserve_id(&mut self, result_type: spirv::Word, result_id: Option, reserve_id: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2775:5 [INFO] [stderr] | [INFO] [stderr] 2775 | / pub fn group_reserve_read_pipe_packets(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, pipe: spirv::Word, num_packets: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2776 | | if self.basic_block.is_none() { [INFO] [stderr] 2777 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2778 | | } [INFO] [stderr] ... | [INFO] [stderr] 2785 | | Ok(_id) [INFO] [stderr] 2786 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2789:5 [INFO] [stderr] | [INFO] [stderr] 2789 | / pub fn group_reserve_write_pipe_packets(&mut self, result_type: spirv::Word, result_id: Option, execution: spirv::Word, pipe: spirv::Word, num_packets: spirv::Word, packet_size: spirv::Word, packet_alignment: spirv::Word) -> BuildResult { [INFO] [stderr] 2790 | | if self.basic_block.is_none() { [INFO] [stderr] 2791 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2792 | | } [INFO] [stderr] ... | [INFO] [stderr] 2799 | | Ok(_id) [INFO] [stderr] 2800 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2808:12 [INFO] [stderr] | [INFO] [stderr] 2808 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2808 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2817:12 [INFO] [stderr] | [INFO] [stderr] 2817 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2817 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2835:5 [INFO] [stderr] | [INFO] [stderr] 2835 | / pub fn enqueue_kernel>(&mut self, result_type: spirv::Word, result_id: Option, queue: spirv::Word, flags: spirv::Word, nd_range: spirv::Word, num_events: spirv::Word, wait_events: spirv::Word, ret_event: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word, local_size: T) -> BuildResult { [INFO] [stderr] 2836 | | if self.basic_block.is_none() { [INFO] [stderr] 2837 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2838 | | } [INFO] [stderr] ... | [INFO] [stderr] 2848 | | Ok(_id) [INFO] [stderr] 2849 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2852:5 [INFO] [stderr] | [INFO] [stderr] 2852 | / pub fn get_kernel_ndrange_sub_group_count(&mut self, result_type: spirv::Word, result_id: Option, nd_range: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 2853 | | if self.basic_block.is_none() { [INFO] [stderr] 2854 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2855 | | } [INFO] [stderr] ... | [INFO] [stderr] 2862 | | Ok(_id) [INFO] [stderr] 2863 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:2866:5 [INFO] [stderr] | [INFO] [stderr] 2866 | / pub fn get_kernel_ndrange_max_sub_group_size(&mut self, result_type: spirv::Word, result_id: Option, nd_range: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 2867 | | if self.basic_block.is_none() { [INFO] [stderr] 2868 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 2869 | | } [INFO] [stderr] ... | [INFO] [stderr] 2876 | | Ok(_id) [INFO] [stderr] 2877 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2913:12 [INFO] [stderr] | [INFO] [stderr] 2913 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2913 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2922:12 [INFO] [stderr] | [INFO] [stderr] 2922 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2922 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> mr/build_norm_insts.rs:2940:27 [INFO] [stderr] | [INFO] [stderr] 2940 | pub fn is_valid_event(&mut self, result_type: spirv::Word, result_id: Option, event: spirv::Word) -> BuildResult { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2959:12 [INFO] [stderr] | [INFO] [stderr] 2959 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2959 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:2968:12 [INFO] [stderr] | [INFO] [stderr] 2968 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 2968 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3033:5 [INFO] [stderr] | [INFO] [stderr] 3033 | / pub fn image_sparse_sample_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3034 | | if self.basic_block.is_none() { [INFO] [stderr] 3035 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3036 | | } [INFO] [stderr] ... | [INFO] [stderr] 3047 | | Ok(_id) [INFO] [stderr] 3048 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3051:5 [INFO] [stderr] | [INFO] [stderr] 3051 | / pub fn image_sparse_sample_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 3052 | | if self.basic_block.is_none() { [INFO] [stderr] 3053 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3054 | | } [INFO] [stderr] ... | [INFO] [stderr] 3062 | | Ok(_id) [INFO] [stderr] 3063 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3099:5 [INFO] [stderr] | [INFO] [stderr] 3099 | / pub fn image_sparse_sample_proj_dref_implicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3100 | | if self.basic_block.is_none() { [INFO] [stderr] 3101 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3102 | | } [INFO] [stderr] ... | [INFO] [stderr] 3113 | | Ok(_id) [INFO] [stderr] 3114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3117:5 [INFO] [stderr] | [INFO] [stderr] 3117 | / pub fn image_sparse_sample_proj_dref_explicit_lod>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: spirv::ImageOperands, additional_params: T) -> BuildResult { [INFO] [stderr] 3118 | | if self.basic_block.is_none() { [INFO] [stderr] 3119 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3120 | | } [INFO] [stderr] ... | [INFO] [stderr] 3128 | | Ok(_id) [INFO] [stderr] 3129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3150:5 [INFO] [stderr] | [INFO] [stderr] 3150 | / pub fn image_sparse_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, component: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3151 | | if self.basic_block.is_none() { [INFO] [stderr] 3152 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3153 | | } [INFO] [stderr] ... | [INFO] [stderr] 3164 | | Ok(_id) [INFO] [stderr] 3165 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3168:5 [INFO] [stderr] | [INFO] [stderr] 3168 | / pub fn image_sparse_dref_gather>(&mut self, result_type: spirv::Word, result_id: Option, sampled_image: spirv::Word, coordinate: spirv::Word, dref: spirv::Word, image_operands: Option, additional_params: T) -> BuildResult { [INFO] [stderr] 3169 | | if self.basic_block.is_none() { [INFO] [stderr] 3170 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3171 | | } [INFO] [stderr] ... | [INFO] [stderr] 3182 | | Ok(_id) [INFO] [stderr] 3183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:3219:12 [INFO] [stderr] | [INFO] [stderr] 3219 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 3219 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> mr/build_norm_insts.rs:3269:5 [INFO] [stderr] | [INFO] [stderr] 3269 | / pub fn get_kernel_local_size_for_subgroup_count(&mut self, result_type: spirv::Word, result_id: Option, subgroup_count: spirv::Word, invoke: spirv::Word, param: spirv::Word, param_size: spirv::Word, param_align: spirv::Word) -> BuildResult { [INFO] [stderr] 3270 | | if self.basic_block.is_none() { [INFO] [stderr] 3271 | | return Err(Error::DetachedInstruction); [INFO] [stderr] 3272 | | } [INFO] [stderr] ... | [INFO] [stderr] 3279 | | Ok(_id) [INFO] [stderr] 3280 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:3316:12 [INFO] [stderr] | [INFO] [stderr] 3316 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 3316 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:4143:12 [INFO] [stderr] | [INFO] [stderr] 4143 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4143 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> mr/build_norm_insts.rs:4166:12 [INFO] [stderr] | [INFO] [stderr] 4166 | Ok(self.basic_block.as_mut().unwrap().instructions.push(inst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 4166 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> mr/builder.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | / fn test_constant_f32() { [INFO] [stderr] 649 | | let mut b = Builder::new(); [INFO] [stderr] 650 | | let float = b.type_float(32); [INFO] [stderr] 651 | | // Normal numbers [INFO] [stderr] ... | [INFO] [stderr] 703 | | } [INFO] [stderr] 704 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> mr/builder.rs:652:31 [INFO] [stderr] | [INFO] [stderr] 652 | b.constant_f32(float, 3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> mr/builder.rs:669:38 [INFO] [stderr] | [INFO] [stderr] 669 | assert_eq!(mr::Operand::from(3.14f32), inst.operands[0]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> mr/constructs.rs:199:25 [INFO] [stderr] | [INFO] [stderr] 199 | self.version = ((major as u32) << 16) | ((minor as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> mr/constructs.rs:199:50 [INFO] [stderr] | [INFO] [stderr] 199 | self.version = ((major as u32) << 16) | ((minor as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> mr/constructs.rs:304:48 [INFO] [stderr] | [INFO] [stderr] 304 | assert_eq!(mr::Operand::LiteralFloat32(3.14f32), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> mr/constructs.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | mr::Operand::from(3.14f32)); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> sr/constants.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub(in sr) fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `sr::context::Context` [INFO] [stderr] --> sr/context.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Context { [INFO] [stderr] 40 | | Context { [INFO] [stderr] 41 | | types: vec![], [INFO] [stderr] 42 | | constants: vec![], [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> sr/type_creation.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn type_image( [INFO] [stderr] 102 | | &mut self, [INFO] [stderr] 103 | | sampled_type: TypeToken, [INFO] [stderr] 104 | | dim: spirv::Dim, [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> sr/types.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | pub(in sr) fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> utils/num.rs:60:30 [INFO] [stderr] | [INFO] [stderr] 60 | word = (word << 8) | (values[len - i - 1] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(values[len - i - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rspirv`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "73ebdac454ab27d9a25471e13291e08a186aeca404f06f04683c4dc836380763"` [INFO] running `"docker" "rm" "-f" "73ebdac454ab27d9a25471e13291e08a186aeca404f06f04683c4dc836380763"` [INFO] [stdout] 73ebdac454ab27d9a25471e13291e08a186aeca404f06f04683c4dc836380763