[INFO] crate rspec 1.0.0-beta.4 is already in cache [INFO] extracting crate rspec 1.0.0-beta.4 into work/ex/clippy-test-run/sources/stable/reg/rspec/1.0.0-beta.4 [INFO] extracting crate rspec 1.0.0-beta.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspec/1.0.0-beta.4 [INFO] validating manifest of rspec-1.0.0-beta.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rspec-1.0.0-beta.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rspec-1.0.0-beta.4 [INFO] finished frobbing rspec-1.0.0-beta.4 [INFO] frobbed toml for rspec-1.0.0-beta.4 written to work/ex/clippy-test-run/sources/stable/reg/rspec/1.0.0-beta.4/Cargo.toml [INFO] started frobbing rspec-1.0.0-beta.4 [INFO] finished frobbing rspec-1.0.0-beta.4 [INFO] frobbed toml for rspec-1.0.0-beta.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rspec/1.0.0-beta.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rspec-1.0.0-beta.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rspec/1.0.0-beta.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6eeb6d6f4fb311742007ed06092ee3b083ecdec2fff8e67a1bc86bd7e4a0fa81 [INFO] running `"docker" "start" "-a" "6eeb6d6f4fb311742007ed06092ee3b083ecdec2fff8e67a1bc86bd7e4a0fa81"` [INFO] [stderr] Compiling derive-new v0.5.6 [INFO] [stderr] Checking rspec v1.0.0-beta.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/example.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/mod.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | configuration: configuration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `configuration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | observers: observers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/suite.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/context.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block/example.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/mod.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | configuration: configuration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `configuration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | observers: observers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `observers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/suite.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | fn suite_internal<'a, F, T>(header: SuiteHeader, environment: T, body: F) -> Suite [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn context<'a, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn specify<'a, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn when<'b, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/block/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Block::Context(ref context) => context.num_examples(), [INFO] [stderr] 21 | | &Block::Example(_) => 1, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Block::Context(ref context) => context.num_examples(), [INFO] [stderr] 21 | Block::Example(_) => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/suite.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &SuiteLabel::Suite => write!(f, "Suite"), [INFO] [stderr] 15 | | &SuiteLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 16 | | &SuiteLabel::Given => write!(f, "Given"), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | SuiteLabel::Suite => write!(f, "Suite"), [INFO] [stderr] 15 | SuiteLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 16 | SuiteLabel::Given => write!(f, "Given"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/context.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &ContextLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 17 | | &ContextLabel::Context => write!(f, "Context"), [INFO] [stderr] 18 | | &ContextLabel::Specify => write!(f, "Specify"), [INFO] [stderr] 19 | | &ContextLabel::Given => write!(f, "Given"), [INFO] [stderr] 20 | | &ContextLabel::When => write!(f, "When"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | ContextLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 17 | ContextLabel::Context => write!(f, "Context"), [INFO] [stderr] 18 | ContextLabel::Specify => write!(f, "Specify"), [INFO] [stderr] 19 | ContextLabel::Given => write!(f, "Given"), [INFO] [stderr] 20 | ContextLabel::When => write!(f, "When"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/example.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &ExampleLabel::It => write!(f, "It"), [INFO] [stderr] 16 | | &ExampleLabel::Example => write!(f, "Example"), [INFO] [stderr] 17 | | &ExampleLabel::Then => write!(f, "Then"), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | ExampleLabel::It => write!(f, "It"), [INFO] [stderr] 16 | ExampleLabel::Example => write!(f, "Example"), [INFO] [stderr] 17 | ExampleLabel::Then => write!(f, "Then"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/example.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / if let &ExampleReport::Failure(_) = self { [INFO] [stderr] 35 | | 1 [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | 0 [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | if let ExampleReport::Failure(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &BlockReport::Context(_, ref report) => Some(report.get_blocks()), [INFO] [stderr] 35 | | &BlockReport::Example(_, _) => None, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | BlockReport::Context(_, ref report) => Some(report.get_blocks()), [INFO] [stderr] 35 | BlockReport::Example(_, _) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &BlockReport::Context(_, ref report) => report.is_success(), [INFO] [stderr] 44 | | &BlockReport::Example(_, ref report) => report.is_success(), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | BlockReport::Context(_, ref report) => report.is_success(), [INFO] [stderr] 44 | BlockReport::Example(_, ref report) => report.is_success(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &BlockReport::Context(_, ref report) => report.is_failure(), [INFO] [stderr] 51 | | &BlockReport::Example(_, ref report) => report.is_failure(), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | BlockReport::Context(_, ref report) => report.is_failure(), [INFO] [stderr] 51 | BlockReport::Example(_, ref report) => report.is_failure(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &BlockReport::Context(_, ref report) => report.get_passed(), [INFO] [stderr] 58 | | &BlockReport::Example(_, ref report) => report.get_passed(), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | BlockReport::Context(_, ref report) => report.get_passed(), [INFO] [stderr] 58 | BlockReport::Example(_, ref report) => report.get_passed(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &BlockReport::Context(_, ref report) => report.get_failed(), [INFO] [stderr] 65 | | &BlockReport::Example(_, ref report) => report.get_failed(), [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | BlockReport::Context(_, ref report) => report.get_failed(), [INFO] [stderr] 65 | BlockReport::Example(_, ref report) => report.get_failed(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self { [INFO] [stderr] 71 | | &BlockReport::Context(_, ref report) => report.get_ignored(), [INFO] [stderr] 72 | | &BlockReport::Example(_, ref report) => report.get_ignored(), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *self { [INFO] [stderr] 71 | BlockReport::Context(_, ref report) => report.get_ignored(), [INFO] [stderr] 72 | BlockReport::Example(_, ref report) => report.get_ignored(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/runner/mod.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match member { [INFO] [stderr] 206 | | &Block::Example(ref example) => { [INFO] [stderr] 207 | | let header = example.header.clone(); [INFO] [stderr] 208 | | let report = self.visit(example, environment); [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 205 | match *member { [INFO] [stderr] 206 | Block::Example(ref example) => { [INFO] [stderr] 207 | let header = example.header.clone(); [INFO] [stderr] 208 | let report = self.visit(example, environment); [INFO] [stderr] 209 | BlockReport::Example(header, report) [INFO] [stderr] 210 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/serial.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / match report { [INFO] [stderr] 85 | | &BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 86 | | if let Some(header) = header.as_ref() { [INFO] [stderr] 87 | | write!(buffer, "{}{}", Self::padding(indent), header)?; [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *report { [INFO] [stderr] 85 | BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 86 | if let Some(header) = header.as_ref() { [INFO] [stderr] 87 | write!(buffer, "{}{}", Self::padding(indent), header)?; [INFO] [stderr] 88 | } [INFO] [stderr] 89 | self.write_context_failures(buffer, indent + 1, report)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/serial.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &ExampleReport::Failure(Some(ref reason)) = report { [INFO] [stderr] 123 | | let padding = Self::padding(indent); [INFO] [stderr] 124 | | writeln!(buffer, "{}{}", padding, reason)?; [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | if let ExampleReport::Failure(Some(ref reason)) = *report { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match report { [INFO] [stderr] 48 | | &BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 49 | | self.replay_context(runner, header.as_ref(), report); [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *report { [INFO] [stderr] 48 | BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 49 | self.replay_context(runner, header.as_ref(), report); [INFO] [stderr] 50 | } [INFO] [stderr] 51 | BlockReport::Example(ref header, ref report) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/suite.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | fn suite_internal<'a, F, T>(header: SuiteHeader, environment: T, body: F) -> Suite [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn context<'a, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn specify<'a, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/block/context.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn when<'b, F>(&mut self, name: &'static str, body: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/block/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / match self { [INFO] [stderr] 20 | | &Block::Context(ref context) => context.num_examples(), [INFO] [stderr] 21 | | &Block::Example(_) => 1, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | Block::Context(ref context) => context.num_examples(), [INFO] [stderr] 21 | Block::Example(_) => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/suite.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &SuiteLabel::Suite => write!(f, "Suite"), [INFO] [stderr] 15 | | &SuiteLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 16 | | &SuiteLabel::Given => write!(f, "Given"), [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | SuiteLabel::Suite => write!(f, "Suite"), [INFO] [stderr] 15 | SuiteLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 16 | SuiteLabel::Given => write!(f, "Given"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/context.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &ContextLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 17 | | &ContextLabel::Context => write!(f, "Context"), [INFO] [stderr] 18 | | &ContextLabel::Specify => write!(f, "Specify"), [INFO] [stderr] 19 | | &ContextLabel::Given => write!(f, "Given"), [INFO] [stderr] 20 | | &ContextLabel::When => write!(f, "When"), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | ContextLabel::Describe => write!(f, "Describe"), [INFO] [stderr] 17 | ContextLabel::Context => write!(f, "Context"), [INFO] [stderr] 18 | ContextLabel::Specify => write!(f, "Specify"), [INFO] [stderr] 19 | ContextLabel::Given => write!(f, "Given"), [INFO] [stderr] 20 | ContextLabel::When => write!(f, "When"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/header/example.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &ExampleLabel::It => write!(f, "It"), [INFO] [stderr] 16 | | &ExampleLabel::Example => write!(f, "Example"), [INFO] [stderr] 17 | | &ExampleLabel::Then => write!(f, "Then"), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | ExampleLabel::It => write!(f, "It"), [INFO] [stderr] 16 | ExampleLabel::Example => write!(f, "Example"), [INFO] [stderr] 17 | ExampleLabel::Then => write!(f, "Then"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/example.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / if let &ExampleReport::Failure(_) = self { [INFO] [stderr] 35 | | 1 [INFO] [stderr] 36 | | } else { [INFO] [stderr] 37 | | 0 [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | if let ExampleReport::Failure(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &BlockReport::Context(_, ref report) => Some(report.get_blocks()), [INFO] [stderr] 35 | | &BlockReport::Example(_, _) => None, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | BlockReport::Context(_, ref report) => Some(report.get_blocks()), [INFO] [stderr] 35 | BlockReport::Example(_, _) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &BlockReport::Context(_, ref report) => report.is_success(), [INFO] [stderr] 44 | | &BlockReport::Example(_, ref report) => report.is_success(), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | BlockReport::Context(_, ref report) => report.is_success(), [INFO] [stderr] 44 | BlockReport::Example(_, ref report) => report.is_success(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &BlockReport::Context(_, ref report) => report.is_failure(), [INFO] [stderr] 51 | | &BlockReport::Example(_, ref report) => report.is_failure(), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | BlockReport::Context(_, ref report) => report.is_failure(), [INFO] [stderr] 51 | BlockReport::Example(_, ref report) => report.is_failure(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &BlockReport::Context(_, ref report) => report.get_passed(), [INFO] [stderr] 58 | | &BlockReport::Example(_, ref report) => report.get_passed(), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | BlockReport::Context(_, ref report) => report.get_passed(), [INFO] [stderr] 58 | BlockReport::Example(_, ref report) => report.get_passed(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match self { [INFO] [stderr] 64 | | &BlockReport::Context(_, ref report) => report.get_failed(), [INFO] [stderr] 65 | | &BlockReport::Example(_, ref report) => report.get_failed(), [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | match *self { [INFO] [stderr] 64 | BlockReport::Context(_, ref report) => report.get_failed(), [INFO] [stderr] 65 | BlockReport::Example(_, ref report) => report.get_failed(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/report/mod.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self { [INFO] [stderr] 71 | | &BlockReport::Context(_, ref report) => report.get_ignored(), [INFO] [stderr] 72 | | &BlockReport::Example(_, ref report) => report.get_ignored(), [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *self { [INFO] [stderr] 71 | BlockReport::Context(_, ref report) => report.get_ignored(), [INFO] [stderr] 72 | BlockReport::Example(_, ref report) => report.get_ignored(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/runner/mod.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match member { [INFO] [stderr] 206 | | &Block::Example(ref example) => { [INFO] [stderr] 207 | | let header = example.header.clone(); [INFO] [stderr] 208 | | let report = self.visit(example, environment); [INFO] [stderr] ... | [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 205 | match *member { [INFO] [stderr] 206 | Block::Example(ref example) => { [INFO] [stderr] 207 | let header = example.header.clone(); [INFO] [stderr] 208 | let report = self.visit(example, environment); [INFO] [stderr] 209 | BlockReport::Example(header, report) [INFO] [stderr] 210 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/runner/mod.rs:639:21 [INFO] [stderr] | [INFO] [stderr] 639 | assert!(true == spy.enter_example.load(Ordering::SeqCst)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `spy.enter_example.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/runner/mod.rs:640:21 [INFO] [stderr] | [INFO] [stderr] 640 | assert!(true == spy.exit_example.load(Ordering::SeqCst)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `spy.exit_example.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/serial.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / match report { [INFO] [stderr] 85 | | &BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 86 | | if let Some(header) = header.as_ref() { [INFO] [stderr] 87 | | write!(buffer, "{}{}", Self::padding(indent), header)?; [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *report { [INFO] [stderr] 85 | BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 86 | if let Some(header) = header.as_ref() { [INFO] [stderr] 87 | write!(buffer, "{}{}", Self::padding(indent), header)?; [INFO] [stderr] 88 | } [INFO] [stderr] 89 | self.write_context_failures(buffer, indent + 1, report)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/serial.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &ExampleReport::Failure(Some(ref reason)) = report { [INFO] [stderr] 123 | | let padding = Self::padding(indent); [INFO] [stderr] 124 | | writeln!(buffer, "{}{}", padding, reason)?; [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | if let ExampleReport::Failure(Some(ref reason)) = *report { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/logger/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match report { [INFO] [stderr] 48 | | &BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 49 | | self.replay_context(runner, header.as_ref(), report); [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *report { [INFO] [stderr] 48 | BlockReport::Context(ref header, ref report) => { [INFO] [stderr] 49 | self.replay_context(runner, header.as_ref(), report); [INFO] [stderr] 50 | } [INFO] [stderr] 51 | BlockReport::Example(ref header, ref report) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.21s [INFO] running `"docker" "inspect" "6eeb6d6f4fb311742007ed06092ee3b083ecdec2fff8e67a1bc86bd7e4a0fa81"` [INFO] running `"docker" "rm" "-f" "6eeb6d6f4fb311742007ed06092ee3b083ecdec2fff8e67a1bc86bd7e4a0fa81"` [INFO] [stdout] 6eeb6d6f4fb311742007ed06092ee3b083ecdec2fff8e67a1bc86bd7e4a0fa81