[INFO] crate rsmt2 0.9.11 is already in cache [INFO] extracting crate rsmt2 0.9.11 into work/ex/clippy-test-run/sources/stable/reg/rsmt2/0.9.11 [INFO] extracting crate rsmt2 0.9.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsmt2/0.9.11 [INFO] validating manifest of rsmt2-0.9.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsmt2-0.9.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsmt2-0.9.11 [INFO] finished frobbing rsmt2-0.9.11 [INFO] frobbed toml for rsmt2-0.9.11 written to work/ex/clippy-test-run/sources/stable/reg/rsmt2/0.9.11/Cargo.toml [INFO] started frobbing rsmt2-0.9.11 [INFO] finished frobbing rsmt2-0.9.11 [INFO] frobbed toml for rsmt2-0.9.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsmt2/0.9.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsmt2-0.9.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsmt2/0.9.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dcd04ffaf59669956157887d211aabd6d20e74002b2af4bdec65956ba0b11946 [INFO] running `"docker" "start" "-a" "dcd04ffaf59669956157887d211aabd6d20e74002b2af4bdec65956ba0b11946"` [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking rsmt2 v0.9.11 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/conf.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/conf.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/parse.rs:426:25 [INFO] [stderr] | [INFO] [stderr] 426 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/parse.rs:600:17 [INFO] [stderr] | [INFO] [stderr] 600 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/solver.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/conf.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/conf.rs:221:20 [INFO] [stderr] | [INFO] [stderr] 221 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/parse.rs:426:25 [INFO] [stderr] | [INFO] [stderr] 426 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/parse.rs:600:17 [INFO] [stderr] | [INFO] [stderr] 600 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/solver.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/conf.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.check_sat_assuming.as_ref().map(|s| *s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.check_sat_assuming.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:976:63 [INFO] [stderr] | [INFO] [stderr] 976 | } else if fst_end < self.buff.len() && &self.buff[fst_end..(fst_end + 1)] == "." { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `fst_end..=fst_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:1180:68 [INFO] [stderr] | [INFO] [stderr] 1180 | if err_end < self.buff.len() && &self.buff[err_end..err_end + 1] != "\"" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `err_end..=err_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/conf.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.check_sat_assuming.as_ref().map(|s| *s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.check_sat_assuming.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:976:63 [INFO] [stderr] | [INFO] [stderr] 976 | } else if fst_end < self.buff.len() && &self.buff[fst_end..(fst_end + 1)] == "." { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `fst_end..=fst_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parse.rs:1180:68 [INFO] [stderr] | [INFO] [stderr] 1180 | if err_end < self.buff.len() && &self.buff[err_end..err_end + 1] != "\"" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `err_end..=err_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/example/print_time.rs:321:1 [INFO] [stderr] | [INFO] [stderr] 321 | / fn test_native() { [INFO] [stderr] 322 | | use self::SExpr::*; [INFO] [stderr] 323 | | [INFO] [stderr] 324 | | let mut solver = get_solver(Parser); [INFO] [stderr] ... | [INFO] [stderr] 409 | | solver.kill().expect("kill") [INFO] [stderr] 410 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/example/print_time.rs:413:1 [INFO] [stderr] | [INFO] [stderr] 413 | / fn test_unroll() { [INFO] [stderr] 414 | | use self::SExpr::*; [INFO] [stderr] 415 | | [INFO] [stderr] 416 | | let mut solver = get_solver(Parser); [INFO] [stderr] ... | [INFO] [stderr] 506 | | solver.kill().expect("kill") [INFO] [stderr] 507 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.91s [INFO] running `"docker" "inspect" "dcd04ffaf59669956157887d211aabd6d20e74002b2af4bdec65956ba0b11946"` [INFO] running `"docker" "rm" "-f" "dcd04ffaf59669956157887d211aabd6d20e74002b2af4bdec65956ba0b11946"` [INFO] [stdout] dcd04ffaf59669956157887d211aabd6d20e74002b2af4bdec65956ba0b11946