[INFO] crate rsgen-avro 0.2.0 is already in cache [INFO] extracting crate rsgen-avro 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rsgen-avro/0.2.0 [INFO] extracting crate rsgen-avro 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsgen-avro/0.2.0 [INFO] validating manifest of rsgen-avro-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsgen-avro-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsgen-avro-0.2.0 [INFO] finished frobbing rsgen-avro-0.2.0 [INFO] frobbed toml for rsgen-avro-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rsgen-avro/0.2.0/Cargo.toml [INFO] started frobbing rsgen-avro-0.2.0 [INFO] finished frobbing rsgen-avro-0.2.0 [INFO] frobbed toml for rsgen-avro-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsgen-avro/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsgen-avro-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsgen-avro/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6922755676cf8c61f060bf0d5e269cc072625f4e72f63b2976671972ea8a8748 [INFO] running `"docker" "start" "-a" "6922755676cf8c61f060bf0d5e269cc072625f4e72f63b2976671972ea8a8748"` [INFO] [stderr] Checking by_address v1.0.4 [INFO] [stderr] Checking serde v1.0.85 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking avro-rs v0.6.4 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stderr] Checking rsgen-avro v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/templates.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:331:36 [INFO] [stderr] | [INFO] [stderr] 331 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:331:36 [INFO] [stderr] | [INFO] [stderr] 331 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:498:24 [INFO] [stderr] | [INFO] [stderr] 498 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:498:24 [INFO] [stderr] | [INFO] [stderr] 498 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:180:48 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn gen(&self, source: &Source, output: &mut Box) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:223:53 [INFO] [stderr] | [INFO] [stderr] 223 | fn gen_in_order(&self, schema: &Schema, output: &mut Box) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GeneratorBuilder` [INFO] [stderr] --> src/lib.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | / pub fn new() -> GeneratorBuilder { [INFO] [stderr] 371 | | GeneratorBuilder { [INFO] [stderr] 372 | | precision: 3, [INFO] [stderr] 373 | | nullable: false, [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 363 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsgen-avro`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/templates.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | if symbols.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:331:36 [INFO] [stderr] | [INFO] [stderr] 331 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:331:36 [INFO] [stderr] | [INFO] [stderr] 331 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:498:24 [INFO] [stderr] | [INFO] [stderr] 498 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:498:24 [INFO] [stderr] | [INFO] [stderr] 498 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/templates.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(n - n.ceil()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/templates.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if n == n.ceil() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:180:48 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn gen(&self, source: &Source, output: &mut Box) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:223:53 [INFO] [stderr] | [INFO] [stderr] 223 | fn gen_in_order(&self, schema: &Schema, output: &mut Box) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GeneratorBuilder` [INFO] [stderr] --> src/lib.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | / pub fn new() -> GeneratorBuilder { [INFO] [stderr] 371 | | GeneratorBuilder { [INFO] [stderr] 372 | | precision: 3, [INFO] [stderr] 373 | | nullable: false, [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 363 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsgen-avro`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6922755676cf8c61f060bf0d5e269cc072625f4e72f63b2976671972ea8a8748"` [INFO] running `"docker" "rm" "-f" "6922755676cf8c61f060bf0d5e269cc072625f4e72f63b2976671972ea8a8748"` [INFO] [stdout] 6922755676cf8c61f060bf0d5e269cc072625f4e72f63b2976671972ea8a8748