[INFO] crate rsfuzzy 0.1.3 is already in cache [INFO] extracting crate rsfuzzy 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rsfuzzy/0.1.3 [INFO] extracting crate rsfuzzy 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsfuzzy/0.1.3 [INFO] validating manifest of rsfuzzy-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsfuzzy-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsfuzzy-0.1.3 [INFO] finished frobbing rsfuzzy-0.1.3 [INFO] frobbed toml for rsfuzzy-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rsfuzzy/0.1.3/Cargo.toml [INFO] started frobbing rsfuzzy-0.1.3 [INFO] finished frobbing rsfuzzy-0.1.3 [INFO] frobbed toml for rsfuzzy-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsfuzzy/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsfuzzy-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsfuzzy/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa1b73bee44b5aadd8c52fb3dcb0fead6859281287b0619061592bebbdd03770 [INFO] running `"docker" "start" "-a" "fa1b73bee44b5aadd8c52fb3dcb0fead6859281287b0619061592bebbdd03770"` [INFO] [stderr] Checking rsfuzzy v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hedges.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | hedge: hedge, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hedge` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hedges.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | p: p [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hedges.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | hedge: hedge, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hedge` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hedges.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | p: p [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 49 | | if init.len() != 3 { [INFO] [stderr] 50 | | panic!("init var for Triangle needs 3 values"); [INFO] [stderr] 51 | | } [INFO] [stderr] ... | [INFO] [stderr] 58 | | MfType::Triangle(triangle) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 83 | | if init.len() != 4 { [INFO] [stderr] 84 | | panic!("init var for Trapezoid needs 3 values"); [INFO] [stderr] 85 | | } [INFO] [stderr] ... | [INFO] [stderr] 93 | | MfType::Trapezoid(trapezoid) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 116 | | if init.len() != 2 { [INFO] [stderr] 117 | | panic!("init var for Up needs 2 values"); [INFO] [stderr] 118 | | } [INFO] [stderr] ... | [INFO] [stderr] 124 | | MfType::Up(up) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 153 | | if init.len() != 2 { [INFO] [stderr] 154 | | panic!("init var for Up needs 2 values"); [INFO] [stderr] 155 | | } [INFO] [stderr] ... | [INFO] [stderr] 161 | | MfType::Down(down) [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:29:56 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:29:56 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:99:56 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:99:56 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/deffuz.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | if x > 0.0 && x == xmax { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(x - xmax).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/deffuz.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | if x > 0.0 && x == xmax { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/hedges.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | TYPES.iter().map(|&x| x).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `TYPES.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | rules: Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Engine` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Engine { [INFO] [stderr] 43 | | Engine { [INFO] [stderr] 44 | | inputs: HashMap::with_capacity(3), [INFO] [stderr] 45 | | output: HashMap::with_capacity(1), [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | impl Default for Engine { [INFO] [stderr] 42 | fn default() -> Self { [INFO] [stderr] 43 | Self::new() [INFO] [stderr] 44 | } [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:80:44 [INFO] [stderr] | [INFO] [stderr] 80 | let operators: Vec<&'static str> = OPERATOR.iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `OPERATOR.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let mut input_vars: Vec<(String, mf::MfType, Option>, Option)> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsfuzzy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 49 | | if init.len() != 3 { [INFO] [stderr] 50 | | panic!("init var for Triangle needs 3 values"); [INFO] [stderr] 51 | | } [INFO] [stderr] ... | [INFO] [stderr] 58 | | MfType::Triangle(triangle) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 83 | | if init.len() != 4 { [INFO] [stderr] 84 | | panic!("init var for Trapezoid needs 3 values"); [INFO] [stderr] 85 | | } [INFO] [stderr] ... | [INFO] [stderr] 93 | | MfType::Trapezoid(trapezoid) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 116 | | if init.len() != 2 { [INFO] [stderr] 117 | | panic!("init var for Up needs 2 values"); [INFO] [stderr] 118 | | } [INFO] [stderr] ... | [INFO] [stderr] 124 | | MfType::Up(up) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/mf.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn new(name: &str, init: Vec) -> MfType { [INFO] [stderr] 153 | | if init.len() != 2 { [INFO] [stderr] 154 | | panic!("init var for Up needs 2 values"); [INFO] [stderr] 155 | | } [INFO] [stderr] ... | [INFO] [stderr] 161 | | MfType::Down(down) [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:29:56 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:29:56 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/deffuz.rs:99:56 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/deffuz.rs:99:56 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get(&self, start: usize, end: usize, rules: &Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, inputs: HashMap) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/deffuz.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | if x > 0.0 && x == xmax { [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(x - xmax).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/deffuz.rs:160:31 [INFO] [stderr] | [INFO] [stderr] 160 | if x > 0.0 && x == xmax { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/hedges.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | TYPES.iter().map(|&x| x).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `TYPES.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | rules: Vec<(Vec<(String, mf::MfType, Option>, Option)>, Option>, mf::MfType)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Engine` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Engine { [INFO] [stderr] 43 | | Engine { [INFO] [stderr] 44 | | inputs: HashMap::with_capacity(3), [INFO] [stderr] 45 | | output: HashMap::with_capacity(1), [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | impl Default for Engine { [INFO] [stderr] 42 | fn default() -> Self { [INFO] [stderr] 43 | Self::new() [INFO] [stderr] 44 | } [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:80:44 [INFO] [stderr] | [INFO] [stderr] 80 | let operators: Vec<&'static str> = OPERATOR.iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `OPERATOR.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | let mut input_vars: Vec<(String, mf::MfType, Option>, Option)> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsfuzzy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fa1b73bee44b5aadd8c52fb3dcb0fead6859281287b0619061592bebbdd03770"` [INFO] running `"docker" "rm" "-f" "fa1b73bee44b5aadd8c52fb3dcb0fead6859281287b0619061592bebbdd03770"` [INFO] [stdout] fa1b73bee44b5aadd8c52fb3dcb0fead6859281287b0619061592bebbdd03770