[INFO] crate rsbot 0.2.3 is already in cache [INFO] extracting crate rsbot 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/rsbot/0.2.3 [INFO] extracting crate rsbot 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsbot/0.2.3 [INFO] validating manifest of rsbot-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsbot-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsbot-0.2.3 [INFO] finished frobbing rsbot-0.2.3 [INFO] frobbed toml for rsbot-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/rsbot/0.2.3/Cargo.toml [INFO] started frobbing rsbot-0.2.3 [INFO] finished frobbing rsbot-0.2.3 [INFO] frobbed toml for rsbot-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rsbot/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsbot-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rsbot/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01b91c544d3f62438341031483bcc29498e332906c3fdfdc2b99b3ba209054ed [INFO] running `"docker" "start" "-a" "01b91c544d3f62438341031483bcc29498e332906c3fdfdc2b99b3ba209054ed"` [INFO] [stderr] Checking rsbot v0.2.3 (/opt/crater/workdir) [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/linux/key.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | XStringToKeysym(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/linux/key.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | XStringToKeysym(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/linux/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | XOpenDisplay(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/linux/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | XOpenDisplay(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Bot` [INFO] [stderr] --> src/lib.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new() -> Bot { [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | Bot { [INFO] [stderr] 20 | | display: linux::open_display(None), [INFO] [stderr] 21 | | root_window: None, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for Bot { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsbot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/linux/key.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | XStringToKeysym(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/linux/key.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | XStringToKeysym(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/linux/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | XOpenDisplay(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/linux/mod.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | XOpenDisplay(std::ffi::CString::new(string).unwrap().as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Bot` [INFO] [stderr] --> src/lib.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new() -> Bot { [INFO] [stderr] | _____^ [INFO] [stderr] 19 | | Bot { [INFO] [stderr] 20 | | display: linux::open_display(None), [INFO] [stderr] 21 | | root_window: None, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for Bot { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rsbot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "01b91c544d3f62438341031483bcc29498e332906c3fdfdc2b99b3ba209054ed"` [INFO] running `"docker" "rm" "-f" "01b91c544d3f62438341031483bcc29498e332906c3fdfdc2b99b3ba209054ed"` [INFO] [stdout] 01b91c544d3f62438341031483bcc29498e332906c3fdfdc2b99b3ba209054ed