[INFO] crate rs485 0.1.0 is already in cache [INFO] extracting crate rs485 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rs485/0.1.0 [INFO] extracting crate rs485 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs485/0.1.0 [INFO] validating manifest of rs485-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs485-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs485-0.1.0 [INFO] finished frobbing rs485-0.1.0 [INFO] frobbed toml for rs485-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rs485/0.1.0/Cargo.toml [INFO] started frobbing rs485-0.1.0 [INFO] finished frobbing rs485-0.1.0 [INFO] frobbed toml for rs485-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs485/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs485-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rs485/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c74d30d776299717b5dbcb4c9dc4613b7153d7b3a96b344d453d7e8acab1acfa [INFO] running `"docker" "start" "-a" "c74d30d776299717b5dbcb4c9dc4613b7153d7b3a96b344d453d7e8acab1acfa"` [INFO] [stderr] Checking rs485 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | const SER_RS485_ENABLED = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SerialRs485` [INFO] [stderr] --> src/lib.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> SerialRs485 { [INFO] [stderr] 81 | | unsafe { mem::zeroed() } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for SerialRs485 { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn set_enabled<'a>(&'a mut self, enabled: bool) -> &'a mut Self { [INFO] [stderr] 107 | | if enabled { [INFO] [stderr] 108 | | self.flags |= SER_RS485_ENABLED; [INFO] [stderr] 109 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | self [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn set_rts_on_send<'a>(&'a mut self, rts_on_send: bool) -> &'a mut Self { [INFO] [stderr] 122 | | if rts_on_send { [INFO] [stderr] 123 | | self.flags |= SER_RS485_RTS_ON_SEND; [INFO] [stderr] 124 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 128 | | self [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn set_rts_after_send<'a>(&'a mut self, rts_after_send: bool) -> &'a mut Self { [INFO] [stderr] 137 | | if rts_after_send { [INFO] [stderr] 138 | | self.flags |= SER_RS485_RTS_AFTER_SEND; [INFO] [stderr] 139 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 143 | | self [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn delay_rts_before_send_ms<'a>(&'a mut self, delay_rts_before_send: u32) -> &'a mut Self { [INFO] [stderr] 152 | | self.delay_rts_before_send = delay_rts_before_send; [INFO] [stderr] 153 | | self [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn delay_rts_after_send_ms<'a>(&'a mut self, delay_rts_after_send: u32) -> &'a mut Self { [INFO] [stderr] 162 | | self.delay_rts_after_send = delay_rts_after_send; [INFO] [stderr] 163 | | self [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn set_rx_during_tx<'a>(&'a mut self, set_rx_during_tx: bool) -> &'a mut Self { [INFO] [stderr] 172 | | if set_rx_during_tx { [INFO] [stderr] 173 | | self.flags |= SER_RS485_RX_DURING_TX [INFO] [stderr] 174 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 177 | | self [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | const SER_RS485_ENABLED = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SerialRs485` [INFO] [stderr] --> src/lib.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> SerialRs485 { [INFO] [stderr] 81 | | unsafe { mem::zeroed() } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | impl Default for SerialRs485 { [INFO] [stderr] 76 | fn default() -> Self { [INFO] [stderr] 77 | Self::new() [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn set_enabled<'a>(&'a mut self, enabled: bool) -> &'a mut Self { [INFO] [stderr] 107 | | if enabled { [INFO] [stderr] 108 | | self.flags |= SER_RS485_ENABLED; [INFO] [stderr] 109 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | self [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn set_rts_on_send<'a>(&'a mut self, rts_on_send: bool) -> &'a mut Self { [INFO] [stderr] 122 | | if rts_on_send { [INFO] [stderr] 123 | | self.flags |= SER_RS485_RTS_ON_SEND; [INFO] [stderr] 124 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 128 | | self [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn set_rts_after_send<'a>(&'a mut self, rts_after_send: bool) -> &'a mut Self { [INFO] [stderr] 137 | | if rts_after_send { [INFO] [stderr] 138 | | self.flags |= SER_RS485_RTS_AFTER_SEND; [INFO] [stderr] 139 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 143 | | self [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn delay_rts_before_send_ms<'a>(&'a mut self, delay_rts_before_send: u32) -> &'a mut Self { [INFO] [stderr] 152 | | self.delay_rts_before_send = delay_rts_before_send; [INFO] [stderr] 153 | | self [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn delay_rts_after_send_ms<'a>(&'a mut self, delay_rts_after_send: u32) -> &'a mut Self { [INFO] [stderr] 162 | | self.delay_rts_after_send = delay_rts_after_send; [INFO] [stderr] 163 | | self [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / pub fn set_rx_during_tx<'a>(&'a mut self, set_rx_during_tx: bool) -> &'a mut Self { [INFO] [stderr] 172 | | if set_rx_during_tx { [INFO] [stderr] 173 | | self.flags |= SER_RS485_RX_DURING_TX [INFO] [stderr] 174 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 177 | | self [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "c74d30d776299717b5dbcb4c9dc4613b7153d7b3a96b344d453d7e8acab1acfa"` [INFO] running `"docker" "rm" "-f" "c74d30d776299717b5dbcb4c9dc4613b7153d7b3a96b344d453d7e8acab1acfa"` [INFO] [stdout] c74d30d776299717b5dbcb4c9dc4613b7153d7b3a96b344d453d7e8acab1acfa