[INFO] crate rs-jsonpath 0.1.0 is already in cache [INFO] extracting crate rs-jsonpath 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rs-jsonpath/0.1.0 [INFO] extracting crate rs-jsonpath 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-jsonpath/0.1.0 [INFO] validating manifest of rs-jsonpath-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs-jsonpath-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs-jsonpath-0.1.0 [INFO] finished frobbing rs-jsonpath-0.1.0 [INFO] frobbed toml for rs-jsonpath-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rs-jsonpath/0.1.0/Cargo.toml [INFO] started frobbing rs-jsonpath-0.1.0 [INFO] finished frobbing rs-jsonpath-0.1.0 [INFO] frobbed toml for rs-jsonpath-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-jsonpath/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs-jsonpath-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rs-jsonpath/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb91dddfdae5125261c3c07a0df1c5bb680c6bdb218b0618929701ce3df7f596 [INFO] running `"docker" "start" "-a" "bb91dddfdae5125261c3c07a0df1c5bb680c6bdb218b0618929701ce3df7f596"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking rs-jsonpath v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(ParsedJsonPath { op: s("scan"), key: key, args: vec![]}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:35 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(ParsedJsonPath { op: s("scan"), key: key, args: vec![]}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:35 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(ParsedJsonPath {op: op, key: key, args: args}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokenizer.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 50 | | if c == '.' { [INFO] [stderr] 51 | | if token.starts_with(".") { [INFO] [stderr] 52 | | tokens.push(token[1..token.len() - 1].to_string()) [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if c == '.' { [INFO] [stderr] 50 | if token.starts_with(".") { [INFO] [stderr] 51 | tokens.push(token[1..token.len() - 1].to_string()) [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | tokens.push(token[..token.len() - 1].to_string()) [INFO] [stderr] 54 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(ParsedJsonPath {op: s("key"), key: token, args: vec![]}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParsedJsonPath {op: s("key"), key: token, args: vec![]})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | return vect; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | return vect; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokenizer.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 50 | | if c == '.' { [INFO] [stderr] 51 | | if token.starts_with(".") { [INFO] [stderr] 52 | | tokens.push(token[1..token.len() - 1].to_string()) [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | } else if c == '.' { [INFO] [stderr] 50 | if token.starts_with(".") { [INFO] [stderr] 51 | tokens.push(token[1..token.len() - 1].to_string()) [INFO] [stderr] 52 | } else { [INFO] [stderr] 53 | tokens.push(token[..token.len() - 1].to_string()) [INFO] [stderr] 54 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(ParsedJsonPath {op: s("key"), key: token, args: vec![]}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParsedJsonPath {op: s("key"), key: token, args: vec![]})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | return vect; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/requests.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | return vect; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(bracket_idx) = token.find("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | if token.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | if token.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:88:43 [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(bracket_idx) = token.find("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | if tail.contains("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:98:57 [INFO] [stderr] | [INFO] [stderr] 98 | if tail.starts_with("?(") && tail.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | } else if tail.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | args = tail.split(":").map(|arg| arg.trim().to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | args = tail.split(",").map(|arg| arg.trim().to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:130:10 [INFO] [stderr] | [INFO] [stderr] 130 | .ok_or(s("Invalid filter expression")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Invalid filter expression"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:5:43 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn calc_from(array_len: usize, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/requests.rs:6:8 [INFO] [stderr] | [INFO] [stderr] 6 | if args.len() < 1 { return Ok(0); } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/requests.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | from = array_len as i64 + from [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from += array_len as i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/requests.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | _ => Err(format!("Error with range: negative bound")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Error with range: negative bound".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:17:41 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn calc_to(array_len: usize, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/requests.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | _ => Err(format!("Error with range: negative bound")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Error with range: negative bound".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn find_range(json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/requests.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .map(|vec| Value::Array(vec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/requests.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | .ok_or(s("Error with range")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Error with range"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:43:49 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn search_key(json: &Value, key: &str, res: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 43 | pub fn search_key(json: &Value, key: &str, res: &[Value]) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `res.clone()` to [INFO] [stderr] | [INFO] [stderr] 58 | _ => res.to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:64:68 [INFO] [stderr] | [INFO] [stderr] 64 | Value::Object(obj) => obj.get(key).map(|elem| elem.clone()).unwrap_or(Value::Array(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Value::Array(vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | Value::Object(obj) => obj.get(key).map(|elem| elem.clone()).unwrap_or(Value::Array(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `obj.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / obj.get(key) [INFO] [stderr] 67 | | .map(|elem| elem.clone()) [INFO] [stderr] | |_____________________________________________^ help: Consider calling the dedicated `cloned` method: `obj.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn find_indexes(json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/requests.rs:97:10 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|vec| Value::Array(vec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / json.as_array() [INFO] [stderr] 82 | | .and_then(|array| { [INFO] [stderr] 83 | | let length = array.len(); [INFO] [stderr] 84 | | let mut index: i64 = idx; [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | }).map(|elem| elem.clone()) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 81 | json.as_array() [INFO] [stderr] 82 | .and_then(|array| { [INFO] [stderr] 83 | let length = array.len(); [INFO] [stderr] 84 | let mut index: i64 = idx; [INFO] [stderr] 85 | if index < 0 { [INFO] [stderr] 86 | index = length as i64 + index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/requests.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | index = length as i64 + index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += length as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:54 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn find_filter(root: &Value, json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .ok_or(s("Unable to filter json")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Unable to filter json"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | / array.iter().filter(|value| { [INFO] [stderr] 40 | | println!("{:?}", serde_json::to_string(value).unwrap()); [INFO] [stderr] 41 | | let left = eval_expression(root, value, parsed_filter.left.clone()); [INFO] [stderr] 42 | | let right = eval_expression(root, value, parsed_filter.right.clone()); [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | .map(|value| value.clone()) [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 39 | array.iter().filter(|value| { [INFO] [stderr] 40 | println!("{:?}", serde_json::to_string(value).unwrap()); [INFO] [stderr] 41 | let left = eval_expression(root, value, parsed_filter.left.clone()); [INFO] [stderr] 42 | let right = eval_expression(root, value, parsed_filter.right.clone()); [INFO] [stderr] 43 | if let (Ok(l),Ok(r)) = (left,right) { [INFO] [stderr] 44 | eval_filter(l.as_str(), parsed_filter.op.as_str(), r.as_str()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | }).map(|value| Value::Array(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | if !expression.contains("$") && !expression.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | if !expression.contains("$") && !expression.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(bracket_idx) = token.find("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | if token.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | if token.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | if token.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:88:43 [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(bracket_idx) = token.find("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | if tail.contains("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:98:57 [INFO] [stderr] | [INFO] [stderr] 98 | if tail.starts_with("?(") && tail.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | } else if tail.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | args = tail.split(":").map(|arg| arg.trim().to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | args = tail.split(",").map(|arg| arg.trim().to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:130:10 [INFO] [stderr] | [INFO] [stderr] 130 | .ok_or(s("Invalid filter expression")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Invalid filter expression"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:5:43 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn calc_from(array_len: usize, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/requests.rs:6:8 [INFO] [stderr] | [INFO] [stderr] 6 | if args.len() < 1 { return Ok(0); } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/requests.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | from = array_len as i64 + from [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `from += array_len as i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/requests.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | _ => Err(format!("Error with range: negative bound")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Error with range: negative bound".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:17:41 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn calc_to(array_len: usize, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/requests.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | _ => Err(format!("Error with range: negative bound")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Error with range: negative bound".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn find_range(json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/requests.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | .map(|vec| Value::Array(vec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/requests.rs:31:10 [INFO] [stderr] | [INFO] [stderr] 31 | .ok_or(s("Error with range")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Error with range"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:43:49 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn search_key(json: &Value, key: &str, res: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 43 | pub fn search_key(json: &Value, key: &str, res: &[Value]) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `res.clone()` to [INFO] [stderr] | [INFO] [stderr] 58 | _ => res.to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:64:68 [INFO] [stderr] | [INFO] [stderr] 64 | Value::Object(obj) => obj.get(key).map(|elem| elem.clone()).unwrap_or(Value::Array(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Value::Array(vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | Value::Object(obj) => obj.get(key).map(|elem| elem.clone()).unwrap_or(Value::Array(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `obj.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / obj.get(key) [INFO] [stderr] 67 | | .map(|elem| elem.clone()) [INFO] [stderr] | |_____________________________________________^ help: Consider calling the dedicated `cloned` method: `obj.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/requests.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn find_indexes(json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/requests.rs:97:10 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|vec| Value::Array(vec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/requests.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | / json.as_array() [INFO] [stderr] 82 | | .and_then(|array| { [INFO] [stderr] 83 | | let length = array.len(); [INFO] [stderr] 84 | | let mut index: i64 = idx; [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | }).map(|elem| elem.clone()) [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 81 | json.as_array() [INFO] [stderr] 82 | .and_then(|array| { [INFO] [stderr] 83 | let length = array.len(); [INFO] [stderr] 84 | let mut index: i64 = idx; [INFO] [stderr] 85 | if index < 0 { [INFO] [stderr] 86 | index = length as i64 + index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/requests.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | index = length as i64 + index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += length as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:54 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn find_filter(root: &Value, json: &Value, args: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .ok_or(s("Unable to filter json")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| s("Unable to filter json"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | / array.iter().filter(|value| { [INFO] [stderr] 40 | | println!("{:?}", serde_json::to_string(value).unwrap()); [INFO] [stderr] 41 | | let left = eval_expression(root, value, parsed_filter.left.clone()); [INFO] [stderr] 42 | | let right = eval_expression(root, value, parsed_filter.right.clone()); [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | .map(|value| value.clone()) [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 39 | array.iter().filter(|value| { [INFO] [stderr] 40 | println!("{:?}", serde_json::to_string(value).unwrap()); [INFO] [stderr] 41 | let left = eval_expression(root, value, parsed_filter.left.clone()); [INFO] [stderr] 42 | let right = eval_expression(root, value, parsed_filter.right.clone()); [INFO] [stderr] 43 | if let (Ok(l),Ok(r)) = (left,right) { [INFO] [stderr] 44 | eval_filter(l.as_str(), parsed_filter.op.as_str(), r.as_str()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | }).map(|value| Value::Array(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | if !expression.contains("$") && !expression.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | if !expression.contains("$") && !expression.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.83s [INFO] running `"docker" "inspect" "bb91dddfdae5125261c3c07a0df1c5bb680c6bdb218b0618929701ce3df7f596"` [INFO] running `"docker" "rm" "-f" "bb91dddfdae5125261c3c07a0df1c5bb680c6bdb218b0618929701ce3df7f596"` [INFO] [stdout] bb91dddfdae5125261c3c07a0df1c5bb680c6bdb218b0618929701ce3df7f596