[INFO] crate rs-graph-derive 0.14.1 is already in cache [INFO] extracting crate rs-graph-derive 0.14.1 into work/ex/clippy-test-run/sources/stable/reg/rs-graph-derive/0.14.1 [INFO] extracting crate rs-graph-derive 0.14.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-graph-derive/0.14.1 [INFO] validating manifest of rs-graph-derive-0.14.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs-graph-derive-0.14.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs-graph-derive-0.14.1 [INFO] finished frobbing rs-graph-derive-0.14.1 [INFO] frobbed toml for rs-graph-derive-0.14.1 written to work/ex/clippy-test-run/sources/stable/reg/rs-graph-derive/0.14.1/Cargo.toml [INFO] started frobbing rs-graph-derive-0.14.1 [INFO] finished frobbing rs-graph-derive-0.14.1 [INFO] frobbed toml for rs-graph-derive-0.14.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-graph-derive/0.14.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs-graph-derive-0.14.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rs-graph-derive/0.14.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fd42c901b547496b84a65f46570a1afdad997fed4ae12ff6f9e211cc46e23bc [INFO] running `"docker" "start" "-a" "6fd42c901b547496b84a65f46570a1afdad997fed4ae12ff6f9e211cc46e23bc"` [INFO] [stderr] Compiling rs-graph v0.14.2 [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking rs-graph-derive v0.14.1 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | if &field [INFO] [stderr] | ________________^ [INFO] [stderr] 102 | | .ident [INFO] [stderr] 103 | | .as_ref() [INFO] [stderr] 104 | | .map(|id| id.to_string()) [INFO] [stderr] 105 | | .unwrap_or_else(|| String::new()) == &"graph" [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 101 | if field [INFO] [stderr] 102 | .ident [INFO] [stderr] 103 | .as_ref() [INFO] [stderr] 104 | .map(|id| id.to_string()) [INFO] [stderr] 105 | .unwrap_or_else(|| String::new()) == "graph" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:105:33 [INFO] [stderr] | [INFO] [stderr] 105 | .unwrap_or_else(|| String::new()) == &"graph" [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:110:53 [INFO] [stderr] | [INFO] [stderr] 110 | } else if field.attrs.iter().any(|attr| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 111 | | attr.path.segments.len() == 1 [INFO] [stderr] 112 | | && attr.path.segments.first().unwrap().into_value().ident [INFO] [stderr] 113 | | == syn::Ident::new("graph", Span::call_site()) [INFO] [stderr] 114 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | if &field [INFO] [stderr] | ________________^ [INFO] [stderr] 102 | | .ident [INFO] [stderr] 103 | | .as_ref() [INFO] [stderr] 104 | | .map(|id| id.to_string()) [INFO] [stderr] 105 | | .unwrap_or_else(|| String::new()) == &"graph" [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 101 | if field [INFO] [stderr] 102 | .ident [INFO] [stderr] 103 | .as_ref() [INFO] [stderr] 104 | .map(|id| id.to_string()) [INFO] [stderr] 105 | .unwrap_or_else(|| String::new()) == "graph" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:105:33 [INFO] [stderr] | [INFO] [stderr] 105 | .unwrap_or_else(|| String::new()) == &"graph" [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:110:53 [INFO] [stderr] | [INFO] [stderr] 110 | } else if field.attrs.iter().any(|attr| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 111 | | attr.path.segments.len() == 1 [INFO] [stderr] 112 | | && attr.path.segments.first().unwrap().into_value().ident [INFO] [stderr] 113 | | == syn::Ident::new("graph", Span::call_site()) [INFO] [stderr] 114 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.50s [INFO] running `"docker" "inspect" "6fd42c901b547496b84a65f46570a1afdad997fed4ae12ff6f9e211cc46e23bc"` [INFO] running `"docker" "rm" "-f" "6fd42c901b547496b84a65f46570a1afdad997fed4ae12ff6f9e211cc46e23bc"` [INFO] [stdout] 6fd42c901b547496b84a65f46570a1afdad997fed4ae12ff6f9e211cc46e23bc